Another update to also use quotes around the check-for-no-diff script body.
If I don't get any more feedback in the next few hours I'll send another full
version of the patch.
Caleb Thompson
8
Add a new configuration variable commit.verbose to
commit: support commit.verbose and --no-verbose
Documentation/config.txt | 5 +
Documentation/git-commit.txt | 8 +++-
builtin/commit.c | 6 +-
contrib/completion/git-completion.bash | 1 +
t/t7507-commit-verbose.sh | 64
Add a new configuration variable commit.verbose to implicitly pass
`--verbose` to `git-commit`. Add `--no-verbose` to commit to negate that
setting.
Signed-off-by: Caleb Thompson ca...@calebthompson.io
---
Documentation/config.txt | 5 +
Documentation/git-commit.txt
Am 11.06.2014 20:24, schrieb ca...@calebthompson.io:
Add a new configuration variable commit.verbose to implicitly pass
`--verbose` to `git-commit`. Add `--no-verbose` to commit to negate that
setting.
Signed-off-by: Caleb Thompsonca...@calebthompson.io
---
Documentation/config.txt
On Wed, Jun 11, 2014, at 01:41 PM, René Scharfe wrote:
@@ -1556,7 +1560,7 @@ int cmd_commit(int argc, const char **argv, const char
*prefix)
static struct wt_status s;
static struct option builtin_commit_options[] = {
OPT__QUIET(quiet, N_(suppress summary after successful commit)),
-
Jeremiah Mahler jmmah...@gmail.com writes:
On Fri, May 23, 2014 at 04:22:22PM -0500, Caleb Thompson wrote:
This patch allows people to set `commit.verbose` to implicitly send
`--verbose`
...
+cat check-for-no-diff EOF
+#!$SHELL_PATH
+exec grep -v '^diff --git' \$1
+EOF
+chmod +x
test: Use write_script
commit test: test_set_editor in each test
commit: support commit.verbose and --no-verbose
Documentation/config.txt | 5
Documentation/git-commit.txt | 8 +-
builtin/commit.c | 6 -
contrib/completion
Add a new configuration variable commit.verbose to implicitly pass
`--verbose` to `git-commit`. Add `--no-verbose` to commit to negate that
setting.
Signed-off-by: Caleb Thompson ca...@calebthompson.io
---
Documentation/config.txt | 5 +
Documentation/git-commit.txt
j
On Mon, May 26, 2014 at 01:56:26PM -0500, Caleb Thompson wrote:
Add a new configuration variable commit.verbose to implicitly pass
...
+test_expect_success 'commit shows verbose diff with set commit.verbose=true'
'
+ echo morecontent file
+ git add file
+ test_config
The editors, `check-for-diff` and `check-for-no-diffs`, are grepping for the
output and lack thereof, respectively.
On Mon, May 26, 2014 at 01:33:04PM -0700, Jeremiah Mahler wrote:
j
On Mon, May 26, 2014 at 01:56:26PM -0500, Caleb Thompson wrote:
Add a new configuration variable
On Mon, May 26, 2014 at 03:39:55PM -0500, Caleb Thompson wrote:
The editors, `check-for-diff` and `check-for-no-diffs`, are grepping for
the output and lack thereof, respectively.
...
It appears that these tests still aren't checking to see if the
verbose output appears in the commit
Caleb,
On Mon, May 26, 2014 at 01:56:26PM -0500, Caleb Thompson wrote:
Add a new configuration variable commit.verbose to implicitly pass
`--verbose` to `git-commit`. Add `--no-verbose` to commit to negate that
setting.
Signed-off-by: Caleb Thompson ca...@calebthompson.io
---
Caleb,
On Mon, May 26, 2014 at 01:56:21PM -0500, Caleb Thompson wrote:
This patch allows people to set commit.verbose to implicitly send
--verbose to git-commit. It also introduces --no-verbose to
override the configuration setting.
This version incorporates changes suggested by Eric
Great, thanks Jeremiah!
I made that change, and will send up another patch version in the next day or so
while I wait on others who may have input.
I'm really appreciative of everyone's feedback!
Caleb
8--
diff --git
` as a shortened form of `--no-verbose`.
commit 1a49356b87c9028e68e731f34790c11a3075f736
Author: Caleb Thompson ca...@calebthompson.io
Date: Fri May 23 11:47:44 2014 -0500
commit: support commit.verbose and --no-verbose
Add a new configuration variable commit.verbose to implicitly pass
On Sun, May 25, 2014 at 01:24:27AM -0500, Caleb Thompson wrote:
...
would be committed at the bottom of the commit message
template. Note that this diff output doesn't have its
- lines prefixed with '#'.
+ lines prefixed with '#'. The `commit.verbose` configuration
+
On Sun, May 25, 2014 at 01:24:27AM -0500, Caleb Thompson wrote:
Incorporated changes from Duy Nguyen and Jeremiah Mahler.
...
+test_expect_success 'commit shows verbose diff with set commit.verbose' '
+ echo morecontent file
+ git add file
+ test_config commit.verbose true
On Sun, May 25, 2014 at 1:24 PM, Caleb Thompson cjays...@gmail.com wrote:
Duy, you were right about `-V`. Do you know of a simple way to add that
shortened flag? `OPT_BOOL('v', verbose, ...)` gives me `-v`, `--verbose`,
and
`--no-verbose`, but no `-V` as a shortened form of `--no-verbose`.
this line. It has no meaning outside of your local repository.
Author: Caleb Thompson ca...@calebthompson.io
Date: Fri May 23 11:47:44 2014 -0500
Ditto for the date.
commit: support commit.verbose and --no-verbose
Add a new configuration variable commit.verbose to implicitly pass
On Fri, May 23, 2014 at 04:22:22PM -0500, Caleb Thompson wrote:
This patch allows people to set `commit.verbose` to implicitly send
`--verbose`
...
+cat check-for-no-diff EOF
+#!$SHELL_PATH
+exec grep -v '^diff --git' \$1
+EOF
+chmod +x check-for-no-diff
+
For new tests, commands
On Sat, May 24, 2014 at 4:22 AM, Caleb Thompson cjays...@gmail.com wrote:
This patch allows people to set `commit.verbose` to implicitly send
`--verbose`
to `git commit`. It also introduces `--no-verbose` to override the
configuration
setting.
The code change looks fine to me (no opinion
...@calebthompson.io
Date: Fri, 23 May 2014 11:47:44 -0500
Subject: [PATCH] commit: support commit.verbose and --no-verbose
Add a new configuration variable commit.verbose to implicitly pass
`--verbose` to `git-commit`. Add `--no-verbose` to commit to negate that
setting.
Signed-off-by: Caleb Thompson ca
22 matches
Mail list logo
