Re: contrib/diff-highlight: stop hard-coding perl location

2016-02-21 Thread Eric Sunshine
[please don't top-post on this list] On Mon, Feb 22, 2016 at 1:49 AM, Peter Dave Hello wrote: > Thank you, is there anything I should do? Or I should just wait? Best is to wait for other review comments, particularly from Junio. Reviewers work at their own pace as time permits, so don't be surpr

Re: contrib/diff-highlight: stop hard-coding perl location

2016-02-21 Thread Peter Dave Hello
Hi Eric, Thank you, is there anything I should do? Or I should just wait? Best, Peter 2016/2/22 下午1:56於 "Eric Sunshine" 寫道: > > On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello > wrote: > > From: Peter Dave Hello > > > > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`, > > the util "e

Re: contrib/diff-highlight: stop hard-coding perl location

2016-02-21 Thread Eric Sunshine
On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello wrote: > From: Peter Dave Hello > > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`, > the util "env" can help located the "perl", > so that it can work on FreeBSD and other platforms. > > Signed-off-by: Peter Dave Hello Better, thanks.

contrib/diff-highlight: stop hard-coding perl location

2016-02-21 Thread Peter Dave Hello
From: Peter Dave Hello Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`, the util "env" can help located the "perl", so that it can work on FreeBSD and other platforms. Signed-off-by: Peter Dave Hello --- contrib/diff-highlight/diff-highlight | 2 +- 1 file changed, 1 insertion(+), 1 del