Re: dotfiles in git template dir are not copied

2017-02-17 Thread Grégoire PARIS
>There was no 'bug' either. It's just the way it is ;-) Sure !

Re: dotfiles in git template dir are not copied

2017-02-17 Thread Grégoire PARIS
> Thanks for your guidance. I believe I just sent the patch to the mailing list. I just retried with the Gmail SMTP, and now I am sure it worked. Sorry for the noobery.

Re: dotfiles in git template dir are not copied

2017-02-17 Thread Grégoire PARIS
Thanks for your guidance. I believe I just sent the patch to the mailing list.

Re: dotfiles in git template dir are not copied

2017-02-17 Thread Junio C Hamano
Grégoire PARIS writes: >> You could, for example, have your template directory itself be a git > repository. > > I can and I do and indeed, that might be the reason behind this. > I made a PR to document this : https://github.com/git/git/pull/325 Let's take a look. >

Re: dotfiles in git template dir are not copied

2017-02-17 Thread Junio C Hamano
Grégoire PARIS writes: >> I do not think we should change the behaviour >> to copy files whose names begin with a dot. > > So bug turned feature it is :) There was no 'bug' either. It's just the way it is ;-)

Re: dotfiles in git template dir are not copied

2017-02-17 Thread Grégoire PARIS
Le 17/02/2017 à 23:39, Philip Oakley a écrit : From: "Grégoire PARIS" > You could, for example, have your template directory itself be a git repository. I can and I do and indeed, that might be the reason behind this. I made a PR to document this :

Re: Re: dotfiles in git template dir are not copied

2017-02-17 Thread Philip Oakley
From: "Grégoire PARIS" > You could, for example, have your template directory itself be a git repository. I can and I do and indeed, that might be the reason behind this. I made a PR to document this : https://github.com/git/git/pull/325 While the PR is a simple one

Re: dotfiles in git template dir are not copied

2017-02-17 Thread Grégoire PARIS
> I do not think we should change the behaviour > to copy files whose names begin with a dot. So bug turned feature it is :) I amended my commit message accordingly. In my case, my template dir is not at the root of the repository where it is versioned, so it would not be a problem for me,

Re: dotfiles in git template dir are not copied

2017-02-17 Thread Junio C Hamano
Grégoire PARIS writes: >> You could, for example, have your template directory itself be a git > repository. > > I can and I do and indeed, that might be the reason behind this. An embedded .git was _not_ the reason behind the current behaviour when we wrote it. The

Re: Re: dotfiles in git template dir are not copied

2017-02-17 Thread Grégoire PARIS
> You could, for example, have your template directory itself be a git repository. I can and I do and indeed, that might be the reason behind this. I made a PR to document this : https://github.com/git/git/pull/325 -- greg0ire

Re: dotfiles in git template dir are not copied

2017-02-17 Thread Jeff King
On Fri, Feb 17, 2017 at 10:31:37AM +0100, greg0ire wrote: > I noticed yesterday that dotfiles inside the directory configured in > init.templatedir are not copied when creating a new repository. > > Here is the line I think is responsible for this behavior : >

dotfiles in git template dir are not copied

2017-02-17 Thread greg0ire
Hi, I noticed yesterday that dotfiles inside the directory configured in init.templatedir are not copied when creating a new repository. Here is the line I think is responsible for this behavior : https://github.com/git/git/blob/master/builtin/init-db.c#L48 Is it a bug or a feature? Steps