Re: [PATCH] git-completion.bash: Add completion for stash list

2018-10-06 Thread Junio C Hamano
Steve writes: > Since stash list accepts git-log options, add the following useful > options that make sense in the context of the `git stash list` command: > > --name-status --oneline --patch-with-stat > > Signed-off-by: Steven Fernandez > --- > > This is my fi

Re: git log -S or -G

2018-10-06 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Sat, Oct 6, 2018 at 5:16 PM Julia Lawall wrote: >> Git log -S or -G make it possible to find commits that have particular >> words in the changed lines. Sometimes it would be helpful to search for >> words in the removed lines

Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error

2018-10-06 Thread Junio C Hamano
Ananya Krishna Maram writes: >> But it does not need to be escaped, when you specify the regular >> expression the way we do. And the way we specified it is really the >> standard when specifying regular expressions in C code, i.e. *without* the >> suggested backslash. > > Aha!. this makes total

Re: git log -S or -G

2018-10-06 Thread Ævar Arnfjörð Bjarmason
On Sat, Oct 6, 2018 at 5:16 PM Julia Lawall wrote: > Git log -S or -G make it possible to find commits that have particular > words in the changed lines. Sometimes it would be helpful to search for > words in the removed lines or in the added lines specifically. From the > implement

Re: [PATCH 0/1] v2.19.0-rc1 Performance Regression in 'git merge-base'

2018-10-06 Thread Jakub Narebski
"Derrick Stolee via GitGitGadget" writes: > As I was testing the release candidate, I stumbled across a regression in > 'git merge-base' as a result of the switch to generation numbers. The commit > message in [PATCH 1/1] describes the topology involved, but you can

git log -S or -G

2018-10-06 Thread Julia Lawall
Hello, Git log -S or -G make it possible to find commits that have particular words in the changed lines. Sometimes it would be helpful to search for words in the removed lines or in the added lines specifically. From the implementation, I had the impression that this would be easy to implement

[PATCH v5 5/7] tests: don't swallow Git errors upstream of pipes

2018-10-05 Thread Matthew DeVore
Some pipes in tests lose the exit code of git processes, which can mask unexpected behavior like crashes. Split these pipes up so that git commands are only at the end of pipes rather than the beginning or middle. The violations fixed in this patch were found in the process of fixing pipe

[PATCH v5 7/7] tests: order arguments to git-rev-list properly

2018-10-05 Thread Matthew DeVore
It is a common mistake to put positional arguments before flags when invoking git-rev-list. Order the positional arguments last. This patch skips git-rev-list invocations which include the --not flag, since the ordering of flags and positional arguments affects the behavior. This patch also skips

[PATCH v5 6/7] t9109: don't swallow Git errors upstream of pipes

2018-10-05 Thread Matthew DeVore
'git ... | foo' will mask any errors or crashes in git, so split up such pipes in this file. One testcase uses several separate pipe sequences in a row which are awkward to split up. Wrap the split-up pipe in a function so the awkwardness is not repeated. Also change that testcase's surrounding

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Jeff King
x-pack or unpack-objects can easily > > get this information. Commands like fast-import can do likewise, and > > "git commit" obviously increments it by one. > > > > I'm not excited about adding a new global on-disk data structure (and > > the accompanying l

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Jeff King
. One option would be > > to keep a counter of "ungraphed commit objects", and have callers update > > it. Anybody admitting a pack via index-pack or unpack-objects can easily > > get this information. Commands like fast-import can do likewise, and > > "git co

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Ævar Arnfjörð Bjarmason
s update > it. Anybody admitting a pack via index-pack or unpack-objects can easily > get this information. Commands like fast-import can do likewise, and > "git commit" obviously increments it by one. > > I'm not excited about adding a new global on-disk data structure

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Derrick Stolee
easily get this information. Commands like fast-import can do likewise, and "git commit" obviously increments it by one. I'm not excited about adding a new global on-disk data structure (and the accompanying lock). If we want, then we can add an optional chunk to the commit-graph file that stores the object count.

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Jeff King
ormation. Commands like fast-import can do likewise, and "git commit" obviously increments it by one. I'm not excited about adding a new global on-disk data structure (and the accompanying lock). -Peff

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Derrick Stolee
On 10/5/2018 3:21 PM, Jeff King wrote: On Fri, Oct 05, 2018 at 09:45:47AM -0400, Derrick Stolee wrote: My misunderstanding was that your proposed change to gc computes the commit-graph in either of these two cases: (1) The auto-GC threshold is met. (2) There is no commit-graph file. And

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Jeff King
On Fri, Oct 05, 2018 at 09:45:47AM -0400, Derrick Stolee wrote: > My misunderstanding was that your proposed change to gc computes the > commit-graph in either of these two cases: > > (1) The auto-GC threshold is met. > > (2) There is no commit-graph file. > > And what I hope to have instead

Re: [PATCH v4 5/7] tests: don't swallow Git errors upstream of pipes

2018-10-05 Thread Matthew DeVore
I just realized that the changes to t9101 should actually be part of the next patch (6/7), not this one. I've fixed that for the next re-roll.

Re: [PATCH v4 5/7] tests: don't swallow Git errors upstream of pipes

2018-10-05 Thread Matthew DeVore
.after the temp files are created, I see git svn proplist and git svn propget being executed... the public documentation for them does not seem to contradict my assumption. (http://svnbook.red-bean.com/en/1.6/svn.ref.svn.c.propget.html) As for the other test files in this patch, all git invocations

[ANNOUNCE] Git for Windows 2.19.1

2018-10-05 Thread Johannes Schindelin
Dear Git users, It is my pleasure to announce that Git for Windows 2.19.1 is available from: https://gitforwindows.org/ Changes since Git for Windows v2.19.0 (September 11th 2018) New Features * Comes with Git v2.19.1. * Comes with Git LFS v2.5.2. * Comes with Git Credential

[Announce] Git 2.14.5, 2.15.3, 2.16.5, 2.17.2, 2.18.1, and 2.19.1

2018-10-05 Thread Junio C Hamano
These releases fix a security flaw (CVE-2018-17456), which allowed an attacker to execute arbitrary code by crafting a malicious .gitmodules file in a project cloned with --recurse-submodules. When running "git clone --recurse-submodules", Git parses the supplied .gitmodules file for a

Re: [PATCH v4 5/7] tests: don't swallow Git errors upstream of pipes

2018-10-05 Thread Junio C Hamano
Matthew DeVore writes: > Some pipes in tests lose the exit code of git processes, which can mask > unexpected behavior like crashes. Split these pipes up so that git > commands are only at the end of pipes rather than the beginning or > middle. > > The violations fixed in thi

Re: [PATCH v3 1/3] help: redirect to aliased commands for "git cmd --help"

2018-10-05 Thread Junio C Hamano
Rasmus Villemoes writes: >> It also is strange to count from (0); if the patchset is rerolled >> again, I'd prefer to see these start counting from (1), in which >> case this item will become (3). > > If you prefer, I can send a v4. Sure, if you prefer, you can send a v4 for me to look at and

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Ævar Arnfjörð Bjarmason
ion now, but here's a WIP >>>> patch that implements this, highlights: >>>> >>>>* There's a gc.clone.autoDetach=false default setting which overrides >>>> gc.autoDetach if 'git gc --auto' is run via git-clone (we just pass a >>>>

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Derrick Stolee
a gc.clone.autoDetach=false default setting which overrides gc.autoDetach if 'git gc --auto' is run via git-clone (we just pass a --cloning option to indicate this). I'll repeat that it could make sense to do the same thing on clone _and_ fetch. Perhaps a "--post-fetch" flag would be

Re: [BUG] Error while trying to git apply a patch; works with patch -p1

2018-10-05 Thread SZEDER Gábor
/patches/120-fix_link_segfault.patch: No > > > such file or directory > > > error: > > > package/libs/openssl/patches/1.1.0/100-Configure-afalg-support.patch: > > > No such file or directory > > > error: package/libs/openssl/patches/1.1.0/110-openwrt_targets

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Ævar Arnfjörð Bjarmason
ult setting which overrides >> gc.autoDetach if 'git gc --auto' is run via git-clone (we just pass a >> --cloning option to indicate this). > > I'll repeat that it could make sense to do the same thing on clone > _and_ fetch. Perhaps a "--post-fetch" flag w

Re: [BUG] Error while trying to git apply a patch; works with patch -p1

2018-10-05 Thread Eneas Queiroz
t; > error: package/libs/openssl/patches/1.1.0/110-openwrt_targets.patch: > > No such file or directory > > > > If you get the patch file from > > https://github.com/openwrt/openwrt/pull/965.patch and apply it with > > git apply, it fails. If I apply the same file with

Re: [RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Derrick Stolee
On 10/4/2018 5:42 PM, Ævar Arnfjörð Bjarmason wrote: I don't have time to polish this up for submission now, but here's a WIP patch that implements this, highlights: * There's a gc.clone.autoDetach=false default setting which overrides gc.autoDetach if 'git gc --auto' is run via git-clone

Re: [PATCH v3 1/3] help: redirect to aliased commands for "git cmd --help"

2018-10-05 Thread Rasmus Villemoes
resent immediately above the prompt when the user >> quits the pager/returns to the terminal. That serves as an explanation >> for why one was redirected to "man git-cherry-pick" from "git cp >> --help", and if cp is actually 'cherry-pick -n', it reminds the user >&

Re: [PATCH v3 1/3] help: redirect to aliased commands for "git cmd --help"

2018-10-05 Thread Junio C Hamano
Rasmus Villemoes writes: > As discussed in the thread for v1 of this patch [1] [2], this changes the > rules for "git foo --help" when foo is an alias. > > (0) When invoked as "git help foo", we continue to print the "foo is > aliased to bar" message

Re: [PATCH v4 7/7] tests: order arguments to git-rev-list properly

2018-10-05 Thread Junio C Hamano
echo >&2 message ... which has redirection at the beginning to emphasize that the output goes to the standard error stream, I do agree with your "stylistic" choice of keeping the redirection at the end. > diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh > i

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-05 Thread Junio C Hamano
SZEDER Gábor writes: >> git-gc - Cleanup unnecessary files and optimize the local repository >> >> Creating these indexes like the commit-graph falls under "optimize the >> local repository", > > But it doesn't fall under "cleanup unnecessary fi

Re: [BUG] Error while trying to git apply a patch; works with patch -p1

2018-10-04 Thread SZEDER Gábor
error: package/libs/openssl/patches/1.1.0/100-Configure-afalg-support.patch: > No such file or directory > error: package/libs/openssl/patches/1.1.0/110-openwrt_targets.patch: > No such file or directory > > If you get the patch file from > https://github.com/openwrt/openwrt/pull/965.patch

[RFC PATCH] We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-04 Thread Ævar Arnfjörð Bjarmason
or > /etc/gitconfig to apply them to all repos. > > But when I clone e.g. linux.git stuff like 'tag --contains' will be slow > until whenever my first "gc" kicks in, which may be quite some time if > I'm just using it passively. > > So we should make "git

[BUG] Error while trying to git apply a patch; works with patch -p1

2018-10-04 Thread Eneas Queiroz
If you get the patch file from https://github.com/openwrt/openwrt/pull/965.patch and apply it with git apply, it fails. If I apply the same file with patch -p1, it works fine. I've tried it with git 2.16.4 and 2.19, and they both fail with the same error, and at least 2 more people have confirmed

Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error

2018-10-04 Thread Johannes Schindelin
se. I was thinking from a general regular expression > point of view. But I should be thinking from C point of view and how C > might interpret this newly submitted string. > This explanation is very clear. Thanks for taking time to reply to my > patch. From next time on, I will try to th

Re: Git Evolve

2018-10-04 Thread Stefan Xenos
s writes: >> >>> What is the evolve command? >>> ... >>> - Systems like gerrit would no longer need to rely on "change-id" tags >>> in commit comments to associate commits with the change that they >>> edit, since git itself would have that infor

Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error

2018-10-04 Thread Ananya Krishna Maram
be interpreting the backslash > character as escape character in its own right, seeing the forward slash, > and replacing this sequence by a forward slash. > > But it does not need to be escaped, when you specify the regular > expression the way we do. And the way we specified it i

Re: Git Evolve

2018-10-04 Thread Jakub Narebski
Junio C Hamano writes: > Stefan Xenos writes: > >> What is the evolve command? >> ... >> - Systems like gerrit would no longer need to rely on "change-id" tags >> in commit comments to associate commits with the change that they >> edit

Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error

2018-10-04 Thread Johannes Schindelin
ht, seeing the forward slash, and replacing this sequence by a forward slash. But it does not need to be escaped, when you specify the regular expression the way we do. And the way we specified it is really the standard when specifying regular expressions in C code, i.e. *without* the suggested

Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error

2018-10-04 Thread Ananya Krishna Maram
le to more people. Thanks, Ananya. > Thanks, > Johannes > > > --- > > userdiff.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/userdiff.c b/userdiff.c > > index f565f6731..f4ff9b9e5 100644 > &g

Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error

2018-10-04 Thread Johannes Schindelin
hat explains pretty well what you did, but I wonder why the forward slash needs to be escaped? I would understand if we enclosed the pattern in `//`, as it is done e.g. in Javascript, but we do not... Thanks, Johannes > --- > userdiff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: inside the git folder

2018-10-04 Thread Stephen Smith
Chris - You may want to look at "git bundle" to transfer the repository contents. Then the recipient could fetch from the bundle to get the source git history. Just a thought. sps On Thursday, October 4, 2018 4:03:27 AM MST Johannes Schindelin wrote: > Hi Chris, > > as

[PATCH] [Outreachy] git/userdiff.c fix regex pattern error

2018-10-04 Thread Ananya Krishna Maram
the forward slash character should be escaped with backslash. Fix Unescaped forward slash error in Python regex statements. Signed-off-by: Ananya Krishna Maram --- userdiff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/userdiff.c b/userdiff.c index f565f6731..f4ff9b9e5

Re: inside the git folder

2018-10-04 Thread Johannes Schindelin
Hi Chris, as mentioned by Stefan (who is a respected, active core Git contributor, if you need any more arguments to listen to him), it is inappropriate to copy the contents of the .git/ directory wholesale to another user's machine. For one, it would horribly break in case the user overrode

Re: inside the git folder

2018-10-04 Thread Chris Jeschke
Hi Stefan, thanks for your answer. The Goal after sending the files is to have a copy on the remote site. This includes that the working directory is the same (what we already guarantee with our tool) and that git is at the same 'state' (that means that we have the same history and that we

Re: git fetch behaves weirdely when run in a worktree

2018-10-04 Thread Duy Nguyen
he mean time :-) > > > > Oops, I forgot to mention there's more comments inline! > > BTW, is there an issue if .git/HEAD and .git/index are owned by root? The > owners seem to have changed since I created the worktree possibly due to the > cron job. Just wondering if it migh

Re: git fetch behaves weirdely when run in a worktree

2018-10-04 Thread Kaartic Sivaraam
On 3 October 2018 00:13:06 GMT+05:30, Kaartic Sivaraam wrote: >Hi, > >Sorry for the delay. Got a little busy over the weekend. I seem to have >found the reason behind the issue in the mean time :-) > Oops, I forgot to mention there's more comments inline! BTW, is there an iss

Re: git-remote-helper list command question

2018-10-03 Thread Jonathan Nieder
Hi, Jeff King wrote: > On Tue, Oct 02, 2018 at 11:43:50AM +0200, Stanisław Drozd wrote: >> I'm trying to write a fast-import-based git remote helper, but I'm not >> sure what the output of the `list` command should look like. How can I >> find an example of the format in act

Re: Fwd: Git credentials not working

2018-10-03 Thread Dimitri Kopriwa
Thanks everyone. All your answers helped. I found out that the issue was not related to git. I am using semantic-release to perform a release, apparently git-credentials is not working with semantic-release. I did also setup the double authentication and every fix applied on git-credentials

Re: Fwd: Git credentials not working

2018-10-03 Thread Jeff King
On Thu, Oct 04, 2018 at 02:34:17AM +0700, Dimitri Kopriwa wrote: > I have replaced the way I fill the git credentials store, I have verify > ~/.git-credentials and information are there, the ~/.gitconfig look fine > too. > > I still have 401 error when reading

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Ævar Arnfjörð Bjarmason
thout >> dropping files) would be part of it, or the new >> "write additional files". >> >> Maybe we can move all actions of the second bin into a new >> "git optimize" command, and git gc would do first the "throw away >> things&quo

Re: Fwd: Git credentials not working

2018-10-03 Thread Bryan Turner
On Wed, Oct 3, 2018 at 12:34 PM Dimitri Kopriwa wrote: > > I have replaced the way I fill the git credentials store, I have verify > ~/.git-credentials and information are there, the ~/.gitconfig look fine > too. > > I still have 401 error when reading from that file. > &g

[PATCH 2/3] mingw: set _WIN32_WINNT explicitly for Git for Windows

2018-10-03 Thread Johannes Schindelin via GitGitGadget
the target Windows version to Vista (which we will do in the next commit). Signed-off-by: Johannes Schindelin --- git-compat-util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-compat-util.h b/git-compat-util.h index 5f2e90932f..3ba93d9c15 100644 --- a/git-compat-util.h

Re: Fwd: Git credentials not working

2018-10-03 Thread Dimitri Kopriwa
I have replaced the way I fill the git credentials store, I have verify ~/.git-credentials and information are there, the ~/.gitconfig look fine too. I still have 401 error when reading from that file. This is the paste log : https://paste.gnome.org/pmntlkdw0 Now that I use git approve, I

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Jeff King
iles". > > Maybe we can move all actions of the second bin into a new > "git optimize" command, and git gc would do first the "throw away > things" and then the optimize action, whereas clone would only > go for the second optimizing part? One problem w

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Jeff King
excited about the prospect of a bloom filter for paths which each commit touches. I think that's the next big frontier in getting things like "git log -- path" to a reasonable run-time. -Peff

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Stefan Beller
> > But you thought right, I do have an objection against that. 'git gc' > should, well, collect garbage. Any non-gc stuff is already violating > separation of concerns. I share these concerns in a slightly more abstract way, as I would bucket the actions into two separate bi

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Derrick Stolee
happen if you rm'd .git/objects/info/commit-graph and ran "git commit", which would kick of "gc --auto" in the background and do the same thing. Or generating local bitmaps or pack idx files as well? I'm less familiar with this area, but when I clone I get a pack *.idx fi

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Jeff King
uld > >> happen if you rm'd .git/objects/info/commit-graph and ran "git commit", > >> which would kick of "gc --auto" in the background and do the same thing. > > > > Or generating local bitmaps or pack idx files as well? > > I'm less fa

Re: inside the git folder

2018-10-03 Thread Stefan Beller
On Wed, Oct 3, 2018 at 5:26 AM Chris Jeschke wrote: > > Hey git-team, > I am working on a plug-in for a distributed pair programming tool. To > skip the details: I was thinking about sending parts of the git folder > as a zip folder with our own Bytestream instead of us

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Ævar Arnfjörð Bjarmason
On Wed, Oct 03 2018, Stefan Beller wrote: >> So we wouldn't be spending 5 minutes repacking linux.git right after >> cloning it, just ~10s generating the commit graph, and the same would >> happen if you rm'd .git/objects/info/commit-graph and ran "git commit", >&

Re: Fwd: Git credentials not working

2018-10-03 Thread Jeff King
cipher it). > I have retested the token locally and it work when used in the url or using > `Private-Token: ` as stated in the Gitlab documentation > https://docs.gitlab.com/ee/api/README.html#personal-access-tokens I don't think Git will ever send your token in either of those ways. It will

Re: Fwd: Git credentials not working

2018-10-03 Thread Dimitri Kopriwa
lly and it work when used in the url or using `Private-Token: ` as stated in the Gitlab documentation https://docs.gitlab.com/ee/api/README.html#personal-access-tokens Peff, what would be the appropriate way to input my git credential in a 100% success way in a CI? Is this good: git credential appr

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Stefan Beller
> So we wouldn't be spending 5 minutes repacking linux.git right after > cloning it, just ~10s generating the commit graph, and the same would > happen if you rm'd .git/objects/info/commit-graph and ran "git commit", > which would kick of "gc --auto" in the

Re: Git credentials not working

2018-10-03 Thread Dimitri Kopriwa
On 10/3/18 11:03 PM, Christian Couder wrote: (removing git-security from CC) On Wed, Oct 3, 2018 at 4:09 PM Dimitri Kopriwa wrote: Git credentials in ~/.git-credentials and ~/.config/git/credentials are being removed by git upon reading. https://git-scm.com/docs/git-credential says

Re: Fwd: Git credentials not working

2018-10-03 Thread Jeff King
On Wed, Oct 03, 2018 at 09:06:38PM +0700, Dimitri Kopriwa wrote: > 18:25:52.940307 git.c:659   trace: exec: git-credential-store > erase > 18:25:52.940365 run-command.c:637   trace: run_command: > git-credential-store erase > remote: HTTP Basic: Access

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread SZEDER Gábor
On Wed, Oct 03, 2018 at 05:19:41PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> >> >> So we should make "git gc --auto" be run on clone, > >> >> > > >> >> > There is no garbage after 'git clone'... > >> >> >

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Duy Nguyen
On Wed, Oct 3, 2018 at 3:23 PM Ævar Arnfjörð Bjarmason wrote: > > Don't have time to patch this now, but thought I'd send a note / RFC > about this. > > Now that we have the commit graph it's nice to be able to set > e.g. core.commitGraph=true & gc.writeCommitGraph=true in ~/.gitconfig or >

Re: [PATCH v4 7/7] tests: order arguments to git-rev-list properly

2018-10-03 Thread Matthew DeVore
On Wed, Oct 3, 2018 at 9:26 AM Matthew DeVore wrote: > > - git -C pc1 rev-list HEAD --quiet --objects --missing=print >revs && > + git -C pc1 rev-list --quiet --objects --missing=print >revs HEAD && > awk -f print_1.awk revs | ... >

[PATCH v4 7/7] tests: order arguments to git-rev-list properly

2018-10-03 Thread Matthew DeVore
It is a common mistake to put positional arguments before flags when invoking git-rev-list. Order the positional arguments last. This patch skips git-rev-list invocations which include the --not flag, since the ordering of flags and positional arguments affects the behavior. This patch also skips

[PATCH v4 6/7] t9109: don't swallow Git errors upstream of pipes

2018-10-03 Thread Matthew DeVore
'git ... | foo' will mask any errors or crashes in git, so split up such pipes in this file. One testcase uses several separate pipe sequences in a row which are awkward to split up. Wrap the split-up pipe in a function so the awkwardness is not repeated. Also change that testcase's surrounding

[PATCH v4 5/7] tests: don't swallow Git errors upstream of pipes

2018-10-03 Thread Matthew DeVore
Some pipes in tests lose the exit code of git processes, which can mask unexpected behavior like crashes. Split these pipes up so that git commands are only at the end of pipes rather than the beginning or middle. The violations fixed in this patch were found in the process of fixing pipe

Re: Git credentials not working

2018-10-03 Thread Christian Couder
(removing git-security from CC) On Wed, Oct 3, 2018 at 4:09 PM Dimitri Kopriwa wrote: > Git credentials in ~/.git-credentials and ~/.config/git/credentials are > being removed by git upon reading. https://git-scm.com/docs/git-credential says: "If the action is reject, git-credentia

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Ævar Arnfjörð Bjarmason
onfig to apply them to all repos. >> >> >> >> >> >> But when I clone e.g. linux.git stuff like 'tag --contains' will be >> >> >> slow >> >> >> until whenever my first "gc" kicks in, which may be quite some time if >> &

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread SZEDER Gábor
it graph it's nice to be able to set > >> >> e.g. core.commitGraph=true & gc.writeCommitGraph=true in ~/.gitconfig or > >> >> /etc/gitconfig to apply them to all repos. > >> >> > >> >> But when I clone e.g. linux.git stuff like 'tag --contains'

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Duy Nguyen
ate that without doing a full repack. > > > > Or just teach 'git clone' to run 'git commit-graph write ...' > > Then when adding something like the commit graph we'd need to patch both > git-clone and git-gc, it's much more straightforward to make > need_to_gc() more granular. It is

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Ævar Arnfjörð Bjarmason
>> /etc/gitconfig to apply them to all repos. >> >> >> >> But when I clone e.g. linux.git stuff like 'tag --contains' will be slow >> >> until whenever my first "gc" kicks in, which may be quite some time if >> >> I'm just using it pas

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Ævar Arnfjörð Bjarmason
ains' will be slow >>> until whenever my first "gc" kicks in, which may be quite some time if >>> I'm just using it passively. >>> >>> So we should make "git gc --auto" be run on clone, >> There is no garbage after 'git clone'... >

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread SZEDER Gábor
when I clone e.g. linux.git stuff like 'tag --contains' will be slow > >> until whenever my first "gc" kicks in, which may be quite some time if > >> I'm just using it passively. > >> > >> So we should make "git gc --auto" be run on clone, &

Fwd: Git credentials not working

2018-10-03 Thread Dimitri Kopriwa
Dear Git list, I have tried to used git credentials within Gitlab-CI runners. I have 4 instance of GitLab and discovered a weird bug with Git credentials when use within a CI process. Please note before all that the time spend allowed me multiple time to check that my credentials are valid

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Ævar Arnfjörð Bjarmason
h may be quite some time if >> I'm just using it passively. >> >> So we should make "git gc --auto" be run on clone, > > There is no garbage after 'git clone'... "git gc" is really "git gc-or-create-indexes" these days. >> and change the &g

RE: git projects with submodules in different sites - in txt format (:+(

2018-10-03 Thread Michele Hallak
Thank you so much, I will check this GIT bundle Since you asked, here are my answers suffixed by MHS >> Michele -Original Message- From: Philip Oakley [mailto:philipoak...@iee.org] Sent: Wednesday, October 3, 2018 12:00 AM To: Michele Hallak; git@vger.kernel.org Subject: R

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Derrick Stolee
& gc.writeCommitGraph=true in ~/.gitconfig or /etc/gitconfig to apply them to all repos. But when I clone e.g. linux.git stuff like 'tag --contains' will be slow until whenever my first "gc" kicks in, which may be quite some time if I'm just using it passively. So we should make "gi

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread SZEDER Gábor
rue in ~/.gitconfig or > /etc/gitconfig to apply them to all repos. > > But when I clone e.g. linux.git stuff like 'tag --contains' will be slow > until whenever my first "gc" kicks in, which may be quite some time if > I'm just using it passively. > >

We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-03 Thread Ævar Arnfjörð Bjarmason
tuff like 'tag --contains' will be slow until whenever my first "gc" kicks in, which may be quite some time if I'm just using it passively. So we should make "git gc --auto" be run on clone, and change the need_to_gc() / cmd_gc() behavior so that we detect that the gc.write

Re: Git for games working group

2018-10-03 Thread Thomas Braun
Am 17.09.2018 um 17:58 schrieb Jonathan Nieder: [...] > Ah, thanks. See git-config(1): > > core.bigFileThreshold > Files larger than this size are stored deflated, > without attempting delta compression. > > Default is 512

inside the git folder

2018-10-03 Thread Chris Jeschke
Hey git-team, I am working on a plug-in for a distributed pair programming tool. To skip the details: I was thinking about sending parts of the git folder as a zip folder with our own Bytestream instead of using the git API. Is there a common sense about what should and what shouldn't be done when

[PATCH v3 1/3] help: redirect to aliased commands for "git cmd --help"

2018-10-03 Thread Rasmus Villemoes
As discussed in the thread for v1 of this patch [1] [2], this changes the rules for "git foo --help" when foo is an alias. (0) When invoked as "git help foo", we continue to print the "foo is aliased to bar" message and nothing else. (1) If foo is an alias f

[PATCH v3 3/3] git-help.txt: document "git help cmd" vs "git cmd --help" for aliases

2018-10-03 Thread Rasmus Villemoes
This documents the existing behaviour of "git help cmd" when cmd is an alias, as well as providing a hint to use the "git cmd --help" form to be taken directly to the man page for the aliased command. Signed-off-by: Rasmus Villemoes --- Documentation/git-help.txt | 4 +++

Re: [PATCH v2 1/3] help: redirect to aliased commands for "git cmd --help"

2018-10-03 Thread Jeff King
On Wed, Oct 03, 2018 at 08:24:14AM +0200, Rasmus Villemoes wrote: > > The comment probably needs to spell out that exclude_guides > > is the same as your "we were invoked as...". > > Will do. That will also make the string --exclude-guides (i.e., with a > dash) appear in the comment, making it

Re: [PATCH v2 3/3] git-help.txt: document "git help cmd" vs "git cmd --help" for aliases

2018-10-03 Thread Rasmus Villemoes
On 2018-10-03 04:18, Jeff King wrote: > On Mon, Oct 01, 2018 at 01:21:07PM +0200, Rasmus Villemoes wrote: > >> >> +If an alias is given, git prints a note explaining what it is an alias >> +for on standard output. To get the manual page for the aliased >> +co

Re: [PATCH v2 1/3] help: redirect to aliased commands for "git cmd --help"

2018-10-03 Thread Rasmus Villemoes
On 2018-10-03 04:13, Jeff King wrote: >> +/* >> + * If we were invoked as "git help cmd", or cmd is an >> + * alias for a shell command, we inform the user what >> + * cmd i

Re: hunting for lost highly interactive browser based git tutorial

2018-10-02 Thread Jeff King
On Wed, Oct 03, 2018 at 01:28:20AM -0400, _g e r r y _ _l o w r y _ wrote: > The tutorial "may" have be called something like "Try Git"; > however, I can not find it at try.github.io and other places where i have > looked. Unfortunately, Try Git seems to have been s

hunting for lost highly interactive browser based git tutorial

2018-10-02 Thread _g e r r y _ _l o w r y _
Help, please and thank you. i have spent > one hour searching via Google and by visiting git-scm, BitBucket, github, et cetera, for an excellent tutorial for beginners and refresher for one who has not touched git for quite a while. if you've done the same tutorial, you will recognize

Re: [PATCH v2 3/3] git-help.txt: document "git help cmd" vs "git cmd --help" for aliases

2018-10-02 Thread Jeff King
On Mon, Oct 01, 2018 at 01:21:07PM +0200, Rasmus Villemoes wrote: > This documents the existing behaviour of "git help cmd" when cmd is an > alias, as well as providing a hint to use the "git cmd --help" form to > be taken directly to the man page for the aliased

Re: [PATCH v2 1/3] help: redirect to aliased commands for "git cmd --help"

2018-10-02 Thread Jeff King
On Mon, Oct 01, 2018 at 01:21:05PM +0200, Rasmus Villemoes wrote: > As discussed in the thread for v1 of this patch [1] [2], this changes the > rules for "git foo --help" when foo is an alias. > > (0) When invoked as "git help foo", we continue to print the &

Re: Git Evolve

2018-10-02 Thread Taylor Blau
t; >> > >> I'm interested in porting something like Mercurial's evolve command to > >> Git. > > > > Welcome to Git :-). I think that the discussion in this thread is good, > > but it's not why I'm replying. I have also wanted a Mercurial feature in > > G

Re: git clone works in ide but not git bash CLI

2018-10-02 Thread Johannes Schindelin
Hi David, On Mon, 24 Sep 2018, David Brown wrote: > Howdy, I have a conundrum: > > App: Spring Cloud Config Server > envvars: GIT_URL and SSH_KEY > IDE: Intellij 2018.2.4 Ultimate > > When I use the IDE to assign the SSH_KEY value all is copacetic. > > If I assign

Re: cannot dowload from your amazon server a windows git distro

2018-10-02 Thread Taylor Blau
ink at [1] to do so. Can you try again and see if it is a reproducible failure? If so, either the website is sending you to the wrong place, or there is a problem with GitHub (in which case you should contact supp...@github.com, which will route it to the right place.) Thanks, Taylor [1]: https://gi

<    3   4   5   6   7   8   9   10   11   12   >