Re: git config --help not functional on bad config

2017-07-11 Thread Jeff King
On Tue, Jul 11, 2017 at 12:13:59PM -0700, Stefan Beller wrote: > > There are other die calls hidden deeper. For instance: > > > > $ git -c core.ignorecase=foo help config > > fatal: bad numeric config value 'foo' for 'core.ignorecase': invalid unit > > > > Those ones are hard to fix without

Re: git config --help not functional on bad config

2017-07-11 Thread Stefan Beller
On Tue, Jul 11, 2017 at 12:08 PM, Jeff King wrote: > On Tue, Jul 11, 2017 at 12:05:01PM -0700, Stefan Beller wrote: > >> > diff --git a/builtin/help.c b/builtin/help.c >> > index 334a8494a..c42dfc9e9 100644 >> > --- a/builtin/help.c >> > +++ b/builtin/help.c >> > @@ -273,7 +273,7

Re: git config --help not functional on bad config

2017-07-11 Thread Jeff King
On Tue, Jul 11, 2017 at 12:05:01PM -0700, Stefan Beller wrote: > > diff --git a/builtin/help.c b/builtin/help.c > > index 334a8494a..c42dfc9e9 100644 > > --- a/builtin/help.c > > +++ b/builtin/help.c > > @@ -273,7 +273,7 @@ static int git_help_config(const char *var, const char > > *value, void

Re: git config --help not functional on bad config

2017-07-11 Thread Stefan Beller
On Tue, Jul 11, 2017 at 10:53 AM, Jeff King wrote: > On Tue, Jul 11, 2017 at 03:49:21PM +0100, Peter Krefting wrote: > >> That's fine. However, when trying to look for help, it is not that useful: >> >> $ git config --help >> error: malformed value for branch.autosetuprebase >>

Re: git config --help not functional on bad config

2017-07-11 Thread Jeff King
On Tue, Jul 11, 2017 at 03:49:21PM +0100, Peter Krefting wrote: > That's fine. However, when trying to look for help, it is not that useful: > > $ git config --help > error: malformed value for branch.autosetuprebase > fatal: bad config variable 'branch.autosetuprebase' in file

git config --help not functional on bad config

2017-07-11 Thread Peter Krefting
So, I set the wrong value for a configuration option, and git tells me: $ git config branch.autoSetupRebase false $ git log error: malformed value for branch.autosetuprebase fatal: bad config variable 'branch.autosetuprebase' in file '.git/config' at line 24 That's fine. However, when