Re: git fast-import crashing on big imports

2017-01-19 Thread Ulrich Spörlein
2017-01-18 22:51 GMT+01:00 Jeff King : > > On Wed, Jan 18, 2017 at 03:27:04PM -0500, Jeff King wrote: > > > On Wed, Jan 18, 2017 at 09:20:07PM +0100, Ulrich Spörlein wrote: > > > > > I found your commit via bisect in case you were wondering. Thanks for > > > picking this up. > > > >

Re: git fast-import crashing on big imports

2017-01-18 Thread Jeff King
On Wed, Jan 18, 2017 at 03:27:04PM -0500, Jeff King wrote: > On Wed, Jan 18, 2017 at 09:20:07PM +0100, Ulrich Spörlein wrote: > > > I found your commit via bisect in case you were wondering. Thanks for > > picking this up. > > Still downloading. However, just looking at the code, the obvious >

Re: git fast-import crashing on big imports

2017-01-18 Thread Jeff King
On Wed, Jan 18, 2017 at 09:20:07PM +0100, Ulrich Spörlein wrote: > I found your commit via bisect in case you were wondering. Thanks for > picking this up. Still downloading. However, just looking at the code, the obvious culprit would be clear_delta_base_cache(), which is called from literally

Re: git fast-import crashing on big imports

2017-01-18 Thread Jeff King
On Wed, Jan 18, 2017 at 09:38:14AM -0500, Jeff King wrote: > On Wed, Jan 18, 2017 at 03:01:17PM +0100, Ulrich Spoerlein wrote: > > > Yo Jeff, your commit 8261e1f139db3f8aa6f9fd7d98c876cbeb0f927c from Aug > > 22nd, that changes delta_base_cache to use hashmap.h is the culprit for > > git

Re: git fast-import crashing on big imports

2017-01-18 Thread Jeff King
On Wed, Jan 18, 2017 at 03:01:17PM +0100, Ulrich Spoerlein wrote: > Yo Jeff, your commit 8261e1f139db3f8aa6f9fd7d98c876cbeb0f927c from Aug > 22nd, that changes delta_base_cache to use hashmap.h is the culprit for > git fast-import crashing on large imports. I actually saw your bug report the

Re: git fast-import crashing on big imports

2017-01-18 Thread Ulrich Spoerlein
Yo Jeff, your commit 8261e1f139db3f8aa6f9fd7d98c876cbeb0f927c from Aug 22nd, that changes delta_base_cache to use hashmap.h is the culprit for git fast-import crashing on large imports. Please read below, you can find a 55G SVN dump that should show the problem after a couple of minutes to less

git fast-import crashing on big imports

2017-01-12 Thread Ulrich Spörlein
Hey, the FreeBSD svn2git conversion is crashing somewhat non-deterministically during its long conversion process. From memory, this was not as bad is it is with more recent versions of git (but I can't be sure, really). I have a dump file that you can grab at