Re: git log -S or -G

2018-10-09 Thread Julia Lawall
On Tue, 9 Oct 2018, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Oct 09 2018, Junio C Hamano wrote: > > > Jeff King writes: > > > >> I think that is the best we could do for "-S", though, which is > >> inherently about counting hits. > >> > >> For "-G", we are literally grepping the diff. It

Re: git log -S or -G

2018-10-09 Thread Ævar Arnfjörð Bjarmason
On Tue, Oct 09 2018, Junio C Hamano wrote: > Jeff King writes: > >> I think that is the best we could do for "-S", though, which is >> inherently about counting hits. >> >> For "-G", we are literally grepping the diff. It does not seem >> unreasonable to add the ability to grep only "-" or "+"

Re: git log -S or -G

2018-10-09 Thread Julia Lawall
On Mon, 8 Oct 2018, Jacob Keller wrote: > On Mon, Oct 8, 2018 at 8:22 PM Jeff King wrote: > > > > On Tue, Oct 09, 2018 at 08:09:32AM +0900, Junio C Hamano wrote: > > > > > Julia Lawall writes: > > > > > > >> Doing the same for -S is much harder at the machinery level, as it > > > >> performs

Re: git log -S or -G

2018-10-08 Thread Junio C Hamano
Jeff King writes: > I think that is the best we could do for "-S", though, which is > inherently about counting hits. > > For "-G", we are literally grepping the diff. It does not seem > unreasonable to add the ability to grep only "-" or "+" lines, and the > interface for that should be pretty

Re: git log -S or -G

2018-10-08 Thread Jacob Keller
On Mon, Oct 8, 2018 at 8:22 PM Jeff King wrote: > > On Tue, Oct 09, 2018 at 08:09:32AM +0900, Junio C Hamano wrote: > > > Julia Lawall writes: > > > > >> Doing the same for -S is much harder at the machinery level, as it > > >> performs its thing without internally running "diff" twice, but just

Re: git log -S or -G

2018-10-08 Thread Jeff King
On Tue, Oct 09, 2018 at 08:09:32AM +0900, Junio C Hamano wrote: > Julia Lawall writes: > > >> Doing the same for -S is much harder at the machinery level, as it > >> performs its thing without internally running "diff" twice, but just > >> counts the number of occurrences of 'foo'---that is

Re: git log -S or -G

2018-10-08 Thread Junio C Hamano
Julia Lawall writes: >> Doing the same for -S is much harder at the machinery level, as it >> performs its thing without internally running "diff" twice, but just >> counts the number of occurrences of 'foo'---that is sufficient for >> its intended use, and more efficient. > > There is still the

Re: git log -S or -G

2018-10-06 Thread Julia Lawall
On Sun, 7 Oct 2018, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > On Sat, Oct 6, 2018 at 5:16 PM Julia Lawall wrote: > >> Git log -S or -G make it possible to find commits that have particular > >> words in the changed lines. Sometimes

Re: git log -S or -G

2018-10-06 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Sat, Oct 6, 2018 at 5:16 PM Julia Lawall wrote: >> Git log -S or -G make it possible to find commits that have particular >> words in the changed lines. Sometimes it would be helpful to search for >> words in the removed lines

Re: git log -S or -G

2018-10-06 Thread Ævar Arnfjörð Bjarmason
On Sat, Oct 6, 2018 at 5:16 PM Julia Lawall wrote: > Git log -S or -G make it possible to find commits that have particular > words in the changed lines. Sometimes it would be helpful to search for > words in the removed lines or in the added lines specifically. From the > implement

git log -S or -G

2018-10-06 Thread Julia Lawall
Hello, Git log -S or -G make it possible to find commits that have particular words in the changed lines. Sometimes it would be helpful to search for words in the removed lines or in the added lines specifically. From the implementation, I had the impression that this would be easy to implement