git pull defaults for recursesubmodules

2018-10-23 Thread Tommi Vainikainen
I configured my local git to fetch with recurseSubmodules = on-demand, which I found the most convenient setting. However then I noticed that I mostly use git pull actually to fetch from remotes, but git pull does not utilize any recurseSubmoddules setting now, or at least I could not find such. I

Re: git pull defaults for recursesubmodules

2018-10-23 Thread Stefan Beller
On Tue, Oct 23, 2018 at 2:04 PM Tommi Vainikainen wrote: > > I configured my local git to fetch with recurseSubmodules = on-demand, > which I found the most convenient setting. However then I noticed that > I mostly use git pull actually to fetch from remotes, but git pull > does not utilize any r

Re: git pull defaults for recursesubmodules

2018-10-23 Thread brian m. carlson
On Wed, Oct 24, 2018 at 12:04:06AM +0300, Tommi Vainikainen wrote: > I configured my local git to fetch with recurseSubmodules = on-demand, > which I found the most convenient setting. However then I noticed that > I mostly use git pull actually to fetch from remotes, but git pull > does not utiliz

Re: git pull defaults for recursesubmodules

2018-10-23 Thread Tommi Vainikainen
ke 24. lokak. 2018 klo 0.57 Stefan Beller (sbel...@google.com) kirjoitti: > On Tue, Oct 23, 2018 at 2:04 PM Tommi Vainikainen wrote: > > I would expect that if git-config has fetch.recurseSubmodules set, > > also git pull should use this setting, or at least similar option such > > This makes sens

Re: git pull defaults for recursesubmodules

2018-10-23 Thread Tommi Vainikainen
ke 24. lokak. 2018 klo 2.03 brian m. carlson (sand...@crustytoothpaste.net) kirjoitti: > You have an extra '1" at the end of this line. > Also, missing sign-off. See Documentation/SubmittingPatches. After reading SubmittingPatches I didn't find if I should now send a fresh patch with changes squa

Re: git pull defaults for recursesubmodules

2018-10-25 Thread Junio C Hamano
Tommi Vainikainen writes: > After reading SubmittingPatches I didn't find if I should now send a > fresh patch with > changes squashed together or new commits appended after first commit in that > patch. Patch is updated accordingly as fresh patch. (just on mechanics, not on the contents of your