The first patch is a general fixup as per discussion,
the second patch will make Git compile in Windows again (hopefully, not tested)
The number of #ifdefs seems acceptable to me, opinions on that?
This has been developed on top of d075d2604c0f9 (Merge branch
'rs/daemon-plug-child-leak'
into sb/
On Wed, Nov 4, 2015 at 11:59 AM, Torsten Bögershausen wrote:
> On 11/04/2015 12:00 AM, Stefan Beller wrote:
>> On Tue, Nov 3, 2015 at 1:03 PM, Johannes Sixt wrote:
>>
> The #ifdef assumes that Windows never will have O_NONBLOCK/F_GETFL)
>
> Does the following make more sense ?
> #if defined (O_NO
On 11/04/2015 12:00 AM, Stefan Beller wrote:
> On Tue, Nov 3, 2015 at 1:03 PM, Johannes Sixt wrote:
>
The #ifdef assumes that Windows never will have O_NONBLOCK/F_GETFL)
Does the following make more sense ?
#if defined (O_NONBLOCK) && defined (F_GETFL)
Or may be:
#ifndef NO_O_NONBLOCK
>> #ifndef
On Tue, Nov 3, 2015 at 1:03 PM, Johannes Sixt wrote:
> Am 03.11.2015 um 19:18 schrieb Stefan Beller:
>>
>> ... ReadFileEx ... "overlapped" operation.
>
>
> Let's not go there just yet.
>
>>> 1. Make this an optional feature so that platforms can compile it
>>> out, if it is not already done
Am 03.11.2015 um 19:18 schrieb Stefan Beller:
... ReadFileEx ... "overlapped" operation.
Let's not go there just yet.
1. Make this an optional feature so that platforms can compile it
out, if it is not already done. My preference, even if we go
that route, would be to see if we c
On Tue, Nov 3, 2015 at 9:05 AM, Junio C Hamano wrote:
> Johannes Sixt writes:
>
>> My findings so far are negative. The only short-term and mid-term
>> solution I see so far is to opt-out from the framework during
>> build-time.
So I started reading up on that[1].
As far as I understand, we don'
Johannes Sixt writes:
> My findings so far are negative. The only short-term and mid-term
> solution I see so far is to opt-out from the framework during
> build-time.
Now, from where I sit, it seems that the way forward would be
1. Make this an optional feature so that platforms can compile i
Am 03.11.2015 um 00:06 schrieb Stefan Beller:
On Mon, Nov 2, 2015 at 1:15 PM, Johannes Sixt wrote:
run-command.c: In function 'set_nonblocking':
run-command.c:1011: error: 'F_GETFL' undeclared (first use in this function)
run-command.c:1011: error: (Each undeclared identifier is reported only o
On Mon, Nov 2, 2015 at 1:15 PM, Johannes Sixt wrote:
> Am 02.11.2015 um 03:58 schrieb Junio C Hamano:
>> * sb/submodule-parallel-fetch (2015-10-21) 14 commits
>>(merged to 'next' on 2015-10-23 at 8f04bbd)
>> + run-command: fix missing output from late callbacks
>> + test-run-command: incre
Johannes Sixt writes:
> Am 02.11.2015 um 03:58 schrieb Junio C Hamano:
>> * sb/submodule-parallel-fetch (2015-10-21) 14 commits
>>(merged to 'next' on 2015-10-23 at 8f04bbd)
>> + run-command: fix missing output from late callbacks
>>...
>> + submodule.c: write "Fetching submodule " to std
Am 02.11.2015 um 03:58 schrieb Junio C Hamano:
> * sb/submodule-parallel-fetch (2015-10-21) 14 commits
>(merged to 'next' on 2015-10-23 at 8f04bbd)
> + run-command: fix missing output from late callbacks
> + test-run-command: increase test coverage
> + test-run-command: test for gracefull
I've merged a handful of topics to 'next', and hoping that many of
them can be merged to 'master' before I'll go offline for a few
weeks starting on the week #7 of the cycle (starting Nov 9th).
As I hate sending out the whole text back to back (the last one was
issued on the last Friday), here is
12 matches
Mail list logo
