Re: persistent-https, url insteadof, and `git submodule`

2017-05-31 Thread Jeff King
On Wed, May 31, 2017 at 04:23:49PM +0200, Ævar Arnfjörð Bjarmason wrote: > > It really is an issue of the user knowing about the problem (and how to > > solve it), and I don't think we can get around that securely. So better > > documentation probably is the right solution. > > > > I'll see if I

Re: persistent-https, url insteadof, and `git submodule`

2017-05-31 Thread Ævar Arnfjörð Bjarmason
On Wed, May 31, 2017 at 6:50 AM, Jeff King wrote: > On Fri, May 26, 2017 at 11:22:37AM -0500, Elliott Cable wrote: > >> Hi! Thanks for the responses (I hope reply-all isn't bad mailing-list >> etiquette? Feel free to yell at with a direct reply!). For whatever it's >> worth, as a

Re: persistent-https, url insteadof, and `git submodule`

2017-05-30 Thread Jeff King
On Fri, May 26, 2017 at 11:22:37AM -0500, Elliott Cable wrote: > Hi! Thanks for the responses (I hope reply-all isn't bad mailing-list > etiquette? Feel free to yell at with a direct reply!). For whatever it's > worth, as a random user, here's my thoughts: No, reply-all is the preferred method

Re: persistent-https, url insteadof, and `git submodule`

2017-05-26 Thread Elliott Cable
Hi! Thanks for the responses (I hope reply-all isn't bad mailing-list etiquette? Feel free to yell at with a direct reply!). For whatever it's worth, as a random user, here's my thoughts: On Sat, May 20, 2017 at 2:07 AM, Jeff King wrote: > On Fri, May 19, 2017 at 11:55:34PM +0200,

Re: persistent-https, url insteadof, and `git submodule`

2017-05-20 Thread Jeff King
On Fri, May 19, 2017 at 11:55:34PM +0200, Dennis Kaarsemaker wrote: > > > Presumably this isn't intended behaviour? > > > > It actually is. git-submodule sets GIT_PROTOCOL_FROM_USER to 0, which > > makes git not trust any urls except http(s), git, ssh and file urls > > unless you explicitely

Re: persistent-https, url insteadof, and `git submodule`

2017-05-19 Thread Dennis Kaarsemaker
On Fri, 2017-05-19 at 23:43 +0200, Dennis Kaarsemaker wrote: > On Fri, 2017-05-19 at 14:57 -0500, Elliott Cable wrote: > > Set up `persistent-https` as described in the [README][]; including the > > ‘rewrite https urls’ feature in `.gitconfig`: > > > > [url "persistent-https"] > >

Re: persistent-https, url insteadof, and `git submodule`

2017-05-19 Thread Dennis Kaarsemaker
On Fri, 2017-05-19 at 14:57 -0500, Elliott Cable wrote: > Set up `persistent-https` as described in the [README][]; including the > ‘rewrite https urls’ feature in `.gitconfig`: > > [url "persistent-https"] > insteadof = https > [url "persistent-http"] > insteadof = http >

persistent-https, url insteadof, and `git submodule`

2017-05-19 Thread Elliott Cable
Set up `persistent-https` as described in the [README][]; including the ‘rewrite https urls’ feature in `.gitconfig`: [url "persistent-https"] insteadof = https [url "persistent-http"] insteadof = http Unfortunately, this breaks `git submodule add`: > git submodule