Re: [PATCH v3 11/11] Unify appending signoff in format-patch, commit and sequencer

2013-01-27 Thread Jonathan Nieder
Brandon Casey wrote: --- a/log-tree.c +++ b/log-tree.c [...] @@ -208,94 +207,6 @@ void show_decorations(struct rev_info *opt, struct commit *commit) putchar(')'); } -/* - * Search for ^[-A-Za-z]+: [^@]+@ pattern. It usually matches - * Signed-off-by: and Acked-by: lines. - */

Re: [PATCH v3 00/11] unify appending of sob

2013-01-27 Thread Jonathan Nieder
Brandon Casey wrote: Round 3. Thanks for a pleasant read. My only remaining observations are cosmetic, except for a portability question in Duy's test script, a small behavior change when the commit message ends with an RFC2822-style header with no trailing newline and the possibility of

Updating shared ref from remote helper, or fetch hook

2013-01-27 Thread Jed Brown
I'm working on an hg remote helper that uses git notes for the sha1 revision, so that git users can more easily refer to specific commits when communicating with hg users. Since there may be multiple concurrent fast-import streams, I write the notes to a private ref (refs/notes/hg-REMOTE), to be

Re: [PATCH v3 05/11] sequencer.c: recognize (cherry picked from ... as part of s-o-b footer

2013-01-27 Thread Brandon Casey
On Sun, Jan 27, 2013 at 6:51 PM, Jonathan Nieder jrnie...@gmail.com wrote: Jonathan Nieder wrote: Here's the tweak I suggested last time. I think its behavior is slightly better in the ends with incomplete line case because it limits the characters examined by is_rfc2822_line() and

Re: [PATCH v3 09/11] t4014: more tests about appending s-o-b lines

2013-01-27 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Brandon Casey wrote: [...] --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -1021,4 +1021,246 @@ test_expect_success 'cover letter using branch description (6)' ' grep hello actual /dev/null ' +append_signoff() +{ +

Re: [PATCH 6/7] read-cache: refuse to create index referring to external objects

2013-01-27 Thread Duy Nguyen
On Sat, Jan 26, 2013 at 2:00 AM, Junio C Hamano gits...@pobox.com wrote: This is not a tangent, but if you want to go this forbid making our repository depend on objects we do not have but we know about after we peek submodule odb route [*1*], write_sha1_file() needs to be told about

Re: [PATCH v3 00/11] unify appending of sob

2013-01-27 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Brandon Casey wrote: Round 3. Thanks for a pleasant read. My only remaining observations are cosmetic, except for a portability question in Duy's test script, a small behavior change when the commit message ends with an RFC2822-style header with

Re: [PATCH v3 09/11] t4014: more tests about appending s-o-b lines

2013-01-27 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Is grep -n portable? I didn't find any uses of it elsewhere in the testsuite. Yes, -n is in POSIX. Even though we use it ourselves, git grep supports it, too. Ehh even though we *DONT* use it ourselves, ... that is. I do not think we mind, if its

Re: [PATCH 6/7] read-cache: refuse to create index referring to external objects

2013-01-27 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Sat, Jan 26, 2013 at 2:00 AM, Junio C Hamano gits...@pobox.com wrote: This is not a tangent, but if you want to go this forbid making our repository depend on objects we do not have but we know about after we peek submodule odb route [*1*],

Re: [PATCH 6/7] read-cache: refuse to create index referring to external objects

2013-01-27 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: Another thing needs to be done for this to work. The current reading For *what* to work??? The forbid making our repository depend on objects we do not have but we know about afterwe peek submodule odb With your when our object database is contaminated,

[PATCH] l10n: de.po: translate 11 new messages

2013-01-27 Thread Ralf Thielow
Translate 11 new messages came from git.pot update in 46bc403 (l10n: Update git.pot (11 new, 7 removed messages)). Signed-off-by: Ralf Thielow ralf.thie...@gmail.com --- po/de.po | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/po/de.po

Re: [PATCH 6/7] read-cache: refuse to create index referring to external objects

2013-01-27 Thread Duy Nguyen
On Mon, Jan 28, 2013 at 12:48 PM, Duy Nguyen pclo...@gmail.com wrote: Regardless the submodule odb issue, I think we should prefer reading local loose objects over alternate packed ones. I think I went from one problem to another and did not make it clear. The reason behind this preference is

Re: [PATCH 6/7] read-cache: refuse to create index referring to external objects

2013-01-27 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Mon, Jan 28, 2013 at 12:48 PM, Duy Nguyen pclo...@gmail.com wrote: Regardless the submodule odb issue, I think we should prefer reading local loose objects over alternate packed ones. I think I went from one problem to another and did not make it

What's cooking in git.git (Jan 2013, #10; Sun, 27)

2013-01-27 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. As usual, this cycle is expected to last for 8 to 10 weeks, with a preview -rc0 sometime in the middle of next month. You can find the changes

Re: [PATCH 6/7] read-cache: refuse to create index referring to external objects

2013-01-27 Thread Duy Nguyen
On Mon, Jan 28, 2013 at 1:36 PM, Junio C Hamano gits...@pobox.com wrote: Duy Nguyen pclo...@gmail.com writes: On Mon, Jan 28, 2013 at 12:48 PM, Duy Nguyen pclo...@gmail.com wrote: Regardless the submodule odb issue, I think we should prefer reading local loose objects over alternate packed

Re: [PATCH v4 1/2] for-each-repo: new command used for multi-repo operations

2013-01-27 Thread Lars Hjemli
On Sun, Jan 27, 2013 at 8:04 PM, Junio C Hamano gits...@pobox.com wrote: Lars Hjemli hje...@gmail.com writes: The command also honours the option '--clean' which restricts the set of repos to those which '--dirty' would skip, and '-x' which is used to execute non-git commands. It might make

<    1   2