[PATCH v4 0/2] path: implement common_dir handling in git_path_submodule()

2015-03-18 Thread Max Kirillov
After http://thread.gmane.org/gmane.comp.version-control.git/261990 the only thing which did not enter the serie is these 2 pathes. Should be applied over the patches by link, or ecf2ff6ace6a1cc3d55b6f917be5452b5fb0c21b in current pu. Max Kirillov (2): submodule refactor: use

[PATCH v4 1/2] submodule refactor: use git_path_submodule() in add_submodule_odb()

2015-03-18 Thread Max Kirillov
Signed-off-by: Max Kirillov m...@max630.net --- submodule.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/submodule.c b/submodule.c index 34094f5..4aad3d4 100644 --- a/submodule.c +++ b/submodule.c @@ -122,43 +122,35 @@ void

per-repository and per-worktree config variables

2015-03-18 Thread Max Kirillov
On Sun, Feb 08, 2015 at 09:36:43AM -0800, Jens Lehmann wrote: I wonder if it's worth all the hassle to invent new names. Wouldn't it be much better to just keep a list of per-worktree configuration value names and use that inside the config code to decide where to find them for multiple work

Re: [PATCH v3 1/4] git-credential-store: support multiple credential files

2015-03-18 Thread Paul Tan
Hi all, thanks for providing your feedback. On Sun, Mar 15, 2015 at 6:14 AM, Junio C Hamano gits...@pobox.com wrote: I am not sure if this is not a premature over-engineering---I am not convinced that such a future need will be fulfilled by passing just a single default_fn this version already

[PATCH v5/GSoC/MICRO] revision: forbid combining --graph and --no-walk

2015-03-18 Thread Dongcan Jiang
Because --graph is about connected history while --no-walk is about discrete points, it does not make sense to allow giving these two options at the same time. [1] This change makes a few calls to show --graph fail in t4052, but asking to show one commit with graph is a nonsensical thing to do.

[PATCH] sha1fd_check: die when we cannot open the file

2015-03-18 Thread Jeff King
Right now we return a NULL struct sha1file if we encounter an error. However, the sole caller (write_idx_file) does not check the return value, and will segfault if we hit this case. One option would be to handle the error in the caller. However, there's really nothing for it to do but die. This

<    1   2