Re: t6044 broken on pu

2016-05-09 Thread Jeff King
On Mon, May 09, 2016 at 08:30:51AM +0200, demerphq wrote: > > - perl -le 'print for $ARGV[0]..$ARGV[1]' -- "$@" > > + test_seq_counter__=$1 > > + while test "$test_seq_counter__" -le $2 > > + do > > + echo "$test_seq_counter__" > > +

Re: [PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

2016-05-09 Thread Jeff King
On Mon, May 09, 2016 at 10:13:51AM +0200, Johannes Schindelin wrote: > do you sleep at all? Actually, I just woke up. Nothing like some Git ML to get the blood pumping in the morning. > Yeah, a faulty Apache config will unfortunately *skip* the entire test, as > httpd refuses to start. If you

Re: [PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

2016-05-09 Thread Johannes Schindelin
Hi Peff, do you sleep at all? On Mon, 9 May 2016, Jeff King wrote: > On Mon, May 09, 2016 at 08:19:00AM +0200, Johannes Schindelin wrote: > > > test_expect_success 'custom http headers' ' > > - test_must_fail git fetch "$HTTPD_URL/smart_headers/repo.git" && > > + test_must_fail git -c

Re: [PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

2016-05-09 Thread Jeff King
On Mon, May 09, 2016 at 08:19:00AM +0200, Johannes Schindelin wrote: > To test that extra HTTP headers are passed correctly, t5551 verifies that > a fetch succeeds when two required headers are passed, and that the fetch > does not succeed when those headers are not passed. > > However, this

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

2016-05-09 Thread Jeff King
On Mon, May 09, 2016 at 08:18:52AM +0200, Johannes Schindelin wrote: > +# Apache 2.2 does not understand , so we use RewriteCond. > +# And as RewriteCond unfortunately lacks "not equal" matching, we use this > +# ugly trick to fail *unless* the two headers are present. > +RewriteCond

Re: [PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

2016-05-09 Thread Lars Schneider
On 09 May 2016, at 08:19, Johannes Schindelin wrote: > To test that extra HTTP headers are passed correctly, t5551 verifies that > a fetch succeeds when two required headers are passed, and that the fetch > does not succeed when those headers are not passed. > >

Re: t6044 broken on pu

2016-05-09 Thread demerphq
On 8 May 2016 at 20:20, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> May a simple >> printf "1\n2\n3\n4\n5\n6\n7\n8\n9\n10\n" >> >> be an option ? > > If you were to do that, at least have the decency to make it more > readable by doing something

[PATCH v7 3/3] submodule: pass on http.extraheader config settings

2016-05-09 Thread Johannes Schindelin
To support this developer's use case of allowing build agents token-based access to private repositories, we introduced the http.extraheader feature, allowing extra HTTP headers to be sent along with every HTTP request. This patch allows us to configure these extra HTTP headers for use with `git

[PATCH v7 0/3] Add support for sending additional HTTP headers (part 2)

2016-05-09 Thread Johannes Schindelin
My use case is an army of build agents that need only limited and selective access to otherwise private repositories. The first part already made it into `master`, this is the remainder. This iteration still has the specific patch to make `git -c http.extraHeader=... submodule update` work; I

[PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

2016-05-09 Thread Johannes Schindelin
To test that extra HTTP headers are passed correctly, t5551 verifies that a fetch succeeds when two required headers are passed, and that the fetch does not succeed when those headers are not passed. However, this test would also succeed if the configuration required only one header. As Apache's

[PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

2016-05-09 Thread Johannes Schindelin
Lars Schneider noticed that the configuration introduced to test the extra HTTP headers cannot be used with Apache 2.2 (which is still actively maintained, as pointed out by Junio Hamano). To let the tests pass with Apache 2.2 again, let's substitute the offending and `expr` by using old school

<    1   2