Re: [PATCH 09/12] read-cache: abstract away uses of SHA-1

On Sun, Jan 28, 2018 at 10:57 AM, brian m. carlson wrote: > Convert various uses of direct calls to SHA-1 and 20- and 40-based > constants to use the_hash_algo instead. Don't yet convert the on-disk > data structures, which will be handled in a future commit. > >

Re: [PATCH 08/12] pack-write: switch various SHA-1 values to abstract forms

On Sun, Jan 28, 2018 at 09:30:36PM +0100, Patryk Obara wrote: > On 28/01/2018 16:57, brian m. carlson wrote: > > if (partial_pack_offset == 0) { > > - unsigned char sha1[20]; > > - git_SHA1_Final(sha1, _sha1_ctx); > > - if

Re: [PATCH 06/12] fast-import: switch various uses of SHA-1 to the_hash_algo

On 28/01/2018 16:57, brian m. carlson wrote: - if (last && last->data.buf && last->depth < max_depth && dat->len > 20) { + if (last && last->data.buf && last->depth < max_depth && dat->len > the_hash_algo->rawsz) { At this point line is almost 100 characters long - maybe it's

Re: [PATCH 00/12] object_id part 11 (the_hash_algo)

I looked at your branch object-id-part-12, and it conflicts with my next batch of object_id conversions in quite many places (mostly through formatting). Therefore I'll hold my horses and postpone my conversion patches at least until part 12 will be sent. -- | ← Ceci n'est pas une pipe Patryk

Re: git send-email sets date

On Sun, Jan 28, 2018 at 03:56:57PM -, Philip Oakley wrote: > Michal, you may want to hack up an option that can automatically create > that format if it is of use. I sometimes find the sort order an issue in > some of my mail clients. If there is a From: header in the beginning of the mail

Re: [PATCH RFC 03/24] cat-file: split expand_atom into 2 functions

2018-01-27 0:46 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Split expand_atom function into 2 different functions, >> expand_atom_into_fields prepares variable for further filling, >> (new) expand_atom creates resulting string. >> Need

Dear Sir/Madam!

Dear Sir/Madam, Good day ! Please permit me to introduce myself, I am MIMI IBRAHIM COULIBALY 17 years old female from the Republic of Ivory Coast, in Abidjan; I'm the Daughter of Late Chief Sgt. Ibrahim Coulibaly (A.K.A General Warlord IB ). My late Father was a well known Ivory Coast

Re: [PATCH RFC 01/24] ref-filter: get rid of goto

2018-01-26 23:19 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Get rid of goto command in ref-filter for better readability. >> >> Signed-off-by: Olga Telezhnaia >> Mentored-by: Christian Couder

Re: [PATCH RFC 02/24] ref-filter: add return value to some functions

2018-01-27 0:05 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Add return flag to format_ref_array_item, show_ref_array_item, >> get_ref_array_info and populate_value for further using. >> Need it to handle situations when item is broken but

Re: [PATCH 2/3] perf/aggregate: add --reponame option

On Sun, Jan 28, 2018 at 8:57 PM, Eric Sunshine wrote: > > Not a big deal, but the extra indentation (and noisy diff) could be > avoided like this: > > my $environment; > if ($reponame) { > $environment = $reponame; > } else if (exists ...) { >

Re: git send-email sets date

On Fri, Jan 26, 2018 at 6:32 PM, Michal Suchánek wrote: > This is wrong because the message will most likely not get delivered > when the author date differs from current time. Others have covered other bases here, but I just wanted to ask about this. Are there really mail

Re: [PATCH v2] daemon: add --send-log-to=(stderr|syslog|none)

On Sun, Jan 28, 2018 at 5:58 PM, Lucas Werkmeister wrote: > On 28.01.2018 07:40, Eric Sunshine wrote: >> On Sat, Jan 27, 2018 at 1:31 PM, Lucas Werkmeister >> wrote: >>> This makes it possible to use --inetd while still logging to standard >>>

Re: [PATCH 09/12] read-cache: abstract away uses of SHA-1

On Sun, Jan 28, 2018 at 02:50:18PM -0500, Eric Sunshine wrote: > On Sun, Jan 28, 2018 at 10:57 AM, brian m. carlson > wrote: > > Convert various uses of direct calls to SHA-1 and 20- and 40-based > > constants to use the_hash_algo instead. Don't yet convert the

Re: [PATCH 2/3] perf/aggregate: add --reponame option

On Sun, Jan 28, 2018 at 6:18 AM, Christian Couder wrote: > This makes it easier to use the aggregate script > on the command line when one wants to get the > "environment" fields set in the codespeed output. > > Previously setting GIT_REPO_NAME was needed > for this

Re: [PATCH 02/12] hash: create union for hash context allocation

On 28/01/2018 16:57, brian m. carlson wrote: In various parts of our code, we want to allocate a structure representing the internal state of a hash algorithm. The original implementation of the hash algorithm abstraction assumed we would do that using heap allocations, and added a context size

Re: [PATCH 00/12] object_id part 11 (the_hash_algo)

On Sun, Jan 28, 2018 at 09:48:28PM +0100, Patryk Obara wrote: > I looked at your branch object-id-part-12, and it conflicts with my next > batch of object_id conversions in quite many places (mostly through > formatting). Therefore I'll hold my horses and postpone my conversion > patches at least

Re: Some rough edges of core.fsmonitor

On Sun, Jan 28, 2018 at 9:44 PM, Johannes Schindelin wrote: > Hi, > > On Sat, 27 Jan 2018, Ævar Arnfjörð Bjarmason wrote: > >> I just got around to testing this since it landed, for context some >> previous poking of mine in [1]. >> >> Issues / stuff I've noticed: >>

Re: [RFC PATCH 0/2] alternate hash test

On Sun, Jan 28, 2018 at 07:58:10PM +0100, Ævar Arnfjörð Bjarmason wrote: > On Sun, Jan 28, 2018 at 6:06 PM, brian m. carlson > wrote: > If the goal is to smoke out hardcoded SHA1s in tests, isn't it easier > to instrument SHA-1 (e.g. our blk_sha1 copy, or our

Urgent Message

Dearest I am Mrs. Lucy Nnani, 68 years of age from England, married to an Australian citizen I came across your profile and decided to mail you, I am a cancer patient . looking for somebody I can trust to join hands together and use my life savings to help the less privilege since I know my

t9128 failing randomly with svn 1.9?

While running tests for my object_id part 11 series, I noticed a random segfault in git svn while running t9128. I've reproduced this on a different machine as well, using both Subversion 1.9.5 and 1.9.7 (Debian stable and unstable). It is reproducible on master. When the test fails, it fails

Re: [PATCH 02/12] hash: create union for hash context allocation

On Sun, Jan 28, 2018 at 08:57:21PM +0100, Patryk Obara wrote: > On 28/01/2018 16:57, brian m. carlson wrote: > > In various parts of our code, we want to allocate a structure > > representing the internal state of a hash algorithm. The original > > implementation of the hash algorithm abstraction

Re: [PATCH v2] daemon: add --send-log-to=(stderr|syslog|none)

On 28.01.2018 07:40, Eric Sunshine wrote: > On Sat, Jan 27, 2018 at 1:31 PM, Lucas Werkmeister > wrote: >> This makes it possible to use --inetd while still logging to standard >> error. --syslog is retained as an alias for --send-log-to=syslog. A mode >> to disable

[PATCH] doc: mention 'git show' defaults to HEAD

When 'git show' is called without any object it defaults to HEAD. This has been true since d4ed9793fd ("Simplify common default options setup for built-in log family.", 2006-04-16). The SYNOPSIS suggests that the object argument is required. Clarify that it is not required and note the default.

Re: [PATCH 08/12] pack-write: switch various SHA-1 values to abstract forms

On 28/01/2018 16:57, brian m. carlson wrote: if (partial_pack_offset == 0) { - unsigned char sha1[20]; - git_SHA1_Final(sha1, _sha1_ctx); - if (hashcmp(sha1, partial_pack_sha1) != 0) +

Re: Some rough edges of core.fsmonitor

Hi, On Sat, 27 Jan 2018, Ævar Arnfjörð Bjarmason wrote: > I just got around to testing this since it landed, for context some > previous poking of mine in [1]. > > Issues / stuff I've noticed: > > 1) We end up invalidating the untracked cache because stuff in .git/ > changed. For example: > >

Re: t9128 failing randomly with svn 1.9?

brian m. carlson wrote: > While running tests for my object_id part 11 series, I noticed a random > segfault in git svn while running t9128. I've reproduced this on a > different machine as well, using both Subversion 1.9.5 and 1.9.7 (Debian > stable and unstable). It is reproducible on master.

[PATCH 3/3] perf/aggregate: sort JSON fields in output

It is much easier to diff the output against a preivous one when the fields are sorted. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index

[PATCH 2/3] perf/aggregate: add --reponame option

This makes it easier to use the aggregate script on the command line when one wants to get the "environment" fields set in the codespeed output. Previously setting GIT_REPO_NAME was needed for this purpose. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 31

[PATCH 1/3] perf/aggregate: add --subsection option

This makes it easier to use the aggregate script on the command line, to get results from subsections. Previously setting GIT_PERF_SUBSECTION was needed for this purpose. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 33 -

Re: Creating sparse checkout in a new linked git worktree

On Sun, Jan 28, 2018 at 2:25 PM, Eric Sunshine wrote: > On Wed, Jan 24, 2018 at 11:11 AM, Jessie Hernandez > wrote: >> I am trying to get a sparse checkout in a linked worktree but cannot get >> it working. I have tried the following >> >> * git

Re: [PATCH 3/3] perf/aggregate: sort JSON fields in output

From: "Christian Couder" It is much easier to diff the output against a preivous s/preivous/previous/ one when the fields are sorted. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1

Re: Git For Aix 6 and 7

I have git on my portal www.aixtools.net (See http://www.aixtools.net/index.php/git) These are installp packages - and what you install, you can uninstall. There are some dependencies (e.g., python, gnu grep, and a few others). Can't say I use it daily, but I do use it weekly. For additional

Re: Cloned repository has file changes -> bug?

On Sat, Jan 27, 2018 at 07:35:49PM +, Filip Jorissen wrote: > I think our git repository is bugged. The reason why I say this is the > following. When cloning the repository, the newly cloned repository > immediately has file changes. Steps to reproduce and illustration is at the > end of

Re: [PATCH v2 1/1] setup: recognise extensions.objectFormat

On Sun, Jan 28, 2018 at 01:36:17AM +0100, Patryk Obara wrote: > This extension selects which hashing algorithm from vtable should be > used for reading and writing objects in the object store. At the moment > supports only single value (sha-1). I think you want an "it" here: "At the moment *it*

[PATCH 10/12] csum-file: rename sha1file to hashfile

Rename struct sha1file to struct hashfile, along with all of its related functions. The transformation in this commit was made by global search-and-replace. --- builtin/index-pack.c | 20 +-- builtin/pack-objects.c | 52 +-

[PATCH 03/12] builtin/index-pack: improve hash function abstraction

Convert several uses of unsigned char [20] to struct object_id and convert various hard-coded constants and uses of SHA-1 functions to use the_hash_algo. Signed-off-by: brian m. carlson --- builtin/index-pack.c | 90

[PATCH 02/12] hash: create union for hash context allocation

In various parts of our code, we want to allocate a structure representing the internal state of a hash algorithm. The original implementation of the hash algorithm abstraction assumed we would do that using heap allocations, and added a context size element to struct git_hash_algo. However,

[PATCH 07/12] pack-check: convert various uses of SHA-1 to abstract forms

Convert various explicit calls to use SHA-1 functions and constants to references to the_hash_algo. Make several strings more generic with respect to the hash algorithm used. Signed-off-by: brian m. carlson --- pack-check.c | 32 1

[PATCH 08/12] pack-write: switch various SHA-1 values to abstract forms

Convert various uses of hardcoded 20- and 40-based numbers to use the_hash_algo, along with direct calls to SHA-1. Adjust the names of variables to refer to "hash" instead of "sha1". Signed-off-by: brian m. carlson --- pack-write.c | 49

[PATCH 11/12] csum-file: abstract uses of SHA-1

Convert several direct uses of SHA-1 to use the_hash_algo instead. Convert one use of the constant 20 as well. Signed-off-by: brian m. carlson --- csum-file.c | 10 +- csum-file.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

Re: git send-email sets date

On Fri, Jan 26, 2018 at 06:32:30PM +0100, Michal Suchánek wrote: > git send-email sets the message date to author date. > > This is wrong because the message will most likely not get delivered > when the author date differs from current time. It might give slightly > better results with commit

recommendations for log enhancement

Our team studies the consistent edits of git during evolution. And we find several missed edits in the latest release of git. For example, there are two consist edits we have figured out from historical commits: 1) . Version: git 2.3.9 – git-2.3.10 File: builtin/merge-tree.c

[PATCH 00/12] object_id part 11 (the_hash_algo)

This series includes various changes to adopt the use of the_hash_algo for abstracting hash algorithms away. The series moves much of the hash-related code to hash.h from cache.h, drops the ctxsz member in favor of allowing stack-allocated hash contexts, and switches object-related code to use

[PATCH 01/12] hash: move SHA-1 macros to hash.h

Most of the other code dealing with SHA-1 and other hashes is located in hash.h, which is in turn loaded by cache.h. Move the SHA-1 macros to hash.h as well, so we can use them in additional hash-related items in the future. Signed-off-by: brian m. carlson ---

[PATCH 06/12] fast-import: switch various uses of SHA-1 to the_hash_algo

Switch various uses of explicit calls to SHA-1 to use the_hash_algo. Convert various uses of 20 and the GIT_SHA1 constants as well. Signed-off-by: brian m. carlson --- fast-import.c | 40 1 file changed, 20 insertions(+), 20

[PATCH 04/12] builtin/unpack-objects: switch uses of SHA-1 to the_hash_algo

Switch various uses of explicit calls to SHA-1 into references to the_hash_algo to better abstract away the various uses of it. Signed-off-by: brian m. carlson --- builtin/unpack-objects.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

[PATCH 09/12] read-cache: abstract away uses of SHA-1

Convert various uses of direct calls to SHA-1 and 20- and 40-based constants to use the_hash_algo instead. Don't yet convert the on-disk data structures, which will be handled in a future commit. Signed-off-by: brian m. carlson --- read-cache.c | 54

[PATCH 12/12] bulk-checkin: abstract SHA-1 usage

Convert uses of the direct SHA-1 functions to use the_hash_algo instead. Signed-off-by: brian m. carlson --- bulk-checkin.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/bulk-checkin.c b/bulk-checkin.c index 5f79ed6ea3..8bcd1c8665

[PATCH 05/12] sha1_file: switch uses of SHA-1 to the_hash_algo

Switch various uses of explicit calls to SHA-1 into references to the_hash_algo for better abstraction. Convert some calls to use struct object_id. Signed-off-by: brian m. carlson --- sha1_file.c | 52 ++-- 1 file

RE: git send-email sets date

Behalf Of brian m. carlson > On Fri, Jan 26, 2018 at 06:32:30PM +0100, Michal Suchánek wrote: > > git send-email sets the message date to author date. > > > > This is wrong because the message will most likely not get delivered > > when the author date differs from current time. It might give

[RFC PATCH 2/2] Switch default hash algorithm to short BLAKE2b for testing

Set the default hash algorithm to short (160-bit) BLAKE2b so we can identify tests that rely on a given hash algorithm. This is a test commit and should not be used in production. Widespread test breakage occurs when using this commit. --- repository.c | 2 +- setup.c | 2 +-

[RFC PATCH 1/2] Base test implementation for short BLAKE2b support

Test the implementation of a second hash algorithm with "short" (160-bit) BLAKE2b support. Simply add an additional algorithm to the codebase without changing the use of any hash function and add a test helper. BLAKE2b was chosen simply because it provides a readily accessible hash algorithm

[RFC PATCH 0/2] alternate hash test

This series wires up an alternate hash implementation, namely BLAKE2b-160. The goal is to allow us to identify tests which rely on the hash algorithm in use so that we can fix those tests. For this test, I picked BLAKE2b-160 for a couple reasons: * Debian ships a libb2-1 package which can be

Re: [RFC PATCH 0/2] alternate hash test

> This series wires up an alternate hash implementation, namely > BLAKE2b-160. The goal is to allow us to identify tests which rely on > the hash algorithm in use so that we can fix those tests. > t9903-bash-prompt.sh (Wstat: 256 Tests: 66 > Failed: 53) > Failed

Re: [RFC PATCH 0/2] alternate hash test

On Sun, Jan 28, 2018 at 6:06 PM, brian m. carlson wrote: > For this test, I picked BLAKE2b-160 for a couple reasons: > * Debian ships a libb2-1 package which can be used easily (in other > words, I was lazy and didn't want to add a crypto implementation just >