Re: [RFC PATCH 02/10] submodule: factor out a config_gitmodules_set function

On Mon, May 14, 2018 at 3:58 AM, Antonio Ospite wrote: > Introduce a new config_gitmodules_set function to write config values to the > .gitmodules file. > > This is in preparation for a future change which will use the function > to write to the .gitmodules file in a more controlled

Re: [RFC PATCH 09/10] submodule: support reading .gitmodules even when it's not checked out

On Mon, May 14, 2018 at 3:58 AM, Antonio Ospite wrote: > When the .gitmodules file is not available in the working directory, try > using HEAD:.gitmodules from the index. I think HEAD:.gitmodules is different than the index (the former is part of the latest commit, whereas the index

Re: [PATCH RFC] ref-filter: start using oid_object_info

Junio C Hamano writes: > Olga Telezhnaya writes: > >> Start using oid_object_info_extended(). So, if info from this function >> is enough, we do not need to get and parse whole object (as it was before). >> It's good for 3 reasons: >> 1. Some Git

[PATCH] grep: handle corrupt index files early

Any other caller of 'repo_read_index' dies upon a negative return of it, so grep should, too. Signed-off-by: Stefan Beller --- Found while reviewing the series https://public-inbox.org/git/20180514105823.8378-1-...@ao2.it/ builtin/grep.c | 3 ++- 1 file changed, 2

Re: [RFC PATCH 03/10] t7411: be nicer to other tests and really clean things up

On Mon, May 14, 2018 at 3:58 AM, Antonio Ospite wrote: > Tests 5 and 8 in t/t7411-submodule-config.sh add two commits with > invalid lines in .gitmodules but then only the second commit is removed. > > This may affect subsequent tests if they assume that the .gitmodules > file has no

Re: [PATCH 2/2] merge-recursive: i18n submodule merge output and respect verbosity

I know I said the patches looked okay earlier, but I just noticed something... On Thu, May 10, 2018 at 2:19 PM, Stefan Beller wrote: > case 1: > - MERGE_WARNING(path, "not fast-forward"); > - fprintf(stderr, "Found a possible merge

Re: [RFC PATCH 04/10] submodule--helper: add a new 'config' subcommand

On Mon, May 14, 2018 at 3:58 AM, Antonio Ospite wrote: > Add a new 'config' subcommand to 'submodule--helper', this extra level > of indirection makes it possible to add some flexibility to how the > submodules configuration is handled. > > Signed-off-by: Antonio Ospite

Re: [PATCH v1 2/8] Add initial odb remote support

Christian Couder writes: > diff --git a/odb-helper.h b/odb-helper.h > new file mode 100644 > index 00..61d2ad082b > --- /dev/null > +++ b/odb-helper.h > @@ -0,0 +1,13 @@ > +#ifndef ODB_HELPER_H > +#define ODB_HELPER_H > + Here is a good space to write a

Re: [PATCH RFC] ref-filter: start using oid_object_info

Olga Telezhnaya writes: > Start using oid_object_info_extended(). So, if info from this function > is enough, we do not need to get and parse whole object (as it was before). > It's good for 3 reasons: > 1. Some Git commands potentially will work faster. > 2. It's much

Re: [RFC PATCH 00/10] Make submodules work if .gitmodules is not checked out

Antonio Ospite writes: > - my git terminology may still be a little off: do "work tree" and > "work directory" mean the same thing? Just on this tangent. When we talk about the current working directory of a process returned by getcwd((3) call, we typically spell that word

<    1   2