Re: [RFC/PATCH] avoid SIGPIPE warnings for aliases

2013-01-04 Thread Johannes Sixt
Am 04.01.2013 13:47, schrieb Jeff King: I have two reservations with this patch: 1. We are ignoring SIGPIPE all the time. For an alias that is calling log, that is fine. But if pack-objects dies on the server side, seeing that it died from SIGPIPE is useful data, and we are

Re: What's cooking in git.git (Jan 2013, #02; Thu, 3)

2013-01-04 Thread Adam Spiers
On Thu, Jan 3, 2013 at 7:17 PM, Junio C Hamano gits...@pobox.com wrote: * as/check-ignore (2012-12-28) 19 commits - Add git-check-ignore sub-command - setup.c: document get_pathspec() - pathspec.c: extract new validate_path() for reuse - pathspec.c: move reusable code from builtin/add.c

RE: Lockless Refs? (Was [PATCH] refs: do not use cached refs in repack_without_ref)

2013-01-04 Thread Pyeron, Jason J CTR (US)
From: Martin Fick Sent: Thursday, January 03, 2013 6:53 PM Any thoughts on this idea? Is it flawed? I am trying to write it up in a more formal generalized manner and was hoping to get at least one it seems sane before I do. If you are assuming that atomic renames, etc. are available,

Re: Lockless Refs? (Was [PATCH] refs: do not use cached refs in repack_without_ref)

2013-01-04 Thread Martin Fick
On Friday, January 04, 2013 10:52:43 am Pyeron, Jason J CTR (US) wrote: From: Martin Fick Sent: Thursday, January 03, 2013 6:53 PM Any thoughts on this idea? Is it flawed? I am trying to write it up in a more formal generalized manner and was hoping to get at least one it seems

Re: Proposal for git stash rename

2013-01-04 Thread Micheil Smith
Greg Hewgill greg at hewgill.com writes: On Sun, Jun 20, 2010 at 10:54:43AM +, ??var Arnfj??r?? Bjarmason wrote: It's good to post a WIP PATCH even if it needs cleanup, just as a point for further discussion. Thanks, point taken. WIP patch follows. This patch implements a git

[PATCH] wincred: improve compatibility with windows versions

2013-01-04 Thread Karsten Blees
On WinXP, the windows credential helper doesn't work at all (due to missing Cred[Un]PackAuthenticationBuffer APIs). On Win7, the credential format used by wincred is incompatible with native Windows tools (such as the control panel applet or 'cmdkey.exe /generic'). These Windows tools only set the

[BUG] git submodule update is not fail safe

2013-01-04 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. My network connection at times is rather unstable, so I can experience all sort of network problems. Today I tried to clone the qemu repository, and then to update all submodules. I'm using git from a recent master (790c83 - 14 December). This

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-04 Thread Junio C Hamano
Adam Spiers g...@adamspiers.org writes: diff --git a/builtin/clean.c b/builtin/clean.c index 0c7b3d0..bd18b88 100644 --- a/builtin/clean.c +++ b/builtin/clean.c @@ -97,9 +97,10 @@ int cmd_clean(int argc, const char **argv, const char *prefix) if (!ignored)

Re: as/check-ignore (was Re: What's cooking in git.git (Jan 2013, #02; Thu, 3))

2013-01-04 Thread Junio C Hamano
Adam Spiers g...@adamspiers.org writes: On Thu, Jan 3, 2013 at 7:17 PM, Junio C Hamano gits...@pobox.com wrote: * as/check-ignore (2012-12-28) 19 commits - Add git-check-ignore sub-command - setup.c: document get_pathspec() - pathspec.c: extract new validate_path() for reuse -

RE: [PATCH v4] git-completion.bash: add support for path completion

2013-01-04 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo Sent: Friday, December 21, 2012 11:55 AM To: git@vger.kernel.org Cc: sze...@ira.uka.de; felipe.contre...@gmail.com; Manlio Perillo Subject: [PATCH v4]

Re: [RFC/PATCH] avoid SIGPIPE warnings for aliases

2013-01-04 Thread Jeff King
On Fri, Jan 04, 2013 at 05:55:18PM +0100, Johannes Sixt wrote: Am 04.01.2013 13:47, schrieb Jeff King: I have two reservations with this patch: 1. We are ignoring SIGPIPE all the time. For an alias that is calling log, that is fine. But if pack-objects dies on the server side,

Re: Lockless Refs?

2013-01-04 Thread Junio C Hamano
Martin Fick mf...@codeaurora.org writes: Any thoughts on this idea? Is it flawed? I am trying to write it up in a more formal generalized manner and was hoping to get at least one it seems sane before I do. The general impression I have been getting was that this isn't even worth the

Re: Proposal for git stash rename

2013-01-04 Thread Junio C Hamano
Micheil Smith mich...@brandedcode.com writes: This patch implements a git stash rename using a new git reflog update command that updates the message associated with a reflog entry. ... I note that this proposal is now two years old. A work in progress patch was requested, however, after

Re: [PATCH] SubmittingPatches: Document how to request a patch review tag

2013-01-04 Thread Junio C Hamano
Jason Holden jason.k.holden.sw...@gmail.com writes: A very similiar question was asked previously in: http://thread.gmane.org/gmane.comp.version-control.git/185564/focus=185570 Reviewed-by is for those who are familiar with the part of the system being touched to say I reviewed this patch, it

Re: [BUG] git submodule update is not fail safe

2013-01-04 Thread Junio C Hamano
Manlio Perillo manlio.peri...@gmail.com writes: $ git submodule update --init ... Submodule 'roms/vgabios' (git://git.qemu.org/vgabios.git/) registered for path 'roms/vgabios' fatal: unable to connect to anongit.freedesktop.org: anongit.freedesktop.org[0: 131.252.210.161]: errno=Connection

Re: [PATCH] wincred: improve compatibility with windows versions

2013-01-04 Thread Erik Faye-Lund
On Fri, Jan 4, 2013 at 9:28 PM, Karsten Blees karsten.bl...@gmail.com wrote: On WinXP, the windows credential helper doesn't work at all (due to missing Cred[Un]PackAuthenticationBuffer APIs). On Win7, the credential format used by wincred is incompatible with native Windows tools (such as the

Re: [RFC/PATCH] avoid SIGPIPE warnings for aliases

2013-01-04 Thread Junio C Hamano
Jeff King p...@peff.net writes: I have two reservations with this patch: 1. We are ignoring SIGPIPE all the time. For an alias that is calling log, that is fine. But if pack-objects dies on the server side, seeing that it died from SIGPIPE is useful data, and we are

Re: git.wiki.kernel.org spam ...

2013-01-04 Thread rupert THURNER
2012/12/31 Johannes Schindelin johannes.schinde...@gmx.de: Hi Rupert, On Sat, 29 Dec 2012, rupert THURNER wrote: ich hab gesehen, du bist ober-meister des kernle.org git wikis. da gibt es ganz schön viel neue user und spam derzeit, zb:

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-04 Thread Junio C Hamano
Marc Khouzam marc.khou...@ericsson.com writes: I've been playing with it but I'm not getting the expected behavior when I cd to a sub-directory. Thanks for testing. Manlio? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: git.wiki.kernel.org spam ...

2013-01-04 Thread Johannes Schindelin
Hi Rupert, On Sat, 5 Jan 2013, rupert THURNER wrote: 2012/12/31 Johannes Schindelin johannes.schinde...@gmx.de: there are 3 admins: * https://git.wiki.kernel.org/index.php/Special:Contributions/KorgWikiSysop, last contribution january 2010 *

[PATCH] gitk: Display the date of a tag in a human friendly way.

2013-01-04 Thread Anand Kumria
By selecting a tag within gitk you can display information about it. This information is output by using the command 'git cat-file tag tagid' This outputs the *raw* information from the tag, amongst which is the time - in seconds since the epoch. As useful as that value is, I find it a lot

Re: git.wiki.kernel.org spam ...

2013-01-04 Thread Theodore Ts'o
On Sat, Jan 05, 2013 at 12:27:12AM +0100, Johannes Schindelin wrote: I was. John Hawley trusted me when I asked for admin privileges to keep the spam at bay, but a very vocal voice on the mailing list tried to discredit my work, and in the wake of the ensuing mailing list thread I got the

Re: [PATCH] gitk: Display the date of a tag in a human friendly way.

2013-01-04 Thread Junio C Hamano
Anand Kumria wildf...@progsoc.org writes: By selecting a tag within gitk you can display information about it. This information is output by using the command 'git cat-file tag tagid' This outputs the *raw* information from the tag, amongst which is the time - in seconds since the epoch.

[BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread David Michael
It is possible for this pointer of the GIT_DIR environment variable to survive unduplicated until further getenv calls are made. The standards allow for subsequent calls of getenv to overwrite the string located at its returned pointer, and this can result in broken git operations on certain

Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread Junio C Hamano
David Michael fedora@gmail.com writes: I have encountered an issue with consecutive calls to getenv overwriting earlier values. Most notably, it prevents a plain git clone from working. Long story short: This value of GIT_DIR gets passed around setup.c until it reaches

Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread Duy Nguyen
On Sat, Jan 5, 2013 at 7:35 AM, David Michael fedora@gmail.com wrote: -if (gitdirenv) -return setup_explicit_git_dir(gitdirenv, cwd, len, nongit_ok); +if (gitdirenv) { +gitdirenv = xstrdup(gitdirenv); +ret = setup_explicit_git_dir(gitdirenv, cwd, len,

Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: ... So even if the standard allowed the returned value to be volatile across calls to getenv(3),... ... In fact, http://pubs.opengroup.org/onlinepubs/9699919799/functions/getenv.html says that only ... Apparently I wasn't even reading what I

Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: Maybe we could all this into a wrapper? If getenv() here has a problem, many other places may have the same problem too. This simplifies the change. But one has to check that getenv() must not be used in threaded code. That needs to be done regardless, if

Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread Duy Nguyen
On Sat, Jan 5, 2013 at 11:38 AM, Junio C Hamano gits...@pobox.com wrote: I personally do not think a wrapper with limited slots is a healthy direction to go. Most places we use getenv() do not let the return value live across their scope, and those that do should explicitly copy the value

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-04 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Marc Khouzam marc.khou...@ericsson.com writes: I've been playing with it but I'm not getting the expected behavior when I cd to a sub-directory. Thanks for testing. Manlio? Can you try the attached patch? As I am not familiar with the completion

Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Sat, Jan 5, 2013 at 11:38 AM, Junio C Hamano gits...@pobox.com wrote: I personally do not think a wrapper with limited slots is a healthy direction to go. Most places we use getenv() do not let the return value live across their scope, and those that

[PATCH 00/10] push: switch default from matching to simple

2013-01-04 Thread Junio C Hamano
We promised to change the behaviour of lazy git push [there] that does not say what to push on the command line from matching to simple in Git 2.0. Even though the top-level RelNotes symbolic link points at 1.8.2, we can change our mind to tag 2.0 at the end of this cycle. This carries out the

[PATCH 01/10] t5404: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t5404-tracking-branches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5404-tracking-branches.sh b/t/t5404-tracking-branches.sh index c240035..2b8c0ba 100755 --- a/t/t5404-tracking-branches.sh +++

[PATCH 02/10] t5505: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t5505-remote.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index ccc55eb..6579a86 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -345,7 +345,7 @@ test_expect_success

[PATCH 03/10] t5516: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t5516-fetch-push.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh index b5417cc..1a8753d 100755 --- a/t/t5516-fetch-push.sh +++ b/t/t5516-fetch-push.sh @@ -247,7

[PATCH 04/10] t5517: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t5517-push-mirror.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5517-push-mirror.sh b/t/t5517-push-mirror.sh index e2ad260..12a5dfb 100755 --- a/t/t5517-push-mirror.sh +++ b/t/t5517-push-mirror.sh @@ -256,7 +256,7

[PATCH 05/10] t5519: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t5519-push-alternates.sh | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/t/t5519-push-alternates.sh b/t/t5519-push-alternates.sh index c00c9b0..11fcd37 100755 --- a/t/t5519-push-alternates.sh +++

[PATCH 06/10] t5531: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t5531-deep-submodule-push.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t5531-deep-submodule-push.sh b/t/t5531-deep-submodule-push.sh index 1947c28..8c16e04 100755 --- a/t/t5531-deep-submodule-push.sh +++

[PATCH 07/10] t7406: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t7406-submodule-update.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index feaec6c..c675ce6 100755 --- a/t/t7406-submodule-update.sh +++

[PATCH 10/10] push: switch default from matching to simple

2013-01-04 Thread Junio C Hamano
We promised to change the behaviour of lazy git push [there] that does not say what to push on the command line from matching to simple in Git 2.0. This finally flips that bit. Signed-off-by: Junio C Hamano gits...@pobox.com --- Documentation/config.txt | 6 +++--- builtin/push.c |

[PATCH 09/10] t9401: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t9401-git-cvsserver-crlf.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t9401-git-cvsserver-crlf.sh b/t/t9401-git-cvsserver-crlf.sh index 1c5bc84..8c3db76 100755 --- a/t/t9401-git-cvsserver-crlf.sh +++ b/t/t9401-git-cvsserver-crlf.sh

[PATCH 08/10] t9400: do not assume the matching push is the default

2013-01-04 Thread Junio C Hamano
Signed-off-by: Junio C Hamano gits...@pobox.com --- t/t9400-git-cvsserver-server.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh index 9502f24..0431386 100755 --- a/t/t9400-git-cvsserver-server.sh +++

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

2013-01-04 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Adam Spiers g...@adamspiers.org writes: diff --git a/builtin/clean.c b/builtin/clean.c index 0c7b3d0..bd18b88 100644 --- a/builtin/clean.c +++ b/builtin/clean.c @@ -97,9 +97,10 @@ int cmd_clean(int argc, const char **argv, const char *prefix)