Re: [PATCH v2] CEST is +0200 during April

2013-08-17 Thread Aaron Schrab
Mattias, the convention on this list is to send directly to participants in the thread as well as the list. So I've added Andreas as a recipient. At 05:52 +0200 17 Aug 2013, Mattias Andrée maand...@operamail.com wrote: - For example CET (which is 2 hours ahead UTC) is `+0200`. +

Re: [PATCH v2] CEST is +0200 during April

2013-08-17 Thread Mattias Andrée
Sorry I forgot to add him when I used `git send-email`. On Sat, 17 Aug 2013 02:36:44 -0400 Aaron Schrab aa...@schrab.com wrote: Mattias, the convention on this list is to send directly to participants in the thread as well as the list. So I've added Andreas as a recipient. At 05:52 +0200

Re: [PATCH] create_delta_index: simplify condition always evaluating to true

2013-08-17 Thread Philip Oakley
From: Stefan Beller stefanbel...@googlemail.com The code sequence ' (1u i) hsize i 31 ' is a multi step process, whose first step requires that 'i' is already less that 31, otherwise the result (1u i) is undefined (and 'undef_val hsize' can therefore be assumed to be 'false'), and so

[PATCH v2] bash prompt: test the prompt with newline in repository path

2013-08-17 Thread SZEDER Gábor
Newlines in the path to a git repository were not an issue for the git-specific bash prompt before commit efaa0c1532 (bash prompt: combine 'git rev-parse' executions in the main code path, 2013-06-17), because the path returned by 'git rev-parse --git-dir' was directly stored in a variable, and

Re: [RFC PATCHv2] repack: rewrite the shell script in C.

2013-08-17 Thread René Scharfe
This is the beginning of the rewrite of the repacking. * Removed unneeded system header files * corrected remove_pack to really remove any pack files with the given sha1 * fail if pack-objects fails * Only test t7701 (2nd) fails now with this patch. Signed-off-by: Stefan Beller

Re: [PATCH] tag: Use OPT_BOOL instead of OPT_BOOLEAN to allow one action multiple times

2013-08-17 Thread Stefano Lattarini
(Going through old mail today, sorry for the late reply) On 08/01/2013 12:10 AM, Junio C Hamano wrote: Stefan Beller stefanbel...@googlemail.com writes: On 07/31/13 00:28, Junio C Hamano wrote: we could just do #define OPT_CMDMODE(s, l, v, h) \ { OPTION_CMDMODE, (s), (l), (v),

Re: [PATCH] xread(): Fix read error when filtering = 2GB on Mac OS X

2013-08-17 Thread John Keeping
On Sat, Aug 17, 2013 at 02:40:05PM +0200, Steffen Prohaska wrote: Previously, filtering more than 2GB through an external filter (see test) failed on Mac OS X 10.8.4 (12E55) with: error: read from external filter cat failed error: cannot feed the input to external filter cat

Re: so, for the really out of date...

2013-08-17 Thread Stefan Beller
On 08/17/2013 05:10 PM, Jules wrote: I am running a Mac, v 10.6.8 It's some animal, I really don't follow this, like a lion (I think.) Now, this mac is the only machine I let touch the internet. So obviously I have to make git work here. I have gnu gcc installed. Is their source code

Re: [PATCH] xread(): Fix read error when filtering = 2GB on Mac OS X

2013-08-17 Thread Torsten Bögershausen
On 2013-08-17 14.40, Steffen Prohaska wrote: Previously, filtering more than 2GB through an external filter (see test) failed on Mac OS X 10.8.4 (12E55) with: error: read from external filter cat failed error: cannot feed the input to external filter cat error: cat died of

Re: [PATCH 2/2] submodule: don't print status output with ignore=all

2013-08-17 Thread brian m. carlson
On Sun, Aug 11, 2013 at 04:03:17PM +, brian m. carlson wrote: On Sat, Aug 03, 2013 at 11:24:20AM -0700, Jonathan Nieder wrote: If I just renamed a submodule, will 'module_name $path' do the right thing with the old path? module_name uses whatever's in .gitmodules. I'm not sure what

Re: [PATCH] xread(): Fix read error when filtering = 2GB on Mac OS X

2013-08-17 Thread Johannes Sixt
Am 17.08.2013 14:40, schrieb Steffen Prohaska: Previously, filtering more than 2GB through an external filter (see test) failed on Mac OS X 10.8.4 (12E55) with: error: read from external filter cat failed error: cannot feed the input to external filter cat error: cat died of

[PATCH v2 2/2] submodule: don't print status output with ignore=all

2013-08-17 Thread brian m. carlson
git status prints information for submodules, but it should ignore the status of those which have submodule.name.ignore set to all. Fix it so that it does properly ignore those which have that setting either in .git/config or in .gitmodules. Not ignored are submodules that are added, deleted, or

[PATCH v2 0/2] Don't print status output with submodule.name.ignore=all

2013-08-17 Thread brian m. carlson
There are configuration options for each submodule that specify under what circumstances git status should display output for that submodule. Unfortunately, these settings were not being respected, and as such the tests were marked TODO. This patch series consists of two patches: the first is a

[PATCH v2 1/2] submodule: fix confusing variable name

2013-08-17 Thread brian m. carlson
cmd_summary reads the output of git diff, but reads in the submodule path into a variable called name. Since this variable does not contain the name of the submodule, but the path, rename it to be clearer what data it actually holds. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net

Re: [PATCH] xread(): Fix read error when filtering = 2GB on Mac OS X

2013-08-17 Thread Jonathan Nieder
Hi, Steffen Prohaska wrote: --- a/wrapper.c +++ b/wrapper.c @@ -139,6 +139,14 @@ ssize_t xread(int fd, void *buf, size_t len) { ssize_t nr; while (1) { +#ifdef __APPLE__ + const size_t twoGB = (1l 31); + /* len = 2GB immediately fails on Mac OS X

Re: [RFC PATCHv2] repack: rewrite the shell script in C.

2013-08-17 Thread Kyle J. McKay
On Aug 17, 2013, at 06:34, René Scharfe wrote: On Aug 15, 2013, at 17:12, Stefan Beller wrote: + if (sha_begin = e-d_name !strncmp(sha_begin, sha1, 40)) { + char *fname; + fname = xmalloc(strlen(path) + 1 + strlen(e-d_name)); This

Re: [PATCH] xread(): Fix read error when filtering = 2GB on Mac OS X

2013-08-17 Thread Kyle J. McKay
On Aug 17, 2013, at 05:40, Steffen Prohaska wrote: Previously, filtering more than 2GB through an external filter (see test) failed on Mac OS X 10.8.4 (12E55) with: error: read from external filter cat failed error: cannot feed the input to external filter cat error: cat died of

Re: [PATCH] tag: Use OPT_BOOL instead of OPT_BOOLEAN to allow one action multiple times

2013-08-17 Thread Jonathan Nieder
Stefano Lattarini wrote: Why not encourage the use of a standardized '--action' option instead? Because it's an unpleasant UI. :) This can work with lesser compatibility headaches for both the commands taking mode options and the commands taking mode words: git submodule init becomes

Re: [PATCH] xread(): Fix read error when filtering = 2GB on Mac OS X

2013-08-17 Thread Jonathan Nieder
Kyle J. McKay wrote: According to POSIX [1] for read: If the value of nbyte is greater than {SSIZE_MAX}, the result is implementation-defined. Sure. [...] Since OS X still supports running 32-bit executables, and SSIZE_MAX is 2GB - 1 when running 32-bit it would seem the same limit has