Hi,
Amending a commit using git gui resets its author, unlike plain git
commit --amend.
- Orgad
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Executes checkout without -q
---
git-submodule.sh | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index a33f68d..5c4e057 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -5,11 +5,11 @@
# Copyright (c) 2007
This configuration variable sets the default for the --full-name option.
Signed-off-by: Andreas Schwab sch...@linux-m68k.org
---
Documentation/git-grep.txt | 3 +++
grep.c | 5 +
2 files changed, 8 insertions(+)
diff --git a/Documentation/git-grep.txt
On 3/11/2014 12:10 PM, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
Documentation on the whole argument parsing is quite short, so, I
though, adding an example just to show how usage is generated would
look like I am trying to make this feature look important than it is
:)
Hi,
I'm Yuxuan Shui, a undergraduate student from China. I'm applying for
GSoC 2014, and here is my proposal:
I found this idea on the ideas page, and did some research about it.
The pack bitmap patchset add a new .bitmap file for every pack file
which contains the reachability information of
From: Nishchal nishga...@gmail.com
I am Nishchal Gaba, a GSOC 2014 aspirant, submitting patch in response to
microproject(8)
Similar Execution Time, but increased readability
Alternate Solution Discarded: Table driven code using commonanilty of the
statements to be printed due to _()
On Mar 12, 2014, at 2:38 AM, Orgad Shaneh org...@gmail.com wrote:
Executes checkout without -q
—
Missing sign-off. See Documentation/SubmittingPatches.
Your patch is badly whitespace-damaged, as if it was pasted into your email
client. “git send-email” can avoid this problem.
As I’m not a
Thanks for the submission. Comments below to give you a taste of the
Git review process...
On Tue, Mar 11, 2014 at 11:47 PM, Yao Zhao zhaox...@umn.edu wrote:
Subject: SoC 2014 MicroProject No.8:change multiple if-else statement to
table-driven approach
The email subject is extracted
Nishhal Gaba nishga...@gmail.com writes:
From: Nishchal nishga...@gmail.com
Set user.email/user.name and sendemail.from to the same address to avoid
this inline From:.
I am Nishchal Gaba, a GSOC 2014 aspirant, submitting patch in response to
microproject(8)
This part of your message is the
On Mon, 10 Mar 2014 19:39:00 +, Shawn Pearce wrote:
Yes, this was my real concern. Eclipse users using EGit expect EGit to
be compatible with git-core at the filesystem level so they can do
something in EGit then switch to a shell and bang out a command, or
run a script provided by their
By convention, no full stop in the subject line. The subject should
summarize your changes and add ..NONEG is just one part of it. The
other is convert to use ...NONEG. So I suggest parse-options:
convert to use new macro OPT_SET_INT_NONEG() or something like that.
You should also explain in the
Karsten,
Thanks for your feedback!
On 03/11/2014 11:56 AM, Karsten Blees wrote:
Am 10.03.2014 12:00, schrieb Michael Haggerty:
Reference transactions --
Very cool ideas indeed.
However, I'm concerned a bit that transactions are conceptual
overkill. How many
Hi,
I just added a few microproject suggestions to the list for
newly-arriving students [1]. A couple of them are weak, but I think
number 17 has enough aspects to keep a whole crew of students busy for a
while.
Michael
[1] http://git.github.io/SoC-2014-Microprojects.html
--
Michael Haggerty
Currently the linked list of lockfiles only grows, never shrinks. Once
an object has been linked into the list, there is no way to remove it
again even after the lock has been released. So if a lock needs to be
created dynamically at a random place in the code, its memory is
unavoidably
On Wed, Mar 5, 2014 at 7:10 AM, Junio C Hamano gits...@pobox.com wrote:
[Graduated to master]
* jk/pack-bitmap (2014-02-12) 26 commits
(merged to 'next' on 2014-02-25 at 5f65d26)
And it's finally in! Shall we start thinking about the next on-disk
format? It was put aside last time to focus
From: Orgad Shaneh org...@gmail.com
Executes checkout without -q
Signed-off-by: Orgad Shaneh org...@gmail.com
---
Documentation/git-submodule.txt | 7 +--
git-submodule.sh| 24 +++-
t/t7406-submodule-update.sh | 9 +
3 files changed, 33
memcmp() is replaced with starts_with() when comparing strings from the
beginning. starts_with() looks nicer and it saves the extra argument of
the length of the comparing string.
Signed-off-by: Quint Guvernator quintus.pub...@gmail.com
---
builtin/apply.c | 10
On Wed, Mar 12, 2014 at 8:44 PM, Quint Guvernator
quintus.pub...@gmail.com wrote:
diff --git a/builtin/apply.c b/builtin/apply.c
index a7e72d5..8f21957 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -846,8 +846,8 @@ static int has_epoch_timestamp(const char *nameline)
*
2014-03-12 9:51 GMT-04:00 Duy Nguyen pclo...@gmail.com:
starts_with(..) == !memcmp(...). So
you need to negate every replacement.
My apologies--it doesn't look like the tests caught it either. I will
fix this and submit a new patch.
--
To unsubscribe from this list: send the line unsubscribe
memcmp() is replaced with negated starts_with() when comparing strings
from the beginning. starts_with() looks nicer and it saves the extra
argument of the length of the comparing string.
note: this commit properly handles negation in starts_with()
Signed-off-by: Quint Guvernator
Am 12.03.2014 14:44, schrieb Quint Guvernator:
memcmp() is replaced with starts_with() when comparing strings from the
beginning. starts_with() looks nicer and it saves the extra argument of
the length of the comparing string.
Signed-off-by: Quint Guvernator quintus.pub...@gmail.com
---
Am 12.03.2014 14:42, schrieb Orgad Shaneh:
From: Orgad Shaneh org...@gmail.com
You don't need the line above when you are the sender ;-)
Executes checkout without -q
That's a bit terse. What about:
Add the verbose flag to add and update which displays the
progress of the actual submodule
2014-03-12 11:47 GMT-04:00 Jens Lehmann jens.lehm...@web.de:
I think this hunk should be dropped as the memcmp() here doesn't mean
starts with but is identical (due to the ce_namelen(ce) == 11 in
the line above).
There is an issue with negation in this patch. I've submitted a new
one [1] to
On Wed, Mar 12, 2014 at 3:26 AM, Andreas Krey a.k...@gmx.de wrote:
On Mon, 10 Mar 2014 19:39:00 +, Shawn Pearce wrote:
Yes, this was my real concern. Eclipse users using EGit expect EGit to
be compatible with git-core at the filesystem level so they can do
something in EGit then switch to
Ilya Bobyr ilya.bo...@gmail.com writes:
I though that an example just to describe `argh' while useful would
look a bit disproportional, compared to the amount of text on
--parseopt.
But now that I've added a Usage text section to looks quite in place.
Good thinking.
I was also wondering
On Tue, Mar 11, 2014 at 05:58:08PM -0400, Jeff King wrote:
On Mon, Mar 10, 2014 at 10:24:12PM +0100, Heiko Voigt wrote:
I have also moved all functions into the new submodule-config-cache
module. I am not completely satisfied with the naming since it is quite
long. If someone comes up
Am 12.03.2014 17:46, schrieb Quint Guvernator:
2014-03-12 11:47 GMT-04:00 Jens Lehmann jens.lehm...@web.de:
I think this hunk should be dropped as the memcmp() here doesn't mean
starts with but is identical (due to the ce_namelen(ce) == 11 in
the line above).
There is an issue with negation
On Wed, Mar 12, 2014 at 6:47 PM, Duy Nguyen pclo...@gmail.com wrote:
By convention, no full stop in the subject line. The subject should
summarize your changes and add ..NONEG is just one part of it. The
other is convert to use ...NONEG. So I suggest parse-options:
convert to use new macro
On Wed, Mar 12, 2014 at 10:43:54AM -0400, Quint Guvernator wrote:
memcmp() is replaced with negated starts_with() when comparing strings
from the beginning. starts_with() looks nicer and it saves the extra
argument of the length of the comparing string.
Thanks, I think this is a real
On Wed, Mar 12, 2014 at 06:22:24PM +0100, Jens Lehmann wrote:
Let me know if you still think the hunk should be dropped there.
Yes, I think so. That spot uses memcmp() because ce-name may
not be 0-terminated. If that assumption isn't correct, it should
be replaced with a plain strcmp()
Junio C Hamano gits...@pobox.com writes:
Sorry for back-burnering this topic so long.
I think the following does what you suggested in the message I am
responding to.
Now, hopefully the only thing we need is a documentation update and
the series should be ready to go.
... and here it is,
Yuxuan Shui (2):
fsck.c: Change the type of fsck_ident()'s first argument
fsck.c: Rewrite fsck_commit() to use skip_prefix()
fsck.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
--
1.9.0
--
To unsubscribe from this list: send the line unsubscribe git
Since fsck_ident doesn't change the content of **ident, the type of
ident could be const char **.
This change is required to rewrite fsck_commit() to use skip_prefix().
---
fsck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsck.c b/fsck.c
index 99c0497..1789c34 100644
The purpose of skip_prefix() is much clearer than memcmp(). Also
skip_prefix() takes one less argument and its return value makes more
sense.
---
fsck.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/fsck.c b/fsck.c
index 1789c34..7e6b829 100644
---
Duy Nguyen pclo...@gmail.com writes:
By convention, no full stop in the subject line. The subject should
summarize your changes and add ..NONEG is just one part of it. The
other is convert to use ...NONEG. So I suggest parse-options:
convert to use new macro OPT_SET_INT_NONEG() or something
Jacopo Notarstefano jacopo.notarstef...@gmail.com writes:
On Mon, Mar 3, 2014 at 7:34 PM, Junio C Hamano gits...@pobox.com wrote:
I think you fundamentally cannot use two labels that are merely
distinct and bisect correctly. You need to know which ones
(i.e. good) are to be excluded and the
Duy Nguyen pclo...@gmail.com writes:
On Wed, Mar 12, 2014 at 5:12 AM, Junio C Hamano gits...@pobox.com wrote:
* nd/log-show-linear-break (2014-02-10) 1 commit
- log: add --show-linear-break to help see non-linear history
Attempts to show where a single-strand-of-pearls break in git log
Hi,
On Thu, Mar 13, 2014 at 2:30 AM, Junio C Hamano gits...@pobox.com wrote:
Duy Nguyen pclo...@gmail.com writes:
By convention, no full stop in the subject line. The subject should
summarize your changes and add ..NONEG is just one part of it. The
other is convert to use ...NONEG. So I
Duy Nguyen pclo...@gmail.com writes:
On Wed, Mar 12, 2014 at 3:26 AM, Junio C Hamano gits...@pobox.com wrote:
Sandy Carter sandy.car...@savoirfairelinux.com writes:
3651e45c takes the colon out of the control of the translators.
That is a separate bug we would need to address, then. Duy
I'm sorry for resending these patches, but the previous ones miss the sign-offs.
Yuxuan Shui (2):
fsck.c: Change the type of fsck_ident()'s first argument
fsck.c: Rewrite fsck_commit() to use skip_prefix()
fsck.c | 26 ++
1 file changed, 14 insertions(+), 12
The purpose of skip_prefix() is much clearer than memcmp(). Also
skip_prefix() takes one less argument and its return value makes more
sense.
Signed-off-by: Yuxuan Shui yshu...@gmail.com
---
fsck.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git
Since fsck_ident doesn't change the content of **ident, the type of
ident could be const char **.
This change is required to rewrite fsck_commit() to use skip_prefix().
Signed-off-by: Yuxuan Shui yshu...@gmail.com
---
fsck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Jonathan Nieder jrnie...@gmail.com writes:
@@ -292,6 +291,48 @@ static const char *wt_status_diff_status_string(int
status)
}
}
+static int maxwidth(const char *(*label)(int), int minval, int maxval)
+{
+ const char *s;
+ int result = 0, i;
+
+ for (i = minval; i
Yuxuan Shui yshu...@gmail.com writes:
On Thu, Mar 13, 2014 at 2:30 AM, Junio C Hamano gits...@pobox.com wrote:
Duy Nguyen pclo...@gmail.com writes:
By convention, no full stop in the subject line. The subject should
summarize your changes and add ..NONEG is just one part of it. The
other is
Here is another, as I seem to have managed to kill another one ;-)
-- 8 --
VAR=VAL command is sufficient to run 'command' with environment
variable VAR set to value VAL without affecting the environment of
the shell itself, but we cannot do the same with a shell function
(most notably,
Junio C Hamano gits...@pobox.com writes:
Here is another, as I seem to have managed to kill another one ;-)
-- 8 --
VAR=VAL command is sufficient to run 'command' with environment
variable VAR set to value VAL without affecting the environment of
the shell itself, but we cannot do the same
On Wed, Mar 12, 2014 at 08:16:53PM +0100, David Kastrup wrote:
Junio C Hamano gits...@pobox.com writes:
Here is another, as I seem to have managed to kill another one ;-)
-- 8 --
VAR=VAL command is sufficient to run 'command' with environment
variable VAR set to value VAL without
From: Jonathan Nieder jrnie...@gmail.com
Date: Thu, 19 Dec 11:43:19 2013 -0800
The original code assumes that:
(1) the number of bytes written is the width of a string, so they
can line up;
(2) the how string is always = 19 bytes.
Also a recent change to a similar codepath by 3651e45c
On Tue, Mar 11, 2014 at 03:12:11PM -0700, Junio C Hamano wrote:
* jk/warn-on-object-refname-ambiguity (2014-01-09) 6 commits
- get_sha1: drop object/refname ambiguity flag
- get_sha1: speed up ambiguous 40-hex test
- FIXUP: teach DO_FOR_EACH_NO_RECURSE to prime_ref_dir()
- refs: teach
Jeff King p...@peff.net writes:
static inline int standard_header_field(const char *field, size_t len)
{
-return ((len == 4 !memcmp(field, tree , 5)) ||
-(len == 6 !memcmp(field, parent , 7)) ||
-(len == 6 !memcmp(field, author , 7)) ||
-(len ==
Yuxuan Shui yshu...@gmail.com writes:
The purpose of skip_prefix() is much clearer than memcmp(). Also
skip_prefix() takes one less argument and its return value makes
more sense.
Instead of justifying the change with a subjective-sounding and
vague much clearer and makes more sense, perhaps
On Wed, Mar 12, 2014 at 12:39:01PM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
static inline int standard_header_field(const char *field, size_t len)
{
- return ((len == 4 !memcmp(field, tree , 5)) ||
- (len == 6 !memcmp(field, parent , 7)) ||
-
Jeff King p...@peff.net writes:
On Tue, Mar 11, 2014 at 03:12:11PM -0700, Junio C Hamano wrote:
* jk/warn-on-object-refname-ambiguity (2014-01-09) 6 commits
- get_sha1: drop object/refname ambiguity flag
- get_sha1: speed up ambiguous 40-hex test
- FIXUP: teach DO_FOR_EACH_NO_RECURSE to
On Wed, Mar 12, 2014 at 6:15 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 12.03.2014 14:42, schrieb Orgad Shaneh:
From: Orgad Shaneh org...@gmail.com
You don't need the line above when you are the sender ;-)
Executes checkout without -q
That's a bit terse. What about:
Add the
Jeff King p...@peff.net writes:
Blindly replacing starts_with() with !memcmp() in the above part is
a readability regression otherwise.
I actually think the right solution is:
static inline int standard_header_field(const char *field, size_t len)
{
return mem_equals(field,
Sandy Carter sandy.car...@savoirfairelinux.com writes:
Le 2014-03-12 15:22, Junio C Hamano a écrit :
static const char *wt_status_diff_status_string(int status)
{
switch (status) {
case DIFF_STATUS_ADDED:
-return _(new file);
+return _(new file:);
Le 2014-03-12 16:12, Junio C Hamano a écrit :
Sandy Carter sandy.car...@savoirfairelinux.com writes:
Le 2014-03-12 15:22, Junio C Hamano a écrit :
static const char *wt_status_diff_status_string(int status)
{
switch (status) {
case DIFF_STATUS_ADDED:
-
Orgad Shaneh org...@gmail.com writes:
+--verbose::
+ This option is valid for add and update commands. Display the progress
+ of the actual submodule checkout.
Hmm, is the valid for add and update part we want to keep? I do
not think it is a crime if some other subcommand accepted
On Thu, Mar 13, 2014 at 02:51:29AM +0800, Yuxuan Shui wrote:
Since fsck_ident doesn't change the content of **ident, the type of
ident could be const char **.
Unfortunately, const double-pointers in C are a bit tricky, and a
pointer to char * cannot automatically be passed as a pointer to
Jeff King p...@peff.net writes:
On Wed, Mar 12, 2014 at 08:16:53PM +0100, David Kastrup wrote:
Junio C Hamano gits...@pobox.com writes:
Here is another, as I seem to have managed to kill another one ;-)
-- 8 --
VAR=VAL command is sufficient to run 'command' with environment
Sandy Carter sandy.car...@savoirfairelinux.com writes:
Seems fine except for the bit about returning _(bug), which I brought up.
Seems to do the same thing as my proposal without changing the
alignment of paths in of regular status output. No changes to tests
necessary, less noisy.
It
On Wed, Mar 12, 2014 at 09:37:41PM +0100, David Kastrup wrote:
Try:
zippo() {
echo $XXX
}
XXX=8 zippo
zippo
XXX remains set after the first call under dash (but not bash). I
believe ash has the same behavior.
Yes. I would lean towards considering this a bug.
Junio C Hamano gits...@pobox.com writes:
Jeff King p...@peff.net writes:
static inline int standard_header_field(const char *field, size_t len)
{
- return ((len == 4 !memcmp(field, tree , 5)) ||
- (len == 6 !memcmp(field, parent , 7)) ||
- (len == 6
Am 12.03.2014 20:39, schrieb Junio C Hamano:
Jeff King p...@peff.net writes:
static inline int standard_header_field(const char *field, size_t len)
{
- return ((len == 4 !memcmp(field, tree , 5)) ||
- (len == 6 !memcmp(field, parent , 7)) ||
- (len == 6
Jeff King p...@peff.net writes:
On Wed, Mar 12, 2014 at 09:37:41PM +0100, David Kastrup wrote:
Try:
zippo() {
echo $XXX
}
XXX=8 zippo
zippo
XXX remains set after the first call under dash (but not bash). I
believe ash has the same behavior.
Yes. I would lean
On Wed, Mar 12, 2014 at 01:08:03PM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
Blindly replacing starts_with() with !memcmp() in the above part is
a readability regression otherwise.
I actually think the right solution is:
static inline int
So here is my attempt to clean-up what Jonathan posted in
$gmane/239537 as how about this? patch.
The first one (full label string) fixes up 3651e45c (wt-status: take
the alignment burden off translators, 2013-11-05) to include colon
back to translatable string again, while retaining its label
Earlier in 3651e45c (wt-status: take the alignment burden off
translators, 2013-11-05), we assumed that it is OK to make the
string before the colon in a label string we give as the section
header of various kinds of changes (e.g. new file:) translatable.
This assumption apparently does not hold
From: Jonathan Nieder jrnie...@gmail.com
From: Jonathan Nieder jrnie...@gmail.com
Date: Thu, 19 Dec 2013 11:43:19 -0800
The original code assumes that:
(1) the number of bytes written is the width of a string, so they
can line up;
(2) the how string is always = 19 bytes.
Neither of
From: Jonathan Nieder jrnie...@gmail.com
From: Jonathan Nieder jrnie...@gmail.com
Date: Thu, 19 Dec 2013 11:43:19 -0800
Signed-off-by: Junio C Hamano gits...@pobox.com
---
wt-status.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/wt-status.c
When we show unmerged paths, we had an artificial 20 columns floor
for the width of labels (e.g. both deleted:) shown next to the
pathnames. Depending on the locale, this may result in a label that
is too wide when all the label strings are way shorter than 20
columns, or no-op when a label
On Wed, Mar 12, 2014 at 05:14:15PM -0400, Jeff King wrote:
I also think that eof = next (which I retained here) is off-by-one.
next here is not the newline, but the start of the next line. And I'm
guessing the code actually wanted the newline (otherwise it-key ends
up with the newline in it).
On Wed, Mar 12, 2014 at 05:14:15PM -0400, Jeff King wrote:
One thing that bugs me about the current code is that the sub-function
looks one past the end of the length given to it by the caller.
Switching it to pass eof - line + 1 resolves that, but is it right?
The character pointed at by
Jeff King p...@peff.net writes:
Thanks, I think this is a real readability improvement in most cases.
...
I tried:
perl -i -lpe '
s/memcmp\(([^,]+), (.*?), (\d+)\)/
length($2) == $3 ?
qq{!starts_with($1, $2)} :
$
/ge
' $(git ls-files '*.c')
That comes
Jeff King p...@peff.net writes:
So I think the whole function could use some refactoring to handle
corner cases better. I'll try to take a look tomorrow, but please
feel free if somebody else wants to take a crack at it.
Yup, thanks.
--
To unsubscribe from this list: send the line
On Wed, Mar 12, 2014 at 2:04 PM, Junio C Hamano gits...@pobox.com wrote:
Subject: [PATCH] request-pull: documentation updates
The original description talked only about what it does. Instead,
start it with the purpose of the command, i.e. what it is used for,
and then mention what it does to
On Sat, Mar 8, 2014 at 2:20 AM, Junio C Hamano gits...@pobox.com wrote:
Looking at git grep -B3 OPT_NONEG output, it seems that NONEG is
associated mostly with OPTION_CALLBACK and OPTION_SET_INT in the
existing code.
Perhaps OPT_SET_INT should default to not just OPT_NOARG but also
On Tue, Mar 11, 2014 at 02:45:59PM -0700, Junio C Hamano wrote:
Thanks. Neither this nor John's seems to describe the user-visible
way to trigger the symptom. Can we have tests for them?
I'll try to get to writing some test today or tomorrow. I just noticed
the bugginess by looking at the
Replace the chain of if statements with table of strings.
Signed-off-by: Paweł Wawruch pa...@aleg.pl
---
Thanks to Eric Sunshine and Junio C Hamano.
Simplified printing logic. The name moved to a table.
v4: http://thread.gmane.org/gmane.comp.version-control.git/243914
v3:
On Thu, Mar 13, 2014 at 12:22 AM, Jens Lehmann jens.lehm...@web.de wrote:
That spot uses memcmp() because ce-name may
not be 0-terminated.
ce-name is 0-terminated (at least if it's created the normal way, I
haven't checked where this ce in submodule.c comes from).
ce_namelen() is just an
Hi,
On Tue, Mar 11, 2014 at 07:28:52PM -0700, Jonathan Nieder wrote:
Heiko Voigt wrote:
This submodule configuration cache allows us to lazily read .gitmodules
configurations by commit into a runtime cache which can then be used to
easily lookup values from it. Currently only the values
Today I tried pushing a copy of linux.git from a client that had
bitmaps into a JGit server. The client stalled for a long time with no
progress, because it reused the existing pack. No progress appeared
while it was sending the existing file on the wire:
$ git push git://localhost/linux.git
Hello Dear,
This is a personal email directed to you. My wife and I won the Euro
Millions Jackpot Lottery of £148 million (Pounds) on August 10, 2012. We
just commenced our Charity Donation and we will be giving out a cash
donation of £7,000.000.00 GBP(Seven Million great Britain pounds) to
From what I can gather, there seems to be opposition to specific
pieces of this patch.
The following area is clearly the most controversial:
static inline int standard_header_field(const char *field, size_t len)
{
-return ((len == 4 !memcmp(field, tree , 5)) ||
-(len == 6
Hi,
On Thu, Mar 13, 2014 at 4:22 AM, Jeff King p...@peff.net wrote:
On Thu, Mar 13, 2014 at 02:51:29AM +0800, Yuxuan Shui wrote:
Since fsck_ident doesn't change the content of **ident, the type of
ident could be const char **.
Unfortunately, const double-pointers in C are a bit tricky, and
Improved commit message, and added a missing hunk to the second commit.
Yuxuan Shui (2):
fsck.c: Change the type of fsck_ident()'s first argument
fsck.c: Rewrite fsck_commit() to use skip_prefix()
fsck.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
--
Since fsck_ident doesn't change the content of **ident, the type of
ident could be const char **.
This change is required to rewrite fsck_commit() to use skip_prefix().
Signed-off-by: Yuxuan Shui yshu...@gmail.com
---
fsck.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
87 matches
Mail list logo
