On Tue, Mar 18, 2014 at 12:16 PM, Duy Nguyen pclo...@gmail.com wrote:
But I think it's orthogonal to gc --aggressive improvement.
There's another reason that improving gc may be a good idea (or not).
It depends on how other git implementations handle long delta chains.
If they hate long delta
Jeff King p...@peff.net writes:
On Tue, Mar 18, 2014 at 12:00:48PM +0700, Duy Nguyen wrote:
On Tue, Mar 18, 2014 at 11:50 AM, Jeff King p...@peff.net wrote:
On Sun, Mar 16, 2014 at 08:35:04PM +0700, Nguyễn Thái Ngọc Duy wrote:
As explained in the previous commit, current aggressive
Jeff King p...@peff.net writes:
On Tue, Mar 18, 2014 at 12:50:50AM -0400, Jeff King wrote:
On Sun, Mar 16, 2014 at 08:35:04PM +0700, Nguyễn Thái Ngọc Duy wrote:
As explained in the previous commit, current aggressive settings
--depth=250 --window=250 could slow down repository access
Duy Nguyen pclo...@gmail.com writes:
On Tue, Mar 18, 2014 at 12:16 PM, Duy Nguyen pclo...@gmail.com wrote:
But I think it's orthogonal to gc --aggressive improvement.
There's another reason that improving gc may be a good idea (or not).
It depends on how other git implementations handle long
Cc René; do you have any comments regarding grep --function-context?
Am 3/18/2014 6:24, schrieb Jeff King:
On Fri, Mar 14, 2014 at 07:56:46AM +0100, Johannes Sixt wrote:
Consider this code:
void above()
{}
static int Y;
static int A;
int bar()
{
return X;
}
void
Hi,
I am running a Mac 10.6.8 and tried to install git-1.9.0 off of the
installer (git-1.9.0-intel-universal-snow-leopard.dmg). The
installation worked fine and gave no error messages. But whenever I
type in a git command (see below for some I tried), it gives me this
error message:
Illegal
Teach rebase the same shorthand as checkout and merge; that is, that -
means the branch we were previously on.
Reported-by: Tim Chase g...@tim.thechases.com
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
git-rebase.sh | 4
t/t3400-rebase.sh | 6 ++
2 files changed, 10
Signed-off-by: Benoit Pierre benoit.pie...@gmail.com
---
run-command.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/run-command.h b/run-command.h
index 88460f9..3653bfa 100644
--- a/run-command.h
+++ b/run-command.h
@@ -51,6 +51,7 @@ extern int run_hook_le(const char *const *env, const
- update 'no editor' hook test and add 'editor' hook test
- make sure the tree is reset to a clean state after running a test
(using test_when_finished) so later tests are not impacted
Signed-off-by: Benoit Pierre benoit.pie...@gmail.com
---
t/t7505-prepare-commit-msg-hook.sh | 27
Signed-off-by: Benoit Pierre benoit.pie...@gmail.com
---
t/t7505-prepare-commit-msg-hook.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7505-prepare-commit-msg-hook.sh
b/t/t7505-prepare-commit-msg-hook.sh
index 1c95652..5531abb 100755
---
Add (failing) tests: with commit changing the environment to let hooks
know that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does not work (no editor is launched and the
whole hunk is committed).
Signed-off-by: Benoit Pierre benoit.pie...@gmail.com
---
Signed-off-by: Benoit Pierre benoit.pie...@gmail.com
---
t/t7505-prepare-commit-msg-hook.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7505-prepare-commit-msg-hook.sh
b/t/t7505-prepare-commit-msg-hook.sh
index 3573751..1c95652 100755
---
Don't set GIT_EDITOR to : when calling prepare-commit-msg hook if the
editor is going to be called (e.g. with merge -e).
Signed-off-by: Benoit Pierre benoit.pie...@gmail.com
---
builtin/merge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/merge.c b/builtin/merge.c
Junio C Hamano gits...@pobox.com writes:
Andreas Schwab sch...@linux-m68k.org writes:
This configuration variable sets the default for the --full-name option.
Signed-off-by: Andreas Schwab sch...@linux-m68k.org
---
Would this change break Porcelains (e.g. Emacs modes) and force them
to
On Tue, 18 Mar 2014 01:33:25 -0700
Ray Hengst rkhen...@gmail.com wrote:
Hi,
I am running a Mac 10.6.8 and tried to install git-1.9.0 off of the
installer (git-1.9.0-intel-universal-snow-leopard.dmg). The
installation worked fine and gave no error messages. But whenever I
type in a git
Am 18.03.2014 09:02, schrieb Johannes Sixt:
Cc René; do you have any comments regarding grep --function-context?
Am 3/18/2014 6:24, schrieb Jeff King:
On Fri, Mar 14, 2014 at 07:56:46AM +0100, Johannes Sixt wrote:
Consider this code:
void above()
{}
static int Y;
static int A;
This patch replaces if chain that selects the message with
2 dimensional array of format strings and arguments.
Signed-off-by: Aleksey Mokhovikov moxobu...@gmail.com
---
This patch is unrelated with previous one, but related to GSoC.
So I don't know if I should create new thread for this patch.
Origin code are code with own realisation argv array editing.
It was changed, and code modified for using unified argv-array
realisation from argv-array.h.
Commit for Google Summer of Code 2014
Signed-off-by: Movchan Pavel movchan...@gmail.com
---
builtin/add.c | 21 ++---
1
Please is your email really active?
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear all,
Git won an award in the main category of the English German Linux
Magazine at CeBIT, this year. Jens Lehmann, Heiko Voigt, and myself
were present to accept the award on behalf of the Git community as a
whole.
You can find a short blurb on my blog[1], including a picture of the
Eric Sunshine sunshine at sunshineco.com writes:
The subject should be concise. Try to keep it at 65-70 characters or
less. More detailed information can be written following the subject
(separated from the subject by a blank line).
Write in imperative tone: say replace X with Y rather than
On Tue, Mar 18, 2014 at 9:27 PM, Duy Nguyen pclo...@gmail.com wrote:
I thought about GIT_CAPABILITIES= git-upload-pack ... (and actually
added it in pack-protocol.txt then deleted). The thing is, if you want
to new upload-pack, you would need new git-upload-pack at the remote
end that must
On Tue, Mar 18, 2014 at 12:17:39AM -0400, Jeff King wrote:
On Fri, Mar 14, 2014 at 05:09:45PM -0700, Shawn Pearce wrote:
On Fri, Mar 14, 2014 at 4:30 PM, Duy Nguyen pclo...@gmail.com wrote:
On Fri, Mar 14, 2014 at 11:45 PM, Shawn Pearce spea...@spearce.org
wrote:
You missed the
This patch replaces if chain with
2 dimensional array of format strings and arguments.
Signed-off-by: Aleksey Mokhovikov moxobu...@gmail.com
---
This patch is unrelated with previous one, but related to GSoC.
So I don't know if I should create new thread for this patch.
Compare with original
Matthieu Moy Matthieu.Moy at grenoble-inp.fr writes:
Hi,
Aleksey Mokhovikov moxobukob at gmail.com writes:
Please, read the threads for other submissions for this microproject.
Most remarks done there also apply for your case. See for example:
Jagan:
On Fri, Mar 14, 2014 at 1:11 PM, Jagan Teki jagannadh.t...@gmail.com wrote:
Don't know what happen, I'm unable to join #git channel
[23:40] Jagan hi
[23:40] == Cannot send to channel: #git
I'm not sure if this is the problem that you were having, but #git on
freenode is NickServ
Jagan:
On Fri, Mar 14, 2014 at 12:39 PM, Jagan Teki jagannadh.t...@gmail.com wrote:
Hi,
Hello,
I have two branch in one repo that I need to maintain for 2 different
deliveries.
Say branch1 and branch2 in test.git repo.
test.git
- branch1
foo_v1/text.txt
foo_v2/text.txt
-
User config file location now complies with XDG base directory specification
Signed-off-by: Astril Hayato astrilhay...@gmail.com
---
Documentation/gitk.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/gitk.txt b/Documentation/gitk.txt
index
Andreas Schwab sch...@linux-m68k.org writes:
Yes, that would be required. On the other hand, currently it is
impossible to cut-n-paste a file name without --full-name, since the
pager is always started in top-level. Perhaps it is better to fix the
latter?
So far we never cared where the
Uwe Storbeck u...@ibr.ch writes:
In some places we echo a string that is supplied by the calling
test script and may contain backslash sequences. The echo command
of some shells, most notably dash, interprets these backslash
sequences (POSIX.1 allows this) which may scramble the test
output.
Eric Sunshine sunsh...@sunshineco.com writes:
A patch of this nature doesn't require much more description than
stating what it does (replace memcmp() with starts_with()) and why
(improve code clarity). The following rewrite might be sufficient:
Subject: replace memcmp() with
On 03/18/2014 09:44 AM, Brian Gesiak wrote:
Teach rebase the same shorthand as checkout and merge; that is, that -
means the branch we were previously on.
Reported-by: Tim Chase g...@tim.thechases.com
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
git-rebase.sh | 4
Jacopo Notarstefano jacopo.notarstef...@gmail.com writes:
It seems to me that the topic of adding the checkpatch.pl script to
Git's source tree has cropped up several times in the past, as
recently as a couple of days ago: $gmane/243607.
It should be noted that its usage for its sake has
Brian Gesiak modoca...@gmail.com writes:
Teach rebase the same shorthand as checkout and merge; that is, that -
means the branch we were previously on.
Reported-by: Tim Chase g...@tim.thechases.com
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
git-rebase.sh | 4
Movchan Pavel movchan...@gmail.com writes:
Origin code are code with own realisation argv array editing.
It was changed, and code modified for using unified argv-array
realisation from argv-array.h.
Commit for Google Summer of Code 2014
Signed-off-by: Movchan Pavel movchan...@gmail.com
---
Junio C Hamano gits...@pobox.com writes:
Don't we have the exact same issue for the editor, by the way?
Shouldn't we be running it in the original subdirectory as well?
It's called with an absolute name, so it shouldn't care.
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key
Richard Hartmann richih.mailingl...@gmail.com writes:
Dear all,
Git won an award in the main category of the English German Linux
Magazine at CeBIT, this year. Jens Lehmann, Heiko Voigt, and myself
were present to accept the award on behalf of the Git community as a
whole.
You can find a
Andreas Schwab sch...@linux-m68k.org writes:
Junio C Hamano gits...@pobox.com writes:
Andreas Schwab sch...@linux-m68k.org writes:
This configuration variable sets the default for the --full-name option.
Signed-off-by: Andreas Schwab sch...@linux-m68k.org
---
Would this change break
Originally, the code used subshells instead of FOO=BAR command because
the variable would otherwise leak into the surrounding context of the POSIX
shell when 'command' is a shell function. The subshell was used to hold the
context for the test. Using 'env' in the test function sets the temp
Andreas Schwab sch...@linux-m68k.org writes:
Junio C Hamano gits...@pobox.com writes:
Don't we have the exact same issue for the editor, by the way?
Shouldn't we be running it in the original subdirectory as well?
It's called with an absolute name, so it shouldn't care.
But we should not
David Tran unsignedz...@gmail.com writes:
Originally, the code used subshells instead of FOO=BAR command
because the variable would otherwise leak into the surrounding
context of the POSIX shell when 'command' is a shell function.
The subshell was used to hold the context for the test. Using
On Tue, Mar 18, 2014 at 8:08 AM, David Tran unsignedz...@gmail.com wrote:
Originally, the code used subshells instead of FOO=BAR command because
the variable would otherwise leak into the surrounding context of the POSIX
shell when 'command' is a shell function. The subshell was used to hold
On Mon, Mar 17, 2014 at 7:46 AM, Dragos Foianu dragos.foi...@gmail.com wrote:
Eric Sunshine sunshine at sunshineco.com writes:
Matthieu already mentioned [2] that this sort of lego string
construction is not internationalization-friendly. See section 4.3 [3]
of the gettext manual for details.
On Tue, Mar 18, 2014 at 01:37:39PM -0700, Junio C Hamano wrote:
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index c9c426c..3e3f77b 100755
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@ -974,24 +974,15 @@ test_expect_success SYMLINKS 'symlinked
The latest maintenance release Git v1.9.1 is now available at
the usual places.
The release tarballs are found at:
https://www.kernel.org/pub/software/scm/git/
The following public repositories all have a copy of the v1.9.1
tag and the maint branch that the tag points at:
url =
Junio C Hamano wrote:
Uwe Storbeck wrote:
+ printf '%s\n' $@ | sed -e 's/^/# /'
This is wrong, isn't it? Why do we want one line per item here?
Yes, Hannes caught the same, too. Sorry for the sloppiness.
We currently use echo all over the place (e.g., 'echo $path' in
git-sh-setup),
Jeff King p...@peff.net writes:
On Tue, Mar 18, 2014 at 01:37:39PM -0700, Junio C Hamano wrote:
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index c9c426c..3e3f77b 100755
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@ -974,24 +974,15 @@
Thanks for the resubmission. Comments below...
On Mon, Mar 17, 2014 at 11:51 AM, Dragos Foianu dragos.foi...@gmail.com wrote:
This patch uses a table to store the different messages that can
be emitted by the verbose install_branch_config function. It
computes an index based on the three flags
Michael Haggerty mhag...@alum.mit.edu writes:
I had recently been thinking along the same lines. In many of the
potential callers that I noticed, ALLOC_GROW() was used immediately
before making space in the array for a new element. So I suggest
something more like
+#define
On Tue, Mar 18, 2014 at 5:45 PM, Jeff King p...@peff.net wrote:
On Tue, Mar 18, 2014 at 01:37:39PM -0700, Junio C Hamano wrote:
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index c9c426c..3e3f77b 100755
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@
use of starts_with() instead of memcmp()
use of skip_prefix instead of memcmp() and strlen()
Signed-off-by: Othman Darraz darraz...@gmail.com
---
I am planning to apply to GSOC 214
fsck.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fsck.c b/fsck.c
index
On Tue, Mar 18, 2014 at 03:16:27PM -0700, Junio C Hamano wrote:
Isn't GIT_CONFIG here another way of saying:
test_must_fail git config -f doesnotexist --list
Perhaps that is shorter and more readable still (and there are a few
similar cases in this patch.
Surely, but are we
Thanks for the submission. Comments below to give you a taste of the
Git review process...
On Tue, Mar 18, 2014 at 6:41 PM, Othman Darraz darraz...@gmail.com wrote:
use of starts_with() instead of memcmp()
use of skip_prefix instead of memcmp() and strlen()
Write proper sentences to explain
On Tue, Mar 18, 2014 at 7:09 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
diff --git a/fsck.c b/fsck.c
index 64bf279..5eae856 100644
--- a/fsck.c
+++ b/fsck.c
@@ -290,7 +290,7 @@ static int fsck_commit(struct commit *commit, fsck_error
error_func)
int parents = 0;
int
On 03/19/2014 12:09 AM, Eric Sunshine wrote:
Thanks for the submission. Comments below to give you a taste of the
Git review process...
On Tue, Mar 18, 2014 at 6:41 PM, Othman Darraz darraz...@gmail.com wrote:
use of starts_with() instead of memcmp()
use of skip_prefix instead of memcmp()
On Tue, Mar 18, 2014 at 6:31 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Mon, Mar 17, 2014 at 11:51 AM, Dragos Foianu dragos.foi...@gmail.com
wrote:
This patch uses a table to store the different messages that can
be emitted by the verbose install_branch_config function. It
computes
On Tue, Mar 18, 2014 at 8:29 PM, Junio C Hamano gits...@pobox.com wrote:
I've never said any such thing.
I only said I am not enthused against a proposal to add a build
target that runs checkpatch or equivalent over *all* existing code,
which will invite needless churn (read again the part
this was done in order to implement the GSoC
Micro project for diff-no-index.c this is the
first patch importing dir.h, for the use of
is_dot_or_dotdot(), and renaming
read_directory() to read_directory_contents()
in order to deal with the conflicting function
in dir.h
Signed-off-by: Brian Bourn
Subject: [PATCH] Enable index-pack threading in msysgit.
This adds a Windows implementation of pread. Note that it is NOT
safe to intersperse calls to read() and pread() on a file
descriptor. According to the ReadFile spec, using the 'overlapped'
argument should not affect the implicit position
This adds a Windows implementation of pread. Note that it is NOT
safe to intersperse calls to read() and pread() on a file
descriptor. According to the ReadFile spec, using the 'overlapped'
argument should not affect the implicit position pointer of the
descriptor. Experiments have shown that
Another version, this time very in line with the review and commentary of
Junio, Eric, and Michael. This version boasts a revamped commit message and
fewer but surer hunks changed.
Thanks again for the guidance.
Quint Guvernator (1):
use starts_with() instead of !memcmp()
builtin/apply.c
When checking if a string begins with a constant string, using
starts_with() indicates the intention of the check more clearly and is
less error-prone than calling !memcmp() with an explicit byte count.
Signed-off-by: Quint Guvernator quintus.pub...@gmail.com
---
builtin/apply.c| 4 ++--
Thanks for the submission. Comments below to give you a taste of the
Git review process...
On Tue, Mar 18, 2014 at 8:35 PM, Brian Bourn ba.bo...@gmail.com wrote:
Subject: diff: Imported dir.h and renamed read_directory()
Use imperative voice: import dir.h and rename read_directory()
this was
in accordance with the GSoC Microproject implemented
the call is_dot_or_dotdot() in the code in order to
further universalize the call to the function and
increase code continuity.
Signed-off-by: Brian Bourn bab2...@columbia.edu
---
diff-no-index.c | 2 +-
1 file changed, 1 insertion(+), 1
Originally, we would use VAR=VAL command to execute a test command with
environment variable(s) only for that command. This does not work for commands
that are shell functions (most notably test functions like test_must_fail);
the result of the assignment is retained and affects later commands.
On Tue, Mar 18, 2014 at 9:30 PM, babourn ba.bo...@gmail.com wrote:
Subject: diff: used is_dot_or_dotdot() in code
Use imperative voice: use rather than used
in accordance with the GSoC Microproject implemented
This commentary will not have much meaning to someone reading the
commit log months
On Tue, Mar 18, 2014 at 2:54 PM, David Tran unsignedz...@gmail.com wrote:
Originally, we would use VAR=VAL command to execute a test command with
environment variable(s) only for that command. This does not work for commands
that are shell functions (most notably test functions like
On Tue, Mar 18, 2014 at 11:58 PM, Brian Bourn ba.bo...@gmail.com wrote:
On Tue, Mar 18, 2014 at 11:45 PM, Eric Sunshine sunsh...@sunshineco.com
wrote:
On Tue, Mar 18, 2014 at 9:30 PM, babourn ba.bo...@gmail.com wrote:
Subject: diff: used is_dot_or_dotdot() in code
Signed-off-by: Brian Bourn
On Tue, Mar 18, 2014 at 9:18 PM, Quint Guvernator
quintus.pub...@gmail.com wrote:
Another version, this time very in line with the review and commentary of
Junio, Eric, and Michael. This version boasts a revamped commit message and
fewer but surer hunks changed.
Explaining what changed in
Hi,
In need of a loan for any purpose? Look no further, Motichek Loans Agency can
help you with that loan you so seek and @ a 2% interest rate, you have access
to funds between $10,000.00 to $20,000,000.00 If Interested, send your details
via our email below for fast processing of that loan.
70 matches
Mail list logo
