Hi,
Nit: In subject, patch should be like [PATCH v2] for each increasing order
of revision.
Also, after the --- (three dashes), you can write what you changed with each
patch revision. Also to link the previous patches if you can.
So the corrected mail subject header will look something like
On 2014-03-23 01.44, David Cowden wrote:
http://stackoverflow.com/questions/22585091/git-hooks-pre-push-script-does-not-receive-input-via-stdin
Is this a bug in git? Or am I just a shell noob?
Thanks in advance,
David
I assume that you have the right version of Git ?
You can look into
Thanks for the resubmission. Comments below...
On Sat, Mar 22, 2014 at 11:12 AM, Ashwin Jha ajha@gmail.com wrote:
Subject: [PATCH] Modify fsck_commit. Replace memcmp by skip_prefix
In his review, Tanay already mentioned indicating a resubmission via
[PATCH vN]. Additionally, specify the
In addition to the valuable review comments already provided by
Alexandru and David, see a few more below.
On Sat, Mar 22, 2014 at 5:25 PM, Mustafa Orkun Acar
mustafaorkuna...@gmail.com wrote:
Subject: [PATCH v2] Rewrite strbuf.c:strbuf_cmp() replace memcmp() with
starts_with()
This isn't
Thanks for your comments, Tanay and Eric.
Regarding the [PATCH v2], I will keep this in mind for the subsequent
patches.
On 03/23/2014 02:10 PM, Eric Sunshine wrote:
Thanks for the resubmission. Comments below...
On Sat, Mar 22, 2014 at 11:12 AM, Ashwin Jha ajha@gmail.com wrote:
On Fri, Mar 21, 2014 at 08:31:42AM +0100, Per Cederqvist wrote:
Signed-off-by: Per Cederqvist ced...@opera.com
---
guilt-import-commit | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/guilt-import-commit b/guilt-import-commit
index 20dcee2..9488ded 100755
---
On Fri, Mar 21, 2014 at 08:31:44AM +0100, Per Cederqvist wrote:
When extracting the patch, we only want the actual patches. We don't
want the --- delimiter. Simplify the extraction by simply deleting
everything before the first diff line. (Use sed instead of awk to
simplify the code.)
On Tue, Mar 11, 2014 at 11:37 PM, Andrew Keller and...@kellerfarm.com wrote:
I am considering developing a new feature, and I'd like to poll the group for
opinions.
Background: A couple years ago, I wrote a set of scripts that speed up
cloning of frequently used repositories. The scripts
The documentation as-is does not mention that the pre-push hook is
executed even when there is nothing to push. This can lead a new
reader to beilieve there will always be lines fed to the script's
standerd input and cause minor confusion as to what is happening
when there are no lines provided
The documentation as-is does not mention that the pre-push hook is
executed even when there is nothing to push. This can lead a new
reader to beilieve there will always be lines fed to the script's
standerd input and cause minor confusion as to what is happening
when there are no lines provided
The documentation as-is does not mention that the pre-push hook is
executed even when there is nothing to push. This can lead a new
reader to beilieve there will always be lines fed to the script's
standerd input and cause minor confusion as to what is happening
when there are no lines provided
You are correct, it was a misunderstanding on my part. I have
suggested a patch to clarify the pre-push documentation in a separate
thread.
Thanks for pointing that out!
On Sun, Mar 23, 2014 at 12:19 AM, Torsten Bögershausen tbo...@web.de wrote:
On 2014-03-23 01.44, David Cowden wrote:
Johannes Sixt j...@kdbg.org writes:
I see what you mean. Notice, however, that we also test whether
the regular expressions can be compiled successfully, and for this
it is desirable to have the complete list of userdiff drivers.
Until we have at least one test-case for each driver, we
On Sun, Mar 23, 2014 at 6:04 PM, Jeff Sipek jef...@josefsipek.net wrote:
On Fri, Mar 21, 2014 at 08:31:42AM +0100, Per Cederqvist wrote:
Signed-off-by: Per Cederqvist ced...@opera.com
---
guilt-import-commit | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On Sun, Mar 23, 2014 at 08:57:08PM +0100, Per Cederqvist wrote:
On Sun, Mar 23, 2014 at 6:04 PM, Jeff Sipek jef...@josefsipek.net wrote:
On Fri, Mar 21, 2014 at 08:31:42AM +0100, Per Cederqvist wrote:
Signed-off-by: Per Cederqvist ced...@opera.com
---
guilt-import-commit | 6 +++---
David Cowden dco...@gmail.com writes:
The documentation as-is does not mention that the pre-push hook is
executed even when there is nothing to push. This can lead a new
reader to beilieve there will always be lines fed to the script's
standerd input and cause minor confusion as to what is
On Sun, Mar 23, 2014 at 6:09 PM, Jeff Sipek jef...@josefsipek.net wrote:
On Fri, Mar 21, 2014 at 08:31:44AM +0100, Per Cederqvist wrote:
When extracting the patch, we only want the actual patches. We don't
want the --- delimiter. Simplify the extraction by simply deleting
everything before
On Sun, Mar 23, 2014 at 9:07 PM, Jeff Sipek jef...@josefsipek.net wrote:
On Sun, Mar 23, 2014 at 08:57:08PM +0100, Per Cederqvist wrote:
On Sun, Mar 23, 2014 at 6:04 PM, Jeff Sipek jef...@josefsipek.net wrote:
On Fri, Mar 21, 2014 at 08:31:42AM +0100, Per Cederqvist wrote:
Signed-off-by:
On 03/22/2014 05:56 AM, Jeff King wrote:
On Fri, Mar 21, 2014 at 07:58:55PM -0700, Siddharth Agarwal wrote:
Is it also reproducible just with the tip of next? Note that the
patches in jk/bitmap-reuse-delta have not been widely deployed (in
particular, we are not yet using them at GitHub, and we
On Sun, Mar 23, 2014 at 9:10 AM, Ashwin Jha ajha@gmail.com wrote:
On 03/23/2014 02:10 PM, Eric Sunshine wrote:
On Sat, Mar 22, 2014 at 11:12 AM, Ashwin Jha ajha@gmail.com wrote:
- if (memcmp(buffer, tree , 5))
+ buffer = (char *)skip_prefix(buffer, tree );
These casts are
On Sun, Mar 23, 2014 at 3:01 PM, David Cowden dco...@gmail.com wrote:
The documentation as-is does not mention that the pre-push hook is
executed even when there is nothing to push. This can lead a new
reader to beilieve there will always be lines fed to the script's
standerd input and cause
21 matches
Mail list logo
