Re: [RFC PATCH v2 2/2] headers: include dependent headers

2014-09-07 Thread René Scharfe
Am 07.09.2014 um 02:30 schrieb David Aguilar: Add dependent headers so that including a header does not require including additional headers. This makes it so that gcc -c $header succeeds for each header. Signed-off-by: David Aguilar dav...@gmail.com --- Addresses René's note to not

[PATCH 1/2] strbuf: export strbuf_addchars()

2014-09-07 Thread René Scharfe
Move strbuf_addchars() to strbuf.c, where it belongs, and make it available for other callers. Signed-off-by: Rene Scharfe l@web.de --- Documentation/technical/api-strbuf.txt | 4 strbuf.c | 7 +++ strbuf.h | 1 + utf8.c

[PATCH 2/2] strbuf: use strbuf_addchars() for adding a char multiple times

2014-09-07 Thread René Scharfe
Signed-off-by: Rene Scharfe l@web.de --- graph.c | 5 ++--- merge-recursive.c | 4 +--- pretty.c | 10 +++--- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/graph.c b/graph.c index 6404331..dfb99f6 100644 --- a/graph.c +++ b/graph.c @@ -1145,7 +1145,7

Re: [PATCH] git-svn.txt: Remove mentions of repack options

2014-09-07 Thread Eric Wong
Lawrence Velázquez v...@larryv.me wrote: Git no longer seems to use these flags or their associated config keys; when they are present, git-svn outputs a message indicating that they are being ignored. Signed-off-by: Lawrence Velázquez v...@larryv.me Thanks, will queue. Signed-off-by: Eric

[PATCH v2] git svn: info: correctly handle absolute path args

2014-09-07 Thread Eric Wong
Calling git svn info $(pwd) would hit: Reading from filehandle failed at ... errors due to improper prefixing and canonicalization. Strip the toplevel path from absolute filesystem paths to ensure downstream canonicalization routines are only exposed to paths tracked in git (or SVN). Thanks to

[PATCH] git svn: find-rev allows short switches for near matches

2014-09-07 Thread Eric Wong
Allow -B and -A to act as short aliases for --before and --after options respectively. This reduces typing and hopefully allows reuse of muscle memory for grep(1) users. Signed-off-by: Eric Wong normalper...@yhbt.net --- Will push to git://bogomips.org/git-svn.git Documentation/git-svn.txt |

Re: [PATCH v2] git svn: info: correctly handle absolute path args

2014-09-07 Thread Johannes Sixt
Am 07.09.2014 10:06, schrieb Eric Wong: diff --git a/git-svn.perl b/git-svn.perl index 1f41ee1..47cd6ea 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -1477,10 +1477,20 @@ sub cmd_commit_diff { } } - sub cmd_info { - my $path = canonicalize_path(defined($_[0]) ? $_[0] :

[PATCH v3 2/2] headers: include dependent headers

2014-09-07 Thread David Aguilar
Add dependent headers so that including a header does not require including additional headers. This makes it so that gcc -c $header succeeds for each header. Helped-by: René Scharfe l@web.de Signed-off-by: David Aguilar dav...@gmail.com --- Replacement patch with René's suggestions squashed

Re: [PATCH v3 2/2] headers: include dependent headers

2014-09-07 Thread René Scharfe
Am 07.09.2014 um 11:36 schrieb David Aguilar: Add dependent headers so that including a header does not require including additional headers. This makes it so that gcc -c $header succeeds for each header. diff --git a/cache.h b/cache.h index 4d5b76c..8b827d7 100644 --- a/cache.h +++

Re: [PATCH v3 2/2] headers: include dependent headers

2014-09-07 Thread Ramsay Jones
On 07/09/14 11:35, René Scharfe wrote: Am 07.09.2014 um 11:36 schrieb David Aguilar: Add dependent headers so that including a header does not require including additional headers. This makes it so that gcc -c $header succeeds for each header. diff --git a/cache.h b/cache.h index

Re: [PATCH v4 00/32] Lockfile correctness and refactoring

2014-09-07 Thread Torsten Bögershausen
On 2014-09-06 09.50, Michael Haggerty wrote: Sorry for the long delay since v3. This version mostly cleans up a couple more places where the lockfile object was left in an ill-defined state. No problem with the delay. The most important question is if we do the lk-active handling right. Set

Re: trace.c, line 219: error: identifier redeclared: trace_strbuf

2014-09-07 Thread dev
On September 6, 2014 at 4:53 PM René Scharfe l@web.de wrote: Am 06.09.2014 um 21:26 schrieb dev: snip Solaris 10 with Oracle Studio 12.3 compiler tools. A lengthy maillist discussion last week sorted out the previous release of git just fine however this release fails to

Re: [RFC PATCH v2 1/2] Makefile: add check-headers target

2014-09-07 Thread Jonathan Nieder
Hi, David Aguilar wrote: --- /dev/null +++ b/check-headers.sh @@ -0,0 +1,29 @@ [...] + $@ -Wno-unused -I$subdir -c -o $header.check -x c - $header All .c files in git are supposed to start by #include-ing git-compat-util.h, cache.h, or builtin.h to set the appropriate feature test

Re: [RFC PATCH v2 2/2] headers: include dependent headers

2014-09-07 Thread Jonathan Nieder
David Aguilar wrote: Add dependent headers so that including a header does not require including additional headers. I agree with this goal, modulo the compat-util.h caveat. Thanks for working on it. [...] --- a/archive.h +++ b/archive.h @@ -1,6 +1,7 @@ #ifndef ARCHIVE_H #define

Re: [RFC PATCH v2 2/2] headers: include dependent headers

2014-09-07 Thread Johannes Sixt
Am 07.09.2014 21:49, schrieb Jonathan Nieder: +enum object_type; Enum forward declarations are a relatively new C feature. They certainly don't exist pre-C99. -- Hannes -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: [RFC PATCH v2 2/2] headers: include dependent headers

2014-09-07 Thread Jonathan Nieder
Johannes Sixt wrote: Am 07.09.2014 21:49, schrieb Jonathan Nieder: +enum object_type; Enum forward declarations are a relatively new C feature. They certainly don't exist pre-C99. Good catch. That makes diff --git i/archive.h w/archive.h index 4a791e1..b2ca5bf 100644 --- i/archive.h +++

Re: [RFC PATCH v2 2/2] headers: include dependent headers

2014-09-07 Thread David Aguilar
On Sun, Sep 07, 2014 at 12:49:18PM -0700, Jonathan Nieder wrote: David Aguilar wrote: Add dependent headers so that including a header does not require including additional headers. I agree with this goal, modulo the compat-util.h caveat. Thanks for working on it. [...] ---

Check out git-author

2014-09-07 Thread xmeng
Hi all, I have been using git-blame to track who changed a line of code or who to blame for a line of code. It is easy to use. For example, for this particular line of code: $ git blame -L 2235,2235 fs/ext4/mballoc.c 85556c9a (Wei Yongjun 2012-09-26 20:43:37 -0400 2235) meta_group_info[i]

Re: [PATCH v2] git svn: info: correctly handle absolute path args

2014-09-07 Thread brian m. carlson
On Sun, Sep 07, 2014 at 10:57:43AM +0200, Johannes Sixt wrote: Am 07.09.2014 10:06, schrieb Eric Wong: sub cmd_info { - my $path = canonicalize_path(defined($_[0]) ? $_[0] : .); - my $fullpath = canonicalize_path($cmd_dir_prefix . $path); + my $path_arg = defined($_[0]) ? $_[0] :

Re: Check out git-author

2014-09-07 Thread Jeff King
On Sun, Sep 07, 2014 at 06:05:13PM -0500, xmeng wrote: The problem with git-blame is that it only reports the last author/commit that changed the line, regardless of the magnitude of the change. Sometimes, the last author may only change a tiny part of the code and should not be blamed. I