On 10/10/2014 02:04 PM, Duy Nguyen wrote:
On Fri, Oct 10, 2014 at 7:02 PM, Thomas Braun
thomas.br...@virtuell-zuhause.de wrote:
Are you compiling git.git or msysgit.git?
git.git
And how about the test suite?
running right now, fingers crossed.. kinda slow, not sure if it's
wine or
Hey Duy,
I'm not sure why the pattern would have to be as you describe - I'm
just looking to ignore `*.out` as a general configuration, and disable
it for one specific project, so it would seem a plain `!*.out` should
work.
In any case, I added a `.gitignore` file with the single pattern
The 'hash' variable in test-hashmap.c is not initialised properly
which causes some 'gcc' versions to complain during compilation.
Signed-off-by: Felipe Franciosi fel...@paradoxo.org
---
test-hashmap.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test-hashmap.c
On Mon, Oct 13, 2014 at 2:56 AM, Duy Nguyen pclo...@gmail.com wrote:
On Sun, Oct 12, 2014 at 4:09 PM, Etienne Buira etienne.bu...@gmail.com
wrote:
Replace atexit()s calls with cmd_atexit that is atexit() on threaded
builds, but handles the callbacks list internally for unthreaded builds.
Wrap atexit()s calls on unthreaded builds to handle callback list
internally.
This is needed because on unthreaded builds, asyncs inherits parent's
atexit() list, that gets run as soon as the async exit()s (and again at
the end of the parent process). That led to remove temporary and lock
files
Jeff King wrote:
For small outputs, we sometimes use:
test $(some_cmd) = something we expect
instead of a full test_cmp. The downside of this is that
when it fails, there is no output at all from the script.
There's another downside to that construct: it loses the exit
status from
Etienne Buira etienne.bu...@gmail.com writes:
+#define tmp_atexit atexit
+#define atexit tmp_atexit
+#undef tmp_atexit
What is this supposed to do?
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
And now for
Mark Levedahl mleved...@gmail.com writes:
Some options may be configured globally for a remote (e.g, tagopt).
Or some remotes may have only pushurl and not url. git remote
output for me has a few such remotes but wouldn't this patch break
it?
If a caller that walks the list of remotes
Crabtree, Andrew andrew.crabt...@hp.com writes:
I'm getting the same output with both the triple and double dot for my
specific case, but I have no idea if that change makes sense for all
cases or not. Any guidance?
The difference only matters if any of your 4 patches have been sent
to your
Hi,
I guess this comment is aimed at Scott Chacon.
I have read your blog post on Smart HTTP
(http://git-scm.com/blog/2010/03/04/smart-http.html) and wondered if
there is any documentation that compares in terms of thoroughness with
your sections in the book on using SSH, which does explain the
Ah gotcha. That makes sense.
Default behavior is to do a patch-id check on all of them which is exactly what
you would normally want to happen, and suppressing that speeds things up
considerably at the risk of attempting to re-apply an already existing patch.
Thanks much for the explanation.
Read the configuration to get trailer information, and then process
it and store it in a doubly linked list.
The config information is stored in the list whose first item is
pointed to by:
static struct trailer_item *first_conf_item;
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Implement the logic to process trailers from the input message
and from arguments.
At the beginning trailers from the input message are in their
own in_tok doubly linked list, and trailers from arguments
are in their own arg_tok doubly linked list.
The lists are traversed and when an arg_tok
Parse the trailer command line arguments and put
the result into an arg_tok doubly linked list.
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C Hamano gits...@pobox.com
---
trailer.c | 112 ++
1 file
We will use a doubly linked list to store all information
about trailers and their configuration.
This way we can easily remove or add trailers to or from
trailer lists while traversing the lists in either direction.
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C
And add a few other tests for some special cases.
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C Hamano gits...@pobox.com
---
t/t7513-interpret-trailers.sh | 125 ++
1 file changed, 125 insertions(+)
diff --git
[Sorry to resend this v16, but the series didn't make it to list
the first time...]
This patch series implements a new command:
git interpret-trailers
and an infrastructure to process trailers that can be reused,
for example in commit.c.
1) Rationale
This command should help with RFC
This patch adds the process_trailers() function that
calls all the previously added processing functions
and then prints the results on the standard output.
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C Hamano gits...@pobox.com
---
trailer.c | 69
Read trailers from a file or from stdin, parse the trailers and then
put the result into a doubly linked list.
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C Hamano gits...@pobox.com
---
trailer.c | 123
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C Hamano gits...@pobox.com
---
t/t7513-interpret-trailers.sh | 738 ++
1 file changed, 738 insertions(+)
create mode 100755 t/t7513-interpret-trailers.sh
diff --git
Let the user specify a command that will give on its standard output
the value to use for the specified trailer.
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C Hamano gits...@pobox.com
---
trailer.c | 85
While at it add git-interpret-trailers to command-list.txt.
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C Hamano gits...@pobox.com
---
Documentation/git-interpret-trailers.txt | 314 +++
command-list.txt | 1 +
This patch adds the git interpret-trailers command.
This command uses the previously added process_trailers()
function in trailer.c.
Signed-off-by: Christian Couder chrisc...@tuxfamily.org
Signed-off-by: Junio C Hamano gits...@pobox.com
---
.gitignore | 1 +
Makefile
Jeff King p...@peff.net writes:
... Which makes me wonder if safe-include is really helping that
much versus a project shipping a shell script that munges the repository
config. The latter is less safe (you are, after all, running code, but
you would at least have the chance to examine it),
Jeff King p...@peff.net writes:
These patches are pulled out of the prune-mtime series I posted
earlier[1]. The discussion veered off and there's no reason that the two
topics need to be part of the same series.
These look all sensible.
Is your plan to reroll the prune-mtime stuff on top of
Wrap atexit()s calls on unthreaded builds to handle callback list
internally.
This is needed because on unthreaded builds, asyncs inherits parent's
atexit() list, that gets run as soon as the async exit()s (and again at
the end of the parent process). That led to remove temporary and lock
files
Jeff King p...@peff.net writes:
Hmph. I had originally intended to make this set -x; with a semicolon,
to keep it split from $*. But I forgot to, and much to my surprise, all
of the tests still passed.
Yup, I was wondering why you posted a version without the semicolon,
which looked obviously
Hi,
Junio C Hamano writes:
Fabian Ruch baf...@gmail.com writes:
diff --git a/git-rebase--merge.sh b/git-rebase--merge.sh
index d3fb67d..3f754ae 100644
--- a/git-rebase--merge.sh
+++ b/git-rebase--merge.sh
@@ -67,7 +67,13 @@ call_merge () {
GIT_MERGE_VERBOSITY=1 export
On Mon, 13 Oct 2014 17:29:05 +
John Norris j...@norricorp.f9.co.uk wrote:
I guess this comment is aimed at Scott Chacon.
I have read your blog post on Smart HTTP
(http://git-scm.com/blog/2010/03/04/smart-http.html) and wondered if
there is any documentation that compares in terms of
Jeff King p...@peff.net writes:
On Sat, Oct 11, 2014 at 01:00:16PM +0200, René Scharfe wrote:
The argv_array used in unpack() is never freed. Instead of adding
explicit calls to argv_array_clear() use the args member of struct
child_process and let run_command() and friends clean up for us.
Etienne Buira etienne.bu...@gmail.com writes:
Subject: Re: [PATCH 1/2] fix compilation with --disable-pthreads
That probably is a typo of NO_PTHREADS=NoThanks or something.
Thanks.
Just out of curiosity, are you porting to some exotic platforms?
Signed-off-by: Etienne Buira
David Aguilar dav...@gmail.com writes:
From: Charles Bailey cbaile...@bloomberg.net
Signed-off-by: Charles Bailey cbaile...@bloomberg.net
Signed-off-by: David Aguilar dav...@gmail.com
---
Changes since v2:
This now uses the new git_dir_init function.
git-mergetool.sh | 5 -
1 file
David Aguilar dav...@gmail.com writes:
Teach mergetool to write files in a temporary directory when
'mergetool.writeToTemp' is true.
This is helpful for tools such as Eclipse which cannot cope with
multiple copies of the same file in the worktree.
Suggested-by: Charles Bailey
David Aguilar dav...@gmail.com writes:
Teach mergetool to write files in a temporary directory when
'mergetool.writeToTemp' is true.
This is helpful for tools such as Eclipse which cannot cope with
multiple copies of the same file in the worktree.
With this can we drop the change the
David Aguilar dav...@gmail.com writes:
Avoid filenames with multiple dots so that overly-picky tools do
not misinterpret their extension.
Previously, foo/bar.ext in the worktree would result in e.g.
./foo/bar.ext.BASE.1234.ext
This can be improved by having only a single .ext and
Etienne Buira etienne.bu...@gmail.com writes:
Threads count being defaulted to 0 (autodetect), and --disable-pthreads
build checking that thread count==1, there were spurious warnings about
threads being ignored, despite not specified on command line/conf.
Fixes tests 5521 and 5526 that were
Etienne Buira etienne.bu...@gmail.com writes:
Wrap atexit()s calls on unthreaded builds to handle callback list
internally.
This is needed because on unthreaded builds, asyncs inherits parent's
atexit() list, that gets run as soon as the async exit()s (and again at
the end of the parent
Felipe Franciosi fel...@paradoxo.org writes:
The 'hash' variable in test-hashmap.c is not initialised properly
which causes some 'gcc' versions to complain during compilation.
FNV/I/IDIV10/0 covers all the possibilities of (method 3), I would
have to say that the compiler needs to be fixed.
Thanks, obviously correct.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
brian m. carlson sand...@crustytoothpaste.net writes:
This series is designed to implement the changes necessary to build Git
using Asciidoctor instead of AsciiDoc.
The first two patches are bug fixes. Asciidoctor is stricter about
title underline lengths (± 1 character instead of 2) and
On Mon, Oct 13, 2014 at 11:24:42AM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
These patches are pulled out of the prune-mtime series I posted
earlier[1]. The discussion veered off and there's no reason that the two
topics need to be part of the same series.
These
On Mon, Oct 13, 2014 at 09:10:22AM -0700, Jonathan Nieder wrote:
Jeff King wrote:
For small outputs, we sometimes use:
test $(some_cmd) = something we expect
instead of a full test_cmp. The downside of this is that
when it fails, there is no output at all from the script.
Hi Michael,
On Mon, 13 Oct 2014, Michael Stefaniuc wrote:
On 10/10/2014 02:04 PM, Duy Nguyen wrote:
On Fri, Oct 10, 2014 at 7:02 PM, Thomas Braun
Are you compiling git.git or msysgit.git?
git.git
And how about the test suite?
running right now, fingers crossed.. kinda slow,
Jeff King wrote:
On Mon, Oct 13, 2014 at 09:10:22AM -0700, Jonathan Nieder wrote:
There's another downside to that construct: it loses the exit
status from some_cmd.
Yes, although I think in many cases it's not a big deal. For example,
here we lose the exit code of count-objects, but it
On Mon, Oct 13, 2014 at 2:31 PM, Jonathan Nieder jrnie...@gmail.com wrote:
Jeff King wrote:
On Mon, Oct 13, 2014 at 09:10:22AM -0700, Jonathan Nieder wrote:
There's another downside to that construct: it loses the exit
status from some_cmd.
Yes, although I think in many cases it's not a big
On Mon, Oct 13, 2014 at 02:31:32PM -0700, Jonathan Nieder wrote:
One of my goals was to provide a more generic helper so that we don't
have to make little helpers like this for every command. So I'd much
rather something like:
test_output () {
printf %s\n $1 expect
shift
Junio C Hamano wrote:
On Mon, Oct 13, 2014 at 2:31 PM, Jonathan Nieder jrnie...@gmail.com wrote:
It could segfault after producing the good output, but sure,
count-objects code doesn't change very often.
Doesn't change very often is not the issue. Here we are not testing
if it can count
On Mon, Oct 13, 2014 at 10:53 PM, Felipe Franciosi fel...@paradoxo.org wrote:
On Mon, Oct 13, 2014 at 9:12 PM, Junio C Hamano gits...@pobox.com wrote:
Felipe Franciosi fel...@paradoxo.org writes:
The 'hash' variable in test-hashmap.c is not initialised properly
which causes some 'gcc'
Jonathan Nieder jrnie...@gmail.com writes:
Junio C Hamano wrote:
On Mon, Oct 13, 2014 at 2:31 PM, Jonathan Nieder jrnie...@gmail.com wrote:
It could segfault after producing the good output, but sure,
count-objects code doesn't change very often.
Doesn't change very often is not the issue.
Christian Couder christian.cou...@gmail.com writes:
On Sun, Oct 12, 2014 at 11:36 AM, Christian Couder
christian.cou...@gmail.com wrote:
With v16 you can easily choose if you want to have the S-o-b in the
output or not, when there is already one, ...
By the way, I sent v16 just before the
Jeff King p...@peff.net writes:
On Fri, Oct 10, 2014 at 02:21:56AM -0400, Jeff King wrote:
diff --git a/t/test-lib.sh b/t/test-lib.sh
index a60ec75..81ceb23 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -237,7 +237,11 @@ do
shift ;;
-x)
Junio C Hamano gits...@pobox.com writes:
Does 1308 pass with this patch for you (running it without -x)?
The original that expects a hardcoded line number (not relative to
the original or something) is a bad taste, and also the test setup
procedure is broken (see below for a fix of that
On Mon, Oct 13, 2014 at 03:22:50PM -0700, Junio C Hamano wrote:
Rerolled patch is below. Sorry for all the emails. I'll stop looking at
it now to give you guys a chance to find any remaining mistakes. ;)
Does 1308 pass with this patch for you (running it without -x)?
Hmph. It does not. I
Jeff King p...@peff.net writes:
This fixes it:
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 4dab575..059bb25 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -528,8 +528,7 @@ maybe_setup_valgrind () {
test_eval_inner_ () {
eval
test \$trace\ = t set -x
-
On Mon, Oct 13, 2014 at 06:33:03PM -0400, Jeff King wrote:
But still it is disturbing to see that there is a blank line
difference with and without this change in the file created by the
test (i.e. the client of the code this patch touches).
This fixes it:
diff --git a/t/test-lib.sh
Jeff King p...@peff.net writes:
OK, I lied. I couldn't resist spending 5 more minutes on it.
If you instrument t1308 on master to look at the contents of .git/config
directly after the setup step, you'll see that the file ends with (tabs
marked as ^I):
[...]
^I^Ihorns
^IEOF
Which
I do not want to do too many What's cooking report, so here is
just a summary of the status of various topics. Hopefully I'll do
the real one later this week after a few more integrations.
Thanks.
$ Meta/cook -w
Expecting a reroll.
- jk/makefile
On Mon, Oct 13, 2014 at 01:41:31PM -0700, Junio C Hamano wrote:
brian m. carlson sand...@crustytoothpaste.net writes:
The second two patches implement some basic support for building with
Asciidoctor. The first of these moves some items into variables due to
some differences between the
On Mon, Oct 13, 2014 at 04:14:59PM -0700, Junio C Hamano wrote:
We came to more or less the same conclusion. With your $* fixed,
the test works as before, with the same definition of works,
because without your patch the file ends with HTEOFLF and with
your original $*LFHT the file ends with
On 10/13/2014 01:19 PM, Junio C Hamano wrote:
Mark Levedahl mleved...@gmail.com writes:
Some options may be configured globally for a remote (e.g, tagopt).
Or some remotes may have only pushurl and not url. git remote
output for me has a few such remotes but wouldn't this patch break
it?
If
On Mon, Oct 13, 2014 at 2:53 PM, Felipe Franciosi fel...@paradoxo.org wrote:
On Mon, Oct 13, 2014 at 9:12 PM, Junio C Hamano gits...@pobox.com wrote:
FNV/I/IDIV10/0 covers all the possibilities of (method 3), I would
have to say that the compiler needs to be fixed.
Or insert default: just
Set __git_ps1 to display nothing when present working directory is
ignored, triggered by either the new environmental variable
GIT_PS1_HIDE_ON_IGNORED_PWD or the new repository configuration
variable bash.hideOnIgnoredPwd (or both). In the absence of these
settings this change has no effect.
Many
You sent a virus mail, please check you computer for virus.
Mail header info:
From: git@vger.kernel.org
To: yanhua.d...@wolong.com
Subject: Returned mail: see transcript for details
Date: Tue, 14 Oct 2014 11:32:19 +0700
You sent a virus mail, please check you computer for virus.
Mail header info:
From: git@vger.kernel.org
To: yanhua.d...@wolong.com
Subject: Returned mail: see transcript for details
Date: Tue, 14 Oct 2014 11:32:19 +0700
From: Junio C Hamano gits...@pobox.com
Christian Couder christian.cou...@gmail.com writes:
On Sun, Oct 12, 2014 at 11:36 AM, Christian Couder
christian.cou...@gmail.com wrote:
With v16 you can easily choose if you want to have the S-o-b in the
output or not, when there is already one, ...
65 matches
Mail list logo
