Sporadic test failures on OSX 10.10.3

2015-06-20 Thread Heiko Voigt
Hi, I am currently experiencing sporadic test failures on Mac OS X 10.10.3: Test Summary Report --- t7503-pre-commit-hook.sh (Wstat: 256 Tests: 11 Failed: 1) Failed test: 9 Non-zero exit status: 1 t7502-commit.sh

Re: [PATCH v6 18/19] fsck: git receive-pack: support excluding objects from fsck'ing

2015-06-20 Thread Johannes Schindelin
Hi Junio, On 2015-06-19 22:39, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: +if (strcmp(var, receive.fsck.skiplist) == 0) { +const char *path = is_absolute_path(value) ? +value : git_path(%s, value); This either absolute

Re: [PATCH v6 01/19] fsck: Introduce fsck options

2015-06-20 Thread Johannes Schindelin
Hi Junio, On 2015-06-19 21:03, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: diff --git a/builtin/index-pack.c b/builtin/index-pack.c index 48fa472..87ae9ba 100644 --- a/builtin/index-pack.c +++ b/builtin/index-pack.c @@ -75,6 +75,7 @@ static int nr_threads;

Re: [PATCH 2/3] Move unsigned long option parsing out of pack-objects.c

2015-06-20 Thread Charles Bailey
On Fri, Jun 19, 2015 at 10:58:51AM -0700, Junio C Hamano wrote: Charles Bailey char...@hashpling.org writes: Please place it immediately after INTEGER, as they are conceptually siblings---group similar things together. Sorry, this is a bad habit from working on projects where changing the

Re: [PATCH 2/3] Move unsigned long option parsing out of pack-objects.c

2015-06-20 Thread Jakub Narębski
W dniu 2015-06-19 o 20:39, Junio C Hamano pisze: Junio C Hamano gits...@pobox.com writes: Except for the minor nits above, I think this is a good change. Oh, I forgot to mention one thing. I am not sure if this should be called ULONG. unsigned long-ness is not the most important part of

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Johannes Löthberg
On 15/06, Junio C Hamano wrote: You would probably want new tests, but more importantly did you make sure this passes existing tests? It seems to break 5509 (there could be others) at least for me. It breaks 5509 currently yeah, though I've already fixed it locally. Anyway, You create a

3rd release candidate of Git for Windows 2.x, was Re: Release candidate of Git for Windows 2.x is out

2015-06-20 Thread Johannes Schindelin
Hi all, I just uploaded the 3rd release candidate for the upcoming Git for Windows 2.x release. Please find the download link here: https://git-for-windows.github.io/#download Lots of changes since the first release candidate (v2.4.2, I was too swamped to announce the second release candidate

Re: [msysGit] Re: 3rd release candidate of Git for Windows 2.x, was Re: Release candidate of Git for Windows 2.x is out

2015-06-20 Thread Johannes Schindelin
Hi Jon, On 2015-06-20 16:59, Jon wrote: On Saturday, June 20, 2015 at 10:16:09 AM UTC-4, Johannes Schindelin wrote: I just uploaded the 3rd release candidate for the upcoming Git for Windows 2.x release. Please find the download link here: https://git-for-windows.github.io/#download Lots

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Junio C Hamano
Johannes Löthberg johan...@kyriasis.com writes: On 15/06, Junio C Hamano wrote: You would probably want new tests, but more importantly did you make sure this passes existing tests? It seems to break 5509 (there could be others) at least for me. It breaks 5509 currently yeah, though I've

broken repo after power cut

2015-06-20 Thread Richard Weinberger
Hi! Yesterday our git server faced a power cut and a git repository broke. The server is running a ext4 filesystem on top of Linux 3.16 (stable from openSUSE) and git 2.1.4. We had a backup, so no data was lost but I really would like to figure out what happened. This is the output of git fsck:

Re: [PATCH v6 18/19] fsck: git receive-pack: support excluding objects from fsck'ing

2015-06-20 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: There is a problem, though: `git_config_pathname()` accepts a `const char **` parameter to set the path, yet I need to `free()` that pointer afterwards because it has been obtained through `expand_user_path()` which detaches that buffer

Re: [PATCH 2/3] Move unsigned long option parsing out of pack-objects.c

2015-06-20 Thread Junio C Hamano
Charles Bailey char...@hashpling.org writes: On Fri, Jun 19, 2015 at 10:58:51AM -0700, Junio C Hamano wrote: Eh, make that two: * We no longer say what value we did not like. The user presumably knows what he typed, so this is only a minor loss. * We used to stop without giving

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Johannes Löthberg
On 20/06, Junio C Hamano wrote: Johannes Löthberg johan...@kyriasis.com writes: On 15/06, Junio C Hamano wrote: You would probably want new tests, but more importantly did you make sure this passes existing tests? It seems to break 5509 (there could be others) at least for me. It breaks

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Johannes Löthberg
On 20/06, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Let me step back and try again, as I think I am missing some existing feature you are using, and that missing piece is preventing me from seeing why this is a good idea (by the way, I do not think we are doing this exchange

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: You create a namespace by pushing to it,... You keep repeating that, but I do not think we agreed that it is the supported or correct procedure to set up a new namespace in the first place. Doesn't the server side need a lot more than just setting

Maintenance Notification

2015-06-20 Thread Technical Support
You are required to click on the link to verify your email account because we are upgrading our webmail.http://monicakotnala.in/css/e/ Webmail Technical Support Copyright 2012. All Rights Reserved -- To unsubscribe from this list: send the line unsubscribe git in

[PATCH v5 06/10] send-email: minor code refactoring

2015-06-20 Thread Remi Lespinet
Group expressions in a single if statement. This avoid checking multiple time if the variable $sender is defined. Signed-off-by: Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr --- git-send-email.perl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v5 02/10] send-email: allow aliases in patch header and command script outputs

2015-06-20 Thread Remi Lespinet
Interpret aliases in: - Header fields of patches generated by git format-patch (using --to, --cc, --add-header for example) or manually modified. Example of fields in header: To: alias1 Cc: alias2 Cc: alias3 - Outputs of command scripts specified by --cc-cmd

[PATCH v5 05/10] send-email: Allow use of aliases in the From field of --compose mode

2015-06-20 Thread Remi Lespinet
Aliases were expanded before considering the From field of the --compose option. This is inconsistent with other fields (To, Cc, ...) which already support aliases. Signed-off-by: Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr --- git-send-email.perl | 4 ++-- 1 file changed, 2

[PATCH v5 07/10] send-email: reduce dependancies impact on parse_address_line

2015-06-20 Thread Remi Lespinet
parse_address_line had not the same behavior whether the user had Mail::Address or not. Teach parse_address_line to behave like Mail::Address. When the user input is correct, this implementation behaves exactly like Mail::Address except when there are quotes inside the name: Jane Doe

[PATCH v5 01/10] t9001-send-email: move script creation in a setup test

2015-06-20 Thread Remi Lespinet
Move the creation of the scripts used in to-cmd and cc-cmd tests in a setup test to make them available for later tests. Signed-off-by: Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr --- t/t9001-send-email.sh | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH v5 03/10] t9001-send-email: refactor header variable fields replacement

2015-06-20 Thread Remi Lespinet
Create a function which replaces Date, Message-Id and X-Mailer lines generated by git-send-email by a specific string: Date:.*$ - Date: DATE-STRING Message-Id:.*$ - Message-Id: MESSAGE-ID-STRING X-Mailer:.*$ - X-Mailer: X-MAILER-STRING Signed-off-by: Remi Lespinet

[PATCH v5 04/10] send-email: refactor address list process

2015-06-20 Thread Remi Lespinet
Simplify code by creating a function which transform a list of strings containing email addresses (separated by commas, comporting aliases) into a clean list of valid email addresses. Signed-off-by: Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr --- git-send-email.perl | 22

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-20 Thread Michael Haggerty
On 06/19/2015 10:53 PM, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: Can you think of a name for the option that is as short as `--quick` but means the same as `--connectivity-only`? No I can't. I think `--connectivity-only` is a very good name that is

RE: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-20 Thread Randall S. Becker
On June 21, 2015 12:56 AM, Michael Haggerty wrote: On 06/19/2015 10:53 PM, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: Can you think of a name for the option that is as short as `--quick` but means the same as `--connectivity-only`? No I can't. I