Re: [PATCH] Consider object stores in alternates during a dissociating clone

2015-10-22 Thread Junio C Hamano
Alexander Riesen writes: > Incidentally, what does "---" mean in the documentation hunk? Heh, good eyes. I was hoping that it would turn into an em-dash, but it seems I just get three dashes instead. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] Consider object stores in alternates during a dissociating clone

2015-10-22 Thread Junio C Hamano
Junio C Hamano writes: > Alexander Riesen writes: > >> Incidentally, what does "---" mean in the documentation hunk? > > Heh, good eyes. I was hoping that it would turn into an em-dash, > but it seems I just get three dashes instead. Outside

Re: [PATCH v2 2/2] blame: allow blame --reverse --first-parent when it makes sense

2015-10-22 Thread Junio C Hamano
Max Kirillov writes: > On Wed, Oct 21, 2015 at 09:25:37PM -0700, Junio C Hamano wrote: > >> The logic you implemented feels solid to me, at least at a first >> glance. What kind of gotchas are you worried about? > > The fact than arbitrary commit's children are unknown does >

Watchman/inotify support and other ways to speed up git status

2015-10-22 Thread Christian Couder
Hi everyone, I am starting to investigate ways to speed up git status and other git commands for Booking.com (thanks to AEvar) and I'd be happy to discuss the current status or be pointed to relevant documentation or mailing list threads. >From the threads below ([0], [1], [2], [3], [4], [5],

Re: Watchman/inotify support and other ways to speed up git status

2015-10-22 Thread Duy Nguyen
On Thu, Oct 22, 2015 at 7:59 AM, Christian Couder wrote: > Hi everyone, > > I am starting to investigate ways to speed up git status and other git > commands for Booking.com (thanks to AEvar) and I'd be happy to discuss > the current status or be pointed to relevant

Re: [PATCH 0/5] Remove unused #include "sigchain.h"

2015-10-22 Thread Junio C Hamano
Makes sense; will queue directly on top of the original tempfile series and merge. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] difftool: gracefully handle symlinks to directories

2015-10-22 Thread Junio C Hamano
David Aguilar writes: > difftool's dir-diff feature was blindly feeding worktree paths > to hash-object without checking whether the path was indeed a > file, causing the feature to fail when repositories contain > symlinks to directories. Wait. Anything that considers

Re: [PATCH] Consider object stores in alternates during a dissociating clone

2015-10-22 Thread Junio C Hamano
Alexander Riesen writes: >> Content-Type: text/plain; charset=windows-1252; format=flowed I had to hand-munge it as the above lost all tabs and made the patch unusable for machines X-<. Re-reading the documentation, I realized that the use case this new mode of

Re: [PATCH] Consider object stores in alternates during a dissociating clone

2015-10-22 Thread Alexander Riesen
On 10/22/2015 07:50 PM, Junio C Hamano wrote: Alexander Riesen writes: Content-Type: text/plain; charset=windows-1252; format=flowed I had to hand-munge it as the above lost all tabs and made the patch unusable for machines X-<. I'm very sorry. I don't know why

Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"

2015-10-22 Thread Junio C Hamano
Tobias Klauser writes: > After switching to use the tempfile module in commit ebebeaea (gc: use > tempfile module to handle gc.pid file), no declarations from sigchain.h > are used in builtin/gc.c anymore. Thus, remove the #include. > > Signed-off-by: Tobias Klauser

[PATCH] Documentation: AsciiDoc spells em-dash as double-dashes, not triple

2015-10-22 Thread Junio C Hamano
Again, we do not usually process release notes with AsciiDoc, but it is better to be consistent. This incidentally reveals breakages left by an ancient 5e00439f (Documentation: build html for all files in technical and howto, 2012-10-23). The index-format documentation was originally written to

RE: [PATCH] Add git-grep threads-num param

2015-10-22 Thread Victor Leschuk
Hello John, I haven't noticed the --threads option in pack-objects, I will fix the patch to make naming more uniform. Do you have any comments regarding the functionality? -- Best Regards, Victor From: John Keeping [j...@keeping.me.uk] Sent: Thursday,

Re: [PATCH] Add git-grep threads-num param

2015-10-22 Thread Junio C Hamano
John Keeping writes: > On Thu, Oct 22, 2015 at 04:23:56PM +0300, Victor Leschuk wrote: >> Hello all, I suggest we make number of git-grep worker threads a >> configuration >> parameter. I have run several tests on systems with different number of CPU >> cores. >> It

What's cooking in git.git (Oct 2015, #05; Thu, 22)

2015-10-22 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. With somewhat reduced review bandwidth, I'd expect that the upcoming cycle would be slower than usual. At tinyurl.com/gitCal, I tentatively

Re: ancestor and descendant ~ clarification needed

2015-10-22 Thread Junio C Hamano
Xue Fuqiao writes: > In Documentation/user-manual.txt: > >In the following, we say that commit X is "reachable" from commit Y >if commit X is an ancestor of commit Y. Equivalently, you could say >that Y is a descendant of X, or that there is a chain of parents >

Re: [PATCH v1 0/2] git-p4: Fix tests on OS X

2015-10-22 Thread Luke Diamand
On 12/10/15 18:03, larsxschnei...@gmail.com wrote: From: Lars Schneider I extracted this patch series from "[PATCH v3 0/3] Add Travis CI support" as suggested by Junio. All seems sensible to me. Luke Thanks, Lars Lars Schneider (2): git-p4: Improve test

Re: Make

2015-10-22 Thread Kannan Goundan
Thanks for the explanation. I didn't realize some projects don't want to initialize all their submodules, but the explicit opt-in idea you described sounds nice. I've seen cases where people will financially "sponsor" feature development in open source projects. Is there any precedent for this

Re: [PATCH] Consider object stores in alternates during a dissociating clone

2015-10-22 Thread Johannes Löthberg
On 22/10, Alexander Riesen wrote: On 10/22/2015 07:50 PM, Junio C Hamano wrote: Alexander Riesen writes: Content-Type: text/plain; charset=windows-1252; format=flowed I had to hand-munge it as the above lost all tabs and made the patch unusable for machines

ancestor and descendant ~ clarification needed

2015-10-22 Thread Xue Fuqiao
Hi, In Documentation/user-manual.txt: In the following, we say that commit X is "reachable" from commit Y if commit X is an ancestor of commit Y. Equivalently, you could say that Y is a descendant of X, or that there is a chain of parents leading from commit Y to commit X. [...]

Re: [PATCH] Add git-grep threads-num param

2015-10-22 Thread John Keeping
On Thu, Oct 22, 2015 at 04:23:56PM +0300, Victor Leschuk wrote: > Hello all, I suggest we make number of git-grep worker threads a configuration > parameter. I have run several tests on systems with different number of CPU > cores. > It appeared that the hard-coded number 8 lowers performance on

Re: [PATCH v2 2/2] blame: allow blame --reverse --first-parent when it makes sense

2015-10-22 Thread Max Kirillov
On Wed, Oct 21, 2015 at 09:25:37PM -0700, Junio C Hamano wrote: > Max Kirillov writes: > >> Do not die immediately when the two flags are specified. Instead >> check that the specified range is along first-parent chain. Exploit >> how prepare_revision_walk() handles

[PATCH] Consider object stores in alternates during a dissociating clone

2015-10-22 Thread Alexander Riesen
From: Alex Riesen The "--reference" option is not the only way to provide a repository to borrow objects from. For instance, the objects/info/alternates of the origin repository lists object stores which the origin repository borrowed objects from. During clone operations

Re: [PATCH v2 1/2] Add test to describe expectation of blame --reverse with branched history

2015-10-22 Thread Max Kirillov
On Wed, Oct 21, 2015 at 09:19:45PM -0700, Junio C Hamano wrote: > Let me try. > > (1) for merges, an edge with '*' denotes the one to the first > parent. > (2) a commit that touches file.t are in capital > >c1---a3 > /* > // >A0---a1--*a2 >

Re: [PATCH v2 1/2] Add test to describe expectation of blame --reverse with branched history

2015-10-22 Thread Max Kirillov
On Thu, Oct 22, 2015 at 05:37:21PM +0300, Max Kirillov wrote: > Yes. Though I would ... make the line of As straight. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: Make "git checkout" automatically update submodules?

2015-10-22 Thread Kannan Goundan
Junio C Hamano pobox.com> writes: > We are unfortunately not set up to handle money well. For a > background explanation, please go read [*1*], which I wrote my take > on "money" some time ago. Note that it is an explanation and not a > justification. It explains why we are not set up to

Re: Make

2015-10-22 Thread Junio C Hamano
Kannan Goundan writes: > Thanks for the explanation. I didn't realize some projects don't want to > initialize all their submodules, but the explicit opt-in idea you described > sounds nice. > > I've seen cases where people will financially "sponsor" feature development > in

Re: Poor git write performance to NFS

2015-10-22 Thread Daniel Steinborn
Hi, thank you for your answer. I removed the git Debian package and compiled v2.6.2 manually. The performance is much better now (on the same level als v1.7.12.4). We opened a Debian bug report, to request a git version >= 2.6 to be backported to jessie:

[PATCH] Add git-grep threads-num param

2015-10-22 Thread Victor Leschuk
Hello all, I suggest we make number of git-grep worker threads a configuration parameter. I have run several tests on systems with different number of CPU cores. It appeared that the hard-coded number 8 lowers performance on both of my systems: on my 4-core and 8-core systems the thread number

[PATCH 3/5] diff: remove unused #include "sigchain.h"

2015-10-22 Thread Tobias Klauser
After switching to use the tempfile module in commit 284098f1 (diff: use tempfile module), no declarations from sigchain.h are used in diff.c anymore. Thus, remove the #include. Signed-off-by: Tobias Klauser --- diff.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 2/5] credential-cache--daemon: remove unused #include "sigchain.h"

2015-10-22 Thread Tobias Klauser
After switching to use the tempfile module in commit 9e903316 (credential-cache--daemon: use tempfile module), no declarations from sigchain.h are used in credential-cache--daemon.c anymore. Thus, remove the #include. Signed-off-by: Tobias Klauser ---

[PATCH 1/5] gc: remove unused #include "sigchain.h"

2015-10-22 Thread Tobias Klauser
After switching to use the tempfile module in commit ebebeaea (gc: use tempfile module to handle gc.pid file), no declarations from sigchain.h are used in builtin/gc.c anymore. Thus, remove the #include. Signed-off-by: Tobias Klauser --- builtin/gc.c | 1 - 1 file changed,

[PATCH 5/5] shallow: remove unused #include "sigchain.h"

2015-10-22 Thread Tobias Klauser
After switching to use the tempfile module in commit 6e122b44 (setup_temporary_shallow(): use tempfile module), no declarations from sigchain.h are used in read-cache.c anymore. Thus, remove the #include. Signed-off-by: Tobias Klauser --- shallow.c | 1 - 1 file changed, 1

[PATCH 4/5] read-cache: remove unused #include "sigchain.h"

2015-10-22 Thread Tobias Klauser
After switching to use the tempfile module in commit f6ecc62d (write_shared_index(): use tempfile module), no declarations from sigchain.h are used in read-cache.c anymore. Thus, remove the #include. Signed-off-by: Tobias Klauser --- read-cache.c | 1 - 1 file changed, 1

[PATCH 0/5] Remove unused #include "sigchain.h"

2015-10-22 Thread Tobias Klauser
This series removes the #include of sigchain.h from several modules after they were changed to use the tempfile module and they thus no longer use any declarations from sigchain.h Tobias Klauser (5): gc: remove unused #include "sigchain.h" credential-cache--daemon: remove unused #include

Re: ancestor and descendant ~ clarification needed

2015-10-22 Thread Etienne Girard
Hello, I think you're right, branch A is a descendant of master. We could change the misleading sentence to "However, if the current branch is a descendant of the other - if its head is a descendant of the other's head - [...]", to link back to the definition of descendant for commits.

[PATCH] Documentation: fix header markup

2015-10-22 Thread Xue Fuqiao
Asciidoctor is stricter than AsciiDoc when deciding if underlining is a section title or the start of preformatted text. Make the length of the underlining match the text to ensure that it renders correctly in all implementations. Signed-off-by: Xue Fuqiao --- Currently,

Re: [PATCH] Documentation: fix header markup

2015-10-22 Thread Junio C Hamano
Xue Fuqiao writes: > Asciidoctor is stricter than AsciiDoc when deciding if underlining > is a section title or the start of preformatted text. Make the > length of the underlining match the text to ensure that it renders > correctly in all implementations. > >

Re: [PATCH] Consider object stores in alternates during a dissociating clone

2015-10-22 Thread Alexander Riesen
From: Alex Riesen The "--reference" option is not the only way to provide a repository to borrow objects from. For instance, the objects/info/alternates of the origin repository lists object stores which the origin repository borrowed objects from. During clone operations

Re: [PATCH] Consider object stores in alternates during a dissociating clone

2015-10-22 Thread Junio C Hamano
Alexander Riesen writes: > I think I understand. How about this? > > builtin/clone.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/builtin/clone.c b/builtin/clone.c > index 9eaecd9..a7d0c07 100644 > --- a/builtin/clone.c > +++

Re: Poor git write performance to NFS

2015-10-22 Thread Junio C Hamano
Daniel Steinborn writes: > I removed the git Debian package and compiled v2.6.2 manually. The > performance is much better now (on the same level als v1.7.12.4). Thanks. It is good that we must have done something good within the past 12 months between v2.1 and v2.6,

Re: Poor git write performance to NFS

2015-10-22 Thread Jeff King
On Thu, Oct 22, 2015 at 09:07:42AM -0700, Junio C Hamano wrote: > Daniel Steinborn writes: > > > I removed the git Debian package and compiled v2.6.2 manually. The > > performance is much better now (on the same level als v1.7.12.4). > > Thanks. It is good that we

[PATCH] Match underline with the text

2015-10-22 Thread Junio C Hamano
Even though AsciiDoc is more lenient when deciding if an underline is for the contents on the previous line to find section headers, we should match the length of them for other formatters to help them. Signed-off-by: Junio C Hamano --- * A few more instances I found.