Re: [PATCH v1 2/2] add "ok=sigpipe" to test_must_fail and use it to fix flaky tests

2015-11-28 Thread Jeff King
On Fri, Nov 27, 2015 at 10:15:14AM +0100, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" is > flaky in the following case: > 1. remote upload-pack finds out "not our ref" > 2. remote sends a

Re: What's cooking in git.git (Nov 2015, #04; Tue, 24)

2015-11-28 Thread brian m. carlson
On Sat, Nov 28, 2015 at 11:35:43AM -0500, Jeff King wrote: > On Sat, Nov 28, 2015 at 03:40:10PM +, brian m. carlson wrote: > > > On Tue, Nov 24, 2015 at 08:07:23PM -0500, Jeff King wrote: > > > What's cooking in git.git (Nov 2015, #04; Tue, 24) > > >

Re: [PATCHv3] ident.c: add support for IPv6

2015-11-28 Thread Jeff King
On Fri, Nov 27, 2015 at 02:08:27PM +, Elia Pinto wrote: > This is the third version of the patch ($gmane/280488) > Changes from previous: > > - Simplified the implementation, adding the new > function canonical_name (Jeff King) ($gmane/281479). > Fixed a new typo introduced in the second

Re: [PATCH v8] Add Travis CI support

2015-11-28 Thread Jeff King
On Fri, Nov 27, 2015 at 10:23:26AM +0100, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > diff to v7: > * remove NO_GETTEXT patch and install gettext on OS X to compile with > no additional flags (thanks Torsten) > * fix P4 version (15.2 is the latest one

Re: [PATCH v2] wt-status: correct and simplify check for detached HEAD

2015-11-28 Thread Jeff King
On Wed, Nov 25, 2015 at 03:10:18PM +0100, René Scharfe wrote: > Fix that by doing the comparison using strcmp() and only after the > branch name is extracted. This way neither too less nor too many > characters are checked. While at it call strchrnul() to find the end > of the branch name

[PATCH v5] ls-files: Add eol diagnostics

2015-11-28 Thread Torsten Bögershausen
When working in a cross-platform environment, a user wants to check if text files are stored normalized in the repository and if .gitattributes are set appropriately. Make it possible to let Git show the line endings in the index and in the working tree and the effective text/eol attributes. The

Re: What's cooking in git.git (Nov 2015, #04; Tue, 24)

2015-11-28 Thread brian m. carlson
On Tue, Nov 24, 2015 at 08:07:23PM -0500, Jeff King wrote: > What's cooking in git.git (Nov 2015, #04; Tue, 24) > -- > [New Topics] I noticed the object_id series was missing from this list. Was there something that needed fixing or a reroll? --

Re: What's cooking in git.git (Nov 2015, #04; Tue, 24)

2015-11-28 Thread Jeff King
On Sat, Nov 28, 2015 at 03:40:10PM +, brian m. carlson wrote: > On Tue, Nov 24, 2015 at 08:07:23PM -0500, Jeff King wrote: > > What's cooking in git.git (Nov 2015, #04; Tue, 24) > > -- > > [New Topics] > > I noticed the object_id series was

Re: [PATCH v1 1/2] implement test_might_fail using a refactored test_must_fail

2015-11-28 Thread Jeff King
On Fri, Nov 27, 2015 at 12:37:38PM +, Ramsay Jones wrote: > > - if test $exit_code = 0; then > > + if ! list_contains "$_test_ok" success && test "$exit_code" -eq 0 > > + then > > minor nit: > > I would prefer this was 'if test $exit_code -eq 0 && ! list_contains ...' > > ie. the

Re: [PATCH] test_must_fail: compare exit_code using integer -eq operator

2015-11-28 Thread Jeff King
On Wed, Nov 25, 2015 at 10:05:24PM +, Ramsay Jones wrote: > Hi Jeff, > > Can we squash this into your fixup? I think it's a good thing to do, but I had figured it could be a separate patch (especially since it is touching lines that are otherwise unchanged by the patch). Looks like Lars

Git 'pre-receive' hook and 'git-clang-format' script to reliably reject pushes that violate code style conventions

2015-11-28 Thread Alexander Shukaev
Hello, I have posted a question on Stack Overflow [1]. I would like to post it here as well since nobody has answered it yet. Let's immediately start with a scrap of the `pre-receive` hook that I've already written: #!/bin/sh ## format_bold='\e[1m' format_red='\e[31m'

Re: [PATCHv3] ident.c: add support for IPv6

2015-11-28 Thread Elia Pinto
2015-11-28 18:23 GMT+01:00, Jeff King : > On Fri, Nov 27, 2015 at 02:08:27PM +, Elia Pinto wrote: > >> This is the third version of the patch ($gmane/280488) >> Changes from previous: >> >> - Simplified the implementation, adding the new >> function canonical_name (Jeff King)