Re: [PATCH v4 05/12] ref-filter: introduce parsing functions for each valid atom

On Sun, Feb 7, 2016 at 12:03 PM, Eric Sunshine wrote: > On Sat, Feb 6, 2016 at 10:15 AM, Karthik Nayak wrote: >> On Sun, Jan 31, 2016 at 11:12 PM, Karthik Nayak >> wrote: >>> @@ -138,10 +140,9 @@ int

Re: [PATCH 7/8] index-pack: --append-pack implies --strict

On Fri, Feb 5, 2016 at 3:57 AM, Nguyễn Thái Ngọc Duy wrote: > A frankenstein pack, generated by multiple pack-objects runs, > certainly has higher risk of broken, especially when the server side s/of/& being/ > could be some other implementation than pack-objects. Be safe and

Re: [PATCH 5/8] fetch-pack.c: send "skip" line to pack-objects

On Fri, Feb 5, 2016 at 3:57 AM, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > diff --git a/fetch-pack.c b/fetch-pack.c > @@ -856,6 +864,8 @@ static struct ref *do_fetch_pack(struct fetch_pack_args > *args, >

Re: [PATCH v4 06/12] ref-filter: introduce color_atom_parser()

On Sun, Feb 7, 2016 at 1:13 PM, Eric Sunshine wrote: > On Sat, Feb 6, 2016 at 10:20 AM, Karthik Nayak wrote: >> On Fri, Feb 5, 2016 at 3:55 AM, Eric Sunshine >> wrote: >>> On Sun, Jan 31, 2016 at 12:42 PM, Karthik Nayak

Re: [PATCH v4 05/12] ref-filter: introduce parsing functions for each valid atom

On Sun, Feb 7, 2016 at 12:33 PM, Eric Sunshine wrote: > On Sat, Feb 6, 2016 at 9:36 AM, Karthik Nayak wrote: >> On Thu, Feb 4, 2016 at 3:49 AM, Eric Sunshine >> wrote: >>> On Sun, Jan 31, 2016 at 12:42 PM, Karthik Nayak

Re: [PATCH v6 04/11] test-regex: expose full regcomp() to the command line

On Fri, Feb 5, 2016 at 9:03 PM, Nguyễn Thái Ngọc Duy wrote: > diff --git a/test-regex.c b/test-regex.c > @@ -21,8 +38,38 @@ static int test_regex_bug(void) > int main(int argc, char **argv) > { > + const char *pat; > + const char *str; > + int flags = 0; > +

Re: [PATCH v4 05/12] ref-filter: introduce parsing functions for each valid atom

On Sun, Feb 7, 2016 at 4:01 AM, Karthik Nayak wrote: > On Sun, Feb 7, 2016 at 12:03 PM, Eric Sunshine > wrote: >> On Sat, Feb 6, 2016 at 10:15 AM, Karthik Nayak wrote: >>> I think the code needs to be changed to: >>> >>> -

update_linked_gitdir writes relative path to .git/worktrees//gitdir

I noticed that when update_linked_gitdir chooses to update .git/worktrees//gitdir, the path it writes is relative, at least under some circumstances.  This contradicts the gitrepository-layout man page, which says: worktrees//gitdir:: A text file containing the absolute path back to the

Re: [PATCH v6 00/11] Fix icase grep on non-ascii

On Fri, Feb 5, 2016 at 9:02 PM, Nguyễn Thái Ngọc Duy wrote: > v6 fixes comments from Ramsay and Eric. Interdiff below. The only > thing to add is, I decided not to replace !icase_non_ascii with > icase_ascii_only. I went with spelling out "!icase || ascii_only". I > think it

Re: git show doesn't work on file names with square brackets

Hi Johannes, > On 06 Feb 2016, at 19:10 , Johannes Schindelin > wrote: > > git show 'HEAD:bra[ckets].txt' -- > Nice catch! It works for me even without quotes. Although this “--“ is mentioned in the error message, I didn’t even try since its meaning is

Add Cc,Tested-by list while 'git commit'

Do we have any git config options to add Cc and Tested-by list like Signed-off-by is fetched from git config. example: $ git commit -s Cc: Arjun Ani Tested-by: Jagan Teki Signed-off-by: Jagan Teki Please share if we have any inputs

Re: [PATCH] setup.c: make check_filename() return 0 on ENAMETOOLONG

Hi Duy, On Sun, 7 Feb 2016, Nguyễn Thái Ngọc Duy wrote: > Noticed-by: Ole Tange > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > On Sun, Feb 7, 2016 at 4:56 AM, Ole Tange wrote: > > If file name too long it should just try to see if it is a

Re: [PATCH v4 05/12] ref-filter: introduce parsing functions for each valid atom

Karthik Nayak writes: > + if ((( arg && len == arg - sp) || > +(!arg && len == ep - sp )) && len == (arg ? arg : ep) - sp && Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53

Re: git submodule should honor "-c credential.helper" command line argument

On 07.02.2016 05:41, Jacob Keller wrote: On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller wrote: Ok so I am not sure we even really need to use "-c" option in git-clone considering that we can just use the same flow we do for setting core.worktree values. I'll propose a

Re: git show doesn't work on file names with square brackets

Hi Duy, > It's from 28fcc0b (pathspec: avoid the need of "--" when wildcard is > used - 2015-05-02) v2.5.0 is the first release which contains 28fcc0b. I can confirm that older versions of Git work correctly without “--“: # /opt/local/bin/git version git version 1.7.1.1 # /opt/local/bin/git

Re: [RFC] On the --depth argument when fetching with submodules

On 06 Feb 2016, at 01:05, Junio C Hamano wrote: > Stefan Beller writes: > >> Currently when cloning a project, including submodules, the --depth argument >> is passed on recursively, i.e. when cloning with "--depth 2", both the >> superproject as well as

Re: [PATCH v1] config: add '--sources' option to print the source of a config value

On 05 Feb 2016, at 14:58, Jeff King wrote: > On Fri, Feb 05, 2016 at 12:31:15PM +0100, Sebastian Schuberth wrote: > >>> I'm not sure returning here is the best idea. We won't have a config >>> filename if we are reading from "-c", but if we return early from this >>> function,

Re: [PATCH v1] config: add '--sources' option to print the source of a config value

On 05 Feb 2016, at 12:20, Jeff King wrote: > On Fri, Feb 05, 2016 at 09:42:30AM +0100, larsxschnei...@gmail.com wrote: > >> @@ -538,6 +569,17 @@ int cmd_config(int argc, const char **argv, const char >> *prefix) >> error("--name-only is only applicable to --list or

Re: git show doesn't work on file names with square brackets

Hi Kirill, On Sun, 7 Feb 2016, Kirill Likhodedov wrote: > > On 06 Feb 2016, at 19:10 , Johannes Schindelin > > wrote: > > > > git show 'HEAD:bra[ckets].txt' -- > > > > Nice catch! It works for me even without quotes. Only by chance. Once you have a

[PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh

bcb11f1 (mingw: mark t9100's test cases with appropriate prereqs, 2016-01-27) replaced "/bin/sh" in exec.sh by the shell specified in SHELL_PATH, but that breaks the subtest which checks for a specific checksum of a tree containing. Revert that change that was not explained in the commit message

Re: [PATCH v1] config: add '--sources' option to print the source of a config value

On 05 Feb 2016, at 12:22, Jeff King wrote: > On Fri, Feb 05, 2016 at 12:13:04PM +0100, Sebastian Schuberth wrote: > >> On 2/5/2016 9:42, larsxschnei...@gmail.com wrote: >> >>> Teach 'git config' the '--sources' option to print the source >>> configuration file for every printed

Test failures with GNU grep 2.23

It seems that binary file detection has changed in GNU grep 2.23 as a result of commit 40ed879 (grep: fix bug with with invalid unibyte sequence). This causes a couple of test failures in t8005 and t9200 (the t9200 case is less obvious so I'm only including t8005 here): -- >8 -- $

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

Matt McCutchen writes: > I noticed that when update_linked_gitdir chooses to update > .git/worktrees//gitdir, the path it writes is relative, at least > under some circumstances.  This contradicts the gitrepository-layout > man page, which says: Duy, is it safe to say

Re: "git send-email" thru Gmail incurs few minutes delay

On Sun, Jan 3, 2016 at 3:52 PM, Andrey Utkin wrote: > After "Send this email? ([y]es|[n]o|[q]uit|[a]ll): y" prompt and > before "Password for 'smtp://x...@gmail.com@smtp.gmail.com:587':" > prompt I always have a delay of 2-3 minutes. It is weird! "Unsafe >

Re: "git send-email" thru Gmail incurs few minutes delay

On Mon, Feb 8, 2016 at 2:42 AM, Jeff Merkey wrote: > Try this page. Some good gmail config info. > > http://kernelnewbies.org/FirstKernelPatch > > Jeff Thanks Jeff, but I believe there's nothing new for me. I have successfully sent my first kernel patch a long time ago.

Re: git submodule should honor "-c credential.helper" command line argument

On Sun, Feb 7, 2016 at 5:48 AM, Marc Strapetz wrote: > On 07.02.2016 05:41, Jacob Keller wrote: >> >> On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller >> wrote: >>> >>> Ok so I am not sure we even really need to use "-c" option in >>> git-clone

[PATCH] Documentation/git-clean.txt: don't mention deletion of .git/modules/*

I found no evidence of such behavior in the source code. Signed-off-by: Matt McCutchen --- This is based on the maint branch, a08595f. Try #2 to get correct email formatting. Documentation/git-clean.txt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

Re: "git send-email" thru Gmail incurs few minutes delay

On 2/7/16, Andrey Utkin wrote: > On Sun, Jan 3, 2016 at 3:52 PM, Andrey Utkin > wrote: >> After "Send this email? ([y]es|[n]o|[q]uit|[a]ll): y" prompt and >> before "Password for 'smtp://x...@gmail.com@smtp.gmail.com:587':" >>

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

On Sun, 2016-02-07 at 15:56 -0800, Junio C Hamano wrote: > Matt McCutchen writes: > > > I noticed that when update_linked_gitdir chooses to update > > .git/worktrees//gitdir, the path it writes is relative, at > > least > > under some circumstances.  This contradicts the

Re: [PATCH 2/8] pack-objects: produce a stable pack when --skip is given

On Sat, Feb 6, 2016 at 7:48 AM, Junio C Hamano wrote: >> You noticed that tying the behavior only happens when the user asks >> for it, right? I don't expect people to do resumable fetch/clone by >> default. There are tradeoffs to make and they decide it, we offer >> options.

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

On Mon, Feb 8, 2016 at 8:04 AM, Matt McCutchen wrote: > On Sun, 2016-02-07 at 15:56 -0800, Junio C Hamano wrote: >> Matt McCutchen writes: >> >> > I noticed that when update_linked_gitdir chooses to update >> > .git/worktrees//gitdir, the path it

Re: git show doesn't work on file names with square brackets

On Sun, Feb 7, 2016 at 10:11 PM, Kirill Likhodedov wrote: > Hi Duy, > >> It's from 28fcc0b (pathspec: avoid the need of "--" when wildcard is >> used - 2015-05-02) > > v2.5.0 is the first release which contains 28fcc0b. > I can confirm that older versions of Git

[PATCH] Avoid interpreting too-long parameter as file name

Even if it is easier to write HEAD~2000, it is legal to write HEAD^^^... (repeats "^" 2000 times in total). However, such a string is too long to be a legal filename (and on Windows, by default even much, much shorter strings are still illegal because they exceed MAX_PATH). Therefore, if the

Email Account Holder

Details of Transaction in Attached File Dear Email Account Holder.pdf Description: Adobe PDF document