Re: What's cooking in git.git (May 2016, #02; Fri, 6)

Hi Junio, On Fri, 6 May 2016, Junio C Hamano wrote: > * jk/submodule-c-credential (2016-05-06) 6 commits > - submodule: stop sanitizing config options > - submodule: use prepare_submodule_repo_env consistently > - submodule--helper: move config-sanitizing to submodule.c > - submodule: export

Re: What's cooking in git.git (May 2016, #03; Mon, 9)

On Tue, May 10, 2016 at 4:30 AM, Junio C Hamano wrote: > * pb/commit-verbose-config (2016-05-05) 8 commits > - SQUASH??? > - commit: add a commit.verbose config variable > - t7507-commit-verbose: improve test coverage by testing number of diffs > - parse-options.c: make

[PATCH 2/6] t1500: reduce dependence upon global state

This script pollutes its global state by changing its working directory and capturing that state via $(pwd) in the GIT_CONFIG environment variable. This makes it difficult to modernize the script since tests ideally should be self-contained and not rely upon such transient global state. With the

[PATCH 5/6] t1500: avoid setting environment variables outside of tests

Ideally, each test should be responsible for setting up state it needs rather than relying upon transient global state. Toward this end, teach test_rev_parse() to accept a "-g " option to allow callers to specify the value of the GIT_DIR environment variable explicitly, and take advantage of this

[PATCH 3/6] t1500: avoid changing working directory outside of tests

Ideally, each test should be responsible for setting up state it needs rather than relying upon transient global state. Toward this end, teach test_rev_parse() to accept a "-C " option to allow callers to instruct it explicitly in which directory its tests should be run, and take advantage of this

[PATCH 6/6] t1500: be considerate to future potential tests

The final batch of git-rev-parse tests work against a non-local object database named ../repo.git rather than the typically-named ../.git. It prepares by renaming .git/ to repo.git/ and pointing GIT_DIR at ../repo.git, but never restores the name to .git/, which can be problematic for tests added

[PATCH 1/6] t1500: test_rev_parse: facilitate future test enhancements

Tests run by test_rev_parse() are nearly identical; each invokes git-rev-parse with a single option and compares the result against an expected value. Such duplication makes it onerous to extend the tests since any change needs to be repeated in each test. Reduce the duplication by parameterizing

[PATCH 0/6] modernize t1500

This series modernizes t1500; it takes an entirely different approach than [1][2] and is intended to replace that series. Whereas [1][2] dropped the systematic function-driven testing of git-rev-parse in favor of dozens of nearly identical copy/paste tests, this series retains the structure of the

[PATCH 4/6] t1500: avoid setting configuration options outside of tests

Ideally, each test should be responsible for setting up state it needs rather than relying upon transient global state. Toward this end, teach test_rev_parse() to accept a "-b " option to allow callers to set "core.bare" explicitly or undefine it, and take advantage of this new option to avoid

Re: [PATCH v2] t6302: simplify non-gpg cases

On Mon, May 9, 2016 at 10:40 PM, Jeff King wrote: > On Mon, May 09, 2016 at 01:47:35PM -0400, Eric Sunshine wrote: >> > - test_prepare_expect <<-\EOF | sed -e "s/Z$//" >expect && >> > + cat <<-\EOF | sed -e "s/Z$//" >expect && >> >> To make this as close to a reversion

Re: t6044 broken on pu

On Mon, May 09, 2016 at 11:36:09AM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > Yes, I think the comment should just go. Nobody used that alphabet > > form since it was written in d17cf5f3 (tests: Introduce test_seq, > > 2012-08-04). > > > >> I don't really

[PATCH v2] t6302: simplify non-gpg cases

[+cc Junio as this should be the final version] On Mon, May 09, 2016 at 01:47:35PM -0400, Eric Sunshine wrote: > > Subject: [PATCH] t6302: simplify non-gpg cases > > > > When commit 618310a taught t6302 to run without the GPG > > 618310a (t6302: skip only signed tags rather than all tests when

Re: [PATCH v9 00/19] index-helper/watchman

On 10/05/16 00:12, David Turner wrote: > On Mon, 2016-05-09 at 15:32 -0700, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> David Turner writes: >>> On Mon, 2016-05-09 at 14:40 -0700, Junio C Hamano wrote: > Hmmm, I seem to be

Re: [PATCH v9 00/19] index-helper/watchman

On Mon, 2016-05-09 at 15:32 -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > David Turner writes: > > > > > On Mon, 2016-05-09 at 14:40 -0700, Junio C Hamano wrote: > > > > Hmmm, I seem to be getting > > > > > > > > $ cat

What's cooking in git.git (May 2016, #03; Mon, 9)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. The 'master' branch now has the

Re: [PATCH v9 00/19] index-helper/watchman

Junio C Hamano writes: > David Turner writes: > >> On Mon, 2016-05-09 at 14:40 -0700, Junio C Hamano wrote: >>> Hmmm, I seem to be getting >>> >>> $ cat t/trash*7900*/err >>> fatal: Already running >>> >>> after running t7900 and it fails

Re: [PATCH v9 00/19] index-helper/watchman

David Turner writes: > On Mon, 2016-05-09 at 14:40 -0700, Junio C Hamano wrote: >> Hmmm, I seem to be getting >> >> $ cat t/trash*7900*/err >> fatal: Already running >> >> after running t7900 and it fails at #5, after applying >> "index-helper: optionally

Re: [PATCH v9 00/19] index-helper/watchman

On Mon, 2016-05-09 at 14:40 -0700, Junio C Hamano wrote: > Hmmm, I seem to be getting > > $ cat t/trash*7900*/err > fatal: Already running > > after running t7900 and it fails at #5, after applying > "index-helper: optionally automatically run" It still passes for me (with or without

Re: [PATCH v2 00/33] Yet more preparation for reference backends

Michael Haggerty writes: >> The "demonstrate an existing breakage first" order makes it slightly >> easier to review and follow a long series, as it forces the reviewer >> to see the issue first and think about possible avenues to solve it >> for themselves, before seeing a

Re: [PATCH v2 00/33] Yet more preparation for reference backends

On 05/09/2016 11:05 PM, Junio C Hamano wrote: > David Turner writes: >> [...] >> I generally like to put the bug fixes before the tests for those fixes >> (so that bisect on the complete suite works). But maybe the git policy >> is different. > > The Git policy only

Re: [PATCH v9 00/19] index-helper/watchman

Hmmm, I seem to be getting $ cat t/trash*7900*/err fatal: Already running after running t7900 and it fails at #5, after applying "index-helper: optionally automatically run". -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

Re: [PATCH] t6302: simplify non-gpg cases

On Mon, May 9, 2016 at 4:24 PM, Karthik Nayak wrote: > On Mon, May 9, 2016 at 11:17 PM, Eric Sunshine > wrote: >> Should we cite bc9acea (ref-filter: implement %(if), %(then), and >> %(else) atoms, 2016-04-25) here as an example of a commit for

Re: t4151 missing quotes

On Mon, May 9, 2016 at 4:45 PM, Junio C Hamano wrote: > Eric Sunshine writes: >> On Mon, May 9, 2016 at 2:56 PM, Junio C Hamano wrote: >>> Something like this follows Documentation/SubmittingPatches [...] >>> >>> -- >8 -- >>> From:

Re: t6044 broken on pu

On Mon, May 9, 2016 at 5:08 PM, Junio C Hamano wrote: > Subject: [PATCH] test-lib-functions.sh: rewrite test_seq without Perl > > Rewrite the 'seq' imitation only with commands and features > that are typically found as built-in in modern POSIX shells, > instead of relying on

Re: t6044 broken on pu

Junio C Hamano writes: > Stop promising that we may allow using "letters"; this would open an > easier reimplementation that does not rely on $PERL, if somebody > later wants to. > > Signed-off-by: Junio C Hamano And I am not the one who particularly wants

Re: [PATCH v2 00/33] Yet more preparation for reference backends

David Turner writes: > On Fri, 2016-05-06 at 18:13 +0200, Michael Haggerty wrote: >> Thanks to David, Junio, and Peff for their comments on v1 of this >> patch series [1]. I think I have addressed all of the points that >> were >> brought up. Plus I fixed a pre-existing

[PATCH v9 05/19] index-helper: log warnings

Instead of writing warnings to stderr, write them to a log. Later, we'll probably be daemonized, so writing to stderr will be pointless. Signed-off-by: David Turner --- Documentation/git-index-helper.txt | 3 +++ index-helper.c | 32

[PATCH v9 19/19] untracked-cache: config option

Add a config option to populate the untracked cache. For installations that have centrally-managed configuration, it's easier to set a config once than to run update-index on every repository. Signed-off-by: David Turner --- Documentation/config.txt | 4

[PATCH v9 17/19] index-helper: optionally automatically run

Introduce a new config option, indexhelper.autorun, to automatically run git index-helper before starting up a builtin git command. This enables users to keep index-helper running without manual intervention. Signed-off-by: David Turner --- Documentation/config.txt |

[PATCH v9 18/19] trace: measure where the time is spent in the index-heavy operations

From: Nguyễn Thái Ngọc Duy All the known heavy code blocks are measured (except object database access). This should help identify if an optimization is effective or not. An unoptimized git-status would give something like below (92% of time is accounted). To sum up the effort

[PATCH v9 04/19] index-helper: add --strict

From: Nguyễn Thái Ngọc Duy There are "holes" in the index-helper approach because the shared memory is not verified again by git. If $USER is compromised, shared memory could be modified. But anyone who could do this could already modify $GIT_DIR/index. A more realistic risk

[PATCH v9 11/19] update-index: enable/disable watchman support

From: Nguyễn Thái Ngọc Duy Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: David Turner --- Documentation/git-index-helper.txt | 3 +++ Documentation/git-update-index.txt | 6 ++ builtin/update-index.c | 16

[PATCH v9 13/19] watchman: add a config option to enable the extension

For installations that have centrally-managed configuration, it's easier to set a config once than to run update-index on every repository. Signed-off-by: David Turner --- .gitignore| 1 + Documentation/config.txt | 4 Makefile

[PATCH v9 10/19] index-helper: use watchman to avoid refreshing index with lstat()

From: Nguyễn Thái Ngọc Duy Watchman is hidden behind index-helper. Before git tries to read the index from shm, it notifies index-helper through the socket and waits for index-helper to prepare a file for sharing memory (with MAP_SHARED). index-helper then contacts watchman,

[PATCH v9 16/19] index-helper: autorun mode

Soon, we'll want to automatically start index-helper, so we need a mode that silently exits if it can't start up (either because it's not in a git dir, or because another one is already running). Signed-off-by: David Turner --- Documentation/git-index-helper.txt | 4

[PATCH v9 03/19] index-helper: new daemon for caching index and related stuff

From: Nguyễn Thái Ngọc Duy Instead of reading the index from disk and worrying about disk corruption, the index is cached in memory (memory bit-flips happen too, but hopefully less often). The result is faster read. Read time is reduced by 70%. The biggest gain is not having

[PATCH v9 15/19] index-helper: don't run if already running

Signed-off-by: David Turner --- index-helper.c | 7 +++ t/t7900-index-helper.sh | 9 + 2 files changed, 16 insertions(+) diff --git a/index-helper.c b/index-helper.c index 4ed1610..b275f6e 100644 --- a/index-helper.c +++ b/index-helper.c @@ -458,6

[PATCH v9 09/19] watchman: support watchman to reduce index refresh cost

From: Nguyễn Thái Ngọc Duy The previous patch has the logic to clear bits in 'WAMA' bitmap. This patch has logic to set bits as told by watchman. The missing bit, _using_ these bits, are not here yet. A lot of this code is written by David Turner originally, mostly from [1].

[PATCH v9 14/19] index-helper: kill mode

Add a new command (and command-line arg) to allow index-helpers to exit cleanly. This is mainly useful for tests. Signed-off-by: David Turner --- Documentation/git-index-helper.txt | 3 +++ index-helper.c | 31 ++-

[PATCH v9 01/19] read-cache.c: fix constness of verify_hdr()

From: Nguyễn Thái Ngọc Duy Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: David Turner --- read-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/read-cache.c b/read-cache.c index d9fb78b..16cc487

[PATCH v9 02/19] read-cache: allow to keep mmap'd memory after reading

From: Nguyễn Thái Ngọc Duy Later, we will introduce git index-helper to share this memory with other git processes. We only unmap it when we discard the index (although the kernel may of course choose to page it out). Signed-off-by: Nguyễn Thái Ngọc Duy

[PATCH v9 08/19] read-cache: add watchman 'WAMA' extension

From: Nguyễn Thái Ngọc Duy The extension contains a bitmap, one bit for each entry in the index. If the n-th bit is zero, the n-th entry is considered unchanged, we can ce_mark_uptodate() it without refreshing. If the bit is non-zero and we found out the corresponding file is

[PATCH v9 12/19] unpack-trees: preserve index extensions

Make git checkout (and other unpack_tree operations) preserve the untracked cache and watchman status. This is valuable for two reasons: 1. Often, an unpack_tree operation will not touch large parts of the working tree, and thus most of the untracked cache will continue to be valid. 2. Even if

[PATCH v9 07/19] index-helper: add --detach

From: Nguyễn Thái Ngọc Duy We detach after creating and opening the socket, because otherwise we might return control to the shell before index-helper is ready to accept commands. This might lead to flaky tests. Signed-off-by: Nguyễn Thái Ngọc Duy

[PATCH v9 06/19] daemonize(): set a flag before exiting the main process

From: Nguyễn Thái Ngọc Duy This allows signal handlers and atexit functions to realize this situation and not clean up. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: David Turner --- builtin/gc.c | 2 +- cache.h | 2 +-

[PATCH v9 00/19] index-helper/watchman

Formatting and patch naming fixes from Junio. No substantive changes. David Turner (8): index-helper: log warnings unpack-trees: preserve index extensions watchman: add a config option to enable the extension index-helper: kill mode index-helper: don't run if already running

Re: t4151 missing quotes

Eric Sunshine writes: > On Mon, May 9, 2016 at 2:56 PM, Junio C Hamano wrote: >> Something like this follows Documentation/SubmittingPatches [...] >> >> -- >8 -- >> From: Armin Kunaschik >> Subject: t4151: make sure argument

Re: [PATCH v9 2/6] convert.c: stream and early out

tbo...@web.de writes: > + if (stats->stat_bits & earlyout) > + break; /* We found what we have been searching for */ Are we sure if our callers are only interested in just one bit at a time? Otherwise, if we want to ensure all of the given bits are set,

Re: [PATCH v2 00/33] Yet more preparation for reference backends

On Fri, 2016-05-06 at 18:13 +0200, Michael Haggerty wrote: > Thanks to David, Junio, and Peff for their comments on v1 of this > patch series [1]. I think I have addressed all of the points that > were > brought up. Plus I fixed a pre-existing bug that I noticed myself > while adding some more

Re: t6044 broken on pu

On Mon, May 9, 2016 at 2:36 PM, Junio C Hamano wrote: > Subject: test-lib-functions.sh: remove misleading comment on test_seq > > We never used the "letters" form since we came up with "test_seq" to > replace use of non-portable "seq" in our test script, which we > introduced

Re: [PATCH v9 1/6] read-cache: factor out get_sha1_from_index() helper

tbo...@web.de writes: > +#define get_sha1_from_cache(path) get_sha1_from_index (_index, (path)) > #endif Micronit: lose the extra SP; i.e. "get_sha1_from_index(_index, (path))". > diff --git a/read-cache.c b/read-cache.c > index d9fb78b..a3ef967 100644 > --- a/read-cache.c > +++

RE: /* compiler workaround */ - what was the issue?

On May 9, 2016 3:40 PM Philip Oakley wrote: > From: "Stefan Beller" > > On Fri, May 6, 2016 at 12:57 PM, Junio C Hamano > wrote: > >> Marc Branchaud writes: > >> > >>> On 2016-05-06 02:54 PM, Junio C Hamano wrote: > > I

Re: /* compiler workaround */ - what was the issue?

From: "Stefan Beller" On Fri, May 6, 2016 at 12:57 PM, Junio C Hamano wrote: Marc Branchaud writes: On 2016-05-06 02:54 PM, Junio C Hamano wrote: I wonder if can we come up with a short and sweet notation to remind futhre

Re: t4151 missing quotes

On Mon, May 9, 2016 at 11:56 AM, Junio C Hamano wrote: > Something like this follows Documentation/SubmittingPatches, except > that it further needs your Sign-off before mine, which I can forge > if you say it is OK. The sign-off is a simple line at the end of the explanation

Re: [PATCH] t6041: do not compress backup tar file

+ cc Jens as he authored both t6041 as well as t3513 in the series leading to ad25da009e2a3730 (2014-07-21, Merge branch 'jl/submodule-tests') On Mon, May 9, 2016 at 11:46 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> diff --git

Re: t4151 missing quotes

Something like this follows Documentation/SubmittingPatches, except that it further needs your Sign-off before mine, which I can forge if you say it is OK. Thanks for a report and an analysis of the issue. -- >8 -- From: Armin Kunaschik Subject: t4151: make sure

Re: [PATCH] t6041: do not compress backup tar file

Stefan Beller writes: > diff --git a/t/t6041-bisect-submodule.sh b/t/t6041-bisect-submodule.sh > index c6b7aa6..62b8a2e 100755 > --- a/t/t6041-bisect-submodule.sh > +++ b/t/t6041-bisect-submodule.sh > @@ -8,7 +8,7 @@ test_description='bisect can handle submodules' >

Re: [PATCH v1 1/1] t5601: Remove trailing space in sed expression

tbo...@web.de writes: > From: Torsten Bögershausen > > The sed expression for IPv6, "Tested User And Host" or "tuah" used a wrong > sed expression, which doesn't work under all versions of sed. > > Reported-By: Armin Kunaschik > Signed-off-by: Torsten

Re: t6044 broken on pu

Junio C Hamano writes: > Yes, I think the comment should just go. Nobody used that alphabet > form since it was written in d17cf5f3 (tests: Introduce test_seq, > 2012-08-04). > >> I don't really care either way whether it is replaced or not (at one >> point there were some

Re: t6044 broken on pu

Jeff King writes: > On Mon, May 09, 2016 at 12:02:45PM -0400, Eric Sunshine wrote: > >> > I had that thought, too, but I think it would be an error to do so. >> > test_seq is supposed to be a replacement for "seq", which does not >> > understand non-numeric sequences. >> >>

Re: t6044 broken on pu

Torsten Bögershausen writes: > On 08.05.16 20:20, Junio C Hamano wrote: >> Torsten Bögershausen writes: >> >>> May a simple >>> printf "1\n2\n3\n4\n5\n6\n7\n8\n9\n10\n" >>> >>> be an option ? >> If you were to do that, at least have the decency to make it more >>

Re: t4151 missing quotes

I'm currently concentrating on finding problems with my setup... this is already a tough job :-) I'm a git beginner, and Documentation/SubmittingPatches would keep me busy for a week. So anybody feel free to submit this thingy. Armin -- To unsubscribe from this list: send the line "unsubscribe

Re: t4151 missing quotes

[please don't top-post on this list] On Mon, May 9, 2016 at 12:35 PM, Armin Kunaschik wrote: > Sorry, this was my first patch to the list. I'll do better :-) > You are right about the "wc -l" parts. Maybe I was a bit over > pessimistic. Throw away my last mail. Done

Re: deadlock git upload-pack command when GIT_TRACE is enabled

On Mon, May 9, 2016 at 10:53 AM, Stefan Beller wrote: > On Mon, May 9, 2016 at 10:49 AM, Eugene Petrenko > wrote: >> Hello, >> >> I stuck around the deadlock inside git when running git upload-pack . >> command. A debugging shown that the bottom

Re: deadlock git upload-pack command when GIT_TRACE is enabled

On Mon, May 9, 2016 at 10:49 AM, Eugene Petrenko wrote: > Hello, > > I stuck around the deadlock inside git when running git upload-pack . > command. A debugging shown that the bottom process (it starts several > processes to implement the task) hangs writing to stderr.

deadlock git upload-pack command when GIT_TRACE is enabled

Hello, I stuck around the deadlock inside git when running git upload-pack . command. A debugging shown that the bottom process (it starts several processes to implement the task) hangs writing to stderr. I managed to reproduce the issue with a tiny bash script. The repository and the script is

[PATCH v1 1/1] t5601: Remove trailing space in sed expression

From: Torsten Bögershausen The sed expression for IPv6, "Tested User And Host" or "tuah" used a wrong sed expression, which doesn't work under all versions of sed. Reported-By: Armin Kunaschik Signed-off-by: Torsten Bögershausen ---

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

Jeff King writes: > On Mon, May 09, 2016 at 09:42:32AM -0700, Junio C Hamano wrote: > >> > Hopefully your patch to remove the -c ... sanitizing makes it to `master` >> > soon, then I can submit my next iteration. >> >> Or we can just merge that "do not sanitize" branch in, and

Re: [PATCH] t6302: simplify non-gpg cases

On Mon, May 9, 2016 at 12:49 PM, Jeff King wrote: > On Mon, May 09, 2016 at 12:30:43PM -0400, Eric Sunshine wrote: > Since you as the author of 618310a seem to agree with this direction, > here it is as a real patch. Thanks for working on this. > Subject: [PATCH] t6302: simplify

Re: [PATCH 80/83] run-command: make dup_devnull() non static

Duy Nguyen writes: > I vote one step at a time, leave multi-thread support for future. > There's a lot more shared state than file descriptors anyway, at least > there are object db and index access and probably a couple of hidden > static variables somewhere. And I'm not sure

Re: Found possible branch point, then "Use of uninitialized value $u in substitution/concatenation"

On 7 May 2016 at 08:07, Christian Couder wrote: > > On Fri, May 6, 2016 at 5:31 PM, Thierry Suzanne > wrote: > > Sorry, can't help :( > > I just sent a patch. It would be nice if you could test it to confirm > that you get a nicer error

Re: Re: [RFD/PATCH] submodule doc: describe where we can configure them

>> Here is what I imagine >> When B mirrors from A, B sets up this special ref for its repository, >> e.g. refs/meta/submodule-B and have a symbolic ref pointing at that. >> (e.g. SUBMODULE_CONFIG pointing at refs/meta/submodule-B, >> which has a worktree which contains a .gitmodules files which

Re: [PATCH v2 1/2] mingw: introduce the 'core.hideDotFiles' setting

Johannes Schindelin writes: > +core.hideDotFiles:: > + (Windows-only) If true, mark newly-created directories and files whose > + name starts with a dot as hidden. If 'dotGitOnly', only the `.git/` > + directory is hidden, but no other files starting with

Re: [PATCH] t6041: do not compress backup tar file

Hi Stefan, I'm currently in the process of skipping through the failed tests on my AIX box. There are more tests which require GNU tools like mktemp (t7610-mergetool.sh) or readlink (t7800-difftool.sh). But I don't have a solution or workaround for these two. But at least there are not more

t5601-clone.sh failures

Hi list, eight t5601 tests don't run with my version of sed. The reason is a trailing space in the sed expression. See below: #IPv6 for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]: [user@::1] [user@::1]: do ehost=$(echo $tuah | sed -e "s/1]:/1]/ "| tr -d "[]")

[PATCH] t6041: do not compress backup tar file

The test uses the 'z' option, i.e. "compress the output while at it", which is GNUism and not portable. Reported-by: Armin Kunaschik Signed-off-by: Stefan Beller --- Thanks Armin for reporting these GNUism! Are there any more? (So we can do these

Re: [PATCH v2 0/2] Support marking .git/ (or all files) as hidden on Windows

Johannes Schindelin writes: > This is a heavily version of patches we carried in Git for Windows for > way too long without submitting them upstream. > > In this iteration, I also claim authorship for the patch because by now > Kusma's changes were so contorted and

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

On Mon, May 09, 2016 at 09:42:32AM -0700, Junio C Hamano wrote: > > Hopefully your patch to remove the -c ... sanitizing makes it to `master` > > soon, then I can submit my next iteration. > > Or we can just merge that "do not sanitize" branch in, and then > queue the "next iteration" which I'd

t6041-bisect-submodule.sh tar -z not portable

Hi, similar to t3513, in t6041 tar is used with the -z flag which is not portable and should be removed the same way as in t3513. Regards, Armin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] t6302: simplify non-gpg cases

On Mon, May 09, 2016 at 12:30:43PM -0400, Eric Sunshine wrote: > The latter seems very preferable, though perhaps it could be made more > concise like this? > > sign= > test_have_prereq GPG && sign=-s > > (But that's a minor issue.) I agree that is nicer, but I wanted to keep the

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

Johannes Schindelin writes: > Okay, I already force-pushed my extra-http-header branch and the next > iteration will sport this paragraph. The new explanation is well written and can and should also replace the comment before the implementation in the configuration

Re: t4151 missing quotes

Sorry, this was my first patch to the list. I'll do better :-) You are right about the "wc -l" parts. Maybe I was a bit over pessimistic. Throw away my last mail. In my case test 9 ran unsuccessful because of an empty "git ls-files -u" This reduces the diff to this one (hopefully the right way

Re: t6392 broken on pu (Mac OS X)

On Mon, May 9, 2016 at 12:07 PM, Jeff King wrote: > On Sat, May 07, 2016 at 06:15:19PM +0200, Torsten Bögershausen wrote: >> These tests fail here under Mac OS, >> they pass under Linux: >> commit ff3d9b660a4b6e9d3eeb664ce1febe717adff737 >> I haven't had a chance to dig further. >

Re: t4151 missing quotes

On Mon, May 9, 2016 at 12:22 PM, Eric Sunshine wrote: > On Mon, May 9, 2016 at 12:09 PM, Armin Kunaschik > wrote: >> *** t4151-am-abort.sh Mon May 9 17:51:44 2016 >> --- t4151-am-abort.sh.orig Fri Apr 29 23:37:00 2016 >> ! test 3

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

Johannes Schindelin writes: > +# Apache 2.2 does not understand , so we use RewriteCond. > +# And as RewriteCond unfortunately lacks "not equal" matching, we use this > +# ugly trick to fail *unless* the two headers are present. > +RewriteCond %{HTTP:x-magic-one}

Re: t4151 missing quotes

On Mon, May 9, 2016 at 12:09 PM, Armin Kunaschik wrote: > skipping through some failed tests I found more (smaller) problems > inside the test... when test arguments are empty they need to be > quoted (quite a lot test in this sentence). > > Error is like >

Re: [RFD/PATCH] submodule doc: describe where we can configure them

Heiko Voigt writes: >> > - When upstream adds a new submodule, I have to do the same manual >> > work to change the options for that new submodule. >> >> Because a new module is not automatically "init"ed by default? >> >> Isn't "config only" vs "config with gitmodules

Re: t6044 broken on pu

On Mon, May 09, 2016 at 12:02:45PM -0400, Eric Sunshine wrote: > > I had that thought, too, but I think it would be an error to do so. > > test_seq is supposed to be a replacement for "seq", which does not > > understand non-numeric sequences. > > Although, the comment block just above

t4151 missing quotes

Hi there, skipping through some failed tests I found more (smaller) problems inside the test... when test arguments are empty they need to be quoted (quite a lot test in this sentence). Error is like t4151-am-abort.sh[5]: test: argument expected My patch: *** t4151-am-abort.sh Mon May 9

Re: t6392 broken on pu (Mac OS X)

On Sat, May 07, 2016 at 06:15:19PM +0200, Torsten Bögershausen wrote: > These tests fail here under Mac OS, > they pass under Linux: > commit ff3d9b660a4b6e9d3eeb664ce1febe717adff737 > I haven't had a chance to dig further. I assume you mean t6302. It looks like the difference is not Mac OS, but

Re: [PATCH] Move test-* to t/helper/ subdirectory

Duy Nguyen writes: > So among the options we have so far, which way should we go, or leave it as > is? Thanks for reminding me. I like that version you sent with "I may have rushed to judgment" comment the most. Perhaps I can just queue it with s/PATH/PROG/ fixup? > > On

Re: t6044 broken on pu

On Mon, May 9, 2016 at 4:33 AM, Jeff King wrote: > On Mon, May 09, 2016 at 08:30:51AM +0200, demerphq wrote: >> > - perl -le 'print for $ARGV[0]..$ARGV[1]' -- "$@" >> > + test_seq_counter__=$1 >> > + while test "$test_seq_counter__" -le $2 >> > + do >> > +

Re: [PATCH v16 0/7] config commit verbose

Jeff King writes: > I guess I do not really consider the template content to be the primary > thing the command is doing. It is subjective, though. I don't feel > strongly enough to keep discussing it if other people don't agree. I just see the primary thing of what "commit -e"

Re: [PATCH v5 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

Hey Johannes, On Mon, May 9, 2016 at 8:29 PM, Johannes Schindelin wrote: > Hi Pranit, > > On Sun, 8 May 2016, Pranit Bauva wrote: > >> On Sun, May 8, 2016 at 12:34 PM, Johannes Schindelin >> wrote: >> > >> > On Fri, 6 May 2016, Pranit

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

Hi Peff, On Mon, 9 May 2016, Jeff King wrote: > On Mon, May 09, 2016 at 04:03:48PM +0200, Johannes Schindelin wrote: > > > How about this: > > > > As RewriteCond does not allow testing for *non*-matches, we simply > > match the desired case first and let it pass by marking the > >

Re: [PATCH 80/83] run-command: make dup_devnull() non static

Hi Duy, On Sun, 8 May 2016, Duy Nguyen wrote: > On Sun, May 8, 2016 at 1:33 PM, Johannes Schindelin > wrote: > > The claim is that this libifies the procedure. But it makes the code > > really nasty for use as a library: if this is run in a thread (and you > > know

Re: [PATCH v5 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

Hi Pranit, On Sun, 8 May 2016, Pranit Bauva wrote: > On Sun, May 8, 2016 at 12:34 PM, Johannes Schindelin > wrote: > > > > On Fri, 6 May 2016, Pranit Bauva wrote: > > > >> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > >> index 3324229..d8de651

Re: [PATCH v16 0/7] config commit verbose

On Sun, May 08, 2016 at 11:48:31AM -0700, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > I.e. I really expect --verbose to be a more verbose version of the > > primary thing a command is doing, which in the case of "commit > > --amend" is giving me info I need

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

On Mon, May 09, 2016 at 04:03:48PM +0200, Johannes Schindelin wrote: > How about this: > > As RewriteCond does not allow testing for *non*-matches, we simply > match the desired case first and let it pass by marking the > RewriteRule as '[L]' ("last rule, do not process any

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

Hi Peff, On Mon, 9 May 2016, Jeff King wrote: > On Mon, May 09, 2016 at 08:18:52AM +0200, Johannes Schindelin wrote: > > > +# Apache 2.2 does not understand , so we use RewriteCond. > > +# And as RewriteCond unfortunately lacks "not equal" matching, we use this > > +# ugly trick to fail

  1   2   >