Re: [PATCH v3] send-email: extract email-parsing code into a subroutine

PAYRE NATHAN p1508475 writes: > Without the "print" used for testing. But still smoe broken indentation: > git-send-email.perl | 90 > + > 1 file changed, 63 insertions(+), 27 deletions(-) > > diff --git

Re: [PATCH v2] send-email: extract email-parsing code into a subroutine

On Wed, Dec 6, 2017 at 5:55 PM, Nathan PAYRE wrote: > Junio C Hamano : writes: >> Also "reusable in other place" is by itself not an unconditional >> plus, until readers can be convinced that that 'other place' really >> wants to be able to call this

Re: [PATCH 3/3] diff: use skip_to_opt_val()

On Thu, Dec 7, 2017 at 1:18 AM, Jacob Keller wrote: > On Wed, Dec 6, 2017 at 4:16 PM, Jacob Keller wrote: >> >> This causes a regression in the --relative option which prevents it >> from working properly. >> >> If I have a repository with a

Re: partial_clone_get_default_filter_spec has no callers

On 06/12/17 21:07, Jeff Hostetler wrote: > > > On 12/6/2017 12:39 PM, Ramsay Jones wrote: >> Hi Jeff, >> >> commit f1862e8153 ("partial-clone: define partial clone settings >> in config", 2017-12-05), which is part of your 'jh/partial-clone' >> branch, introduces the

Re: [PATCH] diff: add test showing regression to --relative

On Wed, Dec 6, 2017 at 5:04 PM, Jeff King wrote: > On Wed, Dec 06, 2017 at 04:35:17PM -0800, Jacob Keller wrote: > >> Subject: [PATCH] diff: add test showing regression to --relative > > Since we'd hopefully not ever merge that regression, I think this patch > ought to stand on its

Re: git commit file completion recently broke

On Wed, Dec 06, 2017 at 05:04:02PM -0800, Jacob Keller wrote: > What you outlined above is probably the best we can do. We could even > add some extra helper which does that for us if we want. > > I sent a patch that merely reverts the change to --relative and adds a > test for now though.

Re: git commit file completion recently broke

On Wed, Dec 6, 2017 at 4:56 PM, Jeff King wrote: > On Wed, Dec 06, 2017 at 04:38:29PM -0800, Jacob Keller wrote: > >> >> But nope, it looks like the culprit is f7923a5ece (diff: use >> >> skip_to_optional_val(), 2017-12-04), which switched over parsing of >> >> "--relative". >> >

Re: [PATCH] diff: add test showing regression to --relative

On Wed, Dec 06, 2017 at 04:35:17PM -0800, Jacob Keller wrote: > Subject: [PATCH] diff: add test showing regression to --relative Since we'd hopefully not ever merge that regression, I think this patch ought to stand on its own. In which case it probably wants to say something like: diff: test

[PATCH v2] diff: fix --relative without arguments

From: Jacob Keller Recently, commit f7923a5ece00 ("diff: use skip_to_optional_val()", 2017-12-04) changed how we parsed some diff options, preferring skip_to_optional_val instead of a more complex skip_prefix() setup. Unfortunately, this breaks --relative, because of the

Re: git commit file completion recently broke

On Wed, Dec 06, 2017 at 04:38:29PM -0800, Jacob Keller wrote: > >> But nope, it looks like the culprit is f7923a5ece (diff: use > >> skip_to_optional_val(), 2017-12-04), which switched over parsing of > >> "--relative". > > > > Oh, actually, I guess I was half-right. It feeds >prefix as the > >

Re: git commit file completion recently broke

On Wed, Dec 6, 2017 at 4:24 PM, Jeff King wrote: > On Wed, Dec 06, 2017 at 07:22:35PM -0500, Jeff King wrote: > >> On Wed, Dec 06, 2017 at 04:01:51PM -0800, Jacob Keller wrote: >> >> > I think I narrowed this down to "git diff-index --name-only --relative >> > HEAD" producing a

[PATCH] diff: add test showing regression to --relative

From: Jacob Keller Signed-off-by: Jacob Keller --- t/t4045-diff-relative.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/t/t4045-diff-relative.sh b/t/t4045-diff-relative.sh index 3950f5034d31..41e4f59b2ffb 100755 ---

Re: git commit file completion recently broke

On Wed, Dec 06, 2017 at 07:22:35PM -0500, Jeff King wrote: > On Wed, Dec 06, 2017 at 04:01:51PM -0800, Jacob Keller wrote: > > > I think I narrowed this down to "git diff-index --name-only --relative > > HEAD" producing a list of files *not* relative to the current > > directory. > > Hmm, my

Re: git commit file completion recently broke

On Wed, Dec 06, 2017 at 04:01:51PM -0800, Jacob Keller wrote: > I think I narrowed this down to "git diff-index --name-only --relative > HEAD" producing a list of files *not* relative to the current > directory. Hmm, my guess would have been something funny in the setup code forgetting our

Re: [PATCH 3/3] diff: use skip_to_opt_val()

On Wed, Dec 6, 2017 at 4:16 PM, Jacob Keller wrote: > On Sun, Dec 3, 2017 at 9:04 AM, Christian Couder > wrote: >> From: Christian Couder >> >> Let's simplify diff option parsing using skip_to_opt_val(). >> >>

Re: [PATCH 3/3] diff: use skip_to_opt_val()

On Sun, Dec 3, 2017 at 9:04 AM, Christian Couder wrote: > From: Christian Couder > > Let's simplify diff option parsing using skip_to_opt_val(). > > Signed-off-by: Christian Couder > --- > diff.c | 22

Re: git commit file completion recently broke

On Wed, Dec 6, 2017 at 4:01 PM, Jacob Keller wrote: > On Wed, Dec 6, 2017 at 3:53 PM, Jacob Keller wrote: >> Hi, >> >> I'm still investigating, but thought I'd send an email. I recently >> updated to jch branch, and found that completion for git

Re: [PATCH v3] git-gui: Prevent double UTF-8 conversion

Hi Łukasz, On Tue, 5 Dec 2017, Łukasz Stelmach wrote: > Convert author's name and e-mail address from the UTF-8 (or any other) > encoding in load_last_commit function the same way commit message is > converted. > > Amending commits in git-gui without such conversion breaks UTF-8 > strings. For

Re: git commit file completion recently broke

On Wed, Dec 6, 2017 at 3:53 PM, Jacob Keller wrote: > Hi, > > I'm still investigating, but thought I'd send an email. I recently > updated to jch branch, and found that completion for git commit does > not work as expected. > > If I have a git repository with a modified

git commit file completion recently broke

Hi, I'm still investigating, but thought I'd send an email. I recently updated to jch branch, and found that completion for git commit does not work as expected. If I have a git repository with a modified file in a subdirectiory, then git commit produces the name of the subdirectory instead of

Re: [PATCH v3] send-email: extract email-parsing code into a subroutine

On Thu, Dec 7, 2017 at 12:02 AM, Nathan Payre wrote: > +sub parse_header_line { > + my $lines = shift; > + my $parsed_line = shift; > + > + foreach (split(/\n/, $lines)) { > + if (/^(To|Cc|Bcc):\s*(.+)$/i) { > +

Re: [PATCH v2] send-email: extract email-parsing code into a subroutine

Nathan PAYRE writes: > Junio C Hamano : writes: > >> ... throughout this patch, not limited to this section, indentation >> is strange and there seem to be many "print" that show messages that >> do not seem to be meant for end-user consumption. I can

[PATCH v3] send-email: extract email-parsing code into a subroutine

The existing code mixes parsing of email header with regular expression and actual code. Extract the parsing code into a new subroutine 'parse_header_line()'. This improves the code readability and make parse_header_line reusable in other place. Signed-off-by: Nathan Payre

Re: [PATCH v2] send-email: extract email-parsing code into a subroutine

Junio C Hamano : writes: > ... throughout this patch, not limited to this section, indentation > is strange and there seem to be many "print" that show messages that > do not seem to be meant for end-user consumption. I can see that > this aspires to improve the readability,

Re: [WIP 07/15] connect: convert get_remote_heads to use struct packet_reader

Brandon Williams writes: > @@ -56,6 +62,41 @@ static void die_initial_contact(int unexpected) > "and the repository exists.")); > } > > +static enum protocol_version discover_version(struct packet_reader *reader) > +{ > + enum protocol_version

Re: [WIP 06/15] transport: use get_refs_via_connect to get refs

Brandon Williams writes: > Remove code duplication and use the existing 'get_refs_via_connect()' > function to retrieve a remote's heads in 'fetch_refs_via_pack()' and > 'git_transport_push()'. > > Signed-off-by: Brandon Williams > --- > transport.c | 18

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

On Wed, Dec 6, 2017 at 5:00 PM, Brandon Williams wrote: > On 12/05, Eric Sunshine wrote: >> 557a5998d (submodule: remove gitmodules_config, 2017-08-03) touched a >> fair number of built-in commands. It's not clear from the current >> patch's commit message if diff-tree is the

Re: [PATCH v7 4/7] checkout: describe_detached_head: remove ellipsis after committish

Junio C Hamano writes: > I've however queued the following on top of the entire series. I do > not mind squashing it into this step, though. > Subject: [PATCH] t2020: test variations that matter That sounds and looks fine to me. I'm going to do this on my side (getting it

[PATCH v2] diff-tree: read the index so attribute checks work in bare repositories

A regression was introduced in 557a5998d (submodule: remove gitmodules_config, 2017-08-03) to how attribute processing was handled in bare repositories when running the diff-tree command. By default the attribute system will first try to read ".gitattribute" files from the working tree and then

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

On 12/05, Eric Sunshine wrote: > On Tue, Dec 5, 2017 at 5:13 PM, Brandon Williams wrote: > > A regression was introduced in 557a5998d (submodule: remove > > gitmodules_config, 2017-08-03) to how attribute processing was handled > > in bare repositories when running the

Re: [WIP 04/15] upload-pack: convert to a builtin

Brandon Williams writes: > In order to allow for code sharing with the server-side of fetch in > protocol-v2 convert upload-pack to be a builtin. > > Signed-off-by: Brandon Williams > --- This looks obvious and straight-forward to a cursory look. I

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

On 12/05, Stefan Beller wrote: > On Tue, Dec 5, 2017 at 2:13 PM, Brandon Williams wrote: > > A regression was introduced in 557a5998d (submodule: remove > > gitmodules_config, 2017-08-03) to how attribute processing was handled > > in bare repositories when running the

Re: 'git worktree add' does not fire post-checkout hook

On Wed, Dec 6, 2017 at 4:00 PM, Gumbel, Matthew K wrote: > I've noticed that when I run 'git worktree add /path/to/new/tree', > the post-checkout hook does not fire, even though the worktree > manpage explicitly states that "worktree add" will, "Create > and checkout

Re: [RFC] 'unsigned long' to 'size_t' conversion

On Wed, Dec 06, 2017 at 10:08:23AM -0500, Derrick Stolee wrote: > There are several places in Git where we refer to the size of an object by > an 'unsigned long' instead of a 'size_t'. In 64-bit Linux, 'unsigned long' > is 8 bytes, but in 64-bit Windows it is 4 bytes. > > The main issue with

Re: [PATCH v2] send-email: extract email-parsing code into a subroutine

Nathan Payre writes: > The existing code mixes parsing of email header with regular > expression and actual code. Extract the parsing code into a new > subroutine 'parse_header_line()'. This improves the code readability > and make parse_header_line reusable in

Re: [PATCH v2] pathspec: only match across submodule boundaries when requested

Hi Brandon, On Mon, 4 Dec 2017, Brandon Williams wrote: > Commit 74ed43711fd (grep: enable recurse-submodules to work on > objects, 2016-12-16) taught 'tree_entry_interesting()' to be able to > match across submodule boundaries in the presence of wildcards. This is > done by performing literal

Re: partial_clone_get_default_filter_spec has no callers

On 12/6/2017 12:39 PM, Ramsay Jones wrote: Hi Jeff, commit f1862e8153 ("partial-clone: define partial clone settings in config", 2017-12-05), which is part of your 'jh/partial-clone' branch, introduces the partial_clone_get_default_filter_spec() function without any callers. Could you please

'git worktree add' does not fire post-checkout hook

Hello all, I've noticed that when I run 'git worktree add /path/to/new/tree', the post-checkout hook does not fire, even though the worktree manpage explicitly states that "worktree add" will, "Create and checkout into it." Is this the intended behavior? Seems like maybe a bug, but I'm not

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Wed, Dec 6, 2017 at 7:56 PM, Daniel Jacques wrote: > On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano wrote: >> >> Johannes Sixt writes: >> >> > The updated series works for me now. Nevertheless, I suggest to squash >> > in the following

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano wrote: > > Johannes Sixt writes: > > > The updated series works for me now. Nevertheless, I suggest to squash > > in the following change to protect against IFS and globbing characters in > > $INSTLIBDIR. > > Yeah,

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Johannes Sixt writes: > The updated series works for me now. Nevertheless, I suggest to squash > in the following change to protect against IFS and globbing characters in > $INSTLIBDIR. Yeah, that is very sensible. > diff --git a/Makefile b/Makefile > index

Re: [SCRIPT/RFC 0/3] git-commit --onto-parent (three-way merge, no working tree file changes)

On Wed, Dec 6, 2017 at 10:34 AM, Johannes Sixt wrote: > I am sorry for not responding in detail. I think we've reached a mutual > understanding of our workflows. > > Though, from the ideas you tossed around most recently, you seem to want to > make git-commit into a kitchen-sink

Re: [SCRIPT/RFC 0/3] git-commit --onto-parent (three-way merge, no working tree file changes)

I am sorry for not responding in detail. I think we've reached a mutual understanding of our workflows. Though, from the ideas you tossed around most recently, you seem to want to make git-commit into a kitchen-sink for everything. I have my doubts that this will be a welcome change. Just

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

Am 05.12.2017 um 22:35 schrieb Junio C Hamano: > Dan Jacques writes: > >> Thanks for checking! The patch that you quoted above looks like it's from >> this "v4" thread; however, the patch that you are diffing against in your >> latest reply seems like it is from an earlier

Re: [RFC] 'unsigned long' to 'size_t' conversion

On 12/06, Derrick Stolee wrote: > There are several places in Git where we refer to the size of an > object by an 'unsigned long' instead of a 'size_t'. In 64-bit Linux, > 'unsigned long' is 8 bytes, but in 64-bit Windows it is 4 bytes. > > The main issue with this conversion is that large

Re: git blame --reverse doesn't find line in HEAD

> Can you bisect to see when the feature stopped working as you expect? I will see if I can do that but might take some time. > It finds up to which commit each line survived without getting touched since > the oldest commit in the range. Right, this is where it is failing in my case. With a

Re: [PATCH v3 2/2] Doc/check-ref-format: clarify information about @{-N} syntax

On Sunday 03 December 2017 07:38 AM, Junio C Hamano wrote: Kaartic Sivaraam writes: NOTE: Though a commit-hash is a "syntactically" valid branch name, it is generally not considered as one for the use cases of "git check-ref-format --branch". That's because a user

partial_clone_get_default_filter_spec has no callers

Hi Jeff, commit f1862e8153 ("partial-clone: define partial clone settings in config", 2017-12-05), which is part of your 'jh/partial-clone' branch, introduces the partial_clone_get_default_filter_spec() function without any callers. Could you please confirm that this is intentional and that,

Re: git blame --reverse doesn't find line in HEAD

Nick Snyder writes: > This can be reproduced on Linux and Mac. This behavior seems to be a bug. Can you bisect to see when the feature stopped working as you expect? Unlike a forward blame, where the command tries to find a commit that is responsible for a line being in

Re: [RFC] 'unsigned long' to 'size_t' conversion

Am 06.12.2017 um 16:08 schrieb Derrick Stolee: Hi Derrick, > If there are small, isolated chunks that can be done safely, then this > may be a good target for a first patch. Here are some pointers to past discussions: -

RE: [RFE] install-doc-quick.sh should accept a commit-ish

On December 6, 2017 11:40 AM, Junio C Hamano wrote: >"Randall S. Becker" writes: >> Having the git-manpages repo available is fantastic for platforms that >> cannot easily build documentation on demand, for example, when too >> many dependencies that do not build

Re: What's cooking in git.git (Dec 2017, #01; Mon, 4)

Torsten Bögershausen writes: >> Looks like t0027-auto-crlf.sh is failing on Windows: >> https://travis-ci.org/git/git/jobs/312135514 >> >> Could that patch be related? >> >> - Lars >> > Chances are high, I will have a look. > Thanks for noticing. Thanks.

Re: [PATCH v7 4/7] checkout: describe_detached_head: remove ellipsis after committish

Ann T Ropea writes: > v7: fix style issues (redirection, here-dox, long lines, > setting/exporting/unsetting of env var): cf. > Thanks. I'd say this is polished enough already. Let's stop rerolling, wait for a few days for

Re: [RFE] install-doc-quick.sh should accept a commit-ish

"Randall S. Becker" writes: > Having the git-manpages repo available is fantastic for platforms > that cannot easily build documentation on demand, for example, > when too many dependencies that do not build properly. > > It would be really nice to have a version of

[PATCH v2] send-email: extract email-parsing code into a subroutine

The existing code mixes parsing of email header with regular expression and actual code. Extract the parsing code into a new subroutine 'parse_header_line()'. This improves the code readability and make parse_header_line reusable in other place. Signed-off-by: Nathan Payre

Re: What's cooking in git.git (Dec 2017, #01; Mon, 4)

On 2017-12-06 16:14, Lars Schneider wrote: > >> On 04 Dec 2017, at 22:46, Junio C Hamano wrote: >> >> >> * tb/check-crlf-for-safe-crlf (2017-11-27) 1 commit >> - convert: tighten the safe autocrlf handling >> >> The "safe crlf" check incorrectly triggered for contents that

[RFE] install-doc-quick.sh should accept a commit-ish

Other thread attached as context. Having the git-manpages repo available is fantastic for platforms that cannot easily build documentation on demand, for example, when too many dependencies that do not build properly. It would be really nice to have a version of install-doc-quick.sh to

RE: Documentation Breakage at 2.5.6

-Original Message- On December 6, 2017 3:49 AM, Jeff King wrote: >On Wed, Dec 06, 2017 at 09:14:57AM +0100, Ævar Arnfjörð Bjarmason wrote: >> > I'm trying to upgrade the NonStop port from 2.3.7 upward eventually >> > to >> > 2.15.1 and hit a snag on documentation. The xmlto component is a

Re: git blame --reverse doesn't find line in HEAD

This can be reproduced on Linux and Mac. This behavior seems to be a bug. On Wed, Nov 29, 2017 at 12:06 AM, Nick Snyder wrote: > I have a repo that reproduces a behavior with `git blame --reverse` > that surprises me. https://github.com/nicksnyder/git-blame-bug > > The

[PATCH v2] send-email: extract email-parsing code into a subroutine

The existing code mixes parsing of email header with regular expression and actual code. Extract the parsing code into a new subroutine 'parse_header_line()'. This improves the code readability and make parse_header_line reusable in other place. Signed-off-by: Nathan Payre

Re: What's cooking in git.git (Dec 2017, #01; Mon, 4)

> On 04 Dec 2017, at 22:46, Junio C Hamano wrote: > > > * tb/check-crlf-for-safe-crlf (2017-11-27) 1 commit > - convert: tighten the safe autocrlf handling > > The "safe crlf" check incorrectly triggered for contents that does > not use CRLF as line endings, which has been

[RFC] 'unsigned long' to 'size_t' conversion

There are several places in Git where we refer to the size of an object by an 'unsigned long' instead of a 'size_t'. In 64-bit Linux, 'unsigned long' is 8 bytes, but in 64-bit Windows it is 4 bytes. The main issue with this conversion is that large objects fail to load (they seem to hash and

Re: Git Repository Migration

On Wed, Dec 6, 2017 at 3:02 PM, Saurabh Dixit wrote: > Hi, > > I am new here. I just wondered if the Merge Requests (aka., Pull > Requests on GitHub) are also imported or cloned while > cloning/importing a Git repository, say from GitHub to BitBucket. > While I consider

Git Repository Migration

Hi, I am new here. I just wondered if the Merge Requests (aka., Pull Requests on GitHub) are also imported or cloned while cloning/importing a Git repository, say from GitHub to BitBucket. While I consider that, it may not be possible because of the URL to a remote is already set and cannot be

Kindly Asists

Kindly Assist Me In good faith from Mr.Sonami, actually could you please consider to help me to relocate this sum of five million,three hundred thousand dollars(US$5.3 m) to your country for establishing a medium industry in your country. The said 5.3 millions dollars was deposited in our bank

Assalamu`Alaikum.

Greetings from Dr. mohammad ouattara. Assalamu`Alaikum. My Name is Dr. mohammad ouattara, I am a banker by profession. I'm from Ouagadougou, Burkina Faso, West Africa. My reason for contacting you is to transfer an abandoned $14.6M to your account. The owner of this fund died since 2004 with

Re: Documentation Breakage at 2.5.6

On Wed, Dec 06, 2017 at 09:14:57AM +0100, Ævar Arnfjörð Bjarmason wrote: > > I'm trying to upgrade the NonStop port from 2.3.7 upward eventually to > > 2.15.1 and hit a snag on documentation. The xmlto component is a bit new to > > me and I hit the following error: Did it work before in v2.3.7?

Re: Documentation Breakage at 2.5.6

On Wed, Dec 06 2017, Randall S. Becker jotted: > Hi All, > > I'm trying to upgrade the NonStop port from 2.3.7 upward eventually to > 2.15.1 and hit a snag on documentation. The xmlto component is a bit new to > me and I hit the following error: > > XMLTO git-remote-testgit.1 > xmlto: