Re: [PATCH] git-archive: accept --owner and --group like GNU tar

2018-01-01 Thread suzuki toshiya
Dear René , René Scharfe wrote: Am 29.12.2017 um 15:05 schrieb suzuki toshiya: The ownership of files created by git-archive is always root:root. Add --owner and --group options which work like the GNU tar equivalent to allow overriding these defaults. In which situations do you use the new

Re: [PATCH 4/4] branch: add '--show-description' option

2018-01-01 Thread Eric Sunshine
On Mon, Jan 1, 2018 at 5:54 PM, SZEDER Gábor wrote: > 'git branch' has an option to edit a branch's description, but lacks > the option to show that description. > > Therefore, add a new '--show-description' option to do just that, as a > more user-friendly alternative to

Re: [PATCH] git-archive: accept --owner and --group like GNU tar

2018-01-01 Thread Perry Hutchison
Ren?? Scharfe wrote: > Am 29.12.2017 um 15:05 schrieb suzuki toshiya: > > The ownership of files created by git-archive is always > > root:root. Add --owner and --group options which work > > like the GNU tar equivalent to allow overriding these > > defaults. > ... the receiver

Re: [PATCH] dir.c: avoid stat() in valid_cached_dir()

2018-01-01 Thread Duy Nguyen
On Fri, Dec 29, 2017 at 2:50 AM, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Dec 28 2017, Nguyễn Thái Ngọc Duy jotted: > >> stat() may follow a symlink and return stat data of the link's target >> instead of the link itself. We are concerned about the link itself. >> >>

Re: [PATCH] dir.c: avoid stat() in valid_cached_dir()

2018-01-01 Thread Duy Nguyen
On Fri, Dec 29, 2017 at 2:10 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >>> [1] >>> https://public-inbox.org/git/cacsjy8ambksp0mdlradcwn45veenc03b-gq8r8pqprdt9bm...@mail.gmail.com/ >>> >>> dir.c | 2 +- >>> 1 file changed, 1 insertion(+), 1

Re: [PATCH] Add shell completion for git remote rm

2018-01-01 Thread Duy Nguyen
On Fri, Dec 29, 2017 at 11:19 AM, Keith Smiley wrote: > It looks like that was just about preferring remove in documentation and the > like, I think it would still make sense to have both for completion since rm > is still supported. 'rm' should be deprecated. But because I did

[PATCH 0/4] branch: add '--show-description' option

2018-01-01 Thread SZEDER Gábor
'git branch' has an option to edit a branch's description, but lacks the option to show that description. The last patch adds the option to do just that. The first three patches are while-at-it minor cleanups and fixes in the area. SZEDER Gábor (4): branch: '--edit-description' is

[PATCH 1/4] branch: '--edit-description' is incompatible with other options

2018-01-01 Thread SZEDER Gábor
'--edit-description' is incompatible with 'git branch's other options, but the check for conflicting options doesn't look for this option. As a result 'git branch' doesn't error out showing usage when '--edit-description' is used in combination with other options, but e.g. 'git branch --list

[PATCH 2/4] t3200: fix a misindented line

2018-01-01 Thread SZEDER Gábor
Signed-off-by: SZEDER Gábor --- t/t3200-branch.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh index 503a88d02..e9f55ac04 100755 --- a/t/t3200-branch.sh +++ b/t/t3200-branch.sh @@ -1215,7 +1215,7 @@

[PATCH 3/4] t3200: restore branch after "unborn --edit-description" test

2018-01-01 Thread SZEDER Gábor
The test 'refuse --edit-description on unborn branch for now' switches to an orphan branch and leaves the test repository in that state. This might badly influence the subsequent test expecting 'git branch --merged' to error out, by hiding a potential regression with an error triggered by the

[PATCH 4/4] branch: add '--show-description' option

2018-01-01 Thread SZEDER Gábor
'git branch' has an option to edit a branch's description, but lacks the option to show that description. Therefore, add a new '--show-description' option to do just that, as a more user-friendly alternative to 'git config --get branch.$branchname.description': - it's shorter to type (both in

RE: [Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c

2018-01-01 Thread Randall S. Becker
On January 1, 2018 4:51 PM Eric Sunshine wrote: > On Mon, Jan 1, 2018 at 4:21 PM, Randall S. Becker > wrote: > > * I have defined NO_INTPTR_T = UnfortunatelyYes in config.mak.uname > > for my platform. The c99 compiler I have does not define it. > > * The code compiles

[PATCH v3 1/1] convert_to_git(): checksafe becomes int conv_flags

2018-01-01 Thread tboegi
From: Torsten Bögershausen When calling convert_to_git(), the checksafe parameter has been used to check if commit would give a non-roundtrip conversion of EOL. When checksafe was introduced, 3 values had been in use: SAFE_CRLF_FALSE: no warning SAFE_CRLF_FAIL: reject the commit

Re: [Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c

2018-01-01 Thread Eric Sunshine
On Mon, Jan 1, 2018 at 4:21 PM, Randall S. Becker wrote: > * I have defined NO_INTPTR_T = UnfortunatelyYes in config.mak.uname for my > platform. The c99 compiler I have does not define it. > * The code compiles except for compat/regex/regcomp.c - not sure why this is >

[Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c

2018-01-01 Thread Randall S. Becker
I'm looking for the proper approach for dealing with the following situation in 2.8.5: * I have defined NO_INTPTR_T = UnfortunatelyYes in config.mak.uname for my platform. The c99 compiler I have does not define it. * The code compiles except for compat/regex/regcomp.c - not sure why this is being

Re: [PATCH] git-archive: accept --owner and --group like GNU tar

2018-01-01 Thread René Scharfe
Am 29.12.2017 um 15:05 schrieb suzuki toshiya: > The ownership of files created by git-archive is always > root:root. Add --owner and --group options which work > like the GNU tar equivalent to allow overriding these > defaults. In which situations do you use the new options? (The sender would

Re: [PATCH] refs: drop "clear packed-refs while locked" assertion

2018-01-01 Thread Michael Haggerty
On Fri, Dec 8, 2017 at 12:22 PM, Jeff King wrote: > This patch fixes a regression in v2.14.0. It's actually fixed already in > v2.15.0 because all of the packed-ref code there was rewritten. So > there's no point in applying this on "master" or even "maint". But I > figured it was

Fwd: Unknown option for merge-recursive: -X'diff-algorithm=patience'

2018-01-01 Thread Matwey V. Kornilov
Hello, I am running git 2.15.1 and facing the following issue with linux kernel tree. # git checkout v3.8 # git branch abc-3.8 # git checkout v3.9 # git branch abc-3.9 # git checkout abc-3.8 Introduce new commit on top of abc-3.8. Here, I edit README. # vim README # git commit -a -v [abc-3.8