Re: [PATCH 2/2] completion: simplify ls-files filter

2018-03-17 Thread Junio C Hamano
SZEDER Gábor writes: > First, neither 'git ls-files' nor 'git diff-index' produce quite the > same order as the 'sort' utility does, e.g.: > > $ touch foo.c foo-zzz.c > $ git add foo* > $ git diff-index --name-only HEAD > foo-zzz.c > foo.c > $ git diff-index

Re: [PATCH v5 09/11] pack-objects: shrink size field in struct object_entry

2018-03-17 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > +static inline int contains_in_32bits(unsigned long limit) > +{ This name somehow does not sound right. If the verb "contain" must be used, the way to phrase what this function does with the verb is to say "limit can be contained in a 32-bit

[PATCH] completion: complete tags with git tag --delete/--verify

2018-03-17 Thread Todd Zullinger
Completion of tag names has worked for the short -d/-v options since 88e21dc746 ("Teach bash about completing arguments for git-tag", 2007-08-31). The long options were not added to "git tag" until many years later, in c97eff5a95 ("git-tag: introduce long forms for the options", 2011-08-28).

Re: [PATCH 34/36] t/helper: merge test-urlmatch-.. into test-tool

2018-03-17 Thread Eric Sunshine
On Sat, Mar 17, 2018 at 3:54 AM, Nguyễn Thái Ngọc Duy wrote: > t/helper: merge test-urlmatch-.. into test-tool Spelled out fully: t/helper: merge test-urlmatch-normalization into test-tool needs only 58 columns, so is well within the 70-72 column recommendation for

Re: [PATCH 22/36] t/helepr: merge test-read-cache into test-tool

2018-03-17 Thread Eric Sunshine
On Sat, Mar 17, 2018 at 3:54 AM, Nguyễn Thái Ngọc Duy wrote: > t/helepr: merge test-read-cache into test-tool s/helepr/helper/ > Signed-off-by: Nguyễn Thái Ngọc Duy

Re: [PATCH 04/36] t/helper: merge test-lazy-init-name-hash into test-tool

2018-03-17 Thread Eric Sunshine
On Sat, Mar 17, 2018 at 3:53 AM, Nguyễn Thái Ngọc Duy wrote: > diff --git a/cache.h b/cache.h > @@ -333,7 +333,7 @@ struct index_state { > -extern int test_lazy_init_name_hash(struct index_state *istate, int > try_threaded); > +extern int lazy_init_name_hash_for_testing(struct

Re: [RFC PATCH] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-03-17 Thread Eric Sunshine
On Sat, Mar 17, 2018 at 3:11 PM, Thomas Gummerer wrote: > On 03/17, Eddy Petrișor wrote: >> vin., 16 mar. 2018, 23:44 Eric Sunshine a scris: >> > It may be a disservice to remove mention of git-blame and git-shortlog >> > since git-contacts may not

Re: [PATCH 2/2] completion: simplify ls-files filter

2018-03-17 Thread SZEDER Gábor
> When filtering the ls-files output we take care not to touch absolute > paths. This is redundant, because ls-files will never output absolute > paths. Furthermore, sorting the output is also redundant, because the > output of ls-files is already sorted. > > Remove the unnecessary operations.

Re: [PATCH v3 0/4] worktree: teach "add" to check out existing branches

2018-03-17 Thread Junio C Hamano
Thomas Gummerer writes: > Previous rounds are at <20180121120208.12760-1-t.gumme...@gmail.com> > and <20180204221305.28300-1-t.gumme...@gmail.com>. Thanks Duy, Eric > and Junio for the comments on the previous round. > > Junio: I know it is the rc period right now, but the

Re: [PATCH 2/2] completion: simplify ls-files filter

2018-03-17 Thread Junio C Hamano
Clemens Buchacher writes: > When filtering the ls-files output we take care not to touch absolute > paths. This is redundant, because ls-files will never output absolute > paths. Furthermore, sorting the output is also redundant, because the > output of ls-files is already

Re: [PATCH 1/2] completion: improve ls-files filter performance

2018-03-17 Thread Junio C Hamano
Clemens Buchacher writes: > From the output of ls-files, we remove all but the leftmost path > component and then we eliminate duplicates. We do this in a while loop, > which is a performance bottleneck when the number of iterations is large > (e.g. for 6 files in linux.git).

Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job

2018-03-17 Thread Junio C Hamano
Jeff King writes: > Unfortunately I think that's hard to do in pure make. But we're already > relying on $(shell) here, so we could just move the logic there. > > Something like the patch below, perhaps. It should do the right thing on > clang and gcc, and I added in an extra

Re: QUICK RESPONSE

2018-03-17 Thread Aabidullah Aaiz Finance®
-- Dear Sir/Madam Are you a business man or woman ? Do you need a loan or funding for any reason such as: 1) Personal Loan,Business Expansion , 2) Business Start-up ,Education, 3) Debt Consolidation , Home Improvement Loans 4) Hard Money Loans, Investment Loans, We offer loan at low interest

Attention

2018-03-17 Thread Webmail Service
Dear eMail User, Your email account is due for upgrade. Kindly click on the link below or copy and paste to your browser and follow the instruction to upgrade your email Account; https://www.allcounted.com/s?did=s145rtu7u5uzp=en_US Our webmail Technical Team will update your account. If You do

[PATCH v4 4/4] worktree: teach "add" to check out existing branches

2018-03-17 Thread Thomas Gummerer
Currently 'git worktree add ' creates a new branch named after the basename of the path by default. If a branch with that name already exists, the command refuses to do anything, unless the '--force' option is given. However we can do a little better than that, and check the branch out if it is

[PATCH v4 3/4] worktree: factor out dwim_branch function

2018-03-17 Thread Thomas Gummerer
Factor out a dwim_branch function, which takes care of the dwim'ery in 'git worktree add '. It's not too much code currently, but we're adding a new kind of dwim in a subsequent patch, at which point it makes more sense to have it as a separate function. Factor it out now to reduce the patch

[PATCH v4 1/4] worktree: improve message when creating a new worktree

2018-03-17 Thread Thomas Gummerer
Currently 'git worktree add' produces output like the following, when '--no-checkout' is not given: Preparing foo (identifier foo) HEAD is now at 26da330922 where the first line is written to stderr, and the second line coming from 'git reset --hard' is written to stdout, even though

[PATCH v4 2/4] worktree: be clearer when "add" dwim-ery kicks in

2018-03-17 Thread Thomas Gummerer
Currently there is no indication in the "git worktree add" output that a new branch was created. This would be especially useful information in the case where the dwim of "git worktree add " kicks in, as the user didn't explicitly ask for a new branch, but we create one from them. Print some

[PATCH v4 0/4] worktree: teach "add" to check out existing branches

2018-03-17 Thread Thomas Gummerer
Please ignore v3 of this series, I just noticed that I botched the last commit :( sorry about the noise. Previous rounds (other than v3) are at <20180121120208.12760-1-t.gumme...@gmail.com> and <20180204221305.28300-1-t.gumme...@gmail.com>. Thanks Duy, Eric and Junio for the comments on the

[PATCH v3 4/4] worktree: teach "add" to check out existing branches

2018-03-17 Thread Thomas Gummerer
Currently 'git worktree add ' creates a new branch named after the basename of the path by default. If a branch with that name already exists, the command refuses to do anything, unless the '--force' option is given. However we can do a little better than that, and check the branch out if it is

Why does pack-objects use so much memory on incremental packing?

2018-03-17 Thread Ævar Arnfjörð Bjarmason
On Wed, Feb 28 2018, Duy Nguyen jotted: > linux-2.6.git current has 6483999 objects. "git gc" on my poor laptop > consumes 1.7G out of 4G RAM, pushing lots of data to swap and making > all apps nearly unusuable (granted the problem is partly Linux I/O > scheduler too). So I wonder if we can

[PATCH v3 0/4] worktree: teach "add" to check out existing branches

2018-03-17 Thread Thomas Gummerer
Previous rounds are at <20180121120208.12760-1-t.gumme...@gmail.com> and <20180204221305.28300-1-t.gumme...@gmail.com>. Thanks Duy, Eric and Junio for the comments on the previous round. Junio: I know it is the rc period right now, but the topic is also already queued in 'pu', so I wasn't sure

[PATCH v3 1/4] worktree: improve message when creating a new worktree

2018-03-17 Thread Thomas Gummerer
Currently 'git worktree add' produces output like the following, when '--no-checkout' is not given: Preparing foo (identifier foo) HEAD is now at 26da330922 where the first line is written to stderr, and the second line coming from 'git reset --hard' is written to stdout, even though

[PATCH v3 3/4] worktree: factor out dwim_branch function

2018-03-17 Thread Thomas Gummerer
Factor out a dwim_branch function, which takes care of the dwim'ery in 'git worktree add '. It's not too much code currently, but we're adding a new kind of dwim in a subsequent patch, at which point it makes more sense to have it as a separate function. Factor it out now to reduce the patch

[PATCH v3 2/4] worktree: be clearer when "add" dwim-ery kicks in

2018-03-17 Thread Thomas Gummerer
Currently there is no indication in the "git worktree add" output that a new branch was created. This would be especially useful information in the case where the dwim of "git worktree add " kicks in, as the user didn't explicitly ask for a new branch, but we create one from them. Print some

Re: [PATCH v5 04/11] pack-objects: use bitfield for object_entry::depth

2018-03-17 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 17 2018, Nguyễn Thái Ngọc Duy jotted: > Because of struct packing from now on we can only handle max depth > 4095 > [...] > + if (depth >= (1 << OE_DEPTH_BITS)) > + die(_("delta chain depth %d is greater than maximum limit %d"), > + depth, (1 <<

[GSoC] Some #leftoverbits for anyone looking for little projects

2018-03-17 Thread Ævar Arnfjörð Bjarmason
In lieu of sending a PR to https://git.github.io/SoC-2018-Microprojects/ I thought I'd list a few more suggestions, and hopefully others will chime in. This is all TODO stuff I've been meaning to do myself, but wouldn't mind at all if someone else tackled. I'm not interested in mentoring GSoC,

Re: [GSoC] Scripts to be conversted into builtins

2018-03-17 Thread Christian Couder
On Sat, Mar 17, 2018 at 7:26 PM, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Mar 17 2018, Yash Yadav jotted: > >> Hello, >> >> I am a student going through the GSoC process. >> >> In the project ideas listed there is one idea talking of conversion of >> scripts to builtins. This

Re: [RFC][GSoC] Project proposal: convert interactive rebase to C

2018-03-17 Thread Christian Couder
Hi, On Sat, Mar 17, 2018 at 8:14 PM, Alban Gruin wrote: > > Weeks 3 & 4 — May 18, 2018 – June 11, 2018 > Then, I would start to rewrite git-rebase--interactive, and get rid of git- > rebase--helper. Usually to rewrite a shell script in C, we first rewrite shell functions

Re: [PATCH v5 09/11] pack-objects: shrink size field in struct object_entry

2018-03-17 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 17 2018, Nguyễn Thái Ngọc Duy jotted: > It's very very rare that an uncompressd object is larger than 4GB s/uncompressd/uncompressed/

Re: [PATCH v5 11/11] pack-objects.h: reorder members to shrink struct object_entry

2018-03-17 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 17 2018, Nguyễn Thái Ngọc Duy jotted: > Previous patches leave lots of holes and padding in this struct. This > patch reorders the members and shrinks the struct down to 80 bytes > (from 136 bytes, before any field shrinking is done) with 16 bits to > spare (and a couple more in

Re: [PATCH v5 00/11] nd/pack-objects-pack-struct updates

2018-03-17 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 17 2018, Ævar Arnfjörð Bjarmason jotted: > [...]I.e. on git.git we end up with just over a a 8.5% reduction, and[...] Urgh, sorry, this should say "on linux.git...". None of these numbers came from testing git.git.

Re: [PATCH v5 00/11] nd/pack-objects-pack-struct updates

2018-03-17 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 17 2018, Nguyễn Thái Ngọc Duy jotted: > v5 changes are small enough that the interdiff is pretty self > explanatory (there's also a couple commit msg updates). I've been testing this and it's definitely an improvement. I think it would be good to get some mention in the commit

[RFC][GSoC] Project proposal: convert interactive rebase to C

2018-03-17 Thread Alban Gruin
Hi, here is my first draft of my proposal for the GSoC, about the "convert interactive rebase to C" project. Any feedback is welcome :) --- ABSTRACT git is a modular source control management software, and all of its subcommands are programs on their own. A lot of them are written in C, but a

Re: [RFC PATCH] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-03-17 Thread Thomas Gummerer
On 03/17, Eddy Petrișor wrote: > vin., 16 mar. 2018, 23:44 Eric Sunshine a scris: > > > On Fri, Mar 16, 2018 at 5:33 PM, Thomas Gummerer > > wrote: > > > a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > > > @@ -260,8 +260,8 @@

Odkaz ze stránek http://www.pojistenispektrum.cz

2018-03-17 Thread git
Pan/paní Only the best on dating site URL http://bit.ly/2EjyKcY Vám zasílá odkaz na stránku ze serveru http://www.pojistenispektrum.cz, která by Vás mohla zajímat: http://bit.ly/2EjyKcY

Re: [GSoC] Scripts to be conversted into builtins

2018-03-17 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 17 2018, Yash Yadav jotted: > Hello, > > I am a student going through the GSoC process. > > In the project ideas listed there is one idea talking of conversion of > scripts to builtins. This interests me but no pointer forward is given > and I'd like to dive more into that idea and

[GSoC] Scripts to be conversted into builtins

2018-03-17 Thread Yash Yadav
Hello, I am a student going through the GSoC process. In the project ideas listed there is one idea talking of conversion of scripts to builtins. This interests me but no pointer forward is given and I'd like to dive more into that idea and go through the script(s). So, where should I look

Re: get commit ID from a tree object ID

2018-03-17 Thread Junio C Hamano
Jeff King writes: > If you want to dig further, you can use the diff machinery to show which > commit introduced a particular tree, like: > > git rev-list --all | > git diff-tree --stdin --pretty=raw --raw -t -r | > less +/$desired_tree > > That "less" will find the

Re: get commit ID from a tree object ID

2018-03-17 Thread Jeff King
On Sat, Mar 17, 2018 at 04:01:28PM +0300, Konstantin Khomoutov wrote: > So actually a generic approach to what you need is a full scan of all > the commits in the repository with recursive traversing of the hierarchy > of trees of each of them (via `git ls-tree`) and looking for the SHA-1 > name

Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job

2018-03-17 Thread Jeff King
On Sat, Mar 17, 2018 at 12:08:32PM -0400, Jeff King wrote: > +case "$($CC --version 2>&1)" in > +gcc*) > + print_flags gcc > + ;; > +clang*) > + print_flags clang > + ;; > +*) > + : unknown compiler family > + ;; > +esac By the way, one annoying thing is that running "cc

Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job

2018-03-17 Thread Jeff King
On Sat, Mar 17, 2018 at 03:59:23PM +0100, Duy Nguyen wrote: > On Sat, Mar 17, 2018 at 03:29:31PM +0100, Lars Schneider wrote: > > I interpreted Peff's comment like this: > > > > If DEVELOPER=1 is set and we detect a gcc-6 in the makefile, > > then we could set your additional flags in the

Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job

2018-03-17 Thread Jeff King
On Sat, Mar 17, 2018 at 03:29:31PM +0100, Lars Schneider wrote: > >> Why isn't this just turning on DEVELOPER=1 if we know we have a capable > >> compiler? > > > > DEVELOPER=1 is always set even before this patch. It's set and > > exported in lib-travisci.sh. > > I interpreted Peff's comment

Attention

2018-03-17 Thread Webmail Service
Dear eMail User, Your email account is due for upgrade. Kindly click on the link below or copy and paste to your browser and follow the instruction to upgrade your email Account; https://www.allcounted.com/s?did=s145rtu7u5uzp=en_US Our webmail Technical Team will update your account. If You do

Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job

2018-03-17 Thread Duy Nguyen
On Sat, Mar 17, 2018 at 03:29:31PM +0100, Lars Schneider wrote: > I interpreted Peff's comment like this: > > If DEVELOPER=1 is set and we detect a gcc-6 in the makefile, > then we could set your additional flags in the makefile. > > This way every developer with a new compiler would run these

Re: Assalam u Alaikum!

2018-03-17 Thread Alsha Gaddafi
-- نا عائشة القذافي ، لديّ اقتراح عمل لك وأحتاج إلى الاحترام المتبادل والثقة والصدق والشفافية والدعم اللائق والمساعدة. أنا لك لمساعدتي في الحصول على مبلغ (16.2 مليون دولار أودعت سرا مع شركة الأمن والسعاة Vaults في بوركينا فاسو غرب أفريقيا ، وهذا العمل هو عقبة حرة وأنا أؤكد لك أنك آمنة 100

Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job

2018-03-17 Thread Lars Schneider
> On 17 Mar 2018, at 09:01, Duy Nguyen wrote: > > On Fri, Mar 16, 2018 at 10:22 PM, Jeff King wrote: >>> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh >>> index 3735ce413f..f6f346c468 100755 >>> --- a/ci/run-build-and-tests.sh >>> +++

[PATCH v5 08/11] pack-objects: shrink z_delta_size field in struct object_entry

2018-03-17 Thread Nguyễn Thái Ngọc Duy
We only cache deltas when it's smaller than a certain limit. This limit defaults to 1000 but save its compressed length in a 64-bit field. Shrink that field down to 16 bits, so you can only cache 65kb deltas. Larger deltas must be recomputed at when the pack is written down. Signed-off-by: Nguyễn

[PATCH v5 04/11] pack-objects: use bitfield for object_entry::depth

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Because of struct packing from now on we can only handle max depth 4095 (or even lower when new booleans are added in this struct). This should be ok since long delta chain will cause significant slow down anyway. Signed-off-by: Nguyễn Thái Ngọc Duy ---

[PATCH v5 07/11] pack-objects: refer to delta objects by index instead of pointer

2018-03-17 Thread Nguyễn Thái Ngọc Duy
These delta pointers always point to elements in the objects[] array in packing_data struct. We can only hold maximum 4G of those objects because the array size in nr_objects is uint32_t. We could use uint32_t indexes to address these elements instead of pointers. On 64-bit architecture (8 bytes

[PATCH v5 05/11] pack-objects: move in_pack_pos out of struct object_entry

2018-03-17 Thread Nguyễn Thái Ngọc Duy
This field is only need for pack-bitmap, which is an optional feature. Move it to a separate array that is only allocated when pack-bitmap is used (it's not freed in the same way that objects[] is not). Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/pack-objects.c | 3 ++-

[PATCH v5 09/11] pack-objects: shrink size field in struct object_entry

2018-03-17 Thread Nguyễn Thái Ngọc Duy
It's very very rare that an uncompressd object is larger than 4GB (partly because Git does not handle those large files very well to begin with). Let's optimize it for the common case where object size is smaller than this limit. Shrink size field down to 32 bits [1] and one overflow bit. If the

[PATCH v5 06/11] pack-objects: move in_pack out of struct object_entry

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Instead of using 8 bytes (on 64 bit arch) to store a pointer to a pack. Use an index instead since the number of packs should be relatively small. This limits the number of packs we can handle to 16k. For now if you hit 16k pack files limit, pack-objects will simply fail [1]. [1] The escape

[PATCH v5 01/11] pack-objects: a bit of document about struct object_entry

2018-03-17 Thread Nguyễn Thái Ngọc Duy
The role of this comment block becomes more important after we shuffle fields around to shrink this struct. It will be much harder to see what field is related to what. Signed-off-by: Nguyễn Thái Ngọc Duy --- pack-objects.h | 45 +

[PATCH v5 03/11] pack-objects: use bitfield for object_entry::dfs_state

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/pack-objects.c | 3 +++ pack-objects.h | 28 +--- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 647c01ea34..83f8154865

[PATCH v5 02/11] pack-objects: turn type and in_pack_type to bitfields

2018-03-17 Thread Nguyễn Thái Ngọc Duy
An extra field type_valid is added to carry the equivalent of OBJ_BAD in the original "type" field. in_pack_type always contains a valid type so we only need 3 bits for it. A note about accepting OBJ_NONE as "valid" type. The function read_object_list_from_stdin() can pass this value [1] and it

[PATCH v5 00/11] nd/pack-objects-pack-struct updates

2018-03-17 Thread Nguyễn Thái Ngọc Duy
v5 changes are small enough that the interdiff is pretty self explanatory (there's also a couple commit msg updates). diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index c388d87c3e..fb2aba80bf 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -1611,7 +1611,7 @@

[PATCH v5 10/11] pack-objects: shrink delta_size field in struct object_entry

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Allowing a delta size of 64 bits is crazy. Shrink this field down to 31 bits with one overflow bit. If we find an existing delta larger than 2GB, we do not cache delta_size at all and will get the value from oe_size(), potentially from disk if it's larger than 4GB. Signed-off-by: Nguyễn Thái

[PATCH v5 11/11] pack-objects.h: reorder members to shrink struct object_entry

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Previous patches leave lots of holes and padding in this struct. This patch reorders the members and shrinks the struct down to 80 bytes (from 136 bytes, before any field shrinking is done) with 16 bits to spare (and a couple more in in_pack_header_size when we really run out of bits).

Wir bieten jedem ein GÜNSTIGES Darlehnen zu TOP Konditionen an

2018-03-17 Thread Obrist Nicolas
Sehr geehrte Damen und Herren, Sie brauchen Geld? Sie sind auf der suche nach einem Darlehnen? Seriös und unkompliziert? Dann sind Sie hier bei uns genau richtig. Durch unsere jahrelange Erfahrung und kompetente Beratung sind wir Europaweit tätig. Wir bieten jedem ein GÜNSTIGES Darlehnen zu

Re: get commit ID from a tree object ID

2018-03-17 Thread Konstantin Khomoutov
On Sat, Mar 17, 2018 at 01:17:12PM +0100, Michal Novotny wrote: > let's say I have made an annotated tag on a certain treeish: > > $ git tag -a -m msg tagname HEAD: > > Now, I can try to see the content of the tag: > > $ git tag -v tagname > object 42a1c36553a50ceae2f75ffc4b1446c6c393eae7 >

get commit ID from a tree object ID

2018-03-17 Thread Michal Novotny
Hello, let's say I have made an annotated tag on a certain treeish: $ git tag -a -m msg tagname HEAD: Now, I can try to see the content of the tag: $ git tag -v tagname object 42a1c36553a50ceae2f75ffc4b1446c6c393eae7 type tree tag tagname tagger clime 1521288727 +0100 msg

Re: [PATCH v4 11/11] pack-objects.h: reorder members to shrink struct object_entry

2018-03-17 Thread Duy Nguyen
On Fri, Mar 16, 2018 at 10:02 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Previous patches leave lots of holes and padding in this struct. This >> patch reorders the members and shrinks the struct down to 80 bytes >> (from 136 bytes,

Re: [PATCH v4 01/11] pack-objects: a bit of document about struct object_entry

2018-03-17 Thread Duy Nguyen
On Fri, Mar 16, 2018 at 9:32 PM, Junio C Hamano wrote: >> +/* >> + * basic object info >> + * - >> + * idx.oid is filled up before delta searching starts. idx.crc32 and >> + * is only valid after the object is written out and will be used for > > "and is"?

Re: [PATCH v4 0/3] stash push -u -- fixes

2018-03-17 Thread Thomas Gummerer
On 03/16, Junio C Hamano wrote: > Here is a preliminary fix for an earlier copy-pasto, plus two > patches from your v3. Thanks for catching and fixing this! > I tried to reduce the nesting level by swapping the order of if/elif > chain; please double check the logic to ensure I didn't make

[PATCH 1/2] completion: improve ls-files filter performance

2018-03-17 Thread Clemens Buchacher
>From the output of ls-files, we remove all but the leftmost path component and then we eliminate duplicates. We do this in a while loop, which is a performance bottleneck when the number of iterations is large (e.g. for 6 files in linux.git). $ COMP_WORDS=(git status -- ar) COMP_CWORD=3;

[PATCH 2/2] completion: simplify ls-files filter

2018-03-17 Thread Clemens Buchacher
When filtering the ls-files output we take care not to touch absolute paths. This is redundant, because ls-files will never output absolute paths. Furthermore, sorting the output is also redundant, because the output of ls-files is already sorted. Remove the unnecessary operations.

Re: [PATCH] format-patch: use --compact-summary instead of --summary

2018-03-17 Thread Duy Nguyen
On Fri, Mar 16, 2018 at 10:41 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> For reviewers, a couple fewer lines from diffstat (either cover letter >> or patches) is a good thing because there's less to read. > > I can certainly accept that

Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job

2018-03-17 Thread Duy Nguyen
On Fri, Mar 16, 2018 at 10:22 PM, Jeff King wrote: >> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh >> index 3735ce413f..f6f346c468 100755 >> --- a/ci/run-build-and-tests.sh >> +++ b/ci/run-build-and-tests.sh >> @@ -7,6 +7,22 @@ >> >> ln -s "$cache_dir/.prove"

[PATCH 04/36] t/helper: merge test-lazy-init-name-hash into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile| 2 +- cache.h | 2 +- name-hash.c | 2 +- t/helper/test-lazy-init-name-hash.c | 26 ++---

[PATCH 09/36] t/helper: merge test-drop-caches into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile| 2 +- t/helper/test-drop-caches.c | 3 ++- t/helper/test-tool.c| 1 + t/helper/test-tool.h| 1 + t/perf/p7519-fsmonitor.sh | 12 ++-- 5 files changed, 11 insertions(+), 8

[PATCH 02/36] t/helper: merge test-chmtime into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 3 ++- t/helper/test-chmtime.c | 15 +++--- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 2 ++ t/lib-git-svn.sh | 2

[PATCH 06/36] t/helper: merge test-ctype into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-ctype.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0070-fundamental.sh | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile

[PATCH 07/36] t/helper: merge test-date into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-date.c | 17 + t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0006-date.sh| 8 t/t1300-repo-config.sh | 2 +- t/test-lib.sh |

[PATCH 08/36] t/helper: merge (unused) test-delta into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-delta.c | 5 +++-- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index efb1872c52..327d63217a

[PATCH 16/36] t/helper: merge (unused) test-match-trees into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile| 2 +- t/helper/test-match-trees.c | 3 ++- t/helper/test-tool.c| 1 + t/helper/test-tool.h| 1 + 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index

[PATCH 14/36] t/helper: merge test-hashmap into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile| 2 +- t/helper/test-hashmap.c | 5 +++-- t/helper/test-tool.c| 1 + t/helper/test-tool.h| 1 + t/t0011-hashmap.sh | 4 ++-- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/Makefile

[PATCH 05/36] t/helper: merge test-config into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-config.c| 5 +++-- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t1305-config-include.sh | 2 +- t/t1308-config-set.sh | 22 +++---

[PATCH 17/36] t/helper: merge (unused) test-mergesort into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-mergesort.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index

[PATCH 15/36] t/helper: merge test-index-version into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-index-version.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t1600-index.sh | 2 +-

[PATCH 12/36] t/helper: merge test-example-decorate into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-example-decorate.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t9004-example.sh | 2 +- 5 files changed, 6 insertions(+),

[PATCH 20/36] t/helper: merge test-path-utils into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-path-utils.c | 3 +- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/lib-git-p4.sh| 2 +- t/t0060-path-utils.sh | 60

[PATCH 24/36] t/helper: merge test-regex into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile| 2 +- t/helper/test-regex.c | 7 --- t/helper/test-tool.c| 1 + t/helper/test-tool.h| 1 + t/t0070-fundamental.sh | 2 +- t/t7812-grep-icase-non-ascii.sh |

[PATCH 26/36] t/helper: merge test-run-command into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile| 2 +- t/helper/test-run-command.c | 3 ++- t/helper/test-tool.c| 1 + t/helper/test-tool.h| 1 + t/t0061-run-command.sh | 24 5 files changed, 17

[PATCH 35/36] t/helper: merge test-wildmatch into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/helper/test-wildmatch.c | 3 ++- t/t3070-wildmatch.sh | 14 +++--- 5 files changed, 12 insertions(+), 9 deletions(-)

[PATCH 33/36] t/helper: merge test-subprocess into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-subprocess.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t1501-work-tree.sh | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 22/36] t/helepr: merge test-read-cache into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-read-cache.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/perf/p0002-read-cache.sh | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 31/36] t/helper: merge test-string-list into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile| 2 +- t/helper/test-string-list.c | 3 ++- t/helper/test-tool.c| 1 + t/helper/test-tool.h| 1 + t/perf/p0071-sort.sh| 2 +- t/t0063-string-list.sh | 48

[PATCH 23/36] t/helper: merge test-ref-store into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-ref-store.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t1405-main-ref-store.sh | 2 +- t/t1406-submodule-ref-store.sh | 2 +-

[PATCH 21/36] t/helper: merge test-prio-queue into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-prio-queue.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0009-prio-queue.sh | 6 +++--- 5 files changed, 8 insertions(+), 5 deletions(-) diff

[PATCH 28/36] t/helper: merge test-sha1-array into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-sha1-array.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0064-sha1-array.sh | 16 5 files changed, 13 insertions(+), 10

[PATCH 25/36] t/helper: merge test-revision-walking into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-revision-walking.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0062-revision-walking.sh | 2 +- 5 files changed, 6 insertions(+),

[PATCH 30/36] t/helper: merge test-strcmp-offset into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-strcmp-offset.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0065-strcmp-offset.sh | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-)

[PATCH 34/36] t/helper: merge test-urlmatch-.. into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/helper/test-urlmatch-normalization.c | 5 +- t/t0110-urlmatch-normalization.sh |

[PATCH 27/36] t/helper: merge test-scrap-cache-tree into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-scrap-cache-tree.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0090-cache-tree.sh| 8 5 files changed, 9

[PATCH 29/36] t/helper: merge test-sigchain into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-sigchain.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0005-signals.sh | 4 ++-- 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile

[PATCH 36/36] t/helper: merge test-write-cache into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile| 2 +- t/helper/test-tool.c| 1 + t/helper/test-tool.h| 1 + t/helper/test-write-cache.c | 3 ++- t/perf/p0007-write-cache.sh | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff

[PATCH 32/36] t/helper: merge test-submodule-config into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-submodule-config.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t7411-submodule-config.sh | 18 +- 5 files

[PATCH 18/36] t/helper: merge test-mktemp into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-mktemp.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0070-fundamental.sh | 4 ++-- 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile

[PATCH 03/36] t/helper: merge test-sha1 into test-tool

2018-03-17 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Documentation/howto/recover-corrupted-object-harder.txt | 2 +- Makefile| 4 ++-- t/helper/test-sha1.c| 3 ++- t/helper/test-sha1.sh

  1   2   >