Re: Windows path handling changed between versions

2015-09-01 Thread Johannes Schindelin
Hi Geofrey, On 2015-09-01 18:55, Geofrey Sanders wrote: > I recently upgraded from Windows Git 1.6.2 to 2.5.0 and found myself > unable to rebase. Turns out paths didn't used to be case-sensitive and > now they are, causing a number of operations to halt. A repo created > by pointing at the

Re: Git crash on different versions, including current

2015-08-31 Thread Johannes Schindelin
Hi Christian, On 2015-08-29 10:41, Christian Soltenborn wrote: > today I ran into a git issue on Windows 7/64. My directory structure > looks like this, and I wondered why the content of a dir wouldn't get added. > > C:\Users\chris\git\GoogleTestExtension > -- .git > -- ConsoleApplication1

Re: Git book figure bug

2015-09-02 Thread Johannes Schindelin
Hi Jesper, On 2015-09-02 09:45, Jesper Jørgensen wrote: > I am learning how git works, and is using the excellent book on the > official site. > I believe I have located a mistake in one of the images. > It is about Figure 3.17 on this page : >

Re: git bash bug: ipython doesn't work

2015-09-03 Thread Johannes Schindelin
Hi Sergey, On 2015-09-03 18:56, Sergey Chipiga wrote: > I downloaded git for windows v2.5.1. And in git bash I can't launch ipython. > I suppose it forwards stdout somethere. I replied in the ticket you opened on GitHub: https://github.com/git-for-windows/git/issues/352 Ciao, Johannes -- To

Re: [git-for-windows] Re: Git for Windows 2.5.1 is out

2015-09-02 Thread Johannes Schindelin
On Wed, 2 Sep 2015, Aaron Bird wrote: > I am running windows 8.1. Every time I try and open git Bash I get an > unexpected kernal mode trap error and computer instantly shuts down. For lurkers, Aaron also reported this bug at https://github.com/git-for-windows/git/issues/348 and we are eagerly

Re: GSoC 2015 is over

2015-09-02 Thread Johannes Schindelin
Hi, On Wed, 2 Sep 2015, Paul Tan wrote: > On Wed, Sep 2, 2015 at 12:55 AM, Matthieu Moy > wrote: > > I consider this GSoC as a great success and a pleasant experience. > > Congratulation to Paul and Karthik, and a warm "thank you" to everybody > > who contributed:

Do you plan to release 2.5.2 any time soon?

2015-09-02 Thread Johannes Schindelin
Hi Junio, I have a couple of fixes lined up for bugs in Git for Windows 2.5.1. Do you plan to release 2.5.2 any time soon? If yes, I would hold off, otherwise I will just do a Git for Windows 2.5.1 (Rel 2). Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the

On a personal note

2015-09-03 Thread Johannes Schindelin
Hey all, yes, it is true: since mid-August I am working for Microsoft. Over a year ago, I got into contact with the Visual Studio Online group at Microsoft, of which I am now a happy member. A large part of my mission is to improve the experience of Git for Windows. This is very exciting to me: I

Re: [PATCH] mailmap: update my entry with new email address

2015-09-01 Thread Johannes Schindelin
Hi Ramsay, On 2015-09-01 17:50, Ramsay Jones wrote: > diff --git a/.mailmap b/.mailmap > index ece2951..e5b4126 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -186,7 +186,7 @@ Philip Jägenstedt > > Philipp A. Hartmann

Re: On a personal note

2015-09-06 Thread Johannes Schindelin
On 2015-09-03 15:06, Levente wrote: > Is the 'git for windows' development is in a separate branch? https://github.com/git-for-windows/git/ (see the "repository" link on the upper right of http://git-for-windows.github.io/). Ciao, Johannes -- To unsubscribe from this list: send the line

Re: Do you plan to release 2.5.2 any time soon?

2015-09-04 Thread Johannes Schindelin
Hi Junio, On 2015-09-03 21:00, Junio C Hamano wrote: > Johannes Schindelin <johannes.schinde...@gmx.de> writes: > >> I have a couple of fixes lined up for bugs in Git for Windows 2.5.1. Do >> you plan to release 2.5.2 any time soon? If yes, I would hold off, >>

Re: [PATCH] compat/inet_ntop.c: Use INET_ADDRSTRLEN and INET6_ADDRSTRLEN macroses

2015-08-25 Thread Johannes Schindelin
Hi Kirill, On 2015-08-25 12:34, brillian...@inbox.ru wrote: From: Brilliantov Kirill Vladimirovich brillian...@inbox.ru Signed-off-by: Brilliantov Kirill Vladimirovich brillian...@inbox.ru The commit message makes for an excellent place to fill in the reader on information that is not

Re: Bug report: GIT PRO/Branches chapter

2015-09-09 Thread Johannes Schindelin
Hi Robert, On 2015-09-09 08:11, Robert Macháček wrote: > Just reading this chapter: > https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell > > I believe that: Figure 3-9. Divergent history > (https://git-scm.com/book/en/v2/book/03-git-branching/images/advance-master.png) > does

[PATCH] am --skip/--abort: merge HEAD/ORIG_HEAD tree into index

2015-09-09 Thread Johannes Schindelin
-and-suggested-by: Kim Gybels <kim.gyb...@engilico.com> Original report: https://github.com/git-for-windows/git/issues/365 Acked-by: Paul Tan <pyoka...@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- contrib/examples/git-am.sh | 2 +- 1 file changed,

Re: [PATCH] am --skip/--abort: merge HEAD/ORIG_HEAD tree into index

2015-09-09 Thread Johannes Schindelin
Hi Junio, On 2015-09-09 11:10, Johannes Schindelin wrote: > This is a backport of the corresponding patch to the builtin am in 2.6: > 3ecc704 (am --skip/--abort: merge HEAD/ORIG_HEAD tree into index, > 2015-08-19). > > Reportedly, it can make a huge difference on Windows, in

Re: storing cover letter of a patch series?

2015-09-10 Thread Johannes Schindelin
Hi Jake, On 2015-09-10 18:28, Jacob Keller wrote: > does anyone know of any tricks for storing a cover letter for a patch > series inside of git somehow? It is not stored as a blob, but I use `git branch --edit-description` to write the cover letter for patch series when I expect a couple of

Re: [git-for-windows] Re: Announcing Git for Windows 2.5.2

2015-09-12 Thread Johannes Schindelin
Hi Marko, On 2015-09-12 20:46, Marko Palola wrote: > I have some problems with 2.5.2 and 2.5.1 and bitdefender scanner. > but I can use v2.5.0 We have had plenty of reports since the start of the Git for Windows project in 2007. None of them have turned out to be true viruses, all of them

[PATCH] poll: honor the timeout on Win32

2015-09-12 Thread Johannes Schindelin
stable and monotonically increasing. (Neither GetSystemTime nor QueryPerformanceCounter have all three of these properties.) Signed-off-by: Edward Thomson <ethom...@microsoft.com> Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- compat/poll/poll.c | 16 ++

Announcing Git for Windows 2.5.2 (Release 2)

2015-09-12 Thread Johannes Schindelin
Dear Git users, you probably noticed that there was a really obvious bug in the "Git GUI" entry in the Start Menu (because it has been reported several times). I just released a new version that squashes this bug and three more. Please find it here:

Re: Big path on git add file [windows bug]

2015-09-16 Thread Johannes Schindelin
Hi Alexey, On 2015-09-16 10:01, Alexey Kasyanchuk wrote: > I tried add one of node.js module to git project. But add operation failed: > > libgit2 returned: Invalid path for filesystem >

Re: [PATCH 08/67] add reentrant variants of sha1_to_hex and find_unique_abbrev

2015-09-16 Thread Johannes Schindelin
Hi Junio, Jeff & Ramsay, On 2015-09-16 03:32, Junio C Hamano wrote: > Jeff King writes: > >>> Hmm, I haven't read any other patches yet (including those which use these >>> new '_to' functions), but I can't help feeling they should be named >>> something >>> like

Re: error opening

2015-09-12 Thread Johannes Schindelin
Hi Adrian, please note that Renato never got your mail (you should always use reply-to-all). I re-Cc:ed him, please do not forget to reply-to-all next time. On 2015-09-11 23:33, Adrian Ang wrote: > Renato Akaboci gmail.com> writes: >> >> I´m in trouble just after installation of my Git for

Re: v2.5.2 installation on Windows 10

2015-09-12 Thread Johannes Schindelin
Hi Long, On 2015-09-11 18:13, Long wrote: > Installation of 64bit could complete, but running Git GUI always prompt the > error below: > > Couldn’t read file “C:\Program > Files\Git\cmd\mingw64\libexec\git-core\git-gui”: no such file or > directory Please see the corresponding ticket:

Re: v2.5.2 installation on Windows 10

2015-09-12 Thread Johannes Schindelin
Dear Diaoul, it is considered rude on this mailing list to top-post, and likewise to cull the Cc: list. Please do not do that. On 2015-09-12 11:34, Diaoul wrote: > I can confirm this on the same setup (W10 64bit git 2.5.2) Please see the corresponding ticket:

Re: Git Deployment using existing multiple environments

2015-09-12 Thread Johannes Schindelin
Hi, On 2015-09-12 08:31, Sukhwinder Singh wrote: > We already have 3-4 environments setup on our Windows servers without Git > and each environment already has code which is different from each > other. > > There are three environments > Live > UAT > Test (has the latest code) > > > And then

RE: Git Deployment using existing multiple environments

2015-09-15 Thread Johannes Schindelin
Hi, please stop top-posting. It is quite irritating by now. Thank you. On 2015-09-15 08:50, Sukhwinder Singh wrote: > Now lets say we set up a repository at github which has the latest > code (all test code)., Now at each of our own servers we already have > existing code, that is Test, UAT and

Re: [PATCH 04/67] fsck: don't fsck alternates for connectivity-only check

2015-09-15 Thread Johannes Schindelin
Hi Peff, On 2015-09-15 17:24, Jeff King wrote: > Commit 02976bf (fsck: introduce `git fsck --connectivity-only`, > 2015-06-22) recently gave fsck an option to perform only a > subset of the checks, by skipping the fsck_object_dir() > call. However, it does so only for the local object >

Re: On a personal note

2015-09-17 Thread Johannes Schindelin
Hi Duy, On 2015-09-17 15:29, Duy Nguyen wrote: > On Thu, Sep 3, 2015 at 5:00 PM, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: >> >> yes, it is true: since mid-August I am working for Microsoft. Over a >> year ago, I got into contact with the Visual Studi

Announcing Git for Windows 2.5.2

2015-09-10 Thread Johannes Schindelin
Dear Git users, it is my pleasure to announce Git for Windows 2.5.2. The installers and portable versions can be downloaded from our home page at https://git-for-windows.github.io/. We have been quite busy, lots of contributions (mostly bug reports, but also the occasional Pull Request).

Re: storing cover letter of a patch series?

2015-09-10 Thread Johannes Schindelin
Hi Jake, On 2015-09-10 23:00, Jacob Keller wrote: > On Thu, Sep 10, 2015 at 11:58 AM, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: >> >> On 2015-09-10 18:28, Jacob Keller wrote: >> >>> does anyone know of any tricks for storing a cover lett

RE: v2.5.2 installation on Windows 10

2015-09-12 Thread Johannes Schindelin
Hi Long, On 2015-09-12 13:43, Long Yang wrote: > Thanks for the email to confirm the bug. Of course! Thank you for taking the time to report it. > To answer your question first, I found only the Community page at > http://www.git-scm.com/, as I was looking for a forum-kind of page to > see if

Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions

2015-09-29 Thread Johannes Schindelin
Hi Karsten, On 2015-09-29 12:23, Karsten Blees wrote: > Am 28.09.2015 um 14:52 schrieb Johannes Schindelin: >> Otherwise there would be that little loop-hole where (nsec % 1000) == 0 *by >> chance* and we assume the timestamps to be identical even if they are not. > > Y

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Johannes Schindelin
Hi Junio, On 2015-09-28 20:49, Junio C Hamano wrote: > Junio C Hamano <gits...@pobox.com> writes: > >> Johannes Schindelin <johannes.schinde...@gmx.de> writes: >> >>> When encountering broken symrefs, such as a stale remote HEAD (which can >

Re: [PATCH] git-send-email.perl: Fixed sending of many changes/patches

2015-09-29 Thread Johannes Schindelin
Hi Lars, On 2015-09-29 17:00, Lars Wendler wrote: > From: Stefan Agner > > See http://permalink.gmane.org/gmane.comp.version-control.git/274569 Please summarize the linked discussion in the commit message, as it is the convention here in the Git project to make commit

Announcing Git for Windows 2.6.0

2015-09-29 Thread Johannes Schindelin
Dear Git users, it is my pleasure to announce that Git for Windows 2.6.0 is available (see https://git-for-windows.github.io/ for details and download links). Thank you, contributors! Changes since Git for Windows 2.5.3 (September 18th 2015) New Features • Comes with Git 2.6.0 • The

Re: [PATCH] git-send-email.perl: Fixed sending of many/huge changes/patches

2015-09-30 Thread Johannes Schindelin
Hi Lars, On 2015-09-30 09:26, Lars Wendler wrote: > From: Stefan Agner > > Sometimes sending huge patches/commits fail with > > [Net::SMTP::SSL] Connection closed at /usr/lib/git-core/git-send-email > line 1320. > > Running the command with --smtp-debug=1 yields to > >

[PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Johannes Schindelin
When encountering broken symrefs, such as a stale remote HEAD (which can happen if the active branch was renamed in the remote), it is more helpful to remove those symrefs than to exit with an error. This fixes https://github.com/git-for-windows/git/issues/423 Signed-off-by: Johannes Schindelin

[PATCH v2 2/4] pack-objects: do not get distracted by broken symrefs

2015-09-28 Thread Johannes Schindelin
It is quite possible for, say, a remote HEAD to become broken, e.g. when the default branch was renamed. We should still be able to pack our objects when such a thing happens; simply ignore broken symrefs (because they cannot matter for the packing process anyway). Signed-off-by: Johannes

[PATCH v2 1/4] gc: demonstrate failure with stale remote HEAD

2015-09-28 Thread Johannes Schindelin
Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- t/t6500-gc.sh | 15 +++ 1 file changed, 15 insertions(+) diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh index 63194d8..b736774 100755 --- a/t/t6500-gc.sh +++ b/t/t6500-gc.sh @@ -30,4 +30,19 @@ test_expect_success

[PATCH v2 3/4] mark_reachable_objects(): optionally collect broken symrefs

2015-09-28 Thread Johannes Schindelin
broken symrefs. The behavior of the function is unchanged if that parameter is `NULL`. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- builtin/prune.c | 2 +- builtin/reflog.c | 2 +- reachable.c | 25 +++-- reachable.h | 3 ++- 4 files chang

[PATCH] Fix "inside work tree" detection on case-insensitive filesystems

2015-09-28 Thread Johannes Schindelin
` variable (e.g. `C:\test` vs `c:\test`) the user would be greeted by the error message fatal: git-am cannot be used without a working tree. when trying to run a rebase. This fixes https://github.com/git-for-windows/git/issues/402 (reported by Daniel Harding). Signed-off-by: Johannes

[PATCH v2 0/4] Fix gc failure when a remote HEAD goes stale

2015-09-28 Thread Johannes Schindelin
repository gets renamed. Git's garbage collector should handle this gracefully. The best this developer could come up with, is to simply warn and delete broken symrefs. Thanks to Junio and Peff for their really valuable sanity check. Interdiff vs v1 below diffstat. Johannes Schindelin (4): gc

Re: [RFC/PATCH v1] Add Travis CI support

2015-10-04 Thread Johannes Schindelin
Hi Junio, On 2015-10-04 03:37, Junio C Hamano wrote: > Junio C Hamano writes: > >> On Sat, Oct 3, 2015 at 3:23 PM, Roberto Tyley >> wrote: >>> >>> Given this, enabling Travis CI for git/git seems pretty low risk, >>> are there any strong objections

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-04 Thread Johannes Schindelin
Hi Max, On 2015-10-02 21:21, Max Kirillov wrote: > On Fri, Oct 02, 2015 at 12:13:40PM +0200, Johannes Schindelin wrote: >> On 2015-10-02 12:05, Johannes Schindelin wrote: >> >> > On 2015-10-01 05:29, Max Kirillov wrote: >>>> When a builtin has done its jo

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-05 Thread Johannes Schindelin
Hi Max, On 2015-10-05 06:57, Max Kirillov wrote: > On Sun, Oct 04, 2015 at 04:53:30PM +0200, Johannes Schindelin wrote: >> I guess then we would need two different patches for the >> two different fixes, at least. >> >> So now I am unsure how to proceed: I do not w

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Johannes Schindelin
Hi Max, On 2015-10-01 05:29, Max Kirillov wrote: > When a builtin has done its job, but waits for pager or not waited > by its caller and still hanging it keeps pack files opened. > This can cause a number of issues, for example on Windows git gc > cannot remove the packs. I did not experience

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Johannes Schindelin
Hi Max, On 2015-10-02 12:05, Johannes Schindelin wrote: > On 2015-10-01 05:29, Max Kirillov wrote: >> When a builtin has done its job, but waits for pager or not waited >> by its caller and still hanging it keeps pack files opened. >> This can cause a number of issues, for e

Re: [PATCH/RFC 2/2] sha1_file: set packfile to O_CLOEXEC at open

2015-10-02 Thread Johannes Schindelin
Hi Max, On 2015-10-01 05:29, Max Kirillov wrote: > Windows does not support setting O_CLOEXEC by fcntl, > but there is an open flag O_NOINHERIT which results in same > behaviour. Use it in git_open_noatime() and also bring > setting O_CLOEXEC there also to make it consistent. Rename > the

[PATCH] Provide a dirname() function when NO_LIBGEN_H=YesPlease

2015-09-30 Thread Johannes Schindelin
()` is a sibling of `basename()`, we simply put our very own `gitdirname()` implementation next to `gitbasename()` and use it if `NO_LIBGEN_H` has been set. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- I stumbled over the compile warning when upgrading Git for W

[PATCH] clone --dissociate: avoid locking pack files

2015-09-28 Thread Johannes Schindelin
. On platforms where a file cannot be deleted if another process still holds a handle on it, we therefore need to take pains to release all pack files and indexes before dissociating. This fixes https://github.com/git-for-windows/git/issues/446 Signed-off-by: Johannes Schindelin <johannes.schi

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Johannes Schindelin
Hi Peff, On 2015-09-28 21:03, Jeff King wrote: > On Mon, Sep 28, 2015 at 04:02:08PM +0200, Johannes Schindelin wrote: > >> @@ -136,7 +139,14 @@ int cmd_prune(int argc, const char **argv, const char >> *prefix) >> if (show_progress) >> p

Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions

2015-09-28 Thread Johannes Schindelin
Hi Karsten, On 2015-09-28 12:39, Karsten Blees wrote: > Different git variants record file times in the index with different > precisions, according to their capabilities. E.g. git compiled with NO_NSEC > records seconds only, JGit records the mtime in milliseconds, but leaves > ctime blank

Re: [PATCH v2 1/4] Add Travis CI support

2015-10-05 Thread Johannes Schindelin
Hi Lars, On 2015-10-04 20:06, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > The tests are executed on "Ubuntu 12.04 LTS Server Edition 64 bit" and > on "OS X Mavericks" using gcc and clang. I think that the word "currently" is missing from this

Re: [PATCH v2 2/4] Consolidate code to close a pack's file descriptor

2015-10-05 Thread Johannes Schindelin
Hi Junio, On 2015-10-05 22:57, Junio C Hamano wrote: > Johannes Schindelin <johannes.schinde...@gmx.de> writes: > >> There was a lot of repeated code to close the file descriptor of >> a given pack. Let's just refactor this code into a single function. >

Announcing Git for Windows 2.5.3

2015-09-18 Thread Johannes Schindelin
Dear Git users, it is my pleasure to announce that Git for Windows 2.5.3 can be downloaded from https://git-for-windows.github.io/. I would like to take this opportunity to thank everybody who contributes to this project (and you will see below that there have been quite a few changes since

Re: Unable to create temporary file '/var/git/tmv3-target-overlay.git/shallow_Un8ZOR': Permission denied

2015-09-23 Thread Johannes Schindelin
Hi Joakim, On 2015-09-22 22:58, Joakim Tjernlund wrote: > On Tue, 2015-09-22 at 22:00 +0200, Johannes Schindelin wrote: >> >> The reason should be easy to understand: Git's concept is based on the idea >> that you have full control over >> your repository. Other repos

[PATCH 4/4] gc: remove broken refs

2015-09-24 Thread Johannes Schindelin
When encountering broken refs, such as a stale remote HEAD (which can happen if the active branch was renamed in the remote), it is more helpful to remove those refs than to exit with an error. This fixes https://github.com/git-for-windows/git/issues/423 Signed-off-by: Johannes Schindelin

Re: What's cooking in git.git (Sep 2015, #06; Wed, 23)

2015-09-24 Thread Johannes Schindelin
Hi Junio, On 2015-09-24 00:56, Junio C Hamano wrote: > * jc/fsck-dropped-errors (2015-09-23) 1 commit > - fsck: exit with non-zero when problems are found > > There were some classes of errors that "git fsck" diagnosed to its > standard error that did not cause it to exit with non-zero

[PATCH 3/4] mark_reachable_objects(): optionally collect broken refs

2015-09-24 Thread Johannes Schindelin
of the function is unchanged if that parameter is `NULL`. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- builtin/prune.c | 2 +- builtin/reflog.c | 2 +- reachable.c | 26 -- reachable.h | 3 ++- 4 files changed, 24 insertions(+), 9 del

[PATCH 2/4] pack-objects: do not get distracted by stale refs

2015-09-24 Thread Johannes Schindelin
It is quite possible for, say, a remote HEAD to become stale, e.g. when the default branch was renamed. We should still be able to pack our objects when such a thing happens; simply ignore invalid refs (because they cannot matter for the packing process anyway). Signed-off-by: Johannes

[PATCH 1/4] gc: demonstrate failure with stale remote HEAD

2015-09-24 Thread Johannes Schindelin
Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- t/t6500-gc.sh | 15 +++ 1 file changed, 15 insertions(+) diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh index 63194d8..b736774 100755 --- a/t/t6500-gc.sh +++ b/t/t6500-gc.sh @@ -30,4 +30,19 @@ test_expect_success

[PATCH 0/4] Fix gc failure when a remote HEAD goes stale

2015-09-24 Thread Johannes Schindelin
repository gets renamed. Git's garbage collector should handle this gracefully. The best this developer could come up with, is to simply ignore and delete the now-broken refs. Johannes Schindelin (4): gc: demonstrate failure with stale remote HEAD pack-objects: do not get distracted by stale

Re: Unable to create temporary file '/var/git/tmv3-target-overlay.git/shallow_Un8ZOR': Permission denied

2015-09-22 Thread Johannes Schindelin
Hi Joakim, On 2015-09-21 19:08, Joakim Tjernlund wrote: > On Mon, 2015-09-21 at 09:48 -0700, Junio C Hamano wrote: >> Duy Nguyen writes: >> >> > Is it really necessary to remove write access in $GIT_DIR? Do we (git >> > devs) have some guidelines about things in $GIT_DIR? >>

Re: Unable to create temporary file '/var/git/tmv3-target-overlay.git/shallow_Un8ZOR': Permission denied

2015-09-19 Thread Johannes Schindelin
Hi Duy, On 2015-09-19 04:21, Duy Nguyen wrote: > On Thu, Sep 17, 2015 at 11:54 PM, Joakim Tjernlund > wrote: >> On Thu, 2015-09-17 at 20:18 +0700, Duy Nguyen wrote: >>> On Mon, Sep 14, 2015 at 10:37 PM, Joakim Tjernlund >>> wrote:

Windows patches roadmap, was Re: On a personal note

2015-09-18 Thread Johannes Schindelin
, Stefan Beller wrote: > On Thu, Sep 17, 2015 at 11:54 AM, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: >> >> And yes, the roadmap is pretty clear from the GitHub tickets, e.g. this one: >> >> https://github.com/git-for-windows/git/issues/285 &

Re: Unable to create temporary file '/var/git/tmv3-target-overlay.git/shallow_Un8ZOR': Permission denied

2015-09-23 Thread Johannes Schindelin
Hi Joakim, On 2015-09-23 22:41, Joakim Tjernlund wrote: > On Wed, 2015-09-23 at 13:10 +0200, Johannes Schindelin wrote: >> >> On 2015-09-22 22:58, Joakim Tjernlund wrote: >> > On Tue, 2015-09-22 at 22:00 +0200, Johannes Schindelin wrote: >> > > >> &

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-25 Thread Johannes Schindelin
Hi, On 2015-09-25 05:14, Dennis Kaarsemaker wrote: > On do, 2015-09-24 at 17:41 -0700, Junio C Hamano wrote: >> larsxschnei...@gmail.com writes: >> >> > My idea is that the owner of "https://github.com/git/git; enables this >> > account >> > for Travis (it's free!). Then we would automatically

Re: Fwd: diff not finding difference

2015-09-25 Thread Johannes Schindelin
Hi Jack Adrian, On 2015-09-24 23:09, Jack Adrian Zappa wrote: > This is a weird one: > > [file-1 begin] > > abcd efg hijklmnop > > [file-1 end] > > [file-2 begin] > > blah blah blah > / > abdc boo ya! > >

[PATCH v3 1/2] gc: demonstrate failure with stale remote HEAD

2015-10-06 Thread Johannes Schindelin
Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- t/t6500-gc.sh | 13 + 1 file changed, 13 insertions(+) diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh index 63194d8..9a3a285 100755 --- a/t/t6500-gc.sh +++ b/t/t6500-gc.sh @@ -30,4 +30,17 @@ test_expect_success

Re: [PATCH] pretend_sha1_file(): Change return type from int to void

2015-10-06 Thread Johannes Schindelin
Hi Tobias, On 2015-10-06 14:15, Tobias Klauser wrote: > prented_sha1_file() always returns 0 and its only callsite in > builtin/blame.c doesn't use the return value, so change the return type > to void. While this commit message is technically correct, it would appear that there are some things

[PATCH v3 0/4] Fix locking issues on Windows with `git clone --dissociate`

2015-10-06 Thread Johannes Schindelin
This is version 3, adding that BUG! message if do_not_close was set. Max, I still hope that this patch series helps also your use case! Interdiff below the diffstat. Johannes Schindelin (4): Demonstrate a Windows file locking issue with `git clone --dissociate` Consolidate code to close

[PATCH v3 3/4] Add a function to release all packs

2015-10-06 Thread Johannes Schindelin
in `free_pack_by_name()` into the `close_pack()` function that is used by the new `close_all_packs()` function to avoid repeated code. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- cache.h | 1 + sha1_file.c | 23 --- 2 files changed, 21 insertions

[PATCH v3 2/4] Consolidate code to close a pack's file descriptor

2015-10-06 Thread Johannes Schindelin
There was a lot of repeated code to close the file descriptor of a given pack. Let's just refactor this code into a single function. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- sha1_file.c | 38 ++ 1 file changed, 18 insertions(

[PATCH v3 4/4] clone --dissociate: avoid locking pack files

2015-10-06 Thread Johannes Schindelin
not need to be run on Linux or MacOSX. It won't hurt, either, though. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- builtin/clone.c| 4 +++- t/t5700-clone-reference.sh | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/builtin/clo

[PATCH v3 1/4] Demonstrate a Windows file locking issue with `git clone --dissociate`

2015-10-06 Thread Johannes Schindelin
On Windows, dissociating from a reference can fail very easily due to pack files that are still in use when they want to be removed. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- t/t5700-clone-reference.sh | 21 + 1 file changed, 21 insertions(+)

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-10-06 Thread Johannes Schindelin
Hi Junio, On 2015-10-06 00:06, Junio C Hamano wrote: > Johannes Schindelin <johannes.schinde...@gmx.de> writes: > >> Oh, I appreciate your feedback. I am actually not all *that* certain >> that removing the broken symref is the correct thing. It is this sort >> of

[PATCH v3 0/2] Fix gc failure when a remote HEAD goes stale

2015-10-06 Thread Johannes Schindelin
repository gets renamed. Thanks to Junio and Peff for their really valuable sanity check. Interdiff re: v2 after the diffstat (3/4 and 4/4 were dropped, I am no longer removing the broken symrefs). Johannes Schindelin (2): gc: demonstrate failure with stale remote HEAD pack-objects: do

[PATCH v3 2/2] pack-objects: do not get distracted by broken symrefs

2015-10-06 Thread Johannes Schindelin
/git-for-windows/git/issues/423 Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- reachable.c | 8 +++- t/t6500-gc.sh | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/reachable.c b/reachable.c index 9cff25b..43616d4 100644 --- a/reachable.c

Re: [PATCH v2 2/4] Consolidate code to close a pack's file descriptor

2015-10-06 Thread Johannes Schindelin
Hi Junio, On 2015-10-06 00:15, Junio C Hamano wrote: > Johannes Schindelin <johannes.schinde...@gmx.de> writes: > >>>> + && !p->do_not_close) >>>> + close_pack_fd(p); >>> >>

Re: [BUG?] parallel make interdepencies

2015-10-06 Thread Johannes Schindelin
Hi Michael, On 2015-10-06 10:12, Michael J Gruber wrote: > "make -j3" just errored out on me, a follow-up "make" succeeded". This > looks like an interdependency issue, but I don't know how to track it: > > GEN git-web--browse > GEN git-add--interactive > GEN git-difftool > mv: der

Re: [PATCH v2 0/4] Add Travis CI support

2015-10-05 Thread Johannes Schindelin
Hi Lars, On 2015-10-04 20:06, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > diff to v1: > * improve readabilty of Travis "before_script" section > * make OS X Perforce brew robust against changing Perforce builds [1] > * add a prereq to detect OS X in

Re: Problems installing git-for-windows

2015-12-07 Thread Johannes Schindelin
Hi Peter, On Mon, 7 Dec 2015, Peter Toye wrote: > Thanks - sorry I didn't report the version number - it was 2.6.3 as you > suggested. I didn't realise that development was so active. Do yo know > when the next version will be stable or should I go for an earlier > version? I am "side-tracked"

Re: Problems installing git-for-windows

2015-12-07 Thread Johannes Schindelin
Hi Peter, On Mon, 7 Dec 2015, Peter Toye wrote: > 1) It wanted to install into my User directory instead of the > Program Files directory, which is the best place for all programs. There has been a regression in Git for Windows 2.6.3 (please *always* state the version when reporting bugs) that

Re: [PATCH] mingw: emulate write(2) that fails with a EPIPE

2015-12-17 Thread Johannes Schindelin
Hi Eric, On Wed, 16 Dec 2015, Eric Sunshine wrote: > On Wednesday, December 16, 2015, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: > > diff --git a/compat/mingw.h b/compat/mingw.h > > @@ -210,6 +210,24 @@ FILE *mingw_freopen (const char *filename, cons

Re: CruiseControl.NET hangs on git-submodule bad file descriptor

2015-12-17 Thread Johannes Schindelin
Hi Alexander, On Thu, 17 Dec 2015, Alexander Skrinnik wrote: > I had installed CruiseControl.NET 1.8.5 and Git-1.9.5-preview20150319 > CC.NET invokes bat-file which invokes > git submodule foreach git checkout "myBranch" > > It worked good. > Today I upgraded git to 2.6.4 and CC.NET fails on

Re: [PATCH] mingw: emulate write(2) that fails with a EPIPE

2015-12-17 Thread Johannes Schindelin
Hi Junio, On Wed, 16 Dec 2015, Junio C Hamano wrote: > Johannes Schindelin <johannes.schinde...@gmx.de> writes: > > > int mingw_fflush(FILE *stream); > > #define fflush mingw_fflush > > > > +static inline ssize_t mingw_write(int fd, const void *buf, size_

Announcing Git for Windows 2.6.4

2015-12-15 Thread Johannes Schindelin
Dear Git users, It is my pleasure to announce that Git for Windows 2.6.4 is available from: https://git-for-windows.github.io/ Changes since Git for Windows v2.6.3 (November 10th 2015) New Features ??? Comes with Git v2.6.4. ??? Also available as .tar.bz2 packages (you need an

Re: [PATCH jk/prune-mtime] prune: close directory earlier during loose-object directory traversal

2015-12-13 Thread Johannes Schindelin
Hi Junio & Peff, On Fri, 11 Dec 2015, Jeff King wrote: > On Fri, Dec 11, 2015 at 11:37:54AM -0800, Junio C Hamano wrote: > > > Jeff King writes: > > > > > On Wed, Aug 12, 2015 at 07:43:01PM +0200, Johannes Sixt wrote: > > > > > >> 27e1e22d (prune: factor out loose-object

RE: CruiseControl.NET hangs on git-submodule bad file descriptor

2015-12-17 Thread Johannes Schindelin
Hi Alexander, you might want to refrain from top-posting on this list in the future. Just sayin' ;-) On Thu, 17 Dec 2015, Alexander Skrinnik wrote: > I found workaround, CC.NET invokes bat-file with command: > git submodule foreach git checkout "myBranch" > It works fine. But looks like the

[PATCH v2] mingw: emulate write(2) that fails with a EPIPE

2015-12-17 Thread Johannes Schindelin
on Windows. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- compat/mingw.c | 17 + compat/mingw.h | 3 +++ 2 files changed, 20 insertions(+) diff --git a/compat/mingw.c b/compat/mingw.c index 90bdb1e..5edea29 100644 --- a/compat/mingw.c +++ b/compat/m

Re: [PATCH] mingw: emulate write(2) that fails with a EPIPE

2015-12-17 Thread Johannes Schindelin
Hi Junio, On Thu, 17 Dec 2015, Junio C Hamano wrote: > Johannes Schindelin <johannes.schinde...@gmx.de> writes: > > > My intuition (which I honestly did not verify using performance tests) was > > that write() is called *much* more often than, say, open(),... &g

[PATCH] mingw: emulate write(2) that fails with a EPIPE

2015-12-16 Thread Johannes Schindelin
on Windows. Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- compat/mingw.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/compat/mingw.h b/compat/mingw.h index 738865c..2aca347 100644 --- a/compat/mingw.h +++ b/compat/mingw.h @@ -210,6 +210,24 @

Re: Where does http.sslcainfo get set in Windows (2.6.3)?

2015-12-15 Thread Johannes Schindelin
Hi, On Mon, 14 Dec 2015, Lars Schneider wrote: > try to look here: > C:\Users\All Users\Git\config The location should be C:\ProgramData\Git\config for the Git configuration shared between all users and all Git implementations on Windows. Maybe you are running Windows XP, where C:\ProgramData

Re: [PATCH 2/2] Fix tyop in the 2.7.0 release notes

2015-12-16 Thread Johannes Schindelin
Hi Gábor, On Wed, 16 Dec 2015, SZEDER Gábor wrote: > /^Subject:/ s/tyop/typo/ That was actually on purpose... I guess I made it a habit in another project to call it tyop from time to time to take out the edge (many scientists are pretty bda at speling ;-)). But sure, if that joke is lost,

Re: Question: Exclusions for AV-Software

2015-12-16 Thread Johannes Schindelin
Hi Roman, On Wed, 16 Dec 2015, ro...@roume.de wrote: > do you have any recommendations how exclusions must be set in an anti > virus software what directories etc.? If you are talking about a Git for Windows installed into C:\Program Files (or even C:\Program Files (x86)), it is safe to exclude

[PATCH 2/2] Fix tyop in the 2.7.0 release notes

2015-12-16 Thread Johannes Schindelin
Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- Documentation/RelNotes/2.7.0.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/RelNotes/2.7.0.txt b/Documentation/RelNotes/2.7.0.txt index a84caba..eb179cc 100644 --- a/Documentation/Re

[PATCH 1/2] t3404: fix typo

2015-12-16 Thread Johannes Schindelin
Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> --- t/t3404-rebase-interactive.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh index 544f9ad..11dde66 100755 --- a/t/t3404-rebase-interact

[PATCH 0/2] Fix two tyops

2015-12-16 Thread Johannes Schindelin
These two grammar fixes are here solely to ramp up my commit count. :-) Johannes Schindelin (2): t3404: fix typo Fix tyop in the 2.7.0 release notes Documentation/RelNotes/2.7.0.txt | 2 +- t/t3404-rebase-interactive.sh| 2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: What's cooking in git.git (Dec 2015, #05; Tue, 15)

2015-12-16 Thread Johannes Schindelin
Hi Junio, On Tue, 15 Dec 2015, Junio C Hamano wrote: > Junio C Hamano writes: > > > There already was strbuf_getline_crlf(), and I wanted a new name to > > be conservative. > > When I re-read the series, I realize that the existing one had > exactly the same semantics as

Re: No auto CRLF conversion in Commit Message comments

2015-12-16 Thread Johannes Schindelin
Hi A.J., On Wed, 16 Dec 2015, Harfoot A.J. wrote: > I'm new to Git, so apologies if this is already available, but after > some searching and experimenting I haven't been able to resolve it. > > I am running Git 2.6.4.windows.1 on Windows 7 64 bit. > > I have the global configuration variable

<    4   5   6   7   8   9   10   11   12   13   >