Duy Nguyen pclo...@gmail.com writes:
On Fri, Mar 7, 2014 at 1:37 AM, Junio C Hamano gits...@pobox.com wrote:
I like what I see in this patch, but I wonder if we can essentially
revert that temporary shallow file patch and replace it with the
same (or a similar) mechanism uniformly?
Using
Duy Nguyen pclo...@gmail.com writes:
On Thu, Mar 6, 2014 at 3:49 PM, Nguyễn Thái Ngọc Duy pclo...@gmail.com
wrote:
diff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh
index 3ae9092..a980574 100755
--- a/t/t5537-fetch-shallow.sh
+++ b/t/t5537-fetch-shallow.sh
@@ -173,4 +173,17
Duy Nguyen pclo...@gmail.com writes:
I don't know the scope of these microprojects, but yes I think it'll
take a few hours for this. By the way, a bit more thought on the idea:
instead of making OPT_BOOL_NONEG() that sets NONEG, we could make
OPT_BOOL_FLAGS(..., NONEG), which is more
Andreas Schwab sch...@linux-m68k.org writes:
Yann Droneaud ydrone...@opteya.com writes:
But I'd like to know if there's a specific reason for git merge to not
support --date and --author ?
It's rather unusual that a merge is performed on behalf of a different
author.
Yes. Michael's
Just like git branch can be told to list the branches that has the
named commit by git branch --with commit, teach the same
short-hand to git tag, so that git tag --with commit shows the
releases with the named commit.
Signed-off-by: Junio C Hamano gits...@pobox.com
---
* After umpteenth time I
Christian Couder chrisc...@tuxfamily.org writes:
This patch implements reading the configuration
to get trailer information, and then processing
it and storing it in a doubly linked list.
Read and process the ..., perhaps?
The config information is stored in the list
whose first item is
Christian Couder chrisc...@tuxfamily.org writes:
* many style fixes
This round is readable ;-) Thanks.
* clearer and nicer setup tests
Those long lines that use printf with many embedded \n were harder
to read and also looked harder to maintain if we ever wanted to
change them. Splicing a
David Kastrup d...@gnu.org writes:
Junio C Hamano gits...@pobox.com writes:
Christian Couder chrisc...@tuxfamily.org writes:
The config information is stored in the list
whose first item is pointed to by:
static struct trailer_item *first_conf_item;
If feels somewhat strange ...
Can't
Andrew Keller and...@kellerfarm.com writes:
diff --git a/Documentation/git-submodule.txt
b/Documentation/git-submodule.txt
index 21cb59a..ea837fd 100644
--- a/Documentation/git-submodule.txt
+++ b/Documentation/git-submodule.txt
...
Also, this file contains mostly high-level
Henri GEIST geist.he...@laposte.net writes:
This information is technical in nature but has some importance for general
users.
As this kind of clone have a separate gitdir, you will have a surprise if you
copy past the worktree as the gitdir will not come together.
I am not sure if I
Julian Brost jul...@0x4a42.net writes:
On 07.03.2014 22:04, Jeff King wrote:
If you want to work on it, I think it's an interesting area. But
any development would need to think about the transition plan for
existing sites that will be broken.
I can understand the problem with backward
Duy Nguyen pclo...@gmail.com writes:
On Sat, Mar 8, 2014 at 1:27 AM, Junio C Hamano gits...@pobox.com wrote:
On the receive-pack side, the comment at the bottom of
preprare_shallow_update() makes it clear that, if we wanted to use
hooks, we cannot avoid having the proposed new shallow-file
Øystein Walle oys...@gmail.com writes:
Junio C Hamano gitster at pobox.com writes:
...
is easier to read and maintain if written like so (with using HT
properly---our MUAs may damage it and turn the indentation into
spaces):
...
sed -e s/ Z$/ / expect -\EOF
Andrew Keller and...@kellerfarm.com writes:
On Mar 7, 2014, at 7:50 PM, Henri GEIST wrote:
...
To give one of my project to someone else I have copied it on a USB key.
By a simple drag and drop with the mouse.
And I am quite sure I am not alone doing this way.
I have done those kind of
Rohit Mani rohit.m...@outlook.com writes:
Avoid scanning strings twice, once with strchr() and then with
strlen(), by using strchrnul().
Thanks. The patch looks good.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More
Jeff King p...@peff.net writes:
On Mon, Mar 10, 2014 at 07:30:45AM -0700, Shawn Pearce wrote:
* Store references in a SQLite database, to get correct transaction
handling.
No to SQLLite in git-core. Using it from JGit requires building
SQLLite and a JNI wrapper, which makes JGit
Henri GEIST geist.he...@laposte.net writes:
Le lundi 10 mars 2014 à 08:31 -0700, Junio C Hamano a écrit :
...
This is not limited to submodules. There are multiple lower-level
mechanisms for a $path/.git to borrow the repository data from
elsewhere outside of $path and a cloned submodule
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
After squashing or fixing up, you may want to have a final look at the
commit, edit some more if needed or even do some testing. --postedit
enables that. This is (to me) a paranoid mode so either I enable it
for all squashes and fixups, or none.
Ilya Bobyr ilya.bo...@gmail.com writes:
On 3/4/2014 11:22 AM, Junio C Hamano wrote:
Ilya Bobyr ilya.bo...@gmail.com writes:
@@ -333,6 +339,7 @@ h,helpshow the help
foo some nifty option --foo
bar= some cool option --bar with an argument
+baz=arg another cool option
Johannes Sixt j.s...@viscovery.net writes:
Am 3/5/2014 1:10, schrieb Junio C Hamano:
* nd/gitignore-trailing-whitespace (2014-02-10) 2 commits
- dir: ignore trailing spaces in exclude patterns
- dir: warn about trailing spaces in exclude patterns
Warn and then ignore trailing
Eric Sunshine sunsh...@sunshineco.com writes:
On Mon, Mar 10, 2014 at 2:49 PM, Benoit Pierre benoit.pie...@gmail.com
wrote:
Add (failing) test: with commit changing the environment to let hooks
now that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does
Junio C Hamano gits...@pobox.com writes:
Documentation on the whole argument parsing is quite short, so, I
though, adding an example just to show how usage is generated would
look like I am trying to make this feature look important than it is
:)
You already are by saying the Angle brackets
Jeff King p...@peff.net writes:
Most of us who compile with -Wall decided a while ago to use
-Wno-format-zero-length, because it really is a silly complaint (it
assumes there are no side effects of the function besides printing the
format string, which is obviously not true in this case).
Jeff King p...@peff.net writes:
I'd say keep it at this point. I think there _are_ some good ideas here,
and part of a project is figuring out what is good. And part of the role
of the mentor is applying some taste.
Amen to that. I hope we have enough mentor-candidates with good
taste,
Jeff King p...@peff.net writes:
I think the main flag of interest is giving an fnmatch pattern to limit
the advertised refs. There could potentially be others, but I do not
know of any offhand.
One thing that comes to mind is where symrefs point at, which we
failed to add the last time around
Fredrik Gustafsson iv...@iveqy.com writes:
On Tue, Mar 11, 2014 at 06:58:11PM +0700, Duy Nguyen wrote:
On Tue, Mar 11, 2014 at 5:45 PM, Fredrik Gustafsson iv...@iveqy.com wrote:
Strbuf needs to be released even if it's locally declared.
path is declared static. So yes it's a leak but the
Paweł Wawruch pa...@aleg.pl writes:
Replace the chain of if statements with table of strings.
Signed-off-by: Paweł Wawruch pa...@aleg.pl
---
I changed the commit message. Logic of table has changed. To make it more
clear I added three dimensions of the table.
I am not sure if the message
Sandy Carter sandy.car...@savoirfairelinux.com writes:
diff --git a/wt-status.c b/wt-status.c
index a452407..69e0dfc 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -264,7 +264,7 @@ static void wt_status_print_unmerged_data(struct
wt_status *s,
case 6: how = _(both added:); break;
Michael Haggerty mhag...@alum.mit.edu writes:
It seems to me that -z input will nearly always be machine-generated,
so there is not much reason to accept the empty string as shorthand for
zeros. So I think that my version of the rules, being simpler to
explain, is a slight improvement. But
Jeff King p...@peff.net writes:
On Tue, Mar 11, 2014 at 12:32:37PM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
I think the main flag of interest is giving an fnmatch pattern to limit
the advertised refs. There could potentially be others, but I do not
know of any
Sandy Carter sandy.car...@savoirfairelinux.com writes:
Le 2014-03-11 15:59, Junio C Hamano a écrit :
Sandy Carter sandy.car...@savoirfairelinux.com writes:
diff --git a/wt-status.c b/wt-status.c
index a452407..69e0dfc 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -264,7 +264,7 @@ static
Dmitry Marakasov amd...@amdmi3.ru writes:
On e.g. FreeBSD 10.x, the following situation is common:
- there's iconv implementation in libc, which has no locale_charset()
function
- there's GNU libiconv installed from Ports Collection
Git build process
- detects that iconv is in libc and
Benoit Pierre benoit.pie...@gmail.com writes:
diff --git a/builtin/checkout.c b/builtin/checkout.c
index 5df3837..da423b2 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -53,10 +53,10 @@ struct checkout_opts {
static int post_checkout_hook(struct commit *old, struct commit
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) test: with commit changing the environment to let hooks
now that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does not work (no editor is launched and the
whole hunk is committed).
Signed-off-by:
brian m. carlson sand...@crustytoothpaste.net writes:
We shrink the source and destination arrays, but not the modes or
submodule_gitfile arrays, resulting in potentially mismatched data. Shrink
all the arrays at the same time to prevent this.
Signed-off-by: brian m. carlson
shawn wilson ag4ve...@gmail.com writes:
Currently, I've got a perl script that modifies the Id line in a smudge
filter:
[filter ident-line]
smudge = /usr/local/bin/githook_ident-filter.pl %f
The problem I've noticed with smudge filters is that it leaves the
repo dirty. How do I fix
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.
Topics that have been cooking in 'next' for 2.0 have been merged to
'master', which means we are committed to make the next one a big
release.
Ilya Bobyr ilya.bo...@gmail.com writes:
I though that an example just to describe `argh' while useful would
look a bit disproportional, compared to the amount of text on
--parseopt.
But now that I've added a Usage text section to looks quite in place.
Good thinking.
I was also wondering
Junio C Hamano gits...@pobox.com writes:
Sorry for back-burnering this topic so long.
I think the following does what you suggested in the message I am
responding to.
Now, hopefully the only thing we need is a documentation update and
the series should be ready to go.
... and here
Duy Nguyen pclo...@gmail.com writes:
By convention, no full stop in the subject line. The subject should
summarize your changes and add ..NONEG is just one part of it. The
other is convert to use ...NONEG. So I suggest parse-options:
convert to use new macro OPT_SET_INT_NONEG() or something
Jacopo Notarstefano jacopo.notarstef...@gmail.com writes:
On Mon, Mar 3, 2014 at 7:34 PM, Junio C Hamano gits...@pobox.com wrote:
I think you fundamentally cannot use two labels that are merely
distinct and bisect correctly. You need to know which ones
(i.e. good) are to be excluded
Duy Nguyen pclo...@gmail.com writes:
On Wed, Mar 12, 2014 at 5:12 AM, Junio C Hamano gits...@pobox.com wrote:
* nd/log-show-linear-break (2014-02-10) 1 commit
- log: add --show-linear-break to help see non-linear history
Attempts to show where a single-strand-of-pearls break in git log
Duy Nguyen pclo...@gmail.com writes:
On Wed, Mar 12, 2014 at 3:26 AM, Junio C Hamano gits...@pobox.com wrote:
Sandy Carter sandy.car...@savoirfairelinux.com writes:
3651e45c takes the colon out of the control of the translators.
That is a separate bug we would need to address, then. Duy
Jonathan Nieder jrnie...@gmail.com writes:
@@ -292,6 +291,48 @@ static const char *wt_status_diff_status_string(int
status)
}
}
+static int maxwidth(const char *(*label)(int), int minval, int maxval)
+{
+ const char *s;
+ int result = 0, i;
+
+ for (i = minval; i
Yuxuan Shui yshu...@gmail.com writes:
On Thu, Mar 13, 2014 at 2:30 AM, Junio C Hamano gits...@pobox.com wrote:
Duy Nguyen pclo...@gmail.com writes:
By convention, no full stop in the subject line. The subject should
summarize your changes and add ..NONEG is just one part of it. The
other
Here is another, as I seem to have managed to kill another one ;-)
-- 8 --
VAR=VAL command is sufficient to run 'command' with environment
variable VAR set to value VAL without affecting the environment of
the shell itself, but we cannot do the same with a shell function
(most notably,
, make sure label strings have the trailing colon
that can be localized, and use it when showing the section labels in
the output.
cf. http://bugs.debian.org/725777
Signed-off-by: Jonathan Nieder jrnie...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
* Differences relative
Jeff King p...@peff.net writes:
static inline int standard_header_field(const char *field, size_t len)
{
-return ((len == 4 !memcmp(field, tree , 5)) ||
-(len == 6 !memcmp(field, parent , 7)) ||
-(len == 6 !memcmp(field, author , 7)) ||
-(len ==
Yuxuan Shui yshu...@gmail.com writes:
The purpose of skip_prefix() is much clearer than memcmp(). Also
skip_prefix() takes one less argument and its return value makes
more sense.
Instead of justifying the change with a subjective-sounding and
vague much clearer and makes more sense, perhaps
Jeff King p...@peff.net writes:
On Tue, Mar 11, 2014 at 03:12:11PM -0700, Junio C Hamano wrote:
* jk/warn-on-object-refname-ambiguity (2014-01-09) 6 commits
- get_sha1: drop object/refname ambiguity flag
- get_sha1: speed up ambiguous 40-hex test
- FIXUP: teach DO_FOR_EACH_NO_RECURSE
Jeff King p...@peff.net writes:
Blindly replacing starts_with() with !memcmp() in the above part is
a readability regression otherwise.
I actually think the right solution is:
static inline int standard_header_field(const char *field, size_t len)
{
return mem_equals(field,
Sandy Carter sandy.car...@savoirfairelinux.com writes:
Le 2014-03-12 15:22, Junio C Hamano a écrit :
static const char *wt_status_diff_status_string(int status)
{
switch (status) {
case DIFF_STATUS_ADDED:
-return _(new file);
+return _(new file
Orgad Shaneh org...@gmail.com writes:
+--verbose::
+ This option is valid for add and update commands. Display the progress
+ of the actual submodule checkout.
Hmm, is the valid for add and update part we want to keep? I do
not think it is a crime if some other subcommand accepted
Sandy Carter sandy.car...@savoirfairelinux.com writes:
Seems fine except for the bit about returning _(bug), which I brought up.
Seems to do the same thing as my proposal without changing the
alignment of paths in of regular status output. No changes to tests
necessary, less noisy.
It
in
3651e45c for the tracked paths, while retaining the at least 20
columns floor to avoid the churn to the tests.
And the last lifts the at least 20 columns floor.
Jonathan Nieder (2):
wt-status: extract the code to compute width for labels
wt-status: i18n of section labels
Junio C Hamano (2
for some languages,
e.g. ones that want to have spaces around the colon.
Also introduce a static label_width to avoid having to run
strlen(padding) over and over.
Signed-off-by: Junio C Hamano gits...@pobox.com
---
wt-status.c | 35 +--
1 file changed, 17
...@gmail.com
Helped-by: Sandy Carter
Signed-off-by: Junio C Hamano gits...@pobox.com
---
wt-status.c | 66 +++--
1 file changed, 47 insertions(+), 19 deletions(-)
diff --git a/wt-status.c b/wt-status.c
index db98c52..b1b018e 100644
--- a/wt
From: Jonathan Nieder jrnie...@gmail.com
From: Jonathan Nieder jrnie...@gmail.com
Date: Thu, 19 Dec 2013 11:43:19 -0800
Signed-off-by: Junio C Hamano gits...@pobox.com
---
wt-status.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/wt-status.c b/wt
string is longer than 20 columns.
Just drop the artificial floor. The screen real estate is better
utilized this way when all the strings are shorter.
Adjust the tests to this change.
Signed-off-by: Junio C Hamano gits...@pobox.com
---
t/t7060-wtstatus.sh| 14 +++---
t/t7512-status
Jeff King p...@peff.net writes:
Thanks, I think this is a real readability improvement in most cases.
...
I tried:
perl -i -lpe '
s/memcmp\(([^,]+), (.*?), (\d+)\)/
length($2) == $3 ?
qq{!starts_with($1, $2)} :
$
/ge
' $(git ls-files '*.c')
That comes
Jeff King p...@peff.net writes:
So I think the whole function could use some refactoring to handle
corner cases better. I'll try to take a look tomorrow, but please
feel free if somebody else wants to take a crack at it.
Yup, thanks.
--
To unsubscribe from this list: send the line
Quint Guvernator quintus.pub...@gmail.com writes:
The result after the conversion, however, still have the same magic
numbers, but one less of them each. Doesn't it make it harder to
later spot the patterns to come up with a better abstraction that
does not rely on the magic number?
It is
David Kastrup d...@gnu.org writes:
Junio C Hamano gits...@pobox.com writes:
Taking two random examples from an early and a late parts of the
patch:
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -82,7 +82,7 @@ static int cat_one_file(int opt, const char *exp_type,
const char
Thanks ;-)
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Eric Sunshine sunsh...@sunshineco.com writes:
Shouldn't this logic [to decide what the printf arguments should
be] also be encoded in the table?
...
The same argument also applies to computation of the 'name' variable
above. It too can be pushed into the the table.
Because the printf
Michael Haggerty mhag...@alum.mit.edu writes:
It seems to me that we can infer which mark is which from the normal
bisect user interaction. At the startup phase of a bisect, there are
only three cases:
1. There are fewer than two different types of marks on tested commits.
For example,
Duy Nguyen pclo...@gmail.com writes:
On Sat, Mar 8, 2014 at 2:20 AM, Junio C Hamano gits...@pobox.com wrote:
Looking at git grep -B3 OPT_NONEG output, it seems that NONEG is
associated mostly with OPTION_CALLBACK and OPTION_SET_INT in the
existing code.
Perhaps OPT_SET_INT should default
Yuxuan Shui yshu...@gmail.com writes:
Since fsck_ident doesn't change the content of **ident, the type of
ident could be const char **.
This change is required to rewrite fsck_commit() to use skip_prefix().
Signed-off-by: Yuxuan Shui yshu...@gmail.com
---
It may not be a bad idea to read
Yuxuan Shui yshu...@gmail.com writes:
Currently we use memcmp() in fsck_commit() to check if buffer start
with a certain prefix, and skip the prefix if it does. This is exactly
what skip_prefix() does. And since skip_prefix() has a self-explaintory
name, this could make the code more
Junio C Hamano gits...@pobox.com writes:
-if (memcmp(buffer, tree , 5))
+buffer = skip_prefix(buffer, tree );
+if (buffer == NULL)
We encourage people to write this as:
if (!buffer)
The same comment applies to other new lines in this patch.
I also see a lot
Eric Sunshine sunsh...@sunshineco.com writes:
+Prepare a request to your upstream project to pull your changes to
+their tree to the standard output, by summarizing your changes and
+showing where your changes can be pulled from.
Perhaps splitting this into two sentence (and using fewer
Jeff King p...@peff.net writes:
There are a few ways around this:
1. Add a new phase Writing packs which counts from 0 to 1. Even
though it's more accurate, moving from 0 to 1 really isn't that
useful (the throughput is, but the 0/1 just looks like noise).
2. Add a new phase
John Butterfield johnb...@gmail.com writes:
Has there been any talk about adding a stub for git subtrees in .git/config?
I do not think so, and that is probably for a good reason.
A subtree biding can change over time, but .git/config is about
recording information that do not change depending
Eric Sunshine sunsh...@sunshineco.com writes:
Thanks for the resubmission. Comments below.
Thanks, Eric, for helping so many micro exercises.
On Thu, Mar 13, 2014 at 4:20 PM, Yao Zhao zhaox...@umn.edu wrote:
Subject: [PATCH] GSoC Change multiple if-else statements to be table-driven
It's a
Quint Guvernator quintus.pub...@gmail.com writes:
I'll be re-reading this thread and working on this patch over the
weekend to try to identify the more straightforward hunks I could
submit in a patch.
Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a
Andrew Wong andrew.k...@gmail.com writes:
On Fri, Mar 14, 2014 at 10:33 AM, Marc Branchaud marcn...@xiplink.com wrote:
I know this approach was suggested earlier, but given these dangers it seems
silly to give this big warning on a plain git reset but still go ahead and
do the things the
Jeff King p...@peff.net writes:
On Sat, Mar 01, 2014 at 12:01:44PM +0100, Matthieu Moy wrote:
Jeff King p...@peff.net writes:
If we had the keys in-memory, we could reverse this: config code asks
for keys it cares about, and we can do an optimized lookup (binary
search, hash, etc).
Jeff King p...@peff.net writes:
One option would be to _always_ define test_terminal
That looks like the right direction to go.
Something like the patch below (looks like we should be using $PERL_PATH
instead of perl, too).
;-) Also a SP between test_terminal and (), perhaps.
diff
Jeff King p...@peff.net writes:
On Fri, Mar 14, 2014 at 02:47:14PM -0700, Junio C Hamano wrote:
Something like the patch below (looks like we should be using $PERL_PATH
instead of perl, too).
Actually, we don't need to do this, as of 94221d2 (t: use perl instead
of $PERL_PATH where
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.
More topics merged to 'master', some of which have been cooking
before the v1.9.0 final release.
You can find the changes described here in
Jeff King p...@peff.net writes:
On Sat, Mar 15, 2014 at 05:05:29PM +0100, Thomas Rast wrote:
diff --git a/builtin/mv.c b/builtin/mv.c
index f99c91e..b20cd95 100644
--- a/builtin/mv.c
+++ b/builtin/mv.c
@@ -230,6 +230,11 @@ int cmd_mv(int argc, const char **argv, const char
*prefix)
Junio C Hamano gits...@pobox.com writes:
Would it make sense to go one step further to introduce two macros
to make this kind of screw-up less likely?
...
After letting my eyes coast over hits from git grep memmove, there
do seem to be some places that these would help readability
Tim Chase g...@tim.thechases.com writes:
Is this just an interface inconsistency or is there a some technical
reason this doesn't work (or, has it been addressed/fixed, and just
not pulled into Debian Stable's 1.7.10.4 version of git)?
It is merely that nobody thought rebase would benefit
Chris Packham judge.pack...@gmail.com writes:
Ping?
Hasn't it been already cooking in 'next' for a few days?
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Eric Sunshine sunsh...@sunshineco.com writes:
Perhaps it is time to mark this microproject as taken on the GSoC
page [2], along a fews others for which we have received multiple
submissions.
[2]:
https://github.com/git/git.github.io/blob/master/SoC-2014-Microprojects.md
I actually have
Torsten Bögershausen tbo...@web.de writes:
On 2014-03-14 23.09, Junio C Hamano wrote:
* ap/remote-hg-skip-null-bookmarks (2014-01-02) 1 commit
- remote-hg: do not fail on invalid bookmarks
Reported to break tests ($gmane/240005)
Expecting a reroll.
I wonder what should happen here
Philip Oakley philipoak...@iee.org writes:
* po/git-help-user-manual (2014-02-18) 1 commit
- Provide a 'git help user-manual' route to the docbook
I am not sure if this is even needed.
My rhetorical question would be what should 'git help user-manual'
do? for the beginner, ...
Why would
Ramkumar Ramachandra artag...@gmail.com writes:
... I'd first fix the main issue: stale content. I'm not sure
who uses git show-branch or mailx anymore, for instance.
Unfortunately, I haven't seen a representation better than what
show-branch gives me when assessing what needs to happen during
Duy Nguyen pclo...@gmail.com writes:
There are two minor fixes [1] [2] on top of v5, but I'm not going to
send v6 again unless I see more substantial changes. Just give me a
signal or something before you merge to next so I have a chance to fix
them if v6 never comes.
[1]
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
In the previous patch, git_snpath() is modified to allocate a new
strbuf buffer because vsnpath() needs that. But that makes it awkward
because git_snpath() receives a pre-allocated buffer from outside and
has to copy data back. Rename it to
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) tests: with commit changing the environment to let hooks
know that no editor will be used (by setting GIT_EDITOR to :), the
edit hunk functionality does not work (no editor is launched and the
whole hunk is committed).
Benoit Pierre benoit.pie...@gmail.com writes:
+test_expect_failure 'edit hunk commit -p -m message' '
+ test_when_finished rm -f editor_was_started
Not just when finished, run rm -f here to make sure that the
file does not exist. Later other people may add new tests before
this test
Michael Haggerty mhag...@alum.mit.edu writes:
On 03/17/2014 08:31 AM, Junio C Hamano wrote:
So in short, yes it would have been nicer if we had more micros than
candidates, but I do not think it was detrimental for the purpose of
these micro exercises that multiple candidates ended up
Uwe Storbeck u...@ibr.ch writes:
to avoid shell dependent behavior.
Please do not start the body of the log message half-sentence. The
title ought to be a freestanding title, not just a beginning half
of a sentence that needs to be read with the rest to be understood.
Something like this,
Jonathan Nieder jrnie...@gmail.com writes:
Uwe Storbeck wrote:
Backslash sequences are interpreted as control characters
by the echo command of some shells (e.g. dash).
This has bothered me for a while but never enough to do anything about
it. Thanks for fixing it.
Signed-off-by: Uwe
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
---
v2 renames the option name to --nonlinear-barrier and fixes using it
with --dense. Best used with --no-merges to see patch series.
I think that the earlier name show linear-break is
a stray environment variable.
Make sure all the variables that can be assigned in the command line
parsing are initialized to empty.
Signed-off-by: Junio C Hamano gits...@pobox.com
---
contrib/subtree/git-subtree.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/subtree/git-subtree.sh b
David Tran unsignedz...@gmail.com writes:
Fixed the broken -chain and the tests run correctly. The double env is
fixed to be a single env. The useless subshells are removed.
...
Hmph.
test_expect_success 'need valid notes ref' '
- (MSG=1 GIT_NOTES_REF=/ export MSG GIT_NOTES_REF
-
Benoit Pierre benoit.pie...@gmail.com writes:
On Mon, Mar 17, 2014 at 7:49 PM, Junio C Hamano gits...@pobox.com wrote:
Benoit Pierre benoit.pie...@gmail.com writes:
Add (failing) tests: with commit changing the environment to let hooks
know that no editor will be used (by setting GIT_EDITOR
Benoit Pierre benoit.pie...@gmail.com writes:
Isn't the point of using when finished to have each test leave the
tree clean after execution, to avoid bleeding onto the next test(s)?
But you cannot anticipate what other people will do in the future
before you have a chance to run this piece.
701 - 800 of 27729 matches
Mail list logo
