On 8 August 2017 at 09:48, Nicolas Morey-Chaisemartin
wrote:
> Up to this point, the curl mode only supported getting the username
> and password from the gitconfig file while the legacy mode could also
> fetch them using the credential API.
>
> Signed-off-by:
On 7 August 2017 at 23:12, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> The series looks fine to me overall, though patch 5 is overly gentle IMHO.
>> We could have removed it right there as Junio is very good at resolving
>> conflicts or producing
s://public-inbox.org/git/1439998007-28719-1-git-send-email-dborow...@google.com/T/#m6533a6c4707a30b0d81e86169ff8559460cbf6eb
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Documentation/git-push.txt | 4 ++--
Documentation/git-send-pack.txt | 4 ++--
2 files changed, 4
and diff.colormoved consistent with
other booleans. That should be a good thing, but cc Stefan to be sure.
Martin
[1] https://public-inbox.org/git/xmqq7fotd71o@gitster.dls.corp.google.com/
Martin Ågren (6):
Doc/git-{push,send-pack}: correct --sign= to --signed=
t5334: document that git push --si
y renaming git_parse_maybe_bool to ..._text
and reimplementing the first one as a simple call to the second one. Let
the existing users in config.c use ..._text, since it does what they
need.
[1] https://public-inbox.org/git/xmqq7fotd71o@gitster.dls.corp.google.com/
Signed-off-by: Martin Ågren <martin.ag
it as deprecated in the
technical documentation. While at it, document git_parse_maybe_bool.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Documentation/technical/api-config.txt | 4
builtin/log.c | 4 ++--
builtin/merge.c
. The --signed option has a different notion of
boolean than all other arguments and config options, including the
config option corresponding to it, push.gpgSign.
Add a test documenting the failure to handle --signed=1.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
t/t5534-push-signed.
quot;config" into "parse" and make the latter a
trivial wrapper.
This also fixes the only user of git_parse_maybe_bool, `git push
--signed=..`.
[1] https://public-inbox.org/git/xmqq7fotd71o....@gitster.dls.corp.google.com/
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
The previous commit left it unused.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
builtin/log.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 9182f0ee3..483d15a94 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@
On 7 August 2017 at 19:10, Nicolas Morey-Chaisemartin
<nico...@morey-chaisemartin.com> wrote:
>
>
> Le 07/08/2017 à 18:37, Martin Ågren a écrit :
>> On 7 August 2017 at 16:04, Nicolas Morey-Chaisemartin
>> <nico...@morey-chaisemartin.com> wrote:
>>> Signe
On 7 August 2017 at 19:04, Nicolas Morey-Chaisemartin
<nico...@morey-chaisemartin.com> wrote:
>
>
> Le 07/08/2017 à 18:30, Martin Ågren a écrit :
>> On 7 August 2017 at 16:03, Nicolas Morey-Chaisemartin
>> <nico...@morey-chaisemartin.com> wrote:
>>> Signe
On 7 August 2017 at 16:04, Nicolas Morey-Chaisemartin
wrote:
> Signed-off-by: Nicolas Morey-Chaisemartin
> ---
> imap-send.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index
On 7 August 2017 at 16:04, Nicolas Morey-Chaisemartin
wrote:
> Signed-off-by: Nicolas Morey-Chaisemartin
> ---
> imap-send.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git
On 7 August 2017 at 16:03, Nicolas Morey-Chaisemartin
wrote:
> Signed-off-by: Nicolas Morey-Chaisemartin
> ---
> imap-send.c | 38 --
> 1 file changed, 24 insertions(+), 14 deletions(-)
>
> diff
On 4 August 2017 at 18:00, Junio C Hamano <gits...@pobox.com> wrote:
> Martin Ågren <martin.ag...@gmail.com> writes:
>
>> Since this is my first code contribution to Git, I'll ask about this part of
>> SubmittingPatches:
>>
>> "After the list reac
On 3 August 2017 at 21:29, Jeff King <p...@peff.net> wrote:
> On Wed, Aug 02, 2017 at 09:40:48PM +0200, Martin Ågren wrote:
>
>> This is the third version of my attempt to make `pager tag` useful (v1
>> at [1], v2 at [2]). Thanks to Junio and Peff for comments on v2.
&
On 3 August 2017 at 19:44, Junio C Hamano <gits...@pobox.com> wrote:
> Martin Ågren <martin.ag...@gmail.com> writes:
>> + * . Add `builtin/foo.o` to `BUILTIN_OBJS` in `Makefile`.
>
> Not a new problem but it will become much easier to follow if we
> moved this item
ias, it doesn't get the chance to do so, as outlined above.
That recent patch added a test to document this breakage.
Do not check `pager.foo` before launching a builtin as a dashed
external, i.e., if we recognize the name of the external as a builtin.
Change the test to use `test_expect_success`
rt
users of `git tag -a` as it would have before. Make that change. Update
documentation and tests.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Documentation/git-tag.txt | 2 +-
t/t7006-pager.sh | 28 ++--
builtin/tag.c | 2 +-
3 files cha
-by: Anatoly Borodin <anatoly.boro...@gmail.com>
Suggested-by: Jeff King <p...@peff.net>
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Documentation/git-tag.txt | 3 +++
t/t7006-pager.sh | 15 ++-
builtin/tag.c | 3 +++
git.c
see whether the pager is used or not. Make one of the tests
demonstrate the broken behavior mentioned above, where `git tag -a`
respects `pager.tag`.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
In one place, I now use test_expect_failure (t
ager just yet, one will follow in
a later patch.
Suggested-by: Jeff King <p...@peff.net>
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
builtin.h | 12
git.c | 10 ++
2 files changed, 22 insertions(+)
diff --git a/builtin.h b/builtin.h
index 0f3a7b7
d_external()`. That
call site is arguably wrong, although in a way that is not yet visible,
and will be changed in a slightly different direction in a later patch.
Don't add any users of DELAY_PAGER_CONFIG just yet, one will follow in a
later patch.
Suggested-by: Jeff King <p...@peff.net>
Signe
mentation up to
date with the available flags.
While at it, correct '3 more things to do' to '4 more things to do'.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
I'm still documenting SUPPORT_SUPER_PREFIX. As Junio pointed out, a
nearby patch series is working on losing it (o
[1] https://public-inbox.org/git/cover.1499723297.git.martin.ag...@gmail.com/T/
[2]
https://public-inbox.org/git/cover.1500321657.git.martin.ag...@gmail.com/T/#u
Martin Ågren (7):
builtin.h: take over documentation from api-builtin.txt
git.c: let builtins opt for handling `pager.fo
On 31 July 2017 at 18:37, Junio C Hamano wrote:
> Jeff King writes:
>
>> But here...
>>
>>> +test_expect_success TTY 'git tag -a respects pager.tag' '
>>> +test_when_finished "git tag -d newtag" &&
>>> +rm -f paginated.out &&
>>> +test_terminal git
On 31 July 2017 at 05:45, Jeff King <p...@peff.net> wrote:
> On Mon, Jul 17, 2017 at 10:10:52PM +0200, Martin Ågren wrote:
>
>> One could address this in run_argv(), by making the second call to
>> execv_dashed_external() conditional on "!is_builtin()" whereas a b
On 31 July 2017 at 05:46, Jeff King <p...@peff.net> wrote:
> On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote:
>
>> On 21 July 2017 at 00:27, Junio C Hamano <gits...@pobox.com> wrote:
>> > I tend to agree with you that 1-3/10 may be better off being a
&
On 21 July 2017 at 00:27, Junio C Hamano wrote:
> I tend to agree with you that 1-3/10 may be better off being a
> single patch (or 3/10 dropped, as Brandon is working on losing it
> nearby). I would have expected 7-8/10 to be a single patch, as by
> the time a reader reaches
1. s/unit64_t/uint64_t/
2. add const-qualifier to *p
3. add missing closing ')'
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Applies to pu and passes the tests. I think this should be squashed in
somewhere. Perhaps a mismerge in commit d553324d ("Merge branch
'bp/fsmonit
On 21 July 2017 at 14:59, Uwe Hausbrand wrote:
> git config gc.rerereresolved "60 days"
> git gc
>
> results in:
[...]
> fatal: bad numeric config value '60 days' for 'gc.rerereresolved': invalid
> unit
> error: failed to run rerere
It's not entirely clear, but "man
On 20 July 2017 at 11:20, Marcel Partap wrote:
> So the readline library powers the advanced line editing capabilities behind
> f.e. the bash or the ipython shell. Besides navigating with the cursor keys,
> it provides a history function accessible by the up cursor key ⌨⬆ .
>
On 20 July 2017 at 10:21, Marcel Partap wrote:
> wouldn't it be great to have the power of readline added to the power of git
> interactive commands? Yes, rlwrap will do the job, but still.
> Or am I missing something obvious?
Well maybe *I* am missing something obvious. :)
On 20 July 2017 at 02:54, Tillson Galloway wrote:
> Context:
> We currently have a git project with a root directory ("~/project")
> for pipelines and deployment of a Node app, and then a subdirectory
> ("~/project/project-app").
> After realizing that we didn't need
ias, it doesn't get the chance to do so, as outlined above.
That recent patch added a test to document this breakage.
Do not check `pager.foo` before launching a builtin as a dashed
external, i.e., if we recognize the name of the external as a builtin.
Change the test to use `test_expect_success`
this known breakage. It will be fixed in a later
commit. Add a similar test for `-l`, which works as it should.
Noticed-by: Anatoly Borodin <anatoly.boro...@gmail.com>
Suggested-by: Jeff King <p...@peff.net>
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Documentation/
ous usages.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
builtin/tag.c | 2 ++
git.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 01154ea8d..9eda434fb 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -461
rt
users of `git tag -a` as it would have before. Make that change. Update
documentation and tests.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Documentation/git-tag.txt | 2 +-
t/t7006-pager.sh | 28 ++--
builtin/tag.c | 2 +-
3 files cha
, where
`git tag -a` respects `pager.tag`. Actually, the tests use `git tag -am`
so no editor is launched, but that is irrelevant, since we just want to
see whether the pager is used or not.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
t/t7006-pager.sh | 68 ++
.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Documentation/technical/api-builtin.txt | 73 ---
builtin.h | 76 +
2 files changed, 76 insertions(+), 73 deletions(-)
delete mode 100644 Documen
gs.
While at it, correct '3 more things to do' to '4 more things to do'.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
builtin.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/builtin.h b/builtin.h
index 62f22b547..7bcc08456 100644
--- a/builtin.h
+++ b/builtin.h
ager just yet, one will follow in
a later patch.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
builtin.h | 9 +
git.c | 10 ++
2 files changed, 19 insertions(+)
diff --git a/builtin.h b/builtin.h
index 4186635de..3ca4a53a8 100644
--- a/builtin.h
+++ b/b
The previous commit moved technical documentation verbatim into
builtin.h. Prefix all the lines with '*' to follow the coding
guidelines.
Remove a '+' which was needed when the information was formatted for
AsciiDoc. Similarly, change "::" to ":".
Signed-off-by: Mar
gested-by: Jeff King <p...@peff.net>
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
builtin.h | 8
git.c | 4 +++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/builtin.h b/builtin.h
index 7bcc08456..4186635de 100644
--- a/builtin.h
pect_failure` which this patch
then fixes.
Martin
[1] https://public-inbox.org/git/cover.1499723297.git.martin.ag...@gmail.com/T/
Martin Ågren (10):
builtin.h: take over documentation from api-builtin.txt
builtin.h: format documentation-comment properly
builtin.h: document SUPPORT_SUPER_PR
On 11 July 2017 at 00:42, Junio C Hamano <gits...@pobox.com> wrote:
> Martin Ågren <martin.ag...@gmail.com> writes:
>> I am not moving all builtins to handling the pager on their own,
>> but instead introduce a flag IGNORE_PAGER_CONFIG and use it only
>> with th
On 11 July 2017 at 12:19, Jeff King <p...@peff.net> wrote:
> On Mon, Jul 10, 2017 at 11:55:13PM +0200, Martin Ågren wrote:
>
>> Using, e.g., `git -c pager.tag tag -a new-tag` results in errors such
>> as "Vim: Warning: Output is not to a terminal" and a garbled
On 11 July 2017 at 12:41, Jeff King <p...@peff.net> wrote:
> On Mon, Jul 10, 2017 at 11:55:19PM +0200, Martin Ågren wrote:
>
>> diff --git a/builtin/tag.c b/builtin/tag.c
>> index e0f129872..e96ef7d70 100644
>> --- a/builtin/tag.c
>> +++ b/builtin/tag.c
>>
On 11 July 2017 at 12:37, Jeff King <p...@peff.net> wrote:
> On Mon, Jul 10, 2017 at 11:55:16PM +0200, Martin Ågren wrote:
>
>> +void setup_auto_pager(const char *cmd, int def)
>> +{
>> + if (use_pager != -1)
>> + return;
>
> I think y
On 11 July 2017 at 12:24, Jeff King <p...@peff.net> wrote:
> On Mon, Jul 10, 2017 at 11:55:15PM +0200, Martin Ågren wrote:
>
>> To allow individual builtins to make more informed decisions about when
>> to respect `pager.foo`, introduce a flag IGNORE_PAGER_CONFIG. I
On 11 July 2017 at 00:50, Brandon Williams <bmw...@google.com> wrote:
> On 07/10, Martin Ågren wrote:
>> Commit 74866d75 ("git: make super-prefix option", 2016-10-07) introduced
>> SUPPORT_SUPER_PREFIX as a builtin flag without documenting it in
>> api-builtin
The previous patch introduced `pager.tag.list`. Its default was to use
the value of `pager.tag` or, if that was also not set, to fall back to
"off".
Change that fallback value to "on". Let the default value for
`pager.tag` remain at "off". Update documentation and
n tree which carefully ensures that
setup_auto_pager() is called precisely once. A greedy approach such as
the one taken here works just fine.
Noticed-by: Anatoly Borodin <anatoly.boro...@gmail.com>
Suggested-by: Jeff King <p...@peff.net>
Signed-off-by: Martin Ågren <martin.ag...@g
erroneous usages.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
builtin/tag.c | 2 ++
git.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 01154ea8d..e0f129872 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
applies to two code-paths -- one
in run_builtin() and one in execv_dashed_external().
Document the flag in api-builtin.txt.
Don't add any users of IGNORE_PAGER_CONFIG just yet, one will follow in a
later patch.
Suggested-by: Jeff King <p...@peff.net>
Signed-off-by: Martin Ågr
ich case no editor is launched, but that is irrelevant,
since we just want to see whether the pager is used or not. (If `git tag
-am` ever learns to avoid the pager, these tests will need to be
updated and two of them will fail.)
Signed-off-by: Martin Ågren <martin.ag...@gmai
we split at the first or last '.', so it seems just as
easy, and certainly more flexible, to handle the more general situation.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
builtin.h | 14 ++
git.c | 28
2 files changed, 42 ins
able flags.
Signed-off-by: Martin Ågren <martin.ag...@gmail.com>
---
Documentation/technical/api-builtin.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/technical/api-builtin.txt
b/Documentation/technical/api-builtin.txt
index 22a39b929..60f442822 100644
---
hat's definitely outside this
series, but should not be prohibited by it...
A review would be much appreciated. Comments on the way I structured the series
would be just as welcome as ones on the final result.
Martin
[1] https://public-inbox.org/git/nrmbrl$hsk$1...@blaine.gmane.org/T/
Martin Ågren (7)
On 9 July 2017 at 16:01, René Scharfe <l@web.de> wrote:
> Am 09.07.2017 um 15:25 schrieb Martin Ågren:
>> On 8 July 2017 at 12:35, René Scharfe <l@web.de> wrote:
>>> Convert code that divides and rounds up to use DIV_ROUND_UP to make the
>>> intent
On 8 July 2017 at 12:35, René Scharfe wrote:
> Convert code that divides and rounds up to use DIV_ROUND_UP to make the
> intent clearer and reduce the number of magic constants.
...
> diff --git a/sha1_name.c b/sha1_name.c
> index e7f7b12ceb..8c513dbff6 100644
> --- a/sha1_name.c
>
On 9 June 2017 at 10:53, Ævar Arnfjörð Bjarmason wrote:
> Replace occurrences of `free(p); p = NULL` with `freez(p)`. This
> introduces no functional changes, but cuts the number of lines spent
> on this cleanup in half.
It's even better than that. ;)
> 48 files changed, 97
On 2 June 2017 at 21:32, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote:
> On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren <martin.ag...@gmail.com> wrote:
>> On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote:
>>> On Fri, Jun 2, 2
On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote:
> On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano <gits...@pobox.com> wrote:
>> Martin Ågren <martin.ag...@gmail.com> writes:
>>
>>> I looked into this some more. It turns out it is
On 1 June 2017 at 13:53, Martin Ågren <martin.ag...@gmail.com> wrote:
> On 1 June 2017 at 12:33, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote:
>> On Thu, Jun 1, 2017 at 12:26 PM, Martin Ågren <martin.ag...@gmail.com> wrote:
>>> On 1 June 2017 at 12:08, A
On 1 June 2017 at 12:33, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote:
> On Thu, Jun 1, 2017 at 12:26 PM, Martin Ågren <martin.ag...@gmail.com> wrote:
>> On 1 June 2017 at 12:08, Andreas Schwab <sch...@suse.de> wrote:
>>> Even if the architecture imple
On 1 June 2017 at 12:08, Andreas Schwab wrote:
> On Jun 01 2017, Junio C Hamano wrote:
>
>> Depending on the model of "ARM" (or "SPARC") emulated with QEMU, and
>> depending on the OS that runs on such an "ARM" or "SPARC", we may
>> not see this---if the
501 - 567 of 567 matches
Mail list logo