[PATCH v3 32/56] add_ref_decoration(): convert local variable original_sha1 to object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- log-tree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/log-tree.c b/log-tree.c index abf5cc3..01beb11

[PATCH v3 48/56] mark_complete(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- walker.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/walker.c b/walker.c index bb2e0b9..44a936c

[PATCH v3 36/56] register_replace_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- replace_object.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/replace_object.c b/replace_object.c index

[PATCH v3 51/56] mark_complete(): remove unneeded arguments

From: Michael Haggerty mhag...@alum.mit.edu Now that the function is not being used as an each_ref_sha1_fn, we can delete the unused arguments in its signature. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- fetch-pack.c | 6

[PATCH v3 31/56] add_ref_decoration(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- log-tree.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/log-tree.c b/log-tree.c index 1a0e170

[PATCH v3 45/56] find_symref(): convert local variable unused to object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- upload-pack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/upload-pack.c b/upload-pack.c index 96dbedc

[PATCH v3 56/56] struct ref_lock: convert old_sha1 member to object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/refs.c b/refs.c index 7515c2e

[PATCH v3 46/56] upload-pack: rewrite functions to take object_id arguments

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- upload-pack.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/upload-pack.c b

[PATCH v3 49/56] clear_marks(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- fetch-pack.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/fetch-pack.c b/fetch-pack.c index

[PATCH v3 53/56] rev_list_insert_ref(): remove unneeded arguments

From: Michael Haggerty mhag...@alum.mit.edu Now that the function is not being used as an each_ref_sha1_fn, we can delete the unused arguments in its signature. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- fetch-pack.c | 6

[PATCH v3 41/56] submodule: rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- submodule.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/submodule.c b/submodule.c

[PATCH v3 28/56] append_similar_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- help.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/help.c b/help.c index f813093..6f3415b 100644

[PATCH v3 47/56] send_ref(): convert local variable peeled to object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- upload-pack.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/upload-pack.c b/upload-pack.c index 929284f

[PATCH v3 52/56] rev_list_insert_ref_oid(): new function, taking an object_oid

From: Michael Haggerty mhag...@alum.mit.edu This function can be used with for_each_ref() without having to be wrapped. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- fetch-pack.c | 10 +++--- 1 file changed, 7

[PATCH v3 39/56] handle_one_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- sha1_name.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sha1_name.c b/sha1_name.c index 1aad0a322

[PATCH v3 43/56] write_one_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- transport.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/transport.c b/transport.c index df87386

[PATCH v3 34/56] add_one_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- reachable.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/reachable.c b/reachable.c index acac86a

[PATCH v3 01/56] refs: convert struct ref_entry to use struct object_id

Signed-off-by: brian m. carlson sand...@crustytoothpaste.net Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- refs.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/refs.c b/refs.c index 8480d8d..9ca4651 100644

[PATCH v3 25/56] builtin/show-ref: rewrite to use object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/show-ref.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/builtin

[PATCH v3 17/56] builtin/remote: rewrite functions to take object_id arguments

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/remote.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/builtin/remote.c b/builtin

[PATCH v3 14/56] builtin/reflog: rewrite ref functions to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/reflog.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/builtin/reflog.c b/builtin

[PATCH v3 23/56] cmd_show_branch(): fix error message

From: Michael Haggerty mhag...@alum.mit.edu We need to convert the SHA-1 to hexadecimal before printing it. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/show-branch.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 38/56] add_info_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- server-info.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/server-info.c b/server-info.c index

[PATCH v3 24/56] fsck: change functions to use object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/fsck.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/builtin/fsck.c b

[PATCH v3 30/56] show_head_ref(): convert local variable unused to object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- http-backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/http-backend.c b/http-backend.c index a2d388d

[PATCH v3 40/56] shallow: rewrite functions to take object_id arguments

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- shallow.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/shallow.c b/shallow.c

[PATCH v3 13/56] show_ref_cb(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/receive-pack.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/builtin/receive-pack.c b/builtin

[PATCH v3 29/56] http-backend: rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- http-backend.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/http-backend.c b/http

[PATCH v3 10/56] grab_single_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/for-each-ref.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/builtin/for-each-ref.c b/builtin

[PATCH v3 26/56] show_ref(): convert local variable peeled to object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/show-ref.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/show-ref.c b/builtin/show-ref.c

[PATCH v3 06/56] append_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/branch.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/builtin/branch.c b/builtin/branch.c index

[PATCH v3 20/56] builtin/show-branch: rewrite functions to take object_id arguments

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/show-branch.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

check for certain. So technically, although I wrote it, I also received it from him without changing it, so both (a) and (c) of the DCO apply. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b

[PATCH v3 09/56] builtin/fetch: rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/fetch.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/builtin/fetch.c b

[PATCH v3 16/56] add_branch_for_removal(): don't set util field of string_list entries

From: Michael Haggerty mhag...@alum.mit.edu They were never used. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/remote.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/builtin/remote.c b

[PATCH v3 02/56] each_ref_fn: change to take an object_id parameter

of it consists of simple, mechanical changes to the sites that call any of the for_each_ref family of functions. Subsequent to this change, the call sites can be rewritten one by one to use the new interface. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand

[PATCH v3 19/56] append_matching_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/show-branch.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/builtin/show-branch.c b

[PATCH v3 04/56] handle_one_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- revision.c | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/revision.c b

[PATCH v3 08/56] get_name(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Rewrite to take an object_id argument and convert the local variable peeled object_id. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/describe.c | 16 +++- 1

[PATCH v3 33/56] string_list_add_one_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- notes.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/notes.c b/notes.c index baa1c41..df08209 100644

[PATCH v3 03/56] builtin/rev-parse: rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/rev-parse.c | 41 + 1 file changed, 17 insertions(+), 24 deletions(-) diff --git

[PATCH v3 21/56] append_one_rev(): rewrite to work with object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/show-branch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/show-branch.c b/builtin/show

[PATCH v3 07/56] add_pending_uninteresting_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/checkout.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/builtin/checkout.c b/builtin/checkout.c

[PATCH v3 15/56] add_branch_for_removal(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/remote.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index

[PATCH v3 11/56] name_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/name-rev.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/builtin/name-rev.c b/builtin/name

[PATCH v3 12/56] builtin/pack-objects: rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/pack-objects.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/builtin/pack

[PATCH v3 18/56] show_reference(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/replace.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/builtin/replace.c b/builtin

[PATCH v3 27/56] builtin/show-ref: rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/tag.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/builtin/tag.c b/builtin/tag.c

[PATCH v3 05/56] register_ref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- bisect.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/bisect.c b/bisect.c index 0848d91..03d5cd9

[PATCH v3 00/56] Convert parts of refs.c to struct object_id

rev_list_insert_ref(): remove unneeded arguments each_ref_fn_adapter(): remove adapter warn_if_dangling_symref(): convert local variable junk to object_id struct ref_lock: convert old_sha1 member to object_id brian m. carlson (1): refs: convert struct ref_entry to use struct object_id Documentation

Re: Mark trailing whitespace error in del lines of diff

On Mon, May 25, 2015 at 04:27:40PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: My use case is determining whether a patch to a pristine-tar repository introduced trailing whitespace (which is not okay) or just left it there (which is okay). In your

Re: Mark trailing whitespace error in del lines of diff

want to insert works before like so that it's a complete sentence. + of a patch (i.e. those preceeded with a '-') (not enabled by default) I believe this should be preceded. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My

Re: What's cooking in git.git (Jul 2015, #07; Mon, 27)

less painful (e.g. a reroll or such)? If waiting is the best technique, that's fine; I just want to minimize the impact of this change in terms of other code and maintainer burden. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My

Re: [PATCH v1] send-email: provide whitelist of SMTP AUTH mechanisms

only PLAIN and GSSAPI available server-side, and AUTH is required.) It may be better to simply force the text to upper case, as that would allow us not to have to change Git if Authen::SASL::Perl implements new mechanisms. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623

Re: [PATCH v2 00/10] object_id part 2

the ones to use the GIT_SHA1_* constants, because it's very easy to get off-by-one errors in there or mess up the values such that things break. Extra effort on those, or additional suggestions on how to make them cleaner and less brittle, both now and in the future, would be welcome. -- brian m. carlson

Re: What's cooking in git.git (Jul 2015, #07; Mon, 27)

On Thu, Jul 30, 2015 at 11:58:05AM +0200, Matthieu Moy wrote: brian m. carlson sand...@crustytoothpaste.net writes: On Mon, Jul 27, 2015 at 02:23:04PM -0700, Junio C Hamano wrote: * bc/object-id (2015-06-17) 10 commits Is there anything I can do to make this series less painful (e.g

Re: git blame breaking on repository with CRLF files

. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature

Re: [PATCH] config.mak.uname: Cygwin: Use renames for creation

) properly on shared drives, and if not, would this patch help it do so? I can imagine that perhaps SMB doesn't support the necessary operations to make a POSIX link(2) work properly. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My

Re: [bug report] Signing your work: GnuPG signing failed (gpg version 2.1)

://bugs.debian.org/790316 -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature

Re: OS X Yosemite make all doc fails

/; rewritePrefix=.// rewriteSystem systemIdStartString=http://docbook.sourceforge.net/release/xsl/current/; rewritePrefix=.// I don't know how your system is configured, so I can't tell you what entries would be correct. You might ask in an appropriate user forum for Homebrew. -- brian m. carlson / brian

Re: [PATCH] am: terminate state files with a newline

to discover all of that information trivially (and maybe even then, due to compatibility with older versions of git), people are going to poke around those directories. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only

[PATCH v4 03/12] add_sought_entry_mem: convert to struct object_id

Convert this function to use struct object_id. Express several hardcoded constants in terms of GIT_SHA1_HEXSZ. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- builtin/fetch-pack.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/builtin

[PATCH v4 02/12] Convert struct ref to use object_id.

Use struct object_id in three fields in struct ref and convert all the necessary places that use it. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- builtin/clone.c| 16 +++--- builtin/fetch-pack.c | 4 ++-- builtin/fetch.c

[PATCH v4 09/12] Add several uses of get_object_hash.

instead, are not converted. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- archive.c| 6 +++--- bisect.c | 6 +++--- branch.c | 2 +- builtin/blame.c | 24 ++--- builtin/branch.c | 2 +- b

[PATCH v4 05/12] get_remote_heads: convert to struct object_id

Replace an unsigned char array with struct object_id and express several hard-coded constants in terms of GIT_SHA1_HEXSZ. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- connect.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff

[PATCH v4 11/12] Remove get_object_hash.

Convert all instances of get_object_hash to use an appropriate reference to the hash member of the oid member of struct object. This provides no functional change, as it is essentially a macro substitution. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- The script used

[PATCH v4 01/12] sha1_file: introduce has_object_file helper.

Add has_object_file, which is a wrapper around has_sha1_file, but for struct object_id. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- cache.h | 3 +++ sha1_file.c | 5 + 2 files changed, 8 insertions(+) diff --git a/cache.h b/cache.h index 3ba0b8f3..27bc121b

[PATCH v4 06/12] push_refs_with_export: convert to struct object_id

Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- transport-helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/transport-helper.c b/transport-helper.c index 91cb0e72..0eb3cf01 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -

[PATCH v4 07/12] ref_newer: convert to use struct object_id

Convert ref_newer and its caller to use struct object_id instead of unsigned char *. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- builtin/remote.c | 2 +- http-push.c | 4 ++-- remote.c | 8 remote.h | 2 +- 4 files changed, 8 insertions

[PATCH v4 12/12] remote: convert functions to struct object_id

Convert several unsigned char arrays to use struct object_id instead, and change hard-coded 40-based constants to use GIT_SHA1_HEXSZ as well. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- remote.c | 58 +-

[PATCH v4 04/12] parse_fetch: convert to use struct object_id

Convert the parse_fetch function to use struct object_id. Remove the strlen check as get_oid_hex will fail safely on receiving a too-short NUL-terminated string. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- remote-curl.c | 12 ++-- 1 file changed, 6 inse

[PATCH v4 08/12] object: introduce get_object_hash macro.

This macro is a temporary change to ease the transition of struct object to use struct object_id. It takes an argument of struct object and returns the object's hash. Provide this hash next to struct object for easier conversion. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.

[PATCH v4 00/12] object_id part 2

the first patch. * Re-run the script to expand get_object_hash. brian m. carlson (12): sha1_file: introduce has_object_file helper. Convert struct ref to use object_id. add_sought_entry_mem: convert to struct object_id parse_fetch: convert to use struct object_id get_remote_heads: convert

Re: problem with modification time of packfiles

optionally freshens the object. It's trivial to implement freshening and simple checking by tweaking a single parameter. Signed-off-by: Jeff King <p...@peff.net> Signed-off-by: Junio C Hamano <gits...@pobox.com> Perhaps implementing a backup strategy based on content instead of mt

Re: [PATCH v3 01/13] refs: convert some internal functions to use object_id

On Tue, Oct 13, 2015 at 01:43:30PM +0200, Michael Haggerty wrote: > On 10/09/2015 03:43 AM, brian m. carlson wrote: > > Convert several internal functions in refs.c to use struct object_id, > > and use the GIT_SHA1_HEXSZ constants in parse_ref_line. > > > > Signed-off

Re: problem with modification time of packfiles

operations. > > Given this, would a trivial patch to remove the freshening of packfiles > be acceptable? I'm not familiar enough with the code to say for certain, but it looks like you're right. Peff, Junio, do you think this is safe, or is there something we're missing? -- brian m.

[PATCH v3 03/13] Convert struct ref to use object_id.

Use struct object_id in three fields in struct ref and convert all the necessary places that use it. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- builtin/clone.c| 16 +++--- builtin/fetch-pack.c | 4 ++-- builtin/fetch.c

[PATCH v3 01/13] refs: convert some internal functions to use object_id

Convert several internal functions in refs.c to use struct object_id, and use the GIT_SHA1_HEXSZ constants in parse_ref_line. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- refs.c | 104 - 1 file chang

[PATCH v3 02/13] sha1_file: introduce has_object_file helper.

Add has_object_file, which is a wrapper around has_sha1_file, but for struct object_id. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- cache.h | 3 +++ sha1_file.c | 5 + 2 files changed, 8 insertions(+) diff --git a/cache.h b/cache.h index 752031e8..61a686e3

[PATCH v3 11/13] Convert struct object to object_id

struct object is one of the major data structures dealing with object IDs. Convert it to use struct object_id instead of an unsigned char array. Convert get_object_hash to refer to the new member as well. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- bi

[PATCH v3 13/13] remote: convert functions to struct object_id

Convert several unsigned char arrays to use struct object_id instead, and change hard-coded 40-based constants to use GIT_SHA1_HEXSZ as well. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- remote.c | 64

[PATCH v3 12/13] Remove get_object_hash.

Convert all instances of get_object_hash to use an appropriate reference to the hash member of the oid member of struct object. This provides no functional change, as it is essentially a macro substitution. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- Implemented en

[PATCH v3 10/13] Add several uses of get_object_hash.

instead, are not converted. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- This does not follow a hard and fast rule, but the goal was to keep the changes down between both this patch and the following. *Generally*, things I was going to convert in the next patch I didn't c

[PATCH v3 00/13] object_id part 2

patches. brian m. carlson (13): refs: convert some internal functions to use object_id sha1_file: introduce has_object_file helper. Convert struct ref to use object_id. add_sought_entry_mem: convert to struct object_id parse_fetch: convert to use struct object_id get_remote_heads

[PATCH v3 09/13] object: introduce get_object_hash macro.

This macro is a temporary change to ease the transition of struct object to use struct object_id. It takes an argument of struct object and returns the object's hash. Provide this hash next to struct object for easier conversion. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.

[PATCH v3 08/13] ref_newer: convert to use struct object_id

Convert ref_newer and its caller to use struct object_id instead of unsigned char *. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- builtin/remote.c | 2 +- http-push.c | 4 ++-- remote.c | 8 remote.h | 2 +- 4 files changed, 8 insertions

[PATCH v3 04/13] add_sought_entry_mem: convert to struct object_id

Convert this function to use struct object_id. Express several hardcoded constants in terms of GIT_SHA1_HEXSZ. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- builtin/fetch-pack.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/builtin

[PATCH v3 05/13] parse_fetch: convert to use struct object_id

Convert the parse_fetch function to use struct object_id. Remove the strlen check as get_oid_hex will fail safely on receiving a too-short NUL-terminated string. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- remote-curl.c | 12 ++-- 1 file changed, 6 inse

[PATCH v3 06/13] get_remote_heads: convert to struct object_id

Replace an unsigned char array with struct object_id and express several hard-coded constants in terms of GIT_SHA1_HEXSZ. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- connect.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff

[PATCH v3 07/13] push_refs_with_export: convert to struct object_id

Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- transport-helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/transport-helper.c b/transport-helper.c index 91cb0e72..0eb3cf01 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -

Re: No negotiation for repos on HTTP servers?

d suggest sending the patch as specified in Documentation/SubmittingPatches, and it's likely Junio will pick it up. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552

Re: git commit -a -m is not working

eleted, but new files you have not told Git about are not affected. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: PGP signature

Re: http.c (curl_easy_setopt and CURLAUTH_ANY)

the documentation for PHP. The libcurl documentation[0] doesn't mention a limitation. [0] http://curl.haxx.se/libcurl/c/CURLOPT_PROXYAUTH.html -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b

Re: What's cooking in git.git (Dec 2015, #01; Tue, 1)

likely to undergo a lot of changes, I'll try to keep away from it for now, but it will need to be converted at some point. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196

Re: [PATCH 0/2] format-patch: introduce option to suppress commit hashes

On Sun, Dec 06, 2015 at 06:49:14PM -0800, Junio C Hamano wrote: > "brian m. carlson" <sand...@crustytoothpaste.net> writes: > > > git format-patch is often used to create patches that are then stored in > > version control or displayed with diff. Having the c

Re: Show total commit count of two authors or more authors into first author

hing like this: Jagan Teki <a...@abc.com> Jagannadha Teki <x...@xynz.com> Jagan Teki <a...@abc.com> Jagannadha Sutradharudu Teki <p...@pqr.com> -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My op

[PATCH 1/2] Introduce a null_oid constant.

null_oid is the struct object_id equivalent to null_sha1. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- cache.h | 1 + sha1_file.c | 1 + 2 files changed, 2 insertions(+) diff --git a/cache.h b/cache.h index 5ab6cb50..c63fcc11 100644 --- a/cache.h +++ b/c

[PATCH 0/2] format-patch: introduce option to suppress commit hashes

hat the latter made more sense as an option in struct rev_info, as it's strictly more accurate, while the former is less accurate but more friendly to humans. Of course, this can be changed if reviewers feel it to be undesirable. brian m. carlson (2): Introduce a null_oid constant. format-pa

[PATCH 2/2] format-patch: add an option to suppress commit hash

to avoid this diff noise. Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> --- Documentation/git-format-patch.txt | 4 builtin/log.c | 5 + log-tree.c | 3 ++- revision.h | 1 + t/t4014-format-pa

Re: rebase has no --verify-signatures

d git-rebase--interactive as well. I'm sure I'm not the only person who frequently uses rebase -m. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 22

<    1   2   3   4   5   6   7   8   9   10   >