Re: [PATCH] grep: Add option --max-line-len

2017-11-26 Thread Marc-Antoine Ruel
uot;, should that error out or at least warn > the user that the value is non-sensical? What about -1, etc.? (These > are UX-related questions; the implementation obviously doesn't care > one way or the other.) Precedent with -A is to ignore the negative value. I don't have a strong opinion. 2017-11-23

[PATCH] grep: Add option --max-line-len

2017-11-23 Thread Marc-Antoine Ruel
This tells git grep to skip files longer than a specified length, which is often the result of generators and not actual source files. Signed-off-by: Marc-Antoine Ruel <mar...@chromium.org> --- Documentation/git-grep.txt | 5 + builtin/grep.c | 2 ++

git-svn fails to initialize with submodule setup, when '.git' is a file and not a directory

2013-09-12 Thread Marc-Antoine Ruel
Repro: 1. git clone --recursive a repository with submodules. 2. cd checkout/submoduleA 3. git svn init svn://host/repo Expected: Works as usual Actual: /path/to/checkout/submoduleA/.git/refs: Not a directory init: command returned error: 1 Why: submoduleA/.git is a file, not a directory. $ cat