Re: [PATCH v3 0/3] Add "git rebase --show-current-patch"

2018-02-21 Thread Tim Landscheidt
Junio C Hamano wrote: >> Compared to v2: >> - the potential loss of errno before it's printed out in builtin/am.c >> is fixed. >> - keep update_ref() in sequencer.c non-fatal like this rest >> - rename ORIG_COMMIT to REBASE_HEAD >> Interdiff: > This round hasn't seen any

Re: [PATCH 0/2] Add "git rebase --show-patch"

2018-01-31 Thread Tim Landscheidt
Junio C Hamano wrote: >> The pseudo ref certainly has an appeal. For people very familiar with >> Git's peculiarities such as FETCH_HEAD. Such as myself. >> For users, it is probably substantially worse an experience than having a >> cmdmode like --show-patch in the very

Re: [PATCH 0/2] Add "git rebase --show-patch"

2018-01-26 Thread Tim Landscheidt
Nguyễn Thái Ngọc Duy wrote: > When a conflict happens during a rebase, you often need to look at the > original patch to see what the changes are. This requires opening your > favourite pager with some random path inside $GIT_DIR. > This series makes that experience a bit