Re: [GSoC][PATCH] tag: Make "git tag --contains " less chatty if is invalid

2018-02-20 Thread Junio C Hamano
Stefan Beller writes: >> diff --git a/t/t7013-tag-contains.sh b/t/t7013-tag-contains.sh >> new file mode 100755 >> index 0..65119dada >> --- /dev/null >> +++ b/t/t7013-tag-contains.sh > > Thanks for adding the tests into a new file instead of putting it somewhere >

Re: [GSoC][PATCH] tag: Make "git tag --contains " less chatty if is invalid

2018-02-20 Thread Stefan Beller
Welcome to the Git mailing list! On Mon, Feb 19, 2018 at 1:21 PM, Paul-Sebastian Ungureanu wrote: > git tag --contains prints the whole help text if is > invalid. It should only show the error message instead. Makes sense. > > This bug was a side effect of

[GSoC][PATCH] tag: Make "git tag --contains " less chatty if is invalid

2018-02-19 Thread Paul-Sebastian Ungureanu
git tag --contains prints the whole help text if is invalid. It should only show the error message instead. This bug was a side effect of looking up the commit in option parser callback. When a error occurs in the option parser, the full usage is shown. To fix this bug, the part related to