Re: [GSoC][PATCH v8 00/20] Convert "git stash" to C builtin

2018-09-03 Thread Johannes Schindelin
Hi Paul, On Fri, 31 Aug 2018, Paul-Sebastian Ungureanu wrote: > This a new iteration of `stash.c`. Thank you for the pleasant read! I read through all of the patches, spending particularly some time with the `stash create` one. Apart from the few comments I had, I only have positive things to

Re: [GSoC][PATCH v8 00/20] Convert "git stash" to C builtin

2018-08-31 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > This a new iteration of `stash.c`. What is new? > > * Some commits got squashed. The commit related to replacing > `git apply` child process was dropped since it wasn't the best > idea. > > * In v7, there was a bug [1] related to config `git stash show` >

Re: [GSoC][PATCH v8 00/20] Convert "git stash" to C builtin

2018-08-30 Thread Ævar Arnfjörð Bjarmason
On Thu, Aug 30 2018, Paul-Sebastian Ungureanu wrote: > Hello, > > This a new iteration of `stash.c`. What is new? > > * Some commits got squashed. The commit related to replacing > `git apply` child process was dropped since it wasn't the best > idea. > > * In v7, there was a bug [1]

[GSoC][PATCH v8 00/20] Convert "git stash" to C builtin

2018-08-30 Thread Paul-Sebastian Ungureanu
Hello, This a new iteration of `stash.c`. What is new? * Some commits got squashed. The commit related to replacing `git apply` child process was dropped since it wasn't the best idea. * In v7, there was a bug [1] related to config `git stash show` The bug was fixed and a test file was