Eric Sunshine wrote
On Mon, Mar 10, 2014 at 5:47 PM, Tamer TAS lt;
tamertas@
gt; wrote:
Section 4.3 of the GNU gettext manual [1] explains the issues in more
detail. I urge you to read it. The upshot is that translators fare
best when handed full sentences.
Note also that your change
Thanks for the resubmission. Comments below.
On Tue, Mar 11, 2014 at 7:33 AM, Tamer TAS tamer...@outlook.com wrote:
Subject: changed logical chain in branch.c to lookup tables
Use imperative tone: change rather than changed
Prefix the message with the part of the project you are touching. So,
Signed-off-by: TamerTas tamer...@outlook.com
---
branch.c | 31 ---
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/branch.c b/branch.c
index 723a36b..397edd3 100644
--- a/branch.c
+++ b/branch.c
@@ -50,6 +50,9 @@ static int should_setup_rebase(const
On 10.03.2014 20:04, TamerTas wrote:
Signed-off-by: TamerTas tamer...@outlook.com
---
branch.c | 31 ---
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/branch.c b/branch.c
index 723a36b..397edd3 100644
--- a/branch.c
+++ b/branch.c
@@
On Mon, Mar 10, 2014 at 3:04 PM, TamerTas tamer...@outlook.com wrote:
Signed-off-by: TamerTas tamer...@outlook.com
Thanks for the submission. It appears to be well executed. Read below
for a concern about the approach taken.
---
branch.c | 31 ---
1 file
Eric Sunshine wrote
Even allowing internationalization of them (via N_() in the location[]
and type[] tables) might not be sufficient since grammatical rules
differ from language to language.
I didn't fully understand what you meant by that. Since they were being
internationalized before using
6 matches
Mail list logo
