Re: [PATCH] Add missing test file for UTF-16.

2013-08-06 Thread Duy Nguyen
On Mon, Aug 5, 2013 at 11:44 PM, Junio C Hamano gits...@pobox.com wrote: Duy Nguyen pclo...@gmail.com writes: On Sun, Aug 4, 2013 at 12:26 AM, brian m. carlson sand...@crustytoothpaste.net wrote: The test file that the UTF-16 rejection test looks for is missing, but this went unnoticed

Re: [PATCH] Add missing test file for UTF-16.

2013-08-06 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: The intention was UTF-16 is not supported yet but we want to. But I don't think we (at least I) will put any effort on that front to allow NUL in commit message, so the patch, as in we do not support UTF-16, is fine. Agreed. Here is what I queued. -- 8

Re: [PATCH] Add missing test file for UTF-16.

2013-08-04 Thread brian m. carlson
On Sun, Aug 04, 2013 at 09:31:01AM +0700, Duy Nguyen wrote: Tested-by: Duy Nguyen pclo...@gmai.com I think you're missing an l in the domain name there. and sorry, my bad. I think we need your sign-off in this patch. I just ran across it because I'm going through all the TODO tests and seeing

Re: [PATCH] Add missing test file for UTF-16.

2013-08-03 Thread Duy Nguyen
On Sun, Aug 4, 2013 at 12:26 AM, brian m. carlson sand...@crustytoothpaste.net wrote: The test file that the UTF-16 rejection test looks for is missing, but this went unnoticed because the test is expected to fail anyway; as a consequence, the test fails because the file containing the commit