Re: [PATCH] Added get sendmail from .mailrc

2014-01-27 Thread Jeff King
On Sun, Jan 26, 2014 at 09:17:09AM +, Eric Wong wrote: +use File::HomeDir; We should probably avoid a new dependency and also remain consistent with the rest of git handles home directories. Unfortunately, expand_user_path()/git_config_pathname() isn't currently

Re: [PATCH] Added get sendmail from .mailrc

2014-01-27 Thread Jeff King
On Sat, Jan 25, 2014 at 01:46:50PM +0400, Brilliantov Kirill Vladimirovich wrote: + if (!defined $smtp_server) { + my $mailrc = File::HomeDir-my_home . /.mailrc; The new module dependency has been discussed elsewhere in the thread. + if (-e $mailrc) { +

Re: [PATCH] Added get sendmail from .mailrc

2014-01-27 Thread Kyle J. McKay
On Jan 27, 2014, at 17:15, Jeff King wrote: On Sat, Jan 25, 2014 at 01:46:50PM +0400, Brilliantov Kirill Vladimirovich wrote: + if (!defined $smtp_server) { + my $mailrc = File::HomeDir-my_home . /.mailrc; Actually, based on the output of man mail, this should probably

Re: [PATCH] Added get sendmail from .mailrc

2014-01-26 Thread Brilliantov Kirill Vladimirovich
On 2014-01-26 11:34:38, Brilliantov Kirill Vladimirovich wrote: On 2014-01-25 22:37:21, Eric Wong wrote: We should probably avoid a new dependency and also remain consistent with the rest of git handles home directories. Unfortunately, expand_user_path()/git_config_pathname() isn't

Re: [PATCH] Added get sendmail from .mailrc

2014-01-26 Thread Eric Wong
Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote: On 2014-01-25 22:37:21, Eric Wong wrote: Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote: --- a/git-send-email.perl +++ b/git-send-email.perl @@ -28,6 +28,7 @@ use File::Temp qw/ tempdir tempfile /; use

[PATCH] Added get sendmail from .mailrc

2014-01-25 Thread Brilliantov Kirill Vladimirovich
Signed-off-by: Brilliantov Kirill Vladimirovich brillian...@inbox.ru --- git-send-email.perl | 18 ++ 1 file changed, 18 insertions(+) diff --git a/git-send-email.perl b/git-send-email.perl index 2016d9c..5345fdb 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -28,6

Re: [PATCH] Added get sendmail from .mailrc

2014-01-25 Thread Eric Wong
Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote: Signed-off-by: Brilliantov Kirill Vladimirovich brillian...@inbox.ru --- git-send-email.perl | 18 ++ 1 file changed, 18 insertions(+) Some documentation references to .mailrc and its format would be nice. ---

Re: [PATCH] Added get sendmail from .mailrc

2014-01-25 Thread Brilliantov Kirill Vladimirovich
On 2014-01-25 22:37:21, Eric Wong wrote: Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote: Signed-off-by: Brilliantov Kirill Vladimirovich brillian...@inbox.ru --- git-send-email.perl | 18 ++ 1 file changed, 18 insertions(+) Some documentation references to