Re: [PATCH] fast-import.c: always honor the filename case

2014-02-11 Thread Torsten Bögershausen
did in [PATCH] fast-import.c: always honor the filename case And the same is for fast-export fixes you have made: If you have the time, convert it into a patch and send it to the list. Do you mean the fast-export fixes where I pushed all the delete operations to the front

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-09 Thread Torsten Bögershausen
On 2014-02-06 12.24, Reuben Hawkins wrote: [snipped away minor interesting stuff] Reading the answers from Peff and Junio, I am convinced that the fast-import should not look at core.ignorecase at all. Agreed, but my patch 0001-fast-import.c-ignorecase-iff-... is working very well

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-05 Thread Torsten Bögershausen
. My patch, fast-import.c: always honor the filename case fixes this. Can you verify? Thanks in advance, Reuben Yes, I can verify. My feeling is that a) the fast-export should generate the rename the other way around. Would that be feasable ? I *think

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-03 Thread Junio C Hamano
Jeff King p...@peff.net writes: [+cc Joshua Jensen, who wrote 50906e0] On Sun, Feb 02, 2014 at 07:13:04AM -0600, Reuben Hawkins wrote: fast-import should not use strncmp_icase. I am not sure of that. My gut feeling is that core.ignorecase is completely about the _filesystem_, and that git

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-03 Thread Torsten Bögershausen
[] So to summarize, when fast-import uses strncmp_icase (what fast-import does now) import on a repository where ignorecase=true is wrong. My patch, fast-import.c: always honor the filename case fixes this. Can you verify? Thanks in advance, Reuben Yes, I can verify. My feeling

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-03 Thread Junio C Hamano
Torsten Bögershausen tbo...@web.de writes: [] So to summarize, when fast-import uses strncmp_icase (what fast-import does now) import on a repository where ignorecase=true is wrong. My patch, fast-import.c: always honor the filename case fixes this. Can you verify? Thanks in advance

[PATCH] fast-import.c: always honor the filename case

2014-02-02 Thread Reuben Hawkins
fast-import should not use strncmp_icase. When it does, files with similar names, but different case can be lost in the import. For example... M 100644 :1 FileName.txt D Filename.txt ...would end up deleting FileName from the index during the fast- import when strncmp_icase is used and

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-02 Thread Torsten Bögershausen
On 2014-02-02 14.13, Reuben Hawkins wrote: fast-import should not use strncmp_icase. When it does, files with similar names, but different case can be lost in the import. For example... M 100644 :1 FileName.txt D Filename.txt That seems to be wrong, shouldn't it be D Filename.txt M 100644

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-02 Thread Jeff King
[+cc Joshua Jensen, who wrote 50906e0] On Sun, Feb 02, 2014 at 07:13:04AM -0600, Reuben Hawkins wrote: fast-import should not use strncmp_icase. I am not sure of that. My gut feeling is that core.ignorecase is completely about the _filesystem_, and that git should generally be case-sensitive