Re: [PATCH] fix pushing to //server/share/dir paths on Windows

2016-12-19 Thread Johannes Schindelin
Hi Hannes, On Tue, 13 Dec 2016, Johannes Sixt wrote: > Dscho, it looks like this could fix the original report at > https://github.com/git-for-windows/git/issues/979 Yes, thank you so much for fixing it! I think your v2 is safe enough to cherry-pick directly into Git for Windows' `master`.

Re: [PATCH] fix pushing to //server/share/dir paths on Windows

2016-12-14 Thread Jeff King
On Tue, Dec 13, 2016 at 10:32:01PM +0100, Johannes Sixt wrote: > normalize_path_copy() is not prepared to keep the double-slash of a > //server/share/dir kind of path, but treats it like a regular POSIX > style path and transforms it to /server/share/dir. > > The bug manifests when 'git push

Re: [PATCH] fix pushing to //server/share/dir paths on Windows

2016-12-13 Thread Junio C Hamano
Johannes Sixt writes: > There is a change in behavior: \\server\share is not transformed > into //server/share anymore, but all subsequent directory separators > are rewritten to '/'. This should not make a difference; Windows can > handle the mix. I saw Dscho had a similar

[PATCH] fix pushing to //server/share/dir paths on Windows

2016-12-13 Thread Johannes Sixt
normalize_path_copy() is not prepared to keep the double-slash of a //server/share/dir kind of path, but treats it like a regular POSIX style path and transforms it to /server/share/dir. The bug manifests when 'git push //server/share/dir master' is run, because tmp_objdir_add_as_alternate() uses