Re: [PATCH] fixup! use perl instead of sed

2017-05-09 Thread Ævar Arnfjörð Bjarmason
On Wed, May 10, 2017 at 12:38 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> On Tue, May 9, 2017 at 6:45 PM, Jonathan Tan >> wrote: >> ... >>> # Tweak the push output to make the push option outside the

Re: [PATCH] fixup! use perl instead of sed

2017-05-09 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Tue, May 9, 2017 at 6:45 PM, Jonathan Tan wrote: > ... >> # Tweak the push output to make the push option outside the cert >> # different, then replay it on a fresh dst, checking that ff is not >>

Re: [PATCH] fixup! use perl instead of sed

2017-05-09 Thread Ævar Arnfjörð Bjarmason
On Tue, May 9, 2017 at 10:43 PM, Johannes Sixt wrote: > Am 09.05.2017 um 19:00 schrieb Ævar Arnfjörð Bjarmason: >> >> Finally, you can just use -i like you did with sed, no need for the >> tempfile: > > > Nope. Some implementations of perl attempt to remove the file that it has >

Re: [PATCH] fixup! use perl instead of sed

2017-05-09 Thread Jonathan Tan
On 05/09/2017 01:43 PM, Johannes Sixt wrote: Am 09.05.2017 um 19:00 schrieb Ævar Arnfjörð Bjarmason: Finally, you can just use -i like you did with sed, no need for the tempfile: Nope. Some implementations of perl attempt to remove the file that it has just opened. That doesn't work on

Re: [PATCH] fixup! use perl instead of sed

2017-05-09 Thread Johannes Sixt
Am 09.05.2017 um 19:00 schrieb Ævar Arnfjörð Bjarmason: Finally, you can just use -i like you did with sed, no need for the tempfile: Nope. Some implementations of perl attempt to remove the file that it has just opened. That doesn't work on Windows. You have to supply a backup file name as

Re: [PATCH] fixup! use perl instead of sed

2017-05-09 Thread Ævar Arnfjörð Bjarmason
On Tue, May 9, 2017 at 6:45 PM, Jonathan Tan wrote: > Signed-off-by: Jonathan Tan > --- > > Thanks - I didn't realize the existence of the test lint. Here's a > fixup. Let me know if you prefer a full reroll. > > I had to use perl because

[PATCH] fixup! use perl instead of sed

2017-05-09 Thread Jonathan Tan
Signed-off-by: Jonathan Tan --- Thanks - I didn't realize the existence of the test lint. Here's a fixup. Let me know if you prefer a full reroll. I had to use perl because "push" is a binary file (the first line contains a NUL). t/t5534-push-signed.sh | 4 ++-- 1