Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-19 Thread Junio C Hamano
Andrew Keller and...@kellerfarm.com writes: When displaying a blob in gitweb, if it's an image, specify constraints for maximum display width and height to prevent the image from overflowing the frame of the enclosing page_body div. This change assumes that it is more desirable to see the

[PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-17 Thread Andrew Keller
When displaying a blob in gitweb, if it's an image, specify constraints for maximum display width and height to prevent the image from overflowing the frame of the enclosing page_body div. This change assumes that it is more desirable to see the whole image without scrolling (new behavior) than

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Andrew Keller
On Feb 6, 2014, at 10:31 PM, Andrew Keller wrote: When displaying a blob in gitweb, if it's an image, specify constraints for maximum display width and height to prevent the image from overflowing the frame of the enclosing page_body div. This change assumes that it is more desirable to see

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Vincent van Ravesteijn
On Fri, Feb 7, 2014 at 4:31 AM, Andrew Keller and...@kellerfarm.com wrote: I recently used Git to archive a set of scanned photos, and I used gitweb to provide access to them. Overall, everything worked well, but I found it undesirable that I had to zoom out in my browser on every photo to

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Andrew Keller
On Feb 7, 2014, at 7:35 AM, Vincent van Ravesteijn v...@lyx.org wrote: On Fri, Feb 7, 2014 at 4:31 AM, Andrew Keller and...@kellerfarm.com wrote: I recently used Git to archive a set of scanned photos, and I used gitweb to provide access to them. Overall, everything worked well, but I found

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Tony Finch
Andrew Keller and...@kellerfarm.com wrote: With that said, I don't think it's unreasonable for a software project to contain images larger than a browser window. And, when that happens, I'm pretty confident that the default behavior should be to scale the image down so the user can see the

[PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-06 Thread Andrew Keller
When displaying a blob in gitweb, if it's an image, specify constraints for maximum display width and height to prevent the image from overflowing the frame of the enclosing page_body div. This change assumes that it is more desirable to see the whole image without scrolling (new behavior) than