Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4

2018-01-03 Thread Todd Zullinger
Jeff King wrote: > On Tue, Jan 02, 2018 at 07:39:46PM -0500, Todd Zullinger wrote: >> I don't know if there's a clean way to do that >> automatically, short of parsing the output of 'httpd -v' >> should we ever need to add such a prereq. > > In the general case, we could probably define an

Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4

2018-01-02 Thread Jeff King
On Tue, Jan 02, 2018 at 07:39:46PM -0500, Todd Zullinger wrote: > Brandon Williams wrote: > > Seems good to me. I think I was just being overly cautious when i was > > implementing those patches. Thanks! > > Cool, thanks for taking a look. > > In this case, the test isn't dependent on apache

Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4

2018-01-02 Thread Jeff King
On Sat, Dec 30, 2017 at 09:32:34PM -0500, Todd Zullinger wrote: > The apache config used by tests was updated to use the SetEnvIf > directive to set the Git-Protocol header in 19113a26b6 ("http: tell > server that the client understands v1", 2017-10-16). > > Setting the Git-Protocol header is

Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4

2018-01-02 Thread Todd Zullinger
Brandon Williams wrote: > Seems good to me. I think I was just being overly cautious when i was > implementing those patches. Thanks! Cool, thanks for taking a look. In this case, the test isn't dependent on apache > 2.4, but before I checked that I wondered if we had any way to run a test

Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4

2018-01-02 Thread Brandon Williams
On 12/30, Todd Zullinger wrote: > The apache config used by tests was updated to use the SetEnvIf > directive to set the Git-Protocol header in 19113a26b6 ("http: tell > server that the client understands v1", 2017-10-16). > > Setting the Git-Protocol header is restricted to httpd >= 2.4, but >

[PATCH] http: fix v1 protocol tests with apache httpd < 2.4

2017-12-30 Thread Todd Zullinger
The apache config used by tests was updated to use the SetEnvIf directive to set the Git-Protocol header in 19113a26b6 ("http: tell server that the client understands v1", 2017-10-16). Setting the Git-Protocol header is restricted to httpd >= 2.4, but mod_setenvif and the SetEnvIf directive work