Re: [PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

2018-11-20 Thread Johannes Schindelin
Hi Junio, On Tue, 20 Nov 2018, Junio C Hamano wrote: > Sven Strickroth writes: > > > This also removes an implicit conversion from size_t (unsigned) to int > > (signed). > > > > _stricmp as well as _strnicmp are both available since VS2012. Looks good to me. > > Signed-off-by: Sven

Re: [PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

2018-11-19 Thread Junio C Hamano
Sven Strickroth writes: > This also removes an implicit conversion from size_t (unsigned) to int > (signed). > > _stricmp as well as _strnicmp are both available since VS2012. > > Signed-off-by: Sven Strickroth > --- > compat/msvc.h | 8 +--- > 1 file changed, 1 insertion(+), 7

[PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

2018-11-19 Thread Sven Strickroth
This also removes an implicit conversion from size_t (unsigned) to int (signed). _stricmp as well as _strnicmp are both available since VS2012. Signed-off-by: Sven Strickroth --- compat/msvc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/compat/msvc.h

Re: [PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

2018-11-18 Thread Junio C Hamano
Jeff King writes: > And it seems we worked around this in de2f95ebed (mailmap: work around > implementations with pure inline strcasecmp, 2013-09-12). So I don't > think there is any blocker there. > > (Though of course I have no idea on other portability questions around > _stricmp(); I'll

Re: [PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

2018-11-18 Thread Jeff King
On Sun, Nov 18, 2018 at 10:02:02PM +0100, Sven Strickroth wrote: > This also removes an implicit conversion from size_t (unsigned) to int > (signed). > > _stricmp as well as _strnicmp are both available since VS2012. Once upon a time we had problems with taking a function pointer of strcasecmp

[PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

2018-11-18 Thread Sven Strickroth
This also removes an implicit conversion from size_t (unsigned) to int (signed). _stricmp as well as _strnicmp are both available since VS2012. Signed-off-by: Sven Strickroth --- compat/msvc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/compat/msvc.h