Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-31 Thread Jacob Keller
On October 30, 2017 5:46:36 AM PDT, Johannes Schindelin wrote: >Hi Phillip, > >On Mon, 30 Oct 2017, Phillip Wood wrote: > >> On 30/10/17 06:26, Jacob Keller wrote: >> > On Sun, Oct 29, 2017 at 8:36 PM, Junio C Hamano >wrote: >> >> Jacob Keller

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-30 Thread Johannes Schindelin
Hi Phillip, On Mon, 30 Oct 2017, Phillip Wood wrote: > On 30/10/17 06:26, Jacob Keller wrote: > > On Sun, Oct 29, 2017 at 8:36 PM, Junio C Hamano wrote: > >> Jacob Keller writes: > >> > >>> I am pretty confident we can fix it > >> > >> I am sure

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-30 Thread Phillip Wood
On 30/10/17 06:26, Jacob Keller wrote: > On Sun, Oct 29, 2017 at 8:36 PM, Junio C Hamano wrote: >> Jacob Keller writes: >> >>> I am pretty confident we can fix it >> >> I am sure we can eventually, but 3 hours is not enough soak time. >> >> I am

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-30 Thread Jacob Keller
On Sun, Oct 29, 2017 at 8:36 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> I am pretty confident we can fix it > > I am sure we can eventually, but 3 hours is not enough soak time. > > I am inclined to leave the fix for 2.15.1/2.16.0 instead

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-29 Thread Junio C Hamano
Jacob Keller writes: > I am pretty confident we can fix it I am sure we can eventually, but 3 hours is not enough soak time. I am inclined to leave the fix for 2.15.1/2.16.0 instead of delaying the release by 10 more days.

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-29 Thread Jacob Keller
On Sun, Oct 29, 2017 at 7:26 PM, Junio C Hamano wrote: > Phillip Wood writes: > >> Just clearing GIT_DIR does not match the behavior of the shell version >> (tested by passing -p to avoid rebase--helper) as that passes GIT_DIR to >> exec commands if

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-29 Thread Jacob Keller
On Sun, Oct 29, 2017 at 11:34 AM, Phillip Wood wrote: > > Just clearing GIT_DIR does not match the behavior of the shell version > (tested by passing -p to avoid rebase--helper) as that passes GIT_DIR to > exec commands if it has been explicitly set. I think that users

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-29 Thread Junio C Hamano
Phillip Wood writes: > Just clearing GIT_DIR does not match the behavior of the shell version > (tested by passing -p to avoid rebase--helper) as that passes GIT_DIR to > exec commands if it has been explicitly set. I think that users that set > GIT_DIR on the command

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-29 Thread Phillip Wood
On 28/10/17 17:00, Johannes Schindelin wrote: > > Hi Jake, > > On Fri, 27 Oct 2017, Jacob Keller wrote: > >> From: Jacob Keller >> >> I noticed a failure with git rebase interactive mode which causes "exec" >> commands to be run with GIT_DIR set. When GIT_DIR is in the

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-28 Thread Jacob Keller
On Sat, Oct 28, 2017 at 9:00 AM, Johannes Schindelin wrote: > Hi Jake, > > On Fri, 27 Oct 2017, Jacob Keller wrote: > >> From: Jacob Keller >> >> I noticed a failure with git rebase interactive mode which causes "exec" >> commands to be run

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-28 Thread Johannes Schindelin
Hi Jake, On Fri, 27 Oct 2017, Jacob Keller wrote: > From: Jacob Keller > > I noticed a failure with git rebase interactive mode which causes "exec" > commands to be run with GIT_DIR set. When GIT_DIR is in the environment, > then any command which results in running a

[PATCH] rebase: exec leaks GIT_DIR to environment

2017-10-27 Thread Jacob Keller
From: Jacob Keller I noticed a failure with git rebase interactive mode which causes "exec" commands to be run with GIT_DIR set. When GIT_DIR is in the environment, then any command which results in running a git command in a subdirectory will fail because GIT_DIR=".git".