Re: [PATCH] t3200: clarify description of --set-upstream test

2018-06-17 Thread Kaartic Sivaraam
On Thursday 14 June 2018 11:13 PM, Junio C Hamano wrote: > It is technically correct to call --set-upstream "unsupported", but > the reason why we want to see it fail is not because it is > unsupported, but because we actively interfere with the usual > "unique prefix" logic parse-options API

Re: [PATCH] t3200: clarify description of --set-upstream test

2018-06-14 Thread Junio C Hamano
Kaartic Sivaraam writes: > Support for the --set-upstream option was removed in 52668846ea > (builtin/branch: stop supporting the "--set-upstream" option, > 2017-08-17). The change did not completely remove the command > due to an issue noted in the commit's log message. > > So, a test was added

[PATCH] t3200: clarify description of --set-upstream test

2018-06-14 Thread Kaartic Sivaraam
Support for the --set-upstream option was removed in 52668846ea (builtin/branch: stop supporting the "--set-upstream" option, 2017-08-17). The change did not completely remove the command due to an issue noted in the commit's log message. So, a test was added to ensure that a command which uses