Re: [PATCH] transport: report refs only if transport does

2018-08-02 Thread Jeff King
On Tue, Jul 31, 2018 at 04:23:43PM -0700, Jonathan Tan wrote: > > > Because transport_fetch_refs() filters the refs sent to the transport, > > > it cannot just report the transport's result directly, but first needs > > > to readd the excluded refs, pretending that they are fetched. However, > >

Re: [PATCH] transport: report refs only if transport does

2018-08-01 Thread Brandon Williams
On 07/31, Jonathan Tan wrote: > > On Mon, Jul 30, 2018 at 03:56:01PM -0700, Jonathan Tan wrote: > > > > > Commit 989b8c4452 ("fetch-pack: put shallow info in output parameter", > > > 2018-06-28) allows transports to report the refs that they have fetched > > > in a new out-parameter

Re: [PATCH] transport: report refs only if transport does

2018-07-31 Thread Jonathan Tan
> What leaves me even more confused is that the entire log message > does not make it clear what the end-user observable problem the > patch is trying to solve. > > Is this "we sometimes follow and sometimes fail to follow refs while > fetching"? Does it affect all protocol versions and

Re: [PATCH] transport: report refs only if transport does

2018-07-31 Thread Jonathan Tan
> On Mon, Jul 30, 2018 at 03:56:01PM -0700, Jonathan Tan wrote: > > > Commit 989b8c4452 ("fetch-pack: put shallow info in output parameter", > > 2018-06-28) allows transports to report the refs that they have fetched > > in a new out-parameter "fetched_refs". If they do so, > >

Re: [PATCH] transport: report refs only if transport does

2018-07-31 Thread Junio C Hamano
Jeff King writes: > On Mon, Jul 30, 2018 at 03:56:01PM -0700, Jonathan Tan wrote: > >> Commit 989b8c4452 ("fetch-pack: put shallow info in output parameter", >> 2018-06-28) allows transports to report the refs that they have fetched >> in a new out-parameter "fetched_refs". If they do so, >>

Re: [PATCH] transport: report refs only if transport does

2018-07-31 Thread Jeff King
On Mon, Jul 30, 2018 at 03:56:01PM -0700, Jonathan Tan wrote: > Commit 989b8c4452 ("fetch-pack: put shallow info in output parameter", > 2018-06-28) allows transports to report the refs that they have fetched > in a new out-parameter "fetched_refs". If they do so, > transport_fetch_refs() makes

[PATCH] transport: report refs only if transport does

2018-07-30 Thread Jonathan Tan
Commit 989b8c4452 ("fetch-pack: put shallow info in output parameter", 2018-06-28) allows transports to report the refs that they have fetched in a new out-parameter "fetched_refs". If they do so, transport_fetch_refs() makes this information available to its caller. Because